Re: svn commit: r1655546 - in /opennlp/trunk/opennlp-tools: pom.xml src/test/java/opennlp/tools/ngram/ src/test/java/opennlp/tools/ngram/NGramModelTest.java src/test/resources/opennlp/tools/ngram/ src

2015-01-30 Thread Tommaso Teofili
thanks Jörn I'll follow your suggestion and change the test impl accordingly. Regards, Tommaso 2015-01-29 13:16 GMT+01:00 Joern Kottmann kottm...@gmail.com: In those serialization tests I usually write the Object into a byte buffer, create it again from the byte buffer and then compare the

Re: svn commit: r1655546 - in /opennlp/trunk/opennlp-tools: pom.xml src/test/java/opennlp/tools/ngram/ src/test/java/opennlp/tools/ngram/NGramModelTest.java src/test/resources/opennlp/tools/ngram/ src

2015-01-29 Thread Joern Kottmann
Or if that is a problem for the test, you could also tell RAT to ignore it. On my machine the test fails. The two strings don't match. Jörn On Thu, 2015-01-29 at 09:59 +0100, Tommaso Teofili wrote: right, thanks I'll fix both. Tommaso 2015-01-29 9:54 GMT+01:00 Joern Kottmann

Re: svn commit: r1655546 - in /opennlp/trunk/opennlp-tools: pom.xml src/test/java/opennlp/tools/ngram/ src/test/java/opennlp/tools/ngram/NGramModelTest.java src/test/resources/opennlp/tools/ngram/ src

2015-01-29 Thread Joern Kottmann
On Thu, 2015-01-29 at 08:02 +, tomm...@apache.org wrote: +String modelString = IOUtils.toString(nGramModelStream); +String outputString = out.toString(Charset.defaultCharset().name()); The XML serialization writes it in UTF-8. Shouldn't you use UTF-8 for this test too instead of

Re: svn commit: r1655546 - in /opennlp/trunk/opennlp-tools: pom.xml src/test/java/opennlp/tools/ngram/ src/test/java/opennlp/tools/ngram/NGramModelTest.java src/test/resources/opennlp/tools/ngram/ src

2015-01-29 Thread Tommaso Teofili
even after my latest commit? If so I'll rearrange the test a bit. Tommaso 2015-01-29 10:21 GMT+01:00 Joern Kottmann kottm...@gmail.com: Or if that is a problem for the test, you could also tell RAT to ignore it. On my machine the test fails. The two strings don't match. Jörn On Thu,

Re: svn commit: r1655546 - in /opennlp/trunk/opennlp-tools: pom.xml src/test/java/opennlp/tools/ngram/ src/test/java/opennlp/tools/ngram/NGramModelTest.java src/test/resources/opennlp/tools/ngram/ src

2015-01-29 Thread Tommaso Teofili
right, thanks I'll fix both. Tommaso 2015-01-29 9:54 GMT+01:00 Joern Kottmann kottm...@gmail.com: This file should have an AL header. Jörn On Thu, 2015-01-29 at 08:02 +, tomm...@apache.org wrote: Added:

Re: svn commit: r1655546 - in /opennlp/trunk/opennlp-tools: pom.xml src/test/java/opennlp/tools/ngram/ src/test/java/opennlp/tools/ngram/NGramModelTest.java src/test/resources/opennlp/tools/ngram/ src

2015-01-29 Thread Joern Kottmann
It still fails in the assert. I didn't check but I guess the build server has the same problem. Jörn On Thu, 2015-01-29 at 10:25 +0100, Tommaso Teofili wrote: even after my latest commit? If so I'll rearrange the test a bit. Tommaso 2015-01-29 10:21 GMT+01:00 Joern Kottmann

Re: svn commit: r1655546 - in /opennlp/trunk/opennlp-tools: pom.xml src/test/java/opennlp/tools/ngram/ src/test/java/opennlp/tools/ngram/NGramModelTest.java src/test/resources/opennlp/tools/ngram/ src

2015-01-29 Thread Tommaso Teofili
I've just disabled that test, I'll fix it and re-enable it when done. Regards, Tommaso 2015-01-29 10:51 GMT+01:00 Joern Kottmann kottm...@gmail.com: It still fails in the assert. I didn't check but I guess the build server has the same problem. Jörn On Thu, 2015-01-29 at 10:25 +0100,

Re: svn commit: r1655546 - in /opennlp/trunk/opennlp-tools: pom.xml src/test/java/opennlp/tools/ngram/ src/test/java/opennlp/tools/ngram/NGramModelTest.java src/test/resources/opennlp/tools/ngram/ src

2015-01-29 Thread Joern Kottmann
In those serialization tests I usually write the Object into a byte buffer, create it again from the byte buffer and then compare the two objects, instead of the binary representation. Could that solve the problem we have in this test? Jörn On Thu, 2015-01-29 at 12:11 +0100, Tommaso Teofili