Re: Building AOO

2019-07-27 Thread Damjan Jovanovic
ifneq ($(BUILD_VER_STRING),) $(eval $(call gb_Library_add_defs,cui,-DBUILD_VER_STRING="$(BUILD_VER_STRING)")) endif Please try fiddle with that middle line. Maybe you need $$ instead of $ and/or {} instead of (), for the BUILD_VER_STRING variable. Regards Damjan On Sun, Jul 28, 2019 at 6:24 AM

Re: Java 12 not recognized by AOO

2019-07-27 Thread Damjan Jovanovic
For AdoptOpenJDK it was config files and several .cxx files that register Java implementations (we really should extract that from config files instead). For Java 11/12 it was .cxx files that specify search paths for libjvm.so on *nix. Yes, there may still be issues on Windows/Mac/etc. On Sun,

Building AOO

2019-07-27 Thread Mechtilde
Hello, I started to build AOO like the release. I use all the options of configure as in https://svn.apache.org/viewvc/openoffice/devtools/build-scripts/4.2.0-Dev1/?sortby=date The build breaks with /home/mechtilde/aoo42x/main/cui/Library_cui.mk:37: *** missing separator. Stop. dmake: Error

Re: Java 12 not recognized by AOO

2019-07-27 Thread Peter Kovacs
Should we not move this stuff in some sort of config file?Is the information in the config file you edited? On 27.07.19 21:52, Damjan Jovanovic wrote: > Thank you. > > I've added the new paths in commit 1863883. > > Regards > Damjan > > > On Sat, Jul 27, 2019 at 8:39 PM Mechtilde wrote: > >>

Re: Java 12 not recognized by AOO

2019-07-27 Thread Damjan Jovanovic
Thank you. I've added the new paths in commit 1863883. Regards Damjan On Sat, Jul 27, 2019 at 8:39 PM Mechtilde wrote: > Hello Damjan, > > here you can see the paths of the different Java versions fpr libjvm.so > under Debian: > > /usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so >

Re: Java 12 not recognized by AOO

2019-07-27 Thread Mechtilde
Hello Damjan, here you can see the paths of the different Java versions fpr libjvm.so under Debian: /usr/lib/jvm/java-11-openjdk-amd64/lib/server/libjvm.so /usr/lib/jvm/java-12-openjdk-amd64/lib/server/libjvm.so /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so Kind regards Am

Re: Java 12 not recognized by AOO

2019-07-27 Thread Damjan Jovanovic
The problem with AdoptOpenJDK 11 is that it has a: lib/server/libjvm.so instead of the expected: lib/amd64/server/libjvm.so Patching AOO to search the new path fixes the detection problem. Does OpenJDK 11 / Oracle JDK 11 have the same change in path? Those require a different patch. Regards

Re: Java 12 not recognized by AOO

2019-07-27 Thread Damjan Jovanovic
AdoptOpenJDK 11 isn't detected. I am investigating. On Sat, Jul 27, 2019 at 7:41 PM Damjan Jovanovic wrote: > Hi Mechtilde > > No idea. I'll try AdoptOpenJDK 11 now. > > Regards > Damjan > > > On Sat, Jul 27, 2019 at 7:22 PM Mechtilde wrote: > >> Hello, >> >> @ Damjan >> >> I see your fix

Re: Java 12 not recognized by AOO

2019-07-27 Thread Damjan Jovanovic
Hi Mechtilde No idea. I'll try AdoptOpenJDK 11 now. Regards Damjan On Sat, Jul 27, 2019 at 7:22 PM Mechtilde wrote: > Hello, > > @ Damjan > > I see your fix to Issue #128157. > > Does ist also works with Openjdk 11? > > Is it possible to extend it to OpenJKD because this is standard in the >

Re: Java 12 not recognized by AOO

2019-07-27 Thread Mechtilde
Hello, @ Damjan I see your fix to Issue #128157. Does ist also works with Openjdk 11? Is it possible to extend it to OpenJKD because this is standard in the Linux distributions Kind regards Mechtide Am 10.05.19 um 08:42 schrieb Damjan Jovanovic: > On Fri, May 10, 2019 at 8:35 AM FR web

Re: [discussion] svn migration plan

2019-07-27 Thread Matthias Seidel
Hi all, Am 23.07.19 um 11:08 schrieb Matthias Seidel: > Hi Peter, > > Am 21.07.19 um 12:27 schrieb Peter Kovacs: >> back to the initial discussion. > Obviously you didn't read my mail until the end... >> I have created the request. Simply requesting that trunc, branch and >> tags are moved. All

Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO

2019-07-27 Thread Damjan Jovanovic
If you read through the LO bug report, you'll see that there are many patches for this bug, affecting multiple modules. Why? The historical files that are valid but have the wrong checksum due to having been written by the broken [OO.org-derivative] implementations when they were created, will

Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO

2019-07-27 Thread Peter Kovacs
Hi Brane, This is a very nice Idea. Maybe even beyond the immediate idea on fixing the SHA implementation. Thanks a lot for this Idea. All the Best Peter On 26.07.19 12:36, Branko Čibej wrote: > On 25.07.2019 00:43, Peter Kovacs wrote: >> Hello all, >> >> >> I would like to ask if I or any

Re: SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO

2019-07-27 Thread Peter Kovacs
OT: Welcome back Rafael! On 25.07.19 22:57, Raphael Bircher wrote: > If the code is released from the original author under Apache License > v2.0 then we can include it, else we have to write our own solution > > On Thu, Jul 25, 2019 at 9:54 PM Keith N. McKenna > wrote: >> On 7/25/2019 1:26 PM,