[GitHub] [openoffice] Pilot-Pirx commented on pull request #177: Remove unused(?) code

2023-04-30 Thread via GitHub
Pilot-Pirx commented on PR #177: URL: https://github.com/apache/openoffice/pull/177#issuecomment-1529130242 Thanks, I will check! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [openoffice] ardovm commented on pull request #177: Remove unused(?) code

2023-04-30 Thread via GitHub
ardovm commented on PR #177: URL: https://github.com/apache/openoffice/pull/177#issuecomment-1529129687 Once we delete the implementation of method `SdrGluePoint::Draw`, it is IMHO a good idea to delete its declaration as well. In this way, if any other piece of code refers to that method,

Re: gtest build error

2023-04-30 Thread Matthias Seidel
Hi Peter, Am 30.04.23 um 12:19 schrieb Peter Kovacs: > Hi All, > > As suspekted adding GTEST_ in front fixes my setup. What does that mean? Do we need to change something in our code or is it just a configuration issue? Regards,    Matthias > > All the best > > > Am 29.04.23 um 09:26 schrieb

Re: gtest build error

2023-04-30 Thread Peter Kovacs
Hi All, As suspekted adding GTEST_ in front fixes my setup. All the best Am 29.04.23 um 09:26 schrieb Peter Kovacs: Hi all. Build fails with: main/sal/qa/rtl/crc32/rtl_crc32.cxx:72:1:error: expected constructor, destructor, or type conversion before '(' token   72 | TEST_F(test,