Pilot-Pirx commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-653749584
As a first test I could build AOO42X on Windows with this patch applied.
I could also successfully export a document to PDF with Noto Sans CJK font.
ardovm commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-652807797
Thank you, Petko. It would help me to know what is the expected average size
and variation of such stacks, to give a "meaningful" initial size and optimize
the number of calls to
leginee commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-652654917
If you ncould change those and add them to the PR would be great. Or maybe
make a new PR. I have a look on the weekend.
I try to get some pointers on testing. I struggle
ardovm commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-652464308
I see that in the same file there are other fixed-size arrays used as stacks
(if I understand correctly):
* `CffSubsetterContext::mnValStack`,
*
ardovm opened a new pull request #89:
URL: https://github.com/apache/openoffice/pull/89
This is a follow-up of [bug
125359](https://bz.apache.org/ooo/show_bug.cgi?id=125359).
Instead of using fixed-size arrays, use `std::vector` as a variable-sized
array for `CffLocal` objects.
oooforum opened a new pull request #88:
URL: https://github.com/apache/openoffice/pull/88
Fix for issue #54923
Ctrl + > to increase
Ctrl + < to decrese
This is an automated message from the Apache Git Service.
To
leginee commented on pull request #87:
URL: https://github.com/apache/openoffice/pull/87#issuecomment-640177923
Yes that is correct. Let me Quote Pedro Giffuni from the discussion:
```
While looking for candidates to remove stuff, consider stax. It is
included in Java since
DamjanJovanovic commented on pull request #87:
URL: https://github.com/apache/openoffice/pull/87#issuecomment-640174534
There's a dependency from filter -> saxon -> stax
```
$ grep SAXON filter -R
filter/prj/build.lst:fl filter :L10N:l10n svtools unotools xmloff
cppu
leginee opened a new pull request #87:
URL: https://github.com/apache/openoffice/pull/87
As suggested in the [Discussion on
dev](https://lists.apache.org/thread.html/rec5be7b838a16c55ee64c12128515bc10dc74c20b3f5bf57e85e%40%3Cdev.openoffice.apache.org%3E),
I have created a patch that
leginee commented on pull request #82:
URL: https://github.com/apache/openoffice/pull/82#issuecomment-633401979
Cool, Okay I will have a look.
thx for the pointer.
I will update the pull request. So lets leave it open for now.
Pilot-Pirx merged pull request #28:
URL: https://github.com/apache/openoffice/pull/28
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Pilot-Pirx commented on pull request #83:
URL: https://github.com/apache/openoffice/pull/83#issuecomment-631965250
Anyone else wanting to review this?
This is an automated message from the Apache Git Service.
To respond to
DiGro commented on pull request #76:
URL: https://github.com/apache/openoffice/pull/76#issuecomment-623125835
Carl,
most of these changes are not visible in the office suite itself.
At least I couldn't find them where I expected them
They are part of the index for the
cbmarcum commented on pull request #76:
URL: https://github.com/apache/openoffice/pull/76#issuecomment-623117983
Where would I look in the office to see the effect of this change?
This is an automated message from the Apache
Pilot-Pirx commented on pull request #86:
URL: https://github.com/apache/openoffice/pull/86#issuecomment-623107939
I did some proofreading and I think this could be merged now...
This is an automated message from the Apache
leginee commented on pull request #76:
URL: https://github.com/apache/openoffice/pull/76#issuecomment-623105866
I see. Thanks for the update.
So far I am not negative to this proposal, but I have not checked the change
within OpenOffice.
Hope I can give feedback soon.
DiGro commented on pull request #76:
URL: https://github.com/apache/openoffice/pull/76#issuecomment-623092077
Yes, but it is not that relevant.
When I first started to remove the whitespace, I noticed that the whitespace
was
caused by extra tabs/spaces before the text. Text
leginee commented on pull request #76:
URL: https://github.com/apache/openoffice/pull/76#issuecomment-623024429
Is there a reason why multiple lines have now been addid into a single line?
This is an automated message from
leginee opened a new pull request #86:
URL: https://github.com/apache/openoffice/pull/86
I translated some german comments to english in some files.
My Idea what would be a benefit to review:
- there are only changes in comments
- spelling
- if the translations make sense
cbmarcum commented on pull request #15:
URL: https://github.com/apache/openoffice/pull/15#issuecomment-620075270
I have built the office with this patch and it adds the Insert > Object >
Fontwork Gallery to Writer as described.
Pilot-Pirx commented on pull request #83:
URL: https://github.com/apache/openoffice/pull/83#issuecomment-619529365
My Windows Test Build was successful.
Python scripts could be executed without problems.
This is an
leginee opened a new pull request #85:
URL: https://github.com/apache/openoffice/pull/85
I cleaned the module of all compiler warnings
This is an automated message from the Apache Git Service.
To respond to the message,
Pilot-Pirx commented on pull request #83:
URL: https://github.com/apache/openoffice/pull/83#issuecomment-619377299
Just FYI, these are the changes between 2.7.17 and 2.7.18:
https://github.com/python/cpython/compare/v2.7.17...v2.7.18
leginee commented on pull request #84:
URL: https://github.com/apache/openoffice/pull/84#issuecomment-619343437
I found a small issue in the build logs with undifened variables. Thge fix
fixed it for me.
Please test and merge
leginee opened a new pull request #84:
URL: https://github.com/apache/openoffice/pull/84
changed: ../solenv/bin/deliver.pl
This is an automated message from the Apache Git Service.
To respond to the message,
leginee opened a new pull request #83:
URL: https://github.com/apache/openoffice/pull/83
As announced the commit for review and further testing.
This is an automated message from the Apache Git Service.
To respond to the
701 - 726 of 726 matches
Mail list logo
