Re: [codehealth] casting int to a pointer

2022-09-24 Thread Peter Kovacs
Am 24.09.22 um 09:38 schrieb Arrigo Marchiori: Hello, On Fri, Sep 23, 2022 at 07:08:26AM +0200, Peter Kovacs wrote: Hi all, We cast int to (void*) -> (example in main/sw/source/ui/fldui/changedb.cxx line 234) In general this sounds like not a sane idea to me, see discussions [1] [2] [3].

Re: [codehealth] casting int to a pointer

2022-09-24 Thread Arrigo Marchiori
Hello, On Fri, Sep 23, 2022 at 07:08:26AM +0200, Peter Kovacs wrote: > Hi all, > > We cast int to (void*) -> (example in main/sw/source/ui/fldui/changedb.cxx  > line 234) > > In general this sounds like not a sane idea to me, see discussions [1] [2] > [3]. The solution that the c++ community

Re: [codehealth] casting int to a pointer

2022-09-22 Thread Dave Fisher
This looks like a 32bit/64bit issue. 1. How widespread are problems with C99 in the codebase? 2. Are the fixes obvious, scriptable, and tested? If the answers are easily known then let’s talk effort for trunk. Sent from my iPhone > On Sep 22, 2022, at 10:08 PM, Peter Kovacs wrote: > > Hi

[codehealth] casting int to a pointer

2022-09-22 Thread Peter Kovacs
Hi all, We cast int to (void*) -> (example in main/sw/source/ui/fldui/changedb.cxx  line 234) In general this sounds like not a sane idea to me, see discussions [1] [2] [3]. The solution that the c++ community found is the use of intptr_t, which is defined in C99. In general I would like