Re: Rat Patch take 2

Thanks Regina, We are all green now! :) https://ci.apache.org/projects/openoffice/rat-output.html Gav… > On 14 Jul 2015, at 3:40 pm, Regina Henschel wrote: > > Hi Gavin, > > Gavin McDonald schrieb: >> >>> On 14 Jul 2015, at 12:3

Re: Rat Patch take 2

Hi Gavin, Gavin McDonald schrieb: On 14 Jul 2015, at 12:37 pm, Regina Henschel wrote: Hi Gavin, Gavin McDonald schrieb: Just bumping this, anyone want to apply it? As far as I see Kay has already done this with http://svn.apache.org/r1690817 http://svn.apache.org/r1690818 http://svn.apac

Re: Rat Patch take 2

rat build run and license issues down to just the two we need to exclude:- https://ci.apache.org/projects/openoffice/rat-output.html Gav… > On 14 Jul 2015, at 12:44 pm, Gavin McDonald wrote: > > >> On 14 Jul 2015, at 12:37 pm, Regin

Re: Rat Patch take 2

> On 14 Jul 2015, at 12:37 pm, Regina Henschel wrote: > > Hi Gavin, > > Gavin McDonald schrieb: >> Just bumping this, anyone want to apply it? > > As far as I see Kay has already done this with > http://svn.apache.org/r1690817 > http://svn.apache.org/r1690818 > http://svn.apache.org/r1690819 >

Re: Rat Patch take 2

Hi Gavin, Gavin McDonald schrieb: Just bumping this, anyone want to apply it? As far as I see Kay has already done this with http://svn.apache.org/r1690817 http://svn.apache.org/r1690818 http://svn.apache.org/r1690819 http://svn.apache.org/r1690820 Kind regards Regina Thanks Gav… On 11

Re: Rat Patch take 2

Hi Gavin. I am sorry you are experiencing a delay in getting the patch committed. I have had a look at the patch, and to me it looks perfect. I would commit the patch if I could, but I am currently limited to my ipad (my development system, decided to take a heat holiday). I am convinced when on

Re: Rat Patch take 2

Just bumping this, anyone want to apply it? Thanks Gav… > On 11 Jul 2015, at 7:54 pm, Gavin McDonald wrote: > > > HI All, > > So two issues with the last patch: > > 1. I missed two pref file for excluding > > 2. Four files are treated as binaries (.project and .classpath) and so the > dif

Rat Patch take 2

HI All, So two issues with the last patch: 1. I missed two pref file for excluding 2. Four files are treated as binaries (.project and .classpath) and so the diff never showed. I’ve forced the diff in those files so should be good now. I’ll talk about why those .project and .classpath have m