Re: [RAT REPORT] - 30 files with an unknown or no License Header

2015-06-11 Thread jan i
On 8 June 2015 at 16:58, Regina Henschel rb.hensc...@t-online.de wrote:

 Hi Jürgen,

 is it OK to commit the patch?

if it not ok to commit the patch, then I wonder how the files was committed
in the first place.

If it is not ok, then the files should be deleted. We cannot have files in
trunk without the proper
ALv2 license.

Furthermore we cannot make a release with these files.

I recommend applying the patch. Deleting the files might have sideeffects.

rgds
jan i.



 Kind regards
 Regina

 Jürgen Schmidt schrieb:

  On 06/05/15 14:45, jan i wrote:

 On 6 May 2015 at 14:14, Gavin McDonald gmcdon...@apache.org wrote:

  Hi All,

 http://ci.apache.org/projects/openoffice/rat-output.html

 shows 30 files that need attention in getting valid license headers
 adding.

 A quick look shows to me that we should probably insert ASF license
 Headers
 in all of those files.

 If nobody gets to it before me I’ll provide a patch to that effect.

  I just had a look, all the files should really have ALv2 added. I
 wonder
 what happened, because I know a couple of these files used
 to have ALv2. I will take a look at svn log later.

 The archives however is covered by the general LICENSE file, when we
 make a
 distribution.

 Patches are welcome.
 rgds
 jan I.



 the files were from a new project that is currently stalled, I believe
 the headers were simply forgotten. They are not part of the office yet
 and if they are in the source tarball it is just a mistake.

 Juergen


 -
 To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
 For additional commands, e-mail: dev-h...@openoffice.apache.org




 -
 To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
 For additional commands, e-mail: dev-h...@openoffice.apache.org




review canceled: [Issue 126305] WebDAV lock on 4.1.1 does not work : [Attachment 84738] Add lock functionality to WebDAV, according to RFC4918

2015-06-11 Thread bugzilla
Giuseppe Castagno (aka beppec56) giuseppe.casta...@acca-esse.eu has canceled
Giuseppe Castagno (aka beppec56) giuseppe.casta...@acca-esse.eu's request for
review:
Issue 126305: WebDAV lock on 4.1.1 does not work
https://bz.apache.org/ooo/show_bug.cgi?id=126305

Attachment 84738: Add lock functionality to WebDAV, according to RFC4918
https://bz.apache.org/ooo/attachment.cgi?id=84738action=edit

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



review requested: [Issue 126305] WebDAV lock on 4.1.1 does not work : [Attachment 84784] Proposed patch to fix the issue, version #2

2015-06-11 Thread bugzilla
Giuseppe Castagno (aka beppec56) giuseppe.casta...@acca-esse.eu has asked 
for review:
Issue 126305: WebDAV lock on 4.1.1 does not work
https://bz.apache.org/ooo/show_bug.cgi?id=126305

Attachment 84784: Proposed patch to fix the issue, version #2
https://bz.apache.org/ooo/attachment.cgi?id=84784action=edit



--- Comment #3 from Giuseppe Castagno (aka beppec56)
giuseppe.casta...@acca-esse.eu ---
Created attachment 84784
  -- https://bz.apache.org/ooo/attachment.cgi?id=84784action=edit
Proposed patch to fix the issue, version #2

The patch is rebased on trunk, r1683442.

It completely replaces the former one.

I added the placeholder '//-i126305' where changes where made (sfx2,
ucbhelper, comphelper, offapi, ucb).

The patch was built successfully both on Linux (Ubuntu 14.04 64bit) and Windows
(Windows 7 64bit).

Changes from the previous patch version:

- fixed a regression while doing copy/paste among AOO application;

- added a correct refresh of the document while turning it to r/w from r/o
(e.g. when the other user releases the lock on the WebDAV resource). This same
refresh is operating even when you try to switch from r/o to r/w and the
document is reported as still locked, so the user can see the current document
state;

- corrected a wrong behaviour existent in AOO 4.1.1, where the edit button on
toolbar stop functioning after you try it several time and the file is still
locked by another user;

- shortened the refresh time of the lock because some WebDAV servers even
though they are HTTP/1.1 after some time they return an error that is mapped by
serf to 'connection closed by peer'.
Time was reduced from 3 minutes down to 2 minutes to solve the problem.

- removed some unused white spaces while I was at it...

In my own opinion, this patch should be evaluated to be added to AOO 4.1.2
version.

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org