Re: issue with dmake clean
Hello all, On Tue, Dec 15, 2020 at 05:56:48PM -0500, Carl Marcum wrote: > On 12/15/20 3:37 PM, Peter Kovacs wrote: > > > > On 15.12.20 20:14, Jim Jagielski wrote: > > > > > > > On Dec 15, 2020, at 12:57 PM, Matthias Seidel > > > > wrote: > > > > > > > > Hi Carl, > > > > > > > > Am 13.12.20 um 23:43 schrieb Carl Marcum: > > > > > Hi Matthias, > > > > > > > > > > On 12/13/20 4:29 PM, Matthias Seidel wrote: > > > > > > Hi Carl, > > > > > > > > > > > > Am 13.12.20 um 19:02 schrieb Carl Marcum: > > > > > > > Hi all, > > > > > > > > > > > > > > Just ran into something. > > > > > > > > > > > > > > I ran 'dmake clean' from main probably without having ran source > > > > > > > and it removed all of my directories under > > > > > > > main. > > > > > > Tried to do that on Windows (Cygwin64), went into main, > > > > > > did "autoconf", > > > > > > "dmake clean": > > > > > > > > > > > > $ dmake clean > > > > > > -bash: dmake: command not found > > > > > > > > > > > > Only after "source winenv.set.sh" it did clean up what it should... > > > > > It could be because I have a built and installed dmake on my system. > > > > > > > > > > Thanks for checking! > > > > If an installed dmake does have this consequence we should have > > > > a closer > > > > look at it... > > > > > > > It must be getting those commands from a makefile somewhere > > > though... dmake itself has no concept of 'clean' independent of what > > > a makefile tells it it is AFAIK > > > > there is a makefile on that level. However I think it is for make and > > not for dmake. At least when I want to reset the build for sure I do a > > dmake clean (from instsetoo_native)first, followed by a make clean > > (main). > > > > And the make clean has this rm command and removes all sorts of stuff. > > Could it be that if you execute dmake clean on main folder will let > > dmake read the make file ment for gnumake? [...] > I've had it happen twice now and it's a pain when it happens but probably > not dmake's fault. If main/makefile.mk is used by dmake, then that could be the culprit. The clean target does: > clean .PHONY: > -rm -rf */$(INPATH) [... the rest is uninportant ...] The INPATH variable is set by the Env.sh script If the env.sh script is not set, then the command is interpreted as: rm -rf */ I don't know dmake, but if it was GNU Make a possible fix would be something like: > clean .PHONY: > if [ -z "$(INPATH)" ]; then echo "Environment not set!"; exit 1; fi > -rm -rf */$(INPATH) [... the rest same as above ...] The GNU Make Makefile main/Makefile prevents this error. Its clean target is in fact: > clean: > . ./*Env.Set.sh && \ > dmake clean In English: first include the file ending with "Env.Set.sh" and only then run "dmake clean". I can issue a PR to fix makefile.mk but it will take me one or two days; if no one can react any quicker, please let me know and I will put this in my to-do list. Regards, -- rigo http://rigo.altervista.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice-mwiki] cbmarcum merged pull request #1: add updated OOoIDLtags.php
cbmarcum merged pull request #1: URL: https://github.com/apache/openoffice-mwiki/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice-mwiki] cbmarcum opened a new pull request #1: add updated OOoIDLtags.php
cbmarcum opened a new pull request #1: URL: https://github.com/apache/openoffice-mwiki/pull/1 Updated OOoIDLtags.php file to replace the deprecated ereg_replace methods with the new preg_replace and updated arguments. Also I bumped the minor version number present in the file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: issue with dmake clean
On 12/15/20 3:37 PM, Peter Kovacs wrote: On 15.12.20 20:14, Jim Jagielski wrote: On Dec 15, 2020, at 12:57 PM, Matthias Seidel wrote: Hi Carl, Am 13.12.20 um 23:43 schrieb Carl Marcum: Hi Matthias, On 12/13/20 4:29 PM, Matthias Seidel wrote: Hi Carl, Am 13.12.20 um 19:02 schrieb Carl Marcum: Hi all, Just ran into something. I ran 'dmake clean' from main probably without having ran source and it removed all of my directories under main. Tried to do that on Windows (Cygwin64), went into main, did "autoconf", "dmake clean": $ dmake clean -bash: dmake: command not found Only after "source winenv.set.sh" it did clean up what it should... It could be because I have a built and installed dmake on my system. Thanks for checking! If an installed dmake does have this consequence we should have a closer look at it... It must be getting those commands from a makefile somewhere though... dmake itself has no concept of 'clean' independent of what a makefile tells it it is AFAIK there is a makefile on that level. However I think it is for make and not for dmake. At least when I want to reset the build for sure I do a dmake clean (from instsetoo_native)first, followed by a make clean (main). And the make clean has this rm command and removes all sorts of stuff. Could it be that if you execute dmake clean on main folder will let dmake read the make file ment for gnumake? In total I do not have a high confidence in general in our build system. It is complicated and complex. And if some things do not fit it will do unexpected things. It could very well be the result of me using the same session for many builds and switching back and forth between branches in the same terminal session. I've had it happen twice now and it's a pain when it happens but probably not dmake's fault. I'll see if I can recreate it in a consistent way and report back. Thanks, Carl - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on pull request #112: updated handling of repating groupheaders
leginee commented on pull request #112: URL: https://github.com/apache/openoffice/pull/112#issuecomment-745573586 If not needed I would would opt that the dead code is removed. :) Can you remove it? or should I check how I can incorporate this wish? We need only the Apache License. If I were you I would add the License to the Comments that the patch is under dual License (Apache License, Mozilla License). But this is me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: issue with dmake clean
On 15.12.20 20:14, Jim Jagielski wrote: On Dec 15, 2020, at 12:57 PM, Matthias Seidel wrote: Hi Carl, Am 13.12.20 um 23:43 schrieb Carl Marcum: Hi Matthias, On 12/13/20 4:29 PM, Matthias Seidel wrote: Hi Carl, Am 13.12.20 um 19:02 schrieb Carl Marcum: Hi all, Just ran into something. I ran 'dmake clean' from main probably without having ran source and it removed all of my directories under main. Tried to do that on Windows (Cygwin64), went into main, did "autoconf", "dmake clean": $ dmake clean -bash: dmake: command not found Only after "source winenv.set.sh" it did clean up what it should... It could be because I have a built and installed dmake on my system. Thanks for checking! If an installed dmake does have this consequence we should have a closer look at it... It must be getting those commands from a makefile somewhere though... dmake itself has no concept of 'clean' independent of what a makefile tells it it is AFAIK there is a makefile on that level. However I think it is for make and not for dmake. At least when I want to reset the build for sure I do a dmake clean (from instsetoo_native)first, followed by a make clean (main). And the make clean has this rm command and removes all sorts of stuff. Could it be that if you execute dmake clean on main folder will let dmake read the make file ment for gnumake? In total I do not have a high confidence in general in our build system. It is complicated and complex. And if some things do not fit it will do unexpected things. -- This is the Way! http://www.apache.org/theapacheway/index.html - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: issue with dmake clean
> On Dec 15, 2020, at 12:57 PM, Matthias Seidel > wrote: > > Hi Carl, > > Am 13.12.20 um 23:43 schrieb Carl Marcum: >> Hi Matthias, >> >> On 12/13/20 4:29 PM, Matthias Seidel wrote: >>> Hi Carl, >>> >>> Am 13.12.20 um 19:02 schrieb Carl Marcum: Hi all, Just ran into something. I ran 'dmake clean' from main probably without having ran source and it removed all of my directories under main. >>> Tried to do that on Windows (Cygwin64), went into main, did "autoconf", >>> "dmake clean": >>> >>> $ dmake clean >>> -bash: dmake: command not found >>> >>> Only after "source winenv.set.sh" it did clean up what it should... >> It could be because I have a built and installed dmake on my system. >> >> Thanks for checking! > > If an installed dmake does have this consequence we should have a closer > look at it... > It must be getting those commands from a makefile somewhere though... dmake itself has no concept of 'clean' independent of what a makefile tells it it is AFAIK
Re: [openoffice-mwiki-ext] branch master created (now 61af533)
Hi all, Am 12.12.20 um 21:53 schrieb Dick Groskamp: > > On 2020/12/12 19:51:00, Matthias Seidel wrote: >> Hi Dick, >> >> Am 12.12.20 um 20:45 schrieb Dick Groskamp: >>> My bad. Sorry guys. >>> I had trouble adding the file to the repo because it was empty then. >>> Had to grab back on older documentation and that's how it became what it is. >>> Don't know if it is possible to delete this one and make a new branch, for >>> instance IDLTags, to differentiate the coming content of the repo? >> I already created a branch "main" >> >> I will ask Infra to set it to default, then we can delete "master" >> >> Regards, >> >> Matthias >> > Great! thanks After some discussion we decided to create a new repo: https://github.com/apache/openoffice-mwiki Please use this one only! I will ask Infra to remove the "old" openoffice-mwiki-ext. Additionally I will create a repo for our forum modifications. Furthermore we plan to move our devtools from SVN to a GitHub repo. Regards, Matthias >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> >> > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > smime.p7s Description: S/MIME Cryptographic Signature
Re: issue with dmake clean
Hi Carl, Am 13.12.20 um 23:43 schrieb Carl Marcum: > Hi Matthias, > > On 12/13/20 4:29 PM, Matthias Seidel wrote: >> Hi Carl, >> >> Am 13.12.20 um 19:02 schrieb Carl Marcum: >>> Hi all, >>> >>> Just ran into something. >>> >>> I ran 'dmake clean' from main probably without having ran source >>> and it removed all of my directories under main. >> Tried to do that on Windows (Cygwin64), went into main, did "autoconf", >> "dmake clean": >> >> $ dmake clean >> -bash: dmake: command not found >> >> Only after "source winenv.set.sh" it did clean up what it should... > It could be because I have a built and installed dmake on my system. > > Thanks for checking! If an installed dmake does have this consequence we should have a closer look at it... I remember this bug in Steam: https://www.theregister.com/2015/01/17/scary_code_of_the_week_steam_cleans_linux_pcs/ Regards, Matthias > >> >> Regards, >> >> Matthias >> >>> Looks like it ran 'rm -rf */' >>> >>> Best regards, >>> Carl >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > smime.p7s Description: S/MIME Cryptographic Signature
[GitHub] [openoffice] Grosskopf commented on pull request #112: updated handling of repating groupheaders
Grosskopf commented on pull request #112: URL: https://github.com/apache/openoffice/pull/112#issuecomment-745430027 Thank you for the quick answer :) True, we don't need that. I tried Squashing it but that didn't quite work the way I expected xD is this ok? Also, I committed this patch to Libreoffice too (https://gerrit.libreoffice.org/c/core/+/107780/3), so it would be under Apache License for you and under multiple licenses for TDF right? :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on pull request #112: updated handling of repating groupheaders
leginee commented on pull request #112: URL: https://github.com/apache/openoffice/pull/112#issuecomment-745358578 Awesome! Thanks for the patch. While reviewing the patch, I noticed that some code has only commented out and not removed. Is there any reason why we want to keep it? see main/reportbuilder/java/com/sun/star/report/pentaho/output/text/TextRawReportTarget.java (patched line: 1245 to 1248) `1245/*if (getGroupContext().isGroupWithRepeatingSection()) in to ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] Grosskopf opened a new pull request #112: updated handling of repating groupheaders
Grosskopf opened a new pull request #112: URL: https://github.com/apache/openoffice/pull/112 A fix for [Bug 108383](https://bz.apache.org/ooo/show_bug.cgi?id=108383) Repeating groupheaders were in the page's header while normal groupheaders were in the pages body. So when a normal groupheader was before a repeating groupheader, it would go to body first, write the normal groupheader and then "return" to the next pages header to write the repeating groupheader since that is the next possible header to write to. In this fix I have changed this, so that a repeating groupheader writes to the page body like the normal groupheader, but also creates a followup pagestyle that has the repeating groupheader in the header. This was tested mostly in Libreoffice since their bug 51452 is the exact same and the source code is not so different in this area but it was tested once in open office and created similar results. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Beanshell
Just a FYI: https://twitter.com/jimjag/status/1338840166828568576 TL;DR: I've forked beanshell and beanshell2 into something which maybe we can baseline for AOO - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
