[GitHub] [openoffice] leginee commented on pull request #133: graphite: remove the -Werror option from debug builds

2021-07-04 Thread GitBox
leginee commented on pull request #133: URL: https://github.com/apache/openoffice/pull/133#issuecomment-873534871 Okay, lets merge. The issues are there anyhow. I dont think the code is better or worse with the change. -- This is an automated message from the Apache Git Service. To

[GitHub] [openoffice] leginee commented on pull request #133: graphite: remove the -Werror option from debug builds

2021-06-20 Thread GitBox
leginee commented on pull request #133: URL: https://github.com/apache/openoffice/pull/133#issuecomment-864513194 Then we have 2 choices. Fix the Issues or prepare the switch to a replacement. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [openoffice] leginee commented on pull request #133: graphite: remove the -Werror option from debug builds

2021-06-19 Thread GitBox
leginee commented on pull request #133: URL: https://github.com/apache/openoffice/pull/133#issuecomment-864492889 The meaing of the Flag is -Werror: every warning is treated as an error. Since Grafite is a dependency it is fine to build without. However Imho we should strife for