Re: what is this supposed to do?

2019-11-06 Thread Branko Čibej
On 06.11.2019 18:06, Don Lewis wrote: > On 6 Nov, Branko Čibej wrote: >> On 05.11.2019 20:20, Peter Kovacs wrote: >>> I am not sure why, but if you use gcc++98 std it compiles. Maybe it >>> optimizes the code since it might be dead code. >> That would be a very, very strange way to go about

Re: what is this supposed to do?

2019-11-06 Thread Don Lewis
On 6 Nov, Branko Čibej wrote: > On 05.11.2019 20:20, Peter Kovacs wrote: >> I am not sure why, but if you use gcc++98 std it compiles. Maybe it >> optimizes the code since it might be dead code. > > That would be a very, very strange way to go about things. To figure out > something is dead

Re: what is this supposed to do?

2019-11-06 Thread Branko Čibej
On 05.11.2019 20:20, Peter Kovacs wrote: > I am not sure why, but if you use gcc++98 std it compiles. Maybe it > optimizes the code since it might be dead code. That would be a very, very strange way to go about things. To figure out something is dead code, you have to at *least* parse it first,

Re: what is this supposed to do?

2019-11-06 Thread Peter Kovacs
If it is not used we should drop the code. I do not believe anyone will use this part. The whole file is only used to calculate Grescale palette and some other predifened bitmap. The object created I think behind all this is bitmap device (or similar) which I think should be replaced at some

Re: what is this supposed to do?

2019-11-05 Thread Don Lewis
On 5 Nov, Peter Kovacs wrote: > I am not sure why, but if you use gcc++98 std it compiles. Maybe it > optimizes the code since it might be dead code. It breaks the build in any mode for me with gcc9. I vaguely remember running across this code before, maybe with clang after it's default

Re: what is this supposed to do?

2019-11-05 Thread Peter Kovacs
I am not sure why, but if you use gcc++98 std it compiles. Maybe it optimizes the code since it might be dead code. I rewrote the whole code, and used one class instead of 4 macros that copy paste from each other. I can post the code. But I do not know how to test or apply it into the rest. :P

Re: what is this supposed to do?

2019-11-05 Thread Branko Čibej
On 05.11.2019 19:54, Don Lewis wrote: > I don't understand what this strange little bit of code (line 611 of > basebmp/inc/basebmp/packedpixeliterator.hxx) is supposed to do: > > value_type get(difference_type const & d) const > { > const int remainder( x(d.x) %

what is this supposed to do?

2019-11-05 Thread Don Lewis
I don't understand what this strange little bit of code (line 611 of basebmp/inc/basebmp/packedpixeliterator.hxx) is supposed to do: value_type get(difference_type const & d) const { const int remainder( x(d.x) % num_intraword_positions ); ^^