[dev] Nice tool for better and faster issue reporting/description
Hi, I thought it could be great to describe issues by just recording a short screencast of what is going on then insert the URL of the recording in the bugzilla entry. The company I work for offer a free-really simple tool to record your screen without installation. Users and developers could use it easily to communicate about their experience with OO. For more information, bookmarklet, etc you can check it at http://www.screenjelly.com What do you think ? Sebastien aka PliPli - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Nice tool for better and faster issue reporting/description
On 2009.09.09. 20:51, Sebastien Plisson wrote: Hi, I thought it could be great to describe issues by just recording a short screencast of what is going on then insert the URL of the recording in the bugzilla entry. The company I work for offer a free-really simple tool to record your screen without installation. Users and developers could use it easily to communicate about their experience with OO. For more information, bookmarklet, etc you can check it at http://www.screenjelly.com What do you think ? flash based. personally, i would not use it for that reason (flash is not in an acceptable state on linux). Sebastien aka PliPli -- Rich - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] Re: What is a SLOT and What is a WHICH?
Zhu Lihua wrote:
Modules here means the application module. While slotids mark a
functionality in the UI, whichids mark the corresponding attribute in
the document core of the application.
Does it mean WhichID is a root ID of the corresponding SlotIDs?
I guess, common functionality in different module have different SlotID,
but they have the same WhichID which match this functionality. So we
convert it to WhichID, and the program know which functionality is it.
Right?
A whichid is only valid in the code of a particular application module.
Even slotids that are common to all modules have different whichids
assigned in the applications).
The slotid is a universal ID, it is understood in all modules. In the
code of each application module there is a conversion table that
converts the slot ids into the matching whichids.
Where is this table? I believe it helps to me to understand the
relationship of the SlotID and WhichID. Does it exist as a file? or Is
it a dynamic array in the run time?
This mapping table is constructed as part of the module's pool. In
Writer this e.g. happens in sw/source/core/bastyp/init.cxx, in Calc it's
sc/source/core/data/docpool.cxx.
You will find an array of SlotIds there, and the the whichid belonging
to each slotid just is the position in this array plus an offset that is
specified when the pool is created. In Calc you can see:
static SfxItemInfo __READONLY_DATA aItemInfos[] =
{
{ SID_ATTR_CHAR_FONT, SFX_ITEM_POOLABLE }, // ATTR_FONT
{ SID_ATTR_CHAR_FONTHEIGHT, SFX_ITEM_POOLABLE }, // ATTR_FONT_HEIGHT
{ SID_ATTR_CHAR_WEIGHT, SFX_ITEM_POOLABLE }, // ATTR_FONT_WEIGHT
.
};
where the index of the slotid SID_ATTR_CHAR_FONT is 0.
When the ctor of the ScDocumentPool initializes its base class
SfxItemPool it hands over this array and an offset:
ScDocumentPool::ScDocumentPool(
SfxItemPool* pSecPool, BOOL bLoadRefCounts )
:SfxItemPool (
String::CreateFromAscii(RTL_CONSTASCII_STRINGPARAM(ScDocumentPool)),
ATTR_STARTINDEX, ATTR_ENDINDEX,
aItemInfos, NULL, bLoadRefCounts ),
pSecondary ( pSecPool )
{
..
}
This offset is ATTR_STARTINDEX (=100 as defined in sc/inc/scitems.hxx).
So now the pool knows that the whichid 100 is assigned to the slotid
SID_ATTR_CHAR_FONT, 101 is assigned to SID_ATTR_CHAR_FONTHEIGHT etc.
If you look at the definition of aItemInfos, you will find some array
members with slotid 0:
{ SID_ATTR_CHAR_RELIEF, SFX_ITEM_POOLABLE }, //
ATTR_FONT_RELIEF { SID_ATTR_ALIGN_HYPHENATION,
SFX_ITEM_POOLABLE },//
ATTR_HYPHENATE
{ 0, SFX_ITEM_POOLABLE },// ATTR_SCRIPTSPACE
These whichids don't have a slotid assigned. A whichid whose attribute
is not manipulated by dispatch calls or generic dialogs (see below)
doesn't need a slotid as this is the only place in the code where
slotids are needed. To handle the attribute in the document core code
the whichid is sufficient.
OTOH many slotids don't have a whichid assigned in a particular pool.
Only core attributes (as the Font attributes shown above) have it, but
e.g. an SfxDocumentInfoItem doesn't.
If an SfxItemSet is created, it must get an SfxItemPool. If an item is
put into the SfxItemSet that matches the specified WhichRanges (an
unfortunate name as it can contain whichids as well as slotids) of the
SfxItemSet, the SfxItemSet checks whether the id is a slotid or a
whichid ( this is simple: slotids are = 5000, whichids are 5000). The
SfxItemSet can convert the slotid to the assigned whichid by using the
table of the pool. If no whichid for the slotid is found in the pool,
the item keeps its slotid. Getting this item back from the pool must be
aware of that and use whichids where necessary.
This procedure is needed in two scenarios: UI controls (e.g. toolbar
controls) and generic (application independent) dialogs. Both UI
elements may pass information as SfxPoolItems in an SfxItemSet. As they
don't know in which application they are used, they use the globally
unique slotids to identify items. OTOH the document that finally
receives the call wants to work with its own whichids. So the SfxItemSet
and its SfxItemPool together work as a translator from slot language
to which language. In case of generic dialogs the SfxItemSet is passed
to them when the dialog is constructed, in case of dispatch calls from
UI controls the SfxItemSet is retrieved from the document by the
framework code that receives the SfxPoolItems from the control and puts
it into an SfxItemSet that the document code receives as part of an
SfxRequest object.
HTH,
Mathias
--
Mathias Bauer (mba) - Project Lead OpenOffice.org Writer
OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS
Please don't reply to nospamfor...@gmx.de.
I use it for the OOo lists and only rarely read other mails sent to it.
-
To unsubscribe, e-mail:
Re: [dev] Re: [qa-dev] Looking for QA-Rep for cws cloph13 - create backwards compatible builds for Mac by using the developer-sdk during compilation
Hi Christian, what is the state of your CWS? Today I saw it in a query on EIS and do not see any progress documented in the CWS. Do you think it will be ready soon to get it integrated in OOo 3.2? Release Engineering planned only one more build before the branch - m58 is in work now and m59 should be the version for the branch. So the CWS must be ready until this weekend, I think. Thorsten Christian Lohmaier schrieb: Hi Aaron, Thorsten, *, thanks for your kind offers :-) - see below On Wed, Sep 2, 2009 at 7:54 PM, Thorsten Behrenst...@openoffice.org wrote: Christian Lohmaier wrote: (i.e. if you have a MAC OSX 10.4 and can check the installset, or if you can verify the code changes by themselves,...) can test-drive the installset do the code review; likely no time though for a proper testtool or tcm qa though. Great - no worries, tinderbox did just finish building the Intel-installset: http://termite.go-oo.org/install_sets/MacIntel-3589-cloph13-install_set.zip Please give it a spin :-) As for code review: Feel free to directly comment in the corresponding issue or in EIS or ping me on IRC, write a mail (you get the idea :-)) Unfortunately no PPC build machine that runs with Leopard, only Tiger. While it can be used to check that no reqressions are introduced while building with Tiger, it isn't quite what the issue is about. So again the plead for help: @all:Got a PPC with Mac OSX 10.5? Can build OOo? Great - please give cws cloph13 a shot! (even if you cannot perform tests yourself, having a 10.5 built installset for PPC would help a lot) Nevertheless I'll build one on 10.4 and upload it tomorrow/later today. ciao Christian - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
[dev] Re: Problems building DEV300_m54 on Ubuntu
Eike Rathke wrote: Hi Kristján, On Sunday, 2009-09-06 20:49:27 +, Kristján Bjarni Guðmundsson wrote: I am having problems building DEV300_m54 on Ubuntu, I am using the prepared Ubuntu build image, but with a newer source. I get the following error: /home/ooo/Desktop/DEV300_m54/solver/300/ unxlngi6.pro/inc/mozilla/string/nsTAString.h:529: undefined reference to `nsObsoleteAString::sCanonicalVTable' Did you upgrade the Mozilla pre-built as well? As of m53 newer ones are needed, see http://tools.openoffice.org/moz_prebuild/OOo3.2/ Eike why would he need a prebuilt mozilla? he is using --disable-mozilla: My configure is following: ./configure --with-use-shell=bash --with-system-libs --without-system-jars --without-system-icu --without-system-agg --without-system-lpsolve --without-system-mspack --disable-mozilla --disable-gtk i've had a quick look at the connectivity module, mozab/mozbootstrap, and what an awful mess it is... in the !WITH_MOZILLA case, it still builds something, with most of the code #ifdef-ed out! Frank, you're probably the only one who could know what is going wrong here... my guess: probably there is some mozilla string in there that is not properly #ifdef-ed out or something. michael PS: it seems those mozilla jokers even have renamed their obsolete string classes to indicate they're obsolete; sadly we have not even gotten this far :( PPS: does anybody know how many string classes are actually in use in OOo? recently learned that autodoc does not use sal strings, but a homegrown one... -- As the patent office has been so apt at demonstrating, a failure to find the sources and an unfamiliarity with the subject is easily mistaken for originality. -- Znork - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
[dev] Re: [mac] Re: [dev] Re: [qa-dev] Looking for QA-Rep for cws cloph13 - create backwards compatible builds for Mac by using the developer-sdk during compilation
Hi Thorsten, *, On Thu, Sep 10, 2009 at 11:49 AM, Thorsten Ziehmthorsten.zi...@sun.com wrote: what is the state of your CWS? Today I saw it in a query on EIS and do not see any progress documented in the CWS. Do you think it will be ready soon to get it integrated in OOo 3.2? From my part it is ready - but unfortunately only Thorsten did provide feedback (all OK so far) Release Engineering planned only one more build before the branch - m58 is in work now and m59 should be the version for the branch. So the CWS must be ready until this weekend, I think. As nobody did report any problems, and the cws doesn't touch any actual code, only the makefiles, I think it is OK to integrate. I myself didn't find any either (well, that doesn't count much I guess :-))... ciao Chrstian PS: The build breakers of the ubuntu and solaris bots in connectivity are unrelated to the cws - apparently they're using wrong mozilla zips (the ones needed for m53 and newer, but the cws is based on m52, so you'd need the old zips. /MNSInclude.hxx:77:35: error: nsIAbLDAPAttributeMap.h: No such file or directory - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
[dev] Re: [qa-dev] Re: [mac] Re: [dev] Re: [qa-dev] Looking for QA-Rep for cws cloph13 - create backwards compatible builds for Mac by using the developer-sdk during compilation
Hi Christian, if you think everything is done for this CWS, it can be set to status 'approved by QA'. To make the process correctly, please do the following. - add Thorsten Behrens as QA representative - add the information about bot-results and code review etc. to the CWS descriptions - set all issues to a correct target (perhaps 3.2 or all to dev-tools) - set all issues to status verified and add that the changes were check by another person - let's change the CWS status to 'approved by QA' by Thorsten (I do not know if you can do this) If you need more feedback to be save, you haven't so much time ;-) Regards, Thorsten Christian Lohmaier schrieb: Hi Thorsten, *, On Thu, Sep 10, 2009 at 11:49 AM, Thorsten Ziehmthorsten.zi...@sun.com wrote: what is the state of your CWS? Today I saw it in a query on EIS and do not see any progress documented in the CWS. Do you think it will be ready soon to get it integrated in OOo 3.2? From my part it is ready - but unfortunately only Thorsten did provide feedback (all OK so far) Release Engineering planned only one more build before the branch - m58 is in work now and m59 should be the version for the branch. So the CWS must be ready until this weekend, I think. As nobody did report any problems, and the cws doesn't touch any actual code, only the makefiles, I think it is OK to integrate. I myself didn't find any either (well, that doesn't count much I guess :-))... ciao Chrstian PS: The build breakers of the ubuntu and solaris bots in connectivity are unrelated to the cws - apparently they're using wrong mozilla zips (the ones needed for m53 and newer, but the cws is based on m52, so you'd need the old zips. /MNSInclude.hxx:77:35: error: nsIAbLDAPAttributeMap.h: No such file or directory - To unsubscribe, e-mail: dev-unsubscr...@qa.openoffice.org For additional commands, e-mail: dev-h...@qa.openoffice.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
