Re: [OSM-dev] multipolygon inherits from tags way that are neither inner nor outer
On Tue, Jan 17, 2012 at 12:13 AM, Frederik Ramm frede...@remote.org wrote: It depends on what you want to do. If you want to draw the best possible map with the data you have, and have no option of asking the user what the hell he meant when he entered that, then you will ignore roles (and compute them yourself) because otherwise a significant percentage of multipolygons will appear broken. For me. there is a difference between trying to interprete the data when the role is undefined (good will) and simply ignoring the role definition when it is clearly stating it is not an inner neiter an outer way. Pieren ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
[OSM-dev] multipolygon inherits from tags way that are neither inner nor outer
Today there was an example on talk-it for a multipolygon relation that inherited a building tag from an object that was in the relation with the role admin_centre: This is the relation: http://www.openstreetmap.org/browse/relation/1970835 This is the way in question from which was inherited: http://www.openstreetmap.org/browse/way/63249794 this is the rendering: http://www.openstreetmap.org/?lat=45.7691lon=10.1164zoom=13layers=M Not sure if this had happened as well if the missing tags (boundary=administrative and admin_level) had been associated to the relation, but should tags on ways that aren't outer ways be inherited anyways? cheers, Martin ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] multipolygon inherits from tags way that are neither inner nor outer
I have an update on this: With the boundary and admin_level tags on the relation now the member tagged as admin_centre gets interpreted as inner-way (the administrative boundary is also drawn around the building), but no building tag is inherited anymore on the multipolygon. cheers, Martin ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] multipolygon inherits from tags way that are neither inner nor outer
On 16-1-2012 18:35, Martin Koppenhoefer wrote: With the boundary and admin_level tags on the relation now the member tagged as admin_centre gets interpreted as inner-way (the administrative boundary is also drawn around the building), but no building tag is inherited anymore on the multipolygon. Well, what do you expect when you add an inner way (the building) to an area object (the administrative region)? Never mind any additional tags. It will be interpreted as such: a gap in the area. An enclave, in this particular case, with an appropriate line drawn around the building. So there you have it: don't add stuff to area datatypes that doesn't belong in them. -- Lennard ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] multipolygon inherits from tags way that are neither inner nor outer
Hi, On 01/16/2012 06:35 PM, Martin Koppenhoefer wrote: With the boundary and admin_level tags on the relation now the member tagged as admin_centre gets interpreted as inner-way (the administrative boundary is also drawn around the building), but no building tag is inherited anymore on the multipolygon. This is what I would have expected. At least any code that I have written will completely disregard outer/inner tags and instead find out for itself whether something is outer or inner. Adding anything other than rings of a polygon to a multipolygon relation is not supported. I know the practice of adding admin centre nodes or so but I don't think it makes sense. If you really want to model this right then you need to do: (relation 1) is a type=whatever that represents the country (relation 2) is a type=boundary or multipolygon that represents the country's border or land and is member of r1 in role border (node/way 3) represents the admin center and is member of r1 in role admin_centre Countries have admin centres, and countries have boundaries - not boundaries have admin centres, and neither countries are boundaries. Bye Frederik -- Frederik Ramm ## eMail frede...@remote.org ## N49°00'09 E008°23'33 ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] multipolygon inherits from tags way that are neither inner nor outer
thank you both for your replies, I will paste these back to the local ML. Maybe we should also push this to [tagging] and change the wiki. cheers, Martin ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] multipolygon inherits from tags way that are neither inner nor outer
For a relation of type boundary, it make sense to link the administrative boundary with its administrative centre. This is more elegant than creating 2 relations just because some countries decided to use the same relation type for administrative boundaries and multipolygons (and yes, countries are boundaries). Or more elegant than tagging the centre as capital=WhatEverYouLike just because some apps find easier to interpret tagged nodes/ways than relations roles. I also don't understand why the roles would be ignored in multipolygon relations. Then why JOSM is complaining when the role is undefined, although the wiki says the opposite. And I don't understand why this discussion is happening on the dev list. Pieren ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] multipolygon inherits from tags way that are neither inner nor outer
Hi, On 01/17/2012 12:00 AM, Pieren wrote: For a relation of type boundary, it make sense to link the administrative boundary with its administrative centre. Yes, but the link should be indirect. The boundary should be linked from the country, and the administrative centre should be linked from the country too. Boundaries dont' have administrative centres. Neither do they have capitals. I also don't understand why the roles would be ignored in multipolygon relations. Then why JOSM is complaining when the role is undefined, although the wiki says the opposite. It depends on what you want to do. If you want to draw the best possible map with the data you have, and have no option of asking the user what the hell he meant when he entered that, then you will ignore roles (and compute them yourself) because otherwise a significant percentage of multipolygons will appear broken. It would be good if roles were always well defined, that's why JOSM reminds you of it, but it would not be good if a rendering engine would expect roles to always be well defined. Bye Frederik -- Frederik Ramm ## eMail frede...@remote.org ## N49°00'09 E008°23'33 ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
