On Fri, Aug 30, 2013 at 3:52 PM, Justin Pettit jpet...@nicira.com wrote:
It's probably worth mentioning in NEWS and updating FAQ, SubmittingPatches,
and README to remove references to 2.6.18.
ok, I will send updated patch series.
___
dev mailing
On Aug 30, 2013, at 9:48 PM, Simon Horman ho...@verge.net.au wrote:
On Fri, Aug 30, 2013 at 01:40:16PM -0700, Jarno Rajahalme wrote:
+LIST_FOR_EACH(bucket, list_node, gm-buckets) {
+++n_buckets;
Any reason you favour a pre-increment over a post-increment.
I realise it
On Mon, Sep 2, 2013 at 12:13 AM, Viresh Kumar viresh.ku...@linaro.org wrote:
But in RT kernel we have few usages of raw...
viresh@blr-linut-001:$ ggrep raw include/linux/skbuff.h
include/linux/skbuff.h: raw_spinlock_t raw_lock;
include/linux/skbuff.h:static inline void
I haven't looked at this patch closely yet. Before I do would you
please rebase it against master?
Also please change it to fall back to active-backup instead of SLB.
SLB is weird and dangerous, I don't want to encourage it's use further
than we have to, especially in a network which is likely
Patch removes genl, netlink, rtnl compat code.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
datapath/compat.h |8 --
datapath/datapath.c | 12 +-
datapath/dp_notify.c|2 +-
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
datapath/linux/Modules.mk |1 -
.../linux/compat/include/linux/reciprocal_div.h| 40
datapath/linux/compat/reciprocal_div.c |1 +
3 files changed, 1 insertions(+), 41
datapath support for older kernel is been broken for kernel
older than 2.6.32 for some time now. There have not been any
complains about this. So it makes sense to get rid of the code.
This make datapath module much close to upstream datapath and
make code easy to understand.
To make review easy I
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
datapath/Modules.mk |2 -
datapath/actions.c| 21 +-
datapath/checksum.c | 271 -
datapath/checksum.h
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
datapath/actions.c |2 +-
datapath/compat.h | 39 ---
datapath/datapath.c| 10 ++
datapath/flow.c|9 ++---
datapath/vport-gre.c |2 +-
datapath/vport-lisp.c
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
datapath/Modules.mk |1 -
datapath/datapath.c | 10 --
datapath/datapath.h |5 ---
datapath/linux/compat/netdevice.c |4 --
datapath/linux/compat/vxlan.c | 10 +-
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
datapath/linux/Modules.mk |1 -
datapath/linux/compat/include/net/genetlink.h | 18 -
datapath/linux/compat/include/net/net_namespace.h | 79 +
RHEL5 is based on kernel 2.6.18.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
INSTALL.RHEL| 19 +---
rhel/automake.mk|6 -
rhel/kmodtool-openvswitch-el5.sh| 273 ---
This makes datapath module much close to upstream datapath and
make code easy to understand.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
FAQ |5 +++--
NEWS|1 +
README |2 +-
SubmittingPatches |2 +-
datapath/datapath.c |
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
acinclude.m4 |3 -
datapath/linux/Modules.mk | 16 -
datapath/linux/compat/addrconf_core-openvswitch.c | 82
datapath/linux/compat/include/linux/dmi.h | 114
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
acinclude.m4|1 -
datapath/compat.h | 26
datapath/datapath.c | 55 ---
3 files changed, 0 insertions(+), 82 deletions(-)
diff --git a/acinclude.m4
cleanup various header file.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
datapath/linux/compat/include/linux/if_ether.h | 13
datapath/linux/compat/include/linux/kernel.h| 31 -
datapath/linux/compat/include/linux/netdevice.h | 81 ---
Rather than having compile time check in datapath.c, its better
to check kernel version at configuration step.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
acinclude.m4| 12 ++--
datapath/datapath.c |5 -
2 files changed, 10 insertions(+), 7 deletions(-)
diff
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
datapath/linux/compat/include/linux/if.h |7 ---
datapath/linux/compat/include/net/ip.h |6 --
datapath/vport-internal_dev.c| 13 -
datapath/vport-lisp.c|4
On Sat, Aug 31, 2013 at 5:11 AM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
On Fri, Aug 30, 2013 at 3:11 AM, Jesse Gross je...@nicira.com wrote:
On Thu, Aug 29, 2013 at 3:10 PM, David Miller da...@davemloft.net wrote:
From: Jesse Gross je...@nicira.com
Date: Thu, 29 Aug 2013 14:42:22 -0700
On Fri, Aug 30, 2013 at 9:16 PM, David Miller da...@davemloft.net wrote:
From: Jesse Gross je...@nicira.com
Date: Fri, 30 Aug 2013 16:20:25 -0700
I looked through the struct definition and I think that the idea of
manually padding as Geert did in his patch will be difficult to
maintain over
Hey All,
This commit seems to prevent stp from working properly.
I'll keep learning the code and trying to figure all out. But it would be
helpful if anyone can help.
My experiment configuration is:
- VMA and VMB
- create two gre tunnels (with different key) between eth3 of VMA and VMB
(this
I will take a look.
On Tue, Sep 3, 2013 at 3:14 PM, Alex Wang al...@nicira.com wrote:
Hey All,
This commit seems to prevent stp from working properly.
I'll keep learning the code and trying to figure all out. But it would be
helpful if anyone can help.
My experiment configuration is:
-
On Tue, Sep 3, 2013 at 1:59 PM, Pravin B Shelar pshe...@nicira.com wrote:
RHEL5 is based on kernel 2.6.18.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
Acked-by: Jesse Gross je...@nicira.com
___
dev mailing list
dev@openvswitch.org
On Tue, Sep 3, 2013 at 1:59 PM, Pravin B Shelar pshe...@nicira.com wrote:
diff --git a/FAQ b/FAQ
index 75d9007..5f23778 100644
--- a/FAQ
+++ b/FAQ
@@ -149,12 +149,13 @@ A: The following table lists the Linux kernel versions
against which the
1.10.x 2.6.18 to 3.8
1.11.x
On Tue, Sep 3, 2013 at 1:59 PM, Pravin B Shelar pshe...@nicira.com wrote:
diff --git a/acinclude.m4 b/acinclude.m4
index 73ee5ce..e754cfa 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -134,9 +134,17 @@ AC_DEFUN([OVS_CHECK_LINUX], [
AC_MSG_RESULT([$kversion])
if test $version
On Tue, Sep 3, 2013 at 1:59 PM, Pravin B Shelar pshe...@nicira.com wrote:
diff --git a/datapath/vport.c b/datapath/vport.c
index f26beaf..f62201d 100644
--- a/datapath/vport.c
+++ b/datapath/vport.c
@@ -44,10 +44,8 @@ static const struct vport_ops *vport_ops_list[] = {
On Tue, Sep 3, 2013 at 2:00 PM, Pravin B Shelar pshe...@nicira.com wrote:
Signed-off-by: Pravin B Shelar pshe...@nicira.com
Acked-by: Jesse Gross je...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Sep 3, 2013 at 2:00 PM, Pravin B Shelar pshe...@nicira.com wrote:
Signed-off-by: Pravin B Shelar pshe...@nicira.com
Acked-by: Jesse Gross je...@nicira.com
There's a typo in the subject line though (skb-mask).
___
dev mailing list
Acked-by: Ethan Jackson et...@nicira.com
On Tue, Sep 3, 2013 at 3:39 PM, Ben Pfaff b...@nicira.com wrote:
This member is not used anywhere for anything.
Signed-off-by: Ben Pfaff b...@nicira.com
---
ofproto/ofproto-dpif.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
This member is not used anywhere for anything.
Signed-off-by: Ben Pfaff b...@nicira.com
---
ofproto/ofproto-dpif.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 820ec34..9721e9c 100644
--- a/ofproto/ofproto-dpif.c
On Tue, Sep 3, 2013 at 2:00 PM, Pravin B Shelar pshe...@nicira.com wrote:
diff --git a/datapath/linux/compat/include/net/checksum.h
b/datapath/linux/compat/include/net/checksum.h
index 502d02d..2bead4b 100644
--- a/datapath/linux/compat/include/net/checksum.h
+++
On Tue, Sep 3, 2013 at 2:00 PM, Pravin B Shelar pshe...@nicira.com wrote:
diff --git a/datapath/vlan.h b/datapath/vlan.h
index 1356aed..e930e97 100644
--- a/datapath/vlan.h
+++ b/datapath/vlan.h
@@ -46,13 +46,6 @@
* equivalent to those on 2.6.33+.
*/
Should we clean up the big comment
On Tue, Sep 3, 2013 at 2:00 PM, Pravin B Shelar pshe...@nicira.com wrote:
diff --git a/datapath/linux/compat/genetlink-openvswitch.c
b/datapath/linux/compat/genetlink-openvswitch.c
index 810223b..359f916 100644
--- a/datapath/linux/compat/genetlink-openvswitch.c
+++
On Tue, Sep 3, 2013 at 2:00 PM, Pravin B Shelar pshe...@nicira.com wrote:
cleanup various header file.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
Acked-by: Jesse Gross je...@nicira.com
___
dev mailing list
dev@openvswitch.org
On Tue, Sep 3, 2013 at 2:00 PM, Pravin B Shelar pshe...@nicira.com wrote:
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
acinclude.m4|1 -
datapath/compat.h | 26
datapath/datapath.c | 55
---
On Tue, Sep 3, 2013 at 2:01 PM, Pravin B Shelar pshe...@nicira.com wrote:
diff --git a/datapath/linux/compat/reciprocal_div.c
b/datapath/linux/compat/reciprocal_div.c
index 6a3bd48..d1495bf 100644
--- a/datapath/linux/compat/reciprocal_div.c
+++ b/datapath/linux/compat/reciprocal_div.c
@@
On Tue, Sep 3, 2013 at 2:01 PM, Pravin B Shelar pshe...@nicira.com wrote:
Signed-off-by: Pravin B Shelar pshe...@nicira.com
Acked-by: Jesse Gross je...@nicira.com
Good riddance. I didn't realize that we can so much lockdep compat code.
___
dev mailing
xlate_normal() held the mac_learning lock while calling
output_normal(). When running with patch ports, this could cause
xlate_actions() to be called again, possibly attempting to take a
write lock on the same learning table causing a deadlock. This patch
solves the problem by holding the lock
Acked-by: Justin Pettit jpet...@nicira.com
On Sep 3, 2013, at 5:40 PM, Ethan Jackson et...@nicira.com wrote:
xlate_normal() held the mac_learning lock while calling
output_normal(). When running with patch ports, this could cause
xlate_actions() to be called again, possibly attempting to
Signed-off-by: Romain Lenglet rleng...@vmware.com
---
lib/odp-execute.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 0f03855..c91cc4a 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -182,10 +182,11 @@
This patch fixes a segfault in the CONTROLLER action when the flow
contains a SAMPLE action, which occurs e.g. when sFlow or per-bridge
IPFIX is configured on the bridge.
This patch applies to both branch-2.0 and master.
Glenn, could you please check that this patch fixes your problem?
Thanks
Adjust formatting in ovs-ofctl so that apply_actions, clear_actions
write_metadata and goto_table appear at the same level
of indentation as actions rather being indented as if
they are arguments to the learn action.
Signed-off-by: Simon Horman ho...@verge.net.au
---
utilities/ovs-ofctl.8.in | 2
On Fri, Aug 30, 2013 at 12:24:17PM +0900, YAMAMOTO Takashi wrote:
Batching reduces overheads and enables upto 4 times the upcall processing
performance in a specialized test case.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
v2: Do not wake consumer threads if they are
Commit 9d189a50e (ofproto-dpif-xlate: Pull STP xlation into
ofproto-dpif-xlate.) introduced the bug that sets the port's
stp port number even if stp is not in use. This commit
fixes this bug.
Signed-off-by: Alex Wang al...@nicira.com
---
ofproto/ofproto-dpif-xlate.c |4 ++--
I found the actual cause and it is not related to this commit at all.
Thanks Andy for the help.~
On Tue, Sep 3, 2013 at 3:19 PM, Andy Zhou az...@nicira.com wrote:
I will take a look.
On Tue, Sep 3, 2013 at 3:14 PM, Alex Wang al...@nicira.com wrote:
Hey All,
This commit seems to prevent
Use enum ofp11_group_type for the 'type' field of struct ofgroup
as the enum exactly covers all the valid values of the field.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* First post
---
ofproto/ofproto-provider.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi,
This series is comprised of three components.
A. Enhance existing ofproto group code
[PATCH v2 1/5] Use enum ofp11_group_type in struct ofgroup
[PATCH v2 2/5] ovs-ofctl: Handle any number of buckets in group statistics
B. Support write actions.
With this in place it is possible
Implementation note:
All actions which modify a field are added to the action set
at the point where set actions should be added. In general
modifying a field many times is the same as only modifying it
the last time so the implementation simply adds all set actions to
the action set in the order
This is a first step towards implementing the dpif side of groups.
In order to be useful the action translation code needs
to be taught about groups.
Compile tested only.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* Corrected group_construct_stats() to allocate stats
if they are
Allow translation of indirect and all groups.
Also allow insertion of indirect and all groups by
changing the maximum permitted number in the groups
table from 0 to OFPG_MAX.
Implementation note:
After translating the actions for each bucket
ctx-base_flow is reset to its state prior to
struct ofputil_group_stats has an arbitrary limit
of 16 buckets for which it can record statistics.
However the code does not appear to enforce this
limit and it seems to me that the code could overflow.
This patch aims to remove the arbitrary limit by
removing the 'bucket_stats' field from
From: Nicolas Dichtel nicolas.dich...@6wind.com
Date: Mon, 2 Sep 2013 15:34:53 +0200
We talk recently about harmonizing tunnels so they behave consistently wrt.
SKB
orphaning, cleaning netfilter state, etc.
The goal of this serie is to achieve this.
Note that I test only ipip, sit and
52 matches
Mail list logo
