On 24 September 2013 02:00, Jesse Gross je...@nicira.com wrote:
Search net/core/dev.c for RECURSION_LIMIT.
Ahh, thanks for the pointers..
This stuff was added in 2.6.37 And you said this earlier:
This loop checker is just compatibility code since the exact same
logic exists in net/core/dev.c
Push vlan tag onto packet before segmentation to simplify the code.
As suggested by Pravin Shelar and Jesse Gross.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
datapath/vport-netdev.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff
As suggested by Jesse Gross and Pravin Shelar
in the course of the review of [PATCH v2.39 0/7] MPLS actions and matches.
This series applies on top of the master branch.
Simon Horman (2):
datapath: simplify VLAN segmentation
datapath: Move segmentation compatibility code into a compatibility
Move segmentation compatibility code out of netdev_send and into
rpl_dev_queue_xmit(), a compatibility function used in place
of dev_queue_xmit() as necessary.
As suggested by Jesse Gross.
Some minor though verbose implementation notes:
* This rpl_dev_queue_xmit() endeavours to return a valid
Rather than tracking the MPLS depth as a field in the
flow, which is an entirely poor place for it, just track
the delta to the MPLS depth during translation.
This logic was developed while implementing recirculation
and intended to be used to detect when recirculation should
occur. This variant
On Tue, Sep 24, 2013 at 04:51:35PM +0900, Simon Horman wrote:
Rather than tracking the MPLS depth as a field in the
flow, which is an entirely poor place for it, just track
the delta to the MPLS depth during translation.
This logic was developed while implementing recirculation
and intended
From: Shih-Hao Li shi...@vmware.com
When output to a file, only allow 90% of the free disk space to be used.
---
utilities/bugtool/ovs-bugtool.in | 49 ++
1 file changed, 39 insertions(+), 10 deletions(-)
diff --git a/utilities/bugtool/ovs-bugtool.in
On Tue, Sep 24, 2013 at 09:37:18AM -0700, Shih-Hao Li wrote:
From: Shih-Hao Li shi...@vmware.com
When output to a file, only allow 90% of the free disk space to be used.
This seems like a good idea.
The code to check for free space and then subtract the amount used if it
is allowable is
The hmap code has for a long time incremented a counter when a hash bucket
grew to have many entries. This can let a developer know that some hash
function is performing poorly, but doesn't give any hint as to which one.
This commit improves the situation by adding rate-limited debug logging
that
On Mon, Sep 23, 2013 at 02:19:47PM -0700, Gurucharan Shetty wrote:
The '-m' option is documented in the manpage.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
On Mon, Sep 23, 2013 at 02:19:48PM -0700, Gurucharan Shetty wrote:
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
I agree that there is a missing call. I think that this patch adds the
call too early, though, because a later call to
odp_actions_from_string() also passes port_names.
On Mon, Sep 23, 2013 at 02:19:49PM -0700, Gurucharan Shetty wrote:
Inside dpctl_del_flow() argv[0] is 'del-flow' and argv[1] can
be the flow in the absence of the optional datapath argument.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
It looks like usage() needs an update to mention
On Mon, Sep 23, 2013 at 02:19:50PM -0700, Gurucharan Shetty wrote:
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Sep 23, 2013 at 02:49:23PM -0700, Gurucharan Shetty wrote:
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks for the review. Please see inline.
Shih-Hao
- Original Message -
From: Ben Pfaff b...@nicira.com
To: Shih-Hao Li shi...@nicira.com
Cc: dev@openvswitch.org, Shih-Hao Li shi...@vmware.com
Sent: Tuesday, September 24, 2013 9:58:16 AM
Subject: Re: [ovs-dev] [PATCH] Check disk
On Tue, Sep 24, 2013 at 10:46:59AM -0700, Shih-Hao Li wrote:
It might be worth documenting how to avoid the cap if the user really
wants to (it looks like outputting to a fd instead of a file avoids
it?).
How about adding a new parameter, such as the percentage of free disk
space allowed
On Mon, Sep 23, 2013 at 02:36:37PM -0700, Justin Pettit wrote:
The OVS code has always made a distinction between the unencrypted (TCP)
and SSL port numbers for the OpenFlow and OVSDB protocols. The default
port numbers for both protocols has changed, and there continues to be
no distinction
It looks like usage() needs an update to mention that the DP arguments
are optional now. Do you want to update that too?
Since the usage update needs changes to multiple commands to reflect
the optional datapath name, I will send a separate patch
Acked-by: Ben Pfaff b...@nicira.com
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
utilities/ovs-dpctl.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/utilities/ovs-dpctl.c b/utilities/ovs-dpctl.c
index 43c0db6..3e9cc53 100644
--- a/utilities/ovs-dpctl.c
+++ b/utilities/ovs-dpctl.c
It seems as though there might be use for a flag to allow
using more of the disk somehow, or to tar up existing files
rather than copying them. I assume in most cases the user
can make that decision themselves by manually removing
older files or other things on the FS.
-Reid
On Tue, Sep 24,
Nice! Looks very useful and a nice contained implementation. :-)
--- Keith
{-- Tue, 24 Sep 2013 10:17:45 -0700: Ben b...@nicira.com wrote: --}
Ben The hmap code has for a long time incremented a counter when a hash
bucket
Ben grew to have many entries. This can let a developer know
On Tue, Sep 24, 2013 at 10:37:05AM -0700, Gurucharan Shetty wrote:
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
Thanks!
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Sep 24, 2013 at 12:24:00PM -0700, Shih-Hao Li wrote:
Subject: [ovs-dev] [PATCH] Check disk space in ovs-bugtool
We would usually write this as something like ovs-bugtool: Limit disk
usage.
Add a new command-line parameter to specify the maximum percentage
of free disk space allowed to
On Mon, Sep 23, 2013 at 02:36:38PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
From: Shih-Hao Li shi...@vmware.com
When output to a file with --unlimited unset,
only allow 90% of the free disk space to be used.
---
utilities/bugtool/ovs-bugtool.in | 54 ++
1 file changed, 37 insertions(+), 17 deletions(-)
diff --git
On Mon, Sep 23, 2013 at 02:36:39PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
Should the tcpdump patch check for the old and the new OpenFlow port?
There are many remaining hits for 6633 in the tree. I'd suggest
updating at least lib/vconn-active.man,
On Mon, Sep 23, 2013 at 02:36:40PM -0700, Justin Pettit wrote:
Both OpenFlow and OVSDB have new IANA-assigned port numbers. We still
default to the original values (6633 and 6632, respectively), but this
commit logs a warning. In the future, we will switch to the official
values (6653 and
Thanks, I applied this to master and branch-2.0.
On Mon, Sep 23, 2013 at 12:46:23PM -0700, Justin Pettit wrote:
Acked-by: Justin Pettit jpet...@nicira.com
On Sep 17, 2013, at 4:02 PM, Ben Pfaff b...@nicira.com wrote:
Found by valgrind.
Signed-off-by: Ben Pfaff b...@nicira.com
---
Acked-by: Justin Pettit jpet...@nicira.com
On Sep 24, 2013, at 10:17 AM, Ben Pfaff b...@nicira.com wrote:
The hmap code has for a long time incremented a counter when a hash bucket
grew to have many entries. This can let a developer know that some hash
function is performing poorly, but
On Tue, Sep 24, 2013 at 02:18:34PM -0700, Ben Pfaff wrote:
On Mon, Sep 23, 2013 at 02:36:40PM -0700, Justin Pettit wrote:
Both OpenFlow and OVSDB have new IANA-assigned port numbers. We still
default to the original values (6633 and 6632, respectively), but this
commit logs a warning. In
Thanks Keith and Justin, I applied this to master and branch-2.0.
On Tue, Sep 24, 2013 at 02:33:53PM -0700, Justin Pettit wrote:
Acked-by: Justin Pettit jpet...@nicira.com
On Sep 24, 2013, at 10:17 AM, Ben Pfaff b...@nicira.com wrote:
The hmap code has for a long time incremented a
---
ofproto/ofproto-dpif-upcall.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index d75c61b..16c53e5 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b/ofproto/ofproto-dpif-upcall.c
@@ -254,7 +254,7
Signed-off-by: Ben Pfaff b...@nicira.com
---
datapath/vport.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/vport.c b/datapath/vport.c
index f62201d..3878510 100644
--- a/datapath/vport.c
+++ b/datapath/vport.c
@@ -239,7 +239,7 @@ void ovs_vport_del(struct vport
Acked-by: pritesh pritesh.koth...@cisco.com
On Sep 24, 2013, at 2:58 PM, Ben Pfaff wrote:
---
ofproto/ofproto-dpif-upcall.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index d75c61b..16c53e5
Acked-by: pritesh pritesh.koth...@cisco.com
On Sep 24, 2013, at 2:58 PM, Ben Pfaff wrote:
Signed-off-by: Ben Pfaff b...@nicira.com
---
datapath/vport.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/vport.c b/datapath/vport.c
index f62201d..3878510 100644
Both the IPFIX and SFLOW modules are thread safe, so there's no
particular reason to pass them up to the main thread. Eliminating
this step significantly simplifies the code.
Signed-off-by: Ethan Jackson et...@nicira.com
---
ofproto/ofproto-dpif-upcall.c | 250
On Tue, Sep 24, 2013 at 03:12:37PM -0700, Ethan Jackson wrote:
Both the IPFIX and SFLOW modules are thread safe, so there's no
particular reason to pass them up to the main thread. Eliminating
this step significantly simplifies the code.
Signed-off-by: Ethan Jackson et...@nicira.com
GCC
I applied this to master.
On Tue, Sep 24, 2013 at 10:10:02PM +, Pritesh Kothari (pritkoth) wrote:
Acked-by: pritesh pritesh.koth...@cisco.com
On Sep 24, 2013, at 2:58 PM, Ben Pfaff wrote:
---
ofproto/ofproto-dpif-upcall.c | 10 +-
1 file changed, 5 insertions(+), 5
Another way to handle these upcalls might be to uniformly send every
packet to a handler thread, and then handle all the kinds of upcalls
in the handlers. Did you consider that solution? I don't know,
off-hand, whether it is better. It might do less work in the
dispatcher, allowing the
Both the IPFIX and SFLOW modules are thread safe, so there's no
particular reason to pass them up to the main thread. Eliminating
this step significantly simplifies the code.
Signed-off-by: Ethan Jackson et...@nicira.com
---
ofproto/ofproto-dpif-upcall.c | 250
On Tue, Sep 24, 2013 at 03:54:24PM -0700, Ethan Jackson wrote:
Another way to handle these upcalls might be to uniformly send every
packet to a handler thread, and then handle all the kinds of upcalls
in the handlers. Did you consider that solution? I don't know,
off-hand, whether it is
On Tue, Sep 24, 2013 at 03:56:02PM -0700, Ethan Jackson wrote:
Both the IPFIX and SFLOW modules are thread safe, so there's no
particular reason to pass them up to the main thread. Eliminating
this step significantly simplifies the code.
Signed-off-by: Ethan Jackson et...@nicira.com
This
On Tue, Sep 24, 2013 at 2:58 PM, Ben Pfaff b...@nicira.com wrote:
diff --git a/datapath/vport.c b/datapath/vport.c
index f62201d..3878510 100644
--- a/datapath/vport.c
+++ b/datapath/vport.c
@@ -239,7 +239,7 @@ void ovs_vport_del(struct vport *vport)
* @stats: stats to set
*
*
On Tue, Sep 24, 2013 at 04:10:36PM -0700, Jesse Gross wrote:
On Tue, Sep 24, 2013 at 2:58 PM, Ben Pfaff b...@nicira.com wrote:
diff --git a/datapath/vport.c b/datapath/vport.c
index f62201d..3878510 100644
--- a/datapath/vport.c
+++ b/datapath/vport.c
@@ -239,7 +239,7 @@ void
On Mon, Sep 23, 2013 at 01:25:25PM -0700, Ben Pfaff wrote:
On Mon, Sep 23, 2013 at 10:57:22AM -0700, Jarno Rajahalme wrote:
The key member in struct flow_miss refers to memory held by the struct
upcall, hence the upcalls should be freed only after the flow misses are
processed by the main
Signed-off-by: Ben Pfaff b...@nicira.com
Acked-by: pritesh pritesh.koth...@cisco.com
---
v2: Fix another typo on the same line.
datapath/vport.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/vport.c b/datapath/vport.c
index f62201d..2882cc7 100644
---
On Fri, Sep 20, 2013 at 03:35:52PM +0900, YAMAMOTO Takashi wrote:
plug upcall leak introduced by the commit
ofproto-dpif-upcall: Forward packets in order of arrival.
(commit 04a19fb8f4b8ba19a9805906aac7b30b65b57206)
Signed-off-by: YAMAMOTO Takashi y...@mwd.biglobe.ne.jp
Thanks. I applied
On Sep 24, 2013, at 4:17 PM, Ben Pfaff wrote:
On Tue, Sep 24, 2013 at 04:10:36PM -0700, Jesse Gross wrote:
On Tue, Sep 24, 2013 at 2:58 PM, Ben Pfaff b...@nicira.com wrote:
diff --git a/datapath/vport.c b/datapath/vport.c
index f62201d..3878510 100644
--- a/datapath/vport.c
+++
On Tue, Sep 24, 2013 at 4:24 PM, Ben Pfaff b...@nicira.com wrote:
Signed-off-by: Ben Pfaff b...@nicira.com
Acked-by: pritesh pritesh.koth...@cisco.com
---
v2: Fix another typo on the same line
Acked-by: Jesse Gross je...@nicira.com
___
dev mailing
On Tue, Sep 24, 2013 at 04:31:42PM -0700, Jesse Gross wrote:
On Tue, Sep 24, 2013 at 4:24 PM, Ben Pfaff b...@nicira.com wrote:
Signed-off-by: Ben Pfaff b...@nicira.com
Acked-by: pritesh pritesh.koth...@cisco.com
---
v2: Fix another typo on the same line
Acked-by: Jesse Gross
On Sep 24, 2013, at 2:11 PM, Ben Pfaff b...@nicira.com wrote:
On Mon, Sep 23, 2013 at 02:36:39PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
Should the tcpdump patch check for the old and the new OpenFlow port?
There are many remaining hits for 6633 in the
Both the IPFIX and SFLOW modules are thread safe, so there's no
particular reason to pass them up to the main thread. Eliminating
this step significantly simplifies the code.
Signed-off-by: Ethan Jackson et...@nicira.com
---
ofproto/ofproto-dpif-upcall.c | 290
On Wed, Sep 18, 2013 at 01:42:40PM -0700, Jarno Rajahalme wrote:
Widen TCP flags handling from 7 bits (uint8_t) to 12
bits (uint16_t). The kernel interface remains at 8
bits, which makes no functional difference now, as none
of the higher bits is currenlty of interest to the
currently
Ben,
All valid points, will address once I hear back from Jesse or Pravin.
Thanks,
Jarno
On Sep 24, 2013, at 4:50 PM, Ben Pfaff b...@nicira.com wrote:
On Wed, Sep 18, 2013 at 01:42:40PM -0700, Jarno Rajahalme wrote:
Widen TCP flags handling from 7 bits (uint8_t) to 12
bits (uint16_t).
On Tue, Sep 24, 2013 at 08:42:50AM -0700, Ben Pfaff wrote:
On Tue, Sep 24, 2013 at 04:51:35PM +0900, Simon Horman wrote:
Rather than tracking the MPLS depth as a field in the
flow, which is an entirely poor place for it, just track
the delta to the MPLS depth during translation.
This
On Wed, Sep 18, 2013 at 01:42:41PM -0700, Jarno Rajahalme wrote:
From ovs-ofctl man page:
tcp_flags=flags/mask
Bitwise match on TCP flags. The flags and mask are 16-bit
num???
bers written in decimal or in hexadecimal prefixed by 0x. Each
OK.
The netflow stuff is purely userspace.
On Tue, Sep 24, 2013 at 04:57:33PM -0700, Jarno Rajahalme wrote:
Ben,
All valid points, will address once I hear back from Jesse or Pravin.
Thanks,
Jarno
On Sep 24, 2013, at 4:50 PM, Ben Pfaff b...@nicira.com wrote:
On Wed, Sep 18,
On Thu, Sep 19, 2013 at 08:40:45PM -0700, Jarno Rajahalme wrote:
I had accidentally made corrections to the ovs-ofctl.8 instead of
ovs-ofctl.8.in.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
I guess you'll fold this into the next version?
On Wed, Sep 25, 2013 at 09:02:10AM +0900, Simon Horman wrote:
On Tue, Sep 24, 2013 at 08:42:50AM -0700, Ben Pfaff wrote:
On Tue, Sep 24, 2013 at 04:51:35PM +0900, Simon Horman wrote:
Rather than tracking the MPLS depth as a field in the
flow, which is an entirely poor place for it, just
On Mon, Sep 23, 2013 at 11:20 PM, Viresh Kumar viresh.ku...@linaro.org wrote:
On 24 September 2013 02:00, Jesse Gross je...@nicira.com wrote:
Search net/core/dev.c for RECURSION_LIMIT.
Ahh, thanks for the pointers..
This stuff was added in 2.6.37 And you said this earlier:
This loop
On 25 September 2013 05:51, Jesse Gross je...@nicira.com wrote:
On Mon, Sep 23, 2013 at 11:20 PM, Viresh Kumar viresh.ku...@linaro.org
wrote:
static inline void rcu_read_lock_bh(void)
{
local_bh_disable();
#ifdef CONFIG_PREEMPT_RT_FULL
rcu_read_lock();
#else
On Sep 24, 2013, at 2:02 PM, Ben Pfaff b...@nicira.com wrote:
On Mon, Sep 23, 2013 at 02:36:38PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
Based on the feedback on the third patch about updating vswitch.xml around the
Rebased the commits to current master.
Alex Wang (2):
coverage: Reimplement the ovs-appctl coverage/show command.
ofproto-dpif: Compute the subfacet add/del rate using coverage
counters.
lib/coverage-unixctl.man |4 +-
lib/coverage.c | 113
So far, the subfacet rates (e.g. add rate, del rate) are computed by
exponential moving averaging function in ofproto-dpif.c. This commit
replaces that logic with coverage counters. And the rates can be
checked by running ovs-appctl coverage/show command.
Signed-off-by: Alex Wang
This commit changes the ovs-appctl coverage/show command to show the
the averaged per-second rates for the last few seconds, the last minute
and the last hour, and the total counts of all of the coverage counters.
Signed-off-by: Alex Wang al...@nicira.com
---
lib/coverage-unixctl.man |4 +-
Dear Sir,
Glad to hear that you're on the market for automation instrumentation.
We are specialized in intelligent instruments with good quality and very
competitive price, such as: Transmitters , Sensors , Recorders , Flow meters ,
Analyzers , Control valves , Controllers ,DCS ,
On Sep 24, 2013, at 5:10 PM, Ben Pfaff b...@nicira.com wrote:
On Wed, Sep 18, 2013 at 01:42:41PM -0700, Jarno Rajahalme wrote:
From ovs-ofctl man page:
tcp_flags=flags/mask
Bitwise match on TCP flags. The flags and mask are 16-bit
num???
bers written in
On Sep 24, 2013, at 5:11 PM, Ben Pfaff b...@nicira.com wrote:
On Thu, Sep 19, 2013 at 08:40:45PM -0700, Jarno Rajahalme wrote:
I had accidentally made corrections to the ovs-ofctl.8 instead of
ovs-ofctl.8.in.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
I guess you'll fold this
On Tue, Sep 24, 2013 at 07:48:55PM -0700, Jarno Rajahalme wrote:
On Sep 24, 2013, at 5:10 PM, Ben Pfaff b...@nicira.com wrote:
On Wed, Sep 18, 2013 at 01:42:41PM -0700, Jarno Rajahalme wrote:
I slightly prefer %# over 0x% in the following cases, because 0 looks
a little less silly than
On Tue, Sep 24, 2013 at 07:52:00PM -0700, Jarno Rajahalme wrote:
On Sep 24, 2013, at 5:11 PM, Ben Pfaff b...@nicira.com wrote:
On Thu, Sep 19, 2013 at 08:40:45PM -0700, Jarno Rajahalme wrote:
I had accidentally made corrections to the ovs-ofctl.8 instead of
ovs-ofctl.8.in.
On Tue, Sep 24, 2013 at 04:41:43PM -0700, Justin Pettit wrote:
On Sep 24, 2013, at 2:11 PM, Ben Pfaff b...@nicira.com wrote:
On Mon, Sep 23, 2013 at 02:36:39PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
Should the tcpdump patch check for the old and the
On Tue, Sep 24, 2013 at 05:34:21PM -0700, Justin Pettit wrote:
On Sep 24, 2013, at 2:02 PM, Ben Pfaff b...@nicira.com wrote:
On Mon, Sep 23, 2013 at 02:36:38PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
Based on
On Sep 24, 2013, at 9:05 PM, Ben Pfaff b...@nicira.com wrote:
On Tue, Sep 24, 2013 at 07:48:55PM -0700, Jarno Rajahalme wrote:
On Sep 24, 2013, at 5:10 PM, Ben Pfaff b...@nicira.com wrote:
On Wed, Sep 18, 2013 at 01:42:41PM -0700, Jarno Rajahalme wrote:
I slightly prefer %# over 0x% in the
On Sep 24, 2013, at 9:06 PM, Ben Pfaff b...@nicira.com wrote:
On Tue, Sep 24, 2013 at 07:52:00PM -0700, Jarno Rajahalme wrote:
On Sep 24, 2013, at 5:11 PM, Ben Pfaff b...@nicira.com wrote:
On Thu, Sep 19, 2013 at 08:40:45PM -0700, Jarno Rajahalme wrote:
I had accidentally made
eth_mpls_depth() has been unused as of 1ac7c9bdb2b6fdcb (ofproto-dpif: Use
execute_actions to execute controller actions).
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/packets.c | 26 --
lib/packets.h | 2 --
2 files changed, 28 deletions(-)
diff --git
On Tue, Sep 24, 2013 at 09:22:19PM -0700, Jarno Rajahalme wrote:
On Sep 24, 2013, at 9:05 PM, Ben Pfaff b...@nicira.com wrote:
On Tue, Sep 24, 2013 at 07:48:55PM -0700, Jarno Rajahalme wrote:
On Sep 24, 2013, at 5:10 PM, Ben Pfaff b...@nicira.com wrote:
On Wed, Sep 18, 2013 at
The sole purpose of this change is to avoid sparse warnings
about memset of zero length in the case where the zero field
of struct flow is zero bytes long, as is the case after
Remove mpls_depth field from flow.
Signed-off-by: Simon Horman ho...@verge.net.au
---
This patch could trivially be:
Rather than tracking the MPLS depth as a field in the
flow, which is an entirely poor place for it, just track
the delta to the MPLS depth during translation.
This logic was developed while implementing recirculation
and intended to be used to detect when recirculation should
occur. This variant
A short series to remove the mpls_depth field from struct flow
Changes since v1
[PATCH 1/2] Remove mpls_depth field from flow
* As suggested by Ben Pfaff
- Move pre_push_mpls_lse fron a local variable of do_xlate_actions()
to a field of struct xlate_ctx so that it is accessible across
changes from the previous post: rebase.
YAMAMOTO Takashi (1):
ofproto-dpif-upcall: reduce number of wakeup
ofproto/ofproto-dpif-upcall.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
--
1.8.3.1
___
dev
before the change:
duration=2110s, priority=0, n_packets=3151646, n_bytes=3104180388, \
priority=0,actions=CONTROLLER:65535
table_id=254, duration=2136s, priority=0, n_packets=0, n_bytes=0, \
priority=0,reg0=0x3,actions=drop
table_id=254, duration=2136s, priority=0, n_packets=0, n_bytes=0, \
if a queue length is long (ie. non-0), the consumer thread should
already be busy working on the queue. there's no need to wake it
up repeatedly.
Signed-off-by: YAMAMOTO Takashi y...@mwd.biglobe.ne.jp
---
ofproto/ofproto-dpif-upcall.c | 29 +++--
1 file changed, 19
On Wed, Sep 25, 2013 at 01:26:06PM +0900, Simon Horman wrote:
eth_mpls_depth() has been unused as of 1ac7c9bdb2b6fdcb (ofproto-dpif: Use
execute_actions to execute controller actions).
Signed-off-by: Simon Horman ho...@verge.net.au
Applied, thanks.
On Wed, Sep 25, 2013 at 01:39:48PM +0900, YAMAMOTO Takashi wrote:
before the change:
duration=2110s, priority=0, n_packets=3151646, n_bytes=3104180388, \
priority=0,actions=CONTROLLER:65535
table_id=254, duration=2136s, priority=0, n_packets=0, n_bytes=0, \
priority=0,reg0=0x3,actions=drop
84 matches
Mail list logo
