Sorry, I did not have CONFIG_SPARSE_RCU_POINTER=y with my running
kernel (stock 14.04 kernel), sparse did not generate this warning on
my system. Now I recompiled kernel, sparse works properly now. I will
send out a patch soon. Thanks for reporting it.
On Mon, Jun 23, 2014 at 10:54 AM, Ben
Sparse gives incompatible types in comparison expression (different
address spaces) warning messages. Fix this by add rcu_dereference()
wrappers.
Reported-by: Ben Pfaff b...@nicira.com
Signed-off-by: Andy Zhou az...@nicira.com
---
datapath/flow_table.c | 6 +++---
1 file changed, 3
This patch series adds OpenvSwitch datapath support for Windows platform. The
kernel switch extension has support for bridged back forwarding tunneling
over VXLAN.
The patch series is based on top of 6ddb631 (datapath: keep mask array compact
when deleting mask).
Saurabh Shah (4):
These are some minimal changes required to get the base code to work with our
forwarding extension. These changes are licensed under Apache License, Version
2.0.
Co-Authored-By: Eitan Eliahu elia...@vmware.com
Signed-off-by: Eitan Eliahu elia...@vmware.com
Co-Authored-By: Guolin Yang
On Mon, Jun 23, 2014 at 03:11:57PM -0700, Ben Pfaff wrote:
On Mon, Jun 16, 2014 at 11:29:21AM +0900, Simon Horman wrote:
Use enum ofp14_flow_monitor_flags in place of enum nx_flow_monitor_flags in
struct ofputil_flow_monitor_request and struct rule, translating between
the two enumerations
On Mon, Jun 23, 2014 at 05:00:53PM -0700, Ben Pfaff wrote:
On Mon, Jun 16, 2014 at 11:29:28AM +0900, Simon Horman wrote:
Use a list rather than an array to track monitor requests
in handle_flow_monitor_request().
This is in preparation for supporting OpenFlow1.4 flow monitor requests
Hi,
I need to attach gdb with ovs code, can you please let me know about this.
Thanks in advance.
Regards,
Ajay.
Happiest Minds Disclaimer
This message is for the sole use of the intended recipient(s) and may contain
confidential, proprietary or legally
On 06/23/14 at 05:08pm, Ben Pfaff wrote:
Found by sparse.
Signed-off-by: Ben Pfaff b...@nicira.com
Acked-by: Thomas Graf tg...@noironetworks.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.
Cc: Ravi K rke...@gmail.com
Cc: Leo Alterman lalter...@nicira.com
Cc: Isaku Yamahata
Thanks!
On Mon, Jun 23, 2014 at 11:08:31PM -0700, Andy Zhou wrote:
Sorry, I did not have CONFIG_SPARSE_RCU_POINTER=y with my running
kernel (stock 14.04 kernel), sparse did not generate this warning on
my system. Now I recompiled kernel, sparse works properly now. I will
send out a patch
On Tue, Jun 24, 2014 at 05:22:08PM +0900, Simon Horman wrote:
On Mon, Jun 23, 2014 at 05:00:53PM -0700, Ben Pfaff wrote:
On Mon, Jun 16, 2014 at 11:29:28AM +0900, Simon Horman wrote:
Use a list rather than an array to track monitor requests
in handle_flow_monitor_request().
This is
On Tue, Jun 24, 2014 at 11:05:40AM +0200, Thomas Graf wrote:
On 06/23/14 at 05:08pm, Ben Pfaff wrote:
Found by sparse.
Signed-off-by: Ben Pfaff b...@nicira.com
Acked-by: Thomas Graf tg...@noironetworks.com
Thanks, I applied this to master.
On Mon, Jun 16, 2014 at 11:33:12AM +0900, Simon Horman wrote:
Add helpers for allowing requests and use them in handle_openflow__().
This is a in preparation for supporting multipart requests
on a per message type basis.
Signed-off-by: Simon Horman ho...@verge.net.au
+/* Return if it's a
On Mon, Jun 16, 2014 at 11:33:13AM +0900, Simon Horman wrote:
Buffer a multi-part requests until all its parts are received.
This is achieved by initialising the list_node field of messages
and passing them to ofmp_req_filter().
* If the message is not recognised as part of a multi-part
On Mon, Jun 16, 2014 at 11:33:14AM +0900, Simon Horman wrote:
Signed-off-by: Simon Horman ho...@verge.net.au
I guess that this cannot go in before the ext-187 series, because it
uses the EXT-187 extension in the test. Also at a glance it looks like
the patch requires that to be already applied
On Mon, Jun 16, 2014 at 11:33:15AM +0900, Simon Horman wrote:
Signed-off-by: Simon Horman ho...@verge.net.au
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Jun 18, 2014 at 11:07:12AM -0700, Ryan Wilson wrote:
Typically, kernel datapath threads send upcalls to userspace where
handler threads process the upcalls. For TAP and DPDK devices, the
datapath threads operate in userspace, so there is no need for
separate handler threads.
This
On Thu, Jun 19, 2014 at 10:58:26PM +, Polehn, Mike A wrote:
Large TX and RX queues are needed for high speed 10 GbE physical NICS.
Observed a 250% zero loss improvement over small NIC queue test for
A port to port flow test.
Signed-off-by: Mike A. Polehn mike.a.pol...@intel.com
Please
On Fri, Jun 20, 2014 at 01:17:36PM +0200, Thomas Graf wrote:
Signed-off-by: Thomas Graf tg...@noironetworks.com
Both applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/netdev-dpdk.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 6d92969..3359517 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -832,7 +832,6 @@
On Fri, Jun 20, 2014 at 02:24:50PM +0200, Thomas Graf wrote:
Make the parser compatible with how we print group buckets and allow
actions= to be specified, e.g.:
group_id=1,type=all,bucket=actions=output:2,bucket=actions=output:3
Also, better document the supported syntax in the manual
On Fri, Jun 20, 2014 at 01:55:19PM -0700, Gurucharan Shetty wrote:
There are always a few unit tests that have some race conditions
that cause them to occasionally fail. It is probably a good idea
to re-run the failed tests once while building deb packages.
Co-Authored-By: Keith Amidon
On Fri, Jun 20, 2014 at 04:23:48PM +0100, maryam.tahhan wrote:
From: maryam.tahhan maryam.tah...@intel.com
This patch enables arbitrary port naming for vhost patches, so
they no longer need to be called dpdkvhostn.
Signed-off-by: maryam.tahhan maryam.tah...@intel.com
This is not a
On Fri, Jun 20, 2014 at 04:23:48PM +0100, maryam.tahhan wrote:
From: maryam.tahhan maryam.tah...@intel.com
This patch enables arbitrary port naming for vhost patches, so
they no longer need to be called dpdkvhostn.
Signed-off-by: maryam.tahhan maryam.tah...@intel.com
Oh, also the subject
Please stay on the mailing list.
I'm not doing substantive review of the patch, so I don't need a new
repost. It is possible that whoever does review the patch could request
one.
It is customary to describe the changes from one version of a patch to
another following the commit message, near
On Fri, Jun 20, 2014 at 12:22:14PM -0700, Gurucharan Shetty wrote:
There is no 'errno' field in socket.error. Instead use the
get_exception_errno() function to get the error number.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
On Tue, Jun 24, 2014 at 09:13:14AM -0700, Ben Pfaff wrote:
On Fri, Jun 20, 2014 at 12:22:15PM -0700, Gurucharan Shetty wrote:
In addition to the above bug, I see some other wierdness while dealing with
unicode on Xenserver and Python 2.4.3 . As an example, the following diff
would work fine
On Fri, Jun 20, 2014 at 12:22:15PM -0700, Gurucharan Shetty wrote:
In addition to the above bug, I see some other wierdness while dealing with
unicode on Xenserver and Python 2.4.3 . As an example, the following diff
would work fine if python is run from command line but not from inside
On Fri, Jun 20, 2014 at 01:21:42PM -0700, Gurucharan Shetty wrote:
Run the following command on Xenserver:
PYTHONPATH=`pwd`/python/compat::`pwd`/python python ./tests/test-ovsdb.py \
parse-atoms '{type: string, minLength: 2}'\
'[]' '[a]' '[ab]' '[abc]' '[\ud834\udd1e]'
On Mon, Jun 23, 2014 at 10:52 AM, Ben Pfaff b...@nicira.com wrote:
On Fri, Jun 13, 2014 at 07:40:00AM -0700, Gurucharan Shetty wrote:
WSAStartup() needs to be called before using winsock2 related
functions. We need this for almost all the utilities. So call
it through OVS_CONSTRUCTOR.
That's fine. Thanks!
On Jun 24, 2014 9:24 AM, Gurucharan Shetty shet...@nicira.com wrote:
On Mon, Jun 23, 2014 at 10:52 AM, Ben Pfaff b...@nicira.com wrote:
On Fri, Jun 13, 2014 at 07:40:00AM -0700, Gurucharan Shetty wrote:
WSAStartup() needs to be called before using winsock2 related
FYI: The status of the openvswitch source package
in Debian's testing distribution has changed.
Previous version: 1.9.3+git20131029-1.1
Current version: 2.1.0+git20140411-3
--
This email is automatically generated once a day. As the installation of
new packages into testing happens
On Mon, Jun 23, 2014 at 11:51 AM, Ben Pfaff b...@nicira.com wrote:
On Fri, Jun 13, 2014 at 07:40:02AM -0700, Gurucharan Shetty wrote:
There is no 'kill -l' type functionality available on Windows.
So instead of looking for the string 'ABRT', check for the exit
code in both platforms. On msys
There's a lot of weirdness around python and encodings that varies from
version to version and from one Python configuration to the next. Did
you try this on a non-XenServer system too, say Ubuntu? Also you might
want to try on the Arch distro (I think that's Ethan uses) because I
seem to
On Tue, Jun 24, 2014 at 9:46 AM, Gurucharan Shetty shet...@nicira.com wrote:
On Mon, Jun 23, 2014 at 11:51 AM, Ben Pfaff b...@nicira.com wrote:
On Fri, Jun 13, 2014 at 07:40:02AM -0700, Gurucharan Shetty wrote:
There is no 'kill -l' type functionality available on Windows.
So instead of
On 06/24/14 at 08:56am, Ben Pfaff wrote:
On Fri, Jun 20, 2014 at 02:24:50PM +0200, Thomas Graf wrote:
Make the parser compatible with how we print group buckets and allow
actions= to be specified, e.g.:
group_id=1,type=all,bucket=actions=output:2,bucket=actions=output:3
Also,
There are always a few unit tests that have some race conditions
that cause them to occasionally fail. It is probably a good idea
to re-run the failed tests once while building deb packages.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
Co-authored-by: Keith Amidon kami...@nicira.com
On Tue, Jun 24, 2014 at 10:08:16AM -0700, Gurucharan Shetty wrote:
There are always a few unit tests that have some race conditions
that cause them to occasionally fail. It is probably a good idea
to re-run the failed tests once while building deb packages.
Signed-off-by: Gurucharan Shetty
On Wed, Jun 18, 2014 at 10:14:30PM -0300, Flavio Leitner wrote:
Add IGMP info to struct flow, flow compose and flow extract.
Signed-off-by: Flavio Leitner f...@redhat.com
---
lib/flow.c | 22 --
lib/flow.h | 11 ++-
Acked-by: Pritesh Kothari pritesh.koth...@cisco.com
On Jun 24, 2014, at 8:54 AM, Ben Pfaff b...@nicira.com wrote:
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/netdev-dpdk.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
On Wed, Jun 18, 2014 at 10:14:28PM -0300, Flavio Leitner wrote:
Currently it supports IGMPv1 and IGMPv2 only.
Flavio Leitner (7):
lib: Add IGMP snooping library bits
flow: extend it to carry IGMP protocol information
ofproto-dpif: Introduce multicast snooping handler
ofproto: Add
On Sat, Jun 21, 2014 at 11:59:52AM +0200, Pim van den Berg wrote:
Signed-off-by: Pim van den Berg p...@nethuis.nl
Thanks, applied. I changed ! test to test ! for greatest
portability.
___
dev mailing list
dev@openvswitch.org
On Mon, Jun 23, 2014 at 09:33:56AM +1200, Joe Stringer wrote:
This could cause configuration failure on earlier versions of autoconf.
Reported-by: Lin Shaopeng slin0...@gmail.com
Signed-off-by: Joe Stringer joestrin...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
Make the parser compatible with how we print group buckets and allow
actions= to be specified, e.g.:
group_id=1,type=all,bucket=actions=output:2,bucket=actions=output:3
Also, better document the supported syntax in the manual page and
cover both syntax formats in the unit test.
Signed-off-by:
On Tue, Jun 24, 2014 at 11:09:48AM -0700, Ben Pfaff wrote:
On Wed, Jun 18, 2014 at 10:14:30PM -0300, Flavio Leitner wrote:
Add IGMP info to struct flow, flow compose and flow extract.
Signed-off-by: Flavio Leitner f...@redhat.com
---
lib/flow.c | 22
Suggested-by: Gerald Rogers gerald.rog...@intel.com
Signed-off-by: Ben Pfaff b...@nicira.com
---
AUTHORS |1 +
CodingStyle |7 +++
2 files changed, 8 insertions(+)
diff --git a/AUTHORS b/AUTHORS
index 64ede54..0a6c61a 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -186,6 +186,7 @@ Eric
Thanks. I played with this a little and sent out a patch documenting
it:
http://openvswitch.org/pipermail/dev/2014-June/041999.html
On Mon, Jun 23, 2014 at 10:51:16PM +, Rogers, Gerald wrote:
Ben,
I used the following indent options to format the file :
indent -bad -bap -bbb
Hi Gerald,
Thanks for updating patch, here are few comments:
I got compilation erorr without --with-dpdk config option:
tests/ovs_client/ovs_client.c:38:24: fatal error: rte_config.h: No
such file or directory
#include rte_config.h
On Mon, Jun 23, 2014 at 4:55 AM,
Pravin,
Which version of DPDK are you using?
In mine the rte_config.h is located in the DPDK directory
include/rte_config.h
Gerald
On 6/24/14, 12:11 PM, Pravin Shelar pshe...@nicira.com wrote:
Hi Gerald,
Thanks for updating patch, here are few comments:
I got compilation erorr without
I think you misread Pravin's message. That's what he gets without
using --with-dpdk. Without --with-dpdk, OVS shouldn't need the DPDK
headers.
On Tue, Jun 24, 2014 at 07:29:29PM +, Rogers, Gerald wrote:
Pravin,
Which version of DPDK are you using?
In mine the rte_config.h is located
Ben,
Thanks, I didn¹t catch that. I will fix the makefile to exclude it.
Gerald
On 6/24/14, 12:35 PM, Ben Pfaff b...@nicira.com wrote:
I think you misread Pravin's message. That's what he gets without
using --with-dpdk. Without --with-dpdk, OVS shouldn't need the DPDK
headers.
On Tue, Jun
msys has a set of rules which triggers an automatic conversion of
arguments into something else to suit Windows requirements. Sometimes
this also causes unwanted conversions. Details of the rules is here:
http://www.mingw.org/wiki/Posix_path_conversion
msys converts ::1/::1 into ;1\;1. To prevent
On Windows, we really do not have any socket files created.
We instead create a regular file with a TCP port number written
inside it.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
tests/ovsdb-server.at | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff
We do not support that option in Windows.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
tests/ovsdb-server.at |4
1 file changed, 4 insertions(+)
diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
index 08c56ca..77b7dc1 100644
--- a/tests/ovsdb-server.at
+++
For this particular test, we pass the PKIDIR through a
ovsdb-tool transact and msys does not convert the path style.
(On Windows, we have to pass the directory in the form C:/foo/bar.pem.)
So get the Windows style path through 'pwd -W'(which is called through
the function pwd ())
Signed-off-by:
On Windows ECONNRESET is WSAECONNRESET.
Also, unix connections are done through TCP sockets.
For the 'refuse-connection' test, the error message for Windows
is WSAECONNRESET instead of EPIPE.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
tests/test-vconn.c | 16 ++--
1
xargs echo introduces ^M character inbetween the
records on Windows. Workaround it.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
tests/ovs-vsctl.at |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
index
vlan splinters is to workaround buggy network drivers of Linux.
Skip the test for Windows.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
tests/vlan-splinters.at |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vlan-splinters.at b/tests/vlan-splinters.at
index
sflow feature needs to be investigated for Windows. Right now
test-sflow related tests do not pass because of LOOPBACK_INTERFACE
constraints for 'agent'. Add a TODO item and skip the tests.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
BUILD.Windows |1 +
rename() on an existing destination file fails on Windows. This commit
worksaround that problem.
There are two tests that test it. But both of them use the ovsdb-server's
--run option for the test and it does not exist in Windows. So change
the test to workaround the lack of that feature.
By default, three digit exponents are printed on Windows.
Many unit tests in Open vSwitch expect two digit exponents.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
lib/util.c |1 +
1 file changed, 1 insertion(+)
diff --git a/lib/util.c b/lib/util.c
index 60ec5bc..01ba6bc 100644
On Windows, when a peer terminates without calling a close
on socket fd, the server ends up printing connection dropped
warning messages. We probably don't want those warning messages
when the error is WSAECONNRESET.
(In OVS unit tests on Windows, anytime a client like ovs-ofctl
calls a ovs_fatal
The unit test, OFPST_TABLE reply - OF1.2 in ofp-print.at
sends a very large hex string as an argument to 'ovs-ofctl ofp-print'.
The length of the hex string exceeds the maximum command line length
in Windows. With this commit, we can pass the same hex string by
placing it inside a file.
There is no one-one mapping of symlinks between Linux and
Windows. This test currently fails on Windows and we do not
really need this functionality on Windows. So skip it.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
tests/file_name.at |1 +
1 file changed, 1 insertion(+)
diff
Also, fflush(stderr) when we raise a signal. The test
this commit is changing would fail otherwise.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
lib/fatal-signal.c |1 +
tests/ovs-vsctl.at | 16 ++--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git
Commit ebed9f78(ovsdb-server: Improve message for add-db of
database already open.) improved the error message seen when
opening an already opened database on Linux. For Windows,
we still need to look for the lockfile error message.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
interface-reconfigure.at mostly tests functionality for Xenserver
and the tests use some POSIX only features. Skip them for Windows.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
tests/interface-reconfigure.at |4
1 file changed, 4 insertions(+)
diff --git
On Windows, we create unix sockets by creating TCP sockets
and hiding the TCP port number in files. When we close the
pstream session, we need to delete the file.
Signed-off-by: Gurucharan Shetty gshe...@nicira.com
---
lib/stream-fd-windows.c |4
lib/stream-tcp.c| 19
dpif-packet contains ofpbuf which points to packet data. Here buf
is better name rather than ofp.
Following patch renames all remaining instances of ofp variable.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
lib/netdev-dpdk.c | 4 ++--
lib/odp-execute.c | 20 ++--
Thanks, applied.
On Tue, Jun 24, 2014 at 06:11:36PM +, Pritesh Kothari (pritkoth) wrote:
Acked-by: Pritesh Kothari pritesh.koth...@cisco.com
On Jun 24, 2014, at 8:54 AM, Ben Pfaff b...@nicira.com wrote:
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/netdev-dpdk.c | 7 ---
1
On Mon, Jun 23, 2014 at 10:13:41AM -0700, Daniele Di Proietto wrote:
GCC 4.9.0 triggers a warning (array-bounds) while compiling test-classifier.c
This commit introduces an assertion that suppresses the warning.
Signed-off-by: Daniele Di Proietto ddiproie...@vmware.com
---
While I feel that
On Tue, Jun 24, 2014 at 08:29:30PM +0200, Thomas Graf wrote:
Make the parser compatible with how we print group buckets and allow
actions= to be specified, e.g.:
group_id=1,type=all,bucket=actions=output:2,bucket=actions=output:3
Also, better document the supported syntax in the manual
On Jun 24, 2014, at 1:23 PM, Ben Pfaff b...@nicira.com wrote:
On Mon, Jun 23, 2014 at 10:13:41AM -0700, Daniele Di Proietto wrote:
GCC 4.9.0 triggers a warning (array-bounds) while compiling test-classifier.c
This commit introduces an assertion that suppresses the warning.
Signed-off-by:
Just one comment below. Otherwise, all other issues will be addressed in
the next patch.
Thanks!
On Tue, Jun 24, 2014 at 8:44 AM, Ben Pfaff b...@nicira.com wrote:
On Wed, Jun 18, 2014 at 11:07:12AM -0700, Ryan Wilson wrote:
Typically, kernel datapath threads send upcalls to userspace where
We can't unlock the netdev's mutex after close the netdev, because closing
the netdev might destroy the mutex.
VMware-BZ: #1275187
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/netdev-vport.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-vport.c
Typically, kernel datapath threads send upcalls to userspace where
handler threads process the upcalls. For TAP and DPDK devices, the
datapath threads operate in userspace, so there is no need for
separate handler threads.
This patch allows userspace datapath threads to directly call the
ofproto
On Tue, Jun 24, 2014 at 01:41:13PM -0700, Ryan Wilson wrote:
On Tue, Jun 24, 2014 at 8:44 AM, Ben Pfaff b...@nicira.com wrote:
I'm surprised that dpif_netdev_disable_upcall() is marked
OVS_NO_THREAD_SAFETY_ANALYSIS instead of
OVS_ACQUIRES(dp-upcall_rwlock). Similarly for
On Jun 8, 2014, at 1:18 PM, Pravin B Shelar pshe...@nicira.com wrote:
dpif-packet contains ofpbuf which points to packet data. Here buf
is better name rather than ofp.
Following patch renames all remaining instances of ofp variable.
Signed-off-by: Pravin B Shelar pshe...@nicira.com
---
Acked-by: Ethan Jackson et...@nicira.com
On Tue, Jun 24, 2014 at 1:48 PM, Ben Pfaff b...@nicira.com wrote:
We can't unlock the netdev's mutex after close the netdev, because closing
the netdev might destroy the mutex.
VMware-BZ: #1275187
Signed-off-by: Ben Pfaff b...@nicira.com
---
So I added OVS_NO_THREAD_SAFETY_ANALYSIS to create_dp_netdev() and removed
OVS_NO_THREAD_SAFETY_ANALYSIS annotations on dpif_netdev_disable_upcall()
and dpif_netdev_enable_upcall(). However, I still get a warning from
sparse about dp-upcall_rwlock being locked / unlocked at the end of
Thanks, applied to master, branch-2.2, branch-2.3.
On Tue, Jun 24, 2014 at 02:33:45PM -0700, Ethan Jackson wrote:
Acked-by: Ethan Jackson et...@nicira.com
On Tue, Jun 24, 2014 at 1:48 PM, Ben Pfaff b...@nicira.com wrote:
We can't unlock the netdev's mutex after close the netdev, because
I think you mean Clang rather than sparse in this case.
Let's go with your original solution. It sounds like it's getting
complicated. I originally assumed that you just overlooked something.
On Tue, Jun 24, 2014 at 09:38:31PM +, Ryan Wilson 76511 wrote:
So I added
The syntax is inconvenient but at least it's documented.
Signed-off-by: Ben Pfaff b...@nicira.com
---
utilities/ovs-ofctl.8.in |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index 61a0e0d..63f4fee 100644
---
This patch kind of stands out to me when I look at it. It is awkward
to have to create an extra object (wevent) on Windows but not use it
anywhere except to pass to poll_fd_wait_event(). I didn't properly
understand until now that this was necessary.
Looking through the tree, I think that
Commit f4fd623c4c25 introduced a bug in netdev_dpdk_send(): if multiple
consecutive packets exceed MTU, only the first one is deleted and
counted.
This should fix the bug
Signed-off-by: Daniele Di Proietto ddiproie...@vmware.com
---
lib/netdev-dpdk.c | 10 +-
1 file changed, 5
Signed-off-by: Daniele Di Proietto ddiproie...@vmware.com
---
lib/netdev-dpdk.c | 58 +++
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 3359517..79f67c1 100644
--- a/lib/netdev-dpdk.c
We do not use any offloading (now) or multiple segments per packet, so
we might as well disable those features while configuring the NIC.
This could give performance improvements. For ixgbe, for example, this change
allows the driver to use a simpler tx routine, resulting in throuput
improvements
In dp_netdev_input() we nevered fully covered the case where handler queues are
not there.
With this change we increment the stat counter and free the packet.
Signed-off-by: Daniele Di Proietto ddiproie...@vmware.com
---
I can move this logic into dp_netdev_output_userspace(), if you guys think
On Tue, Jun 24, 2014 at 4:56 AM, Simon Horman ho...@verge.net.au wrote:
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe
Stringer.
Cc:
Open vSwitch userspace is able to implement some actions that the kernel
doesn't support, such as modifying ARP fields. When it does this for a
tunneled packet, it needs to supply the tunnel information with a set
action, because the Linux kernel datapath throws away tunnel information
supplied
Various recent commits have introduced build failures on FreeBSD. This
patch fixes them.
Signed-off-by: Joe Stringer joestrin...@nicira.com
---
lib/bfd.c|1 +
lib/netdev-bsd.c |4 +++-
lib/signals.h|1 +
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git
json_string_unescape() flagged a backslash at the end of a string as an
error, but of course \\ is a valid string. This fixes the problem.
VMware-BZ: #1275208
Reported-by: Michael Hu m...@nicira.com
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/json.c| 14 +-
tests/json.at
On Tue, Jun 24, 2014 at 4:40 PM, Ben Pfaff b...@nicira.com wrote:
Open vSwitch userspace is able to implement some actions that the kernel
doesn't support, such as modifying ARP fields. When it does this for a
tunneled packet, it needs to supply the tunnel information with a set
action,
From: Jesse Gross je...@nicira.com
Date: Tue, 24 Jun 2014 16:24:37 -0700
Applied, thanks for all your work. Time to break out the champagne :)
Congrats, what an amazing journey :-)
___
dev mailing list
dev@openvswitch.org
On Tue, Jun 24, 2014 at 05:08:18PM -0700, Jesse Gross wrote:
On Tue, Jun 24, 2014 at 4:40 PM, Ben Pfaff b...@nicira.com wrote:
Open vSwitch userspace is able to implement some actions that the kernel
doesn't support, such as modifying ARP fields. When it does this for a
tunneled packet, it
Hey Thomas,
Sorry for this very delayed reply and thanks a lot for your close review!
Please see my comments inline,
+
+#define MAX_CPU_SOCKETS 8
Can we bump this to something like 128? SPARC64 and the like have
been pretty crazy on the subject of number of sockets. It shouldn't
hurt
diff --git a/lib/automake.mk b/lib/automake.mk
index 3f984d9..ca6c890 100644
--- a/lib/automake.mk
+++ b/lib/automake.mk
@@ -150,6 +150,8 @@ lib_libopenvswitch_la_SOURCES = \
lib/ovs-atomic-locked.h \
lib/ovs-atomic-pthreads.h \
lib/ovs-atomic.h \
+
On 06/23/14 at 12:37pm, Alex Wang wrote:
This will be the default setting for dpdk iface.
Signed-off-by: Alex Wang al...@nicira.com
I think you can remove the NR_QUEUE #define in lib/dpif-netdev.h
with this patch.
I'll remove it.
---
lib/netdev-dpdk.c | 47
Signed-off-by: Alex Wang al...@nicira.com
---
PATCH - V2:
- Use readdir_r() instead of readdir() for reentrency.
- Address review comments from Thomas Graf.
- Add dummy interface for WIN32 case.
---
lib/automake.mk |2 +
lib/ovs-numa.c | 217
Signed-off-by: Alex Wang al...@nicira.com
---
PATCH - V2:
- Rebase.
---
lib/netdev-dpdk.c | 14 ++
lib/netdev-dpdk.h | 11 +++
2 files changed, 25 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 3359517..df71385 100644
--- a/lib/netdev-dpdk.c
+++
1 - 100 of 112 matches
Mail list logo
