Re: [ovs-dev] Iperf to test the openvswitch

2014-09-29 Thread Gheit Abomakhleb
Thanks for your quick reply Of course it is installed in both VMs Sent from my iPad On 2014年9月29日, at 08:40, Alex Wang al...@nicira.com wrote: Could you confirm that there is iperf installed on both vms? Thanks, Alex Wang, On Sun, Sep 28, 2014 at 8:52 AM, Gheit Abomakhleb

[ovs-dev] dev+unsubscr...@openvswitch.org

2014-09-29 Thread Joop Boonen
dev+unsubscr...@openvswitch.org ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] bridge: Fix bug where IDL wakeup causes 100% CPU.

2014-09-29 Thread Joe Stringer
Commit 9c537baf613a16e (bridge: Refactor the stats and status update.) inadvertently changed the way that the status transaction is destroyed, which could cause the main thread to constantly wake up. The bug occurs when a transaction returns TXN_INCOMPLETE, then there are no subsequent changes to

[ovs-dev] [PATCHv3 1/2] datapath: Add nla_parse_strict().

2014-09-29 Thread Joe Stringer
This function allows netlink attributes to be parsed more strictly, to check for additional constraints beyond those that nla_parse() checks for. Passing flags=0 to nla_parse_strict() implies the same behaviour as nla_parse(). Signed-off-by: Joe Stringer joestrin...@nicira.com --- v3: Shift

[ovs-dev] [PATCHv3 2/2] datapath: Use nla_parse_strict() for netlink parsing.

2014-09-29 Thread Joe Stringer
Reduce duplicate code by using nla_policy and nla_parse_strict(). Signed-off-by: Joe Stringer joestrin...@nicira.com --- v3: Fix match_validate() Make ovs_key_from_nlattrs(),metadata_from_nlattrs() not change the attrs they are given Remove extraneous check for duplicate attributes

[ovs-dev] [PATCH] datapath-windows: Missed packets are not queued.

2014-09-29 Thread Sorin Vinturis
Currently, whenever there's a missed packet, the ovs driver allocates memory and copies the packet even if there's no packet queue setup from userspace. Then if there's no queue created, the packet is released and dropped. The solution was to check for the existence of the userspace queue before

[ovs-dev] [PATCH] flow.c: correct the comment for miniflow_equal

2014-09-29 Thread Wang Sheng-Hui
It's for miniflow equalness check, not flow. Signed-off-by: Wang Sheng-Hui shh...@gmail.com --- lib/flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/flow.c b/lib/flow.c index b9f1820..4f22597 100644 --- a/lib/flow.c +++ b/lib/flow.c @@ -1770,7 +1770,7 @@

Re: [ovs-dev] [PATCH v4] datapath-windows Event read handler

2014-09-29 Thread Ben Pfaff
On Sat, Sep 27, 2014 at 01:39:06AM -0700, Eitan Eliahu wrote: The Read event handler is executed when user mode issues a socket receive on an MC socket associated with the event queue. A new IOCTL READ command is used to differentiate between transaction based and packet miss sockets. An

Re: [ovs-dev] [PATCH] WMI Script that updates Hyper-V friendly port names

2014-09-29 Thread Ben Pfaff
On Thu, Sep 25, 2014 at 06:18:19AM +, Alin Serdean wrote: The following script leverage's the advantages of WMI infrastructure offered in Hyper-V. This scripts allows the user to change the Msvm_EthernetPortAllocationSettingData property of a VM network adapter connected to a Hyper-V

Re: [ovs-dev] [PATCH v2] datapath-windows: NUL character should be left out during VPORT hash lookup

2014-09-29 Thread Ben Pfaff
On Fri, Sep 26, 2014 at 06:38:16PM -0700, Nithin Raju wrote: While calculating the hash on a VPORT name, we don't include the NUL character. We should be doing the same while doing lookup as well. We set the required minimum length of the name to be 2 so that the string has at least one

Re: [ovs-dev] [PATCH v3 01/11] datapath-windows: move OVS_MESSAGE to Netlink.h

2014-09-29 Thread Ben Pfaff
On Fri, Sep 26, 2014 at 05:32:12PM -0700, Ankur Sharma wrote: Moved the structure OVS_MESSAGE to Netlink.h. This change is done for following reasons. a. Patch 2 in this series provides a generic API in Netlink.c for creating netlink message. That API needs OVS_MESSAGE. Including Datapath.h

Re: [ovs-dev] Iperf to test the openvswitch

2014-09-29 Thread Alex Wang
Could you try using `ovs-dpctl dump-flows` to see what the flow look like when you start the iperf test? I checked the radio, iperf test should work if you used that configuration, Thanks, Alex Wang, On Sun, Sep 28, 2014 at 11:44 PM, Gheit Abomakhleb ghibrahi...@icloud.com wrote: Thanks for

Re: [ovs-dev] [PATCH] datapath-windows: Missed packets are not queued.

2014-09-29 Thread Ben Pfaff
On Mon, Sep 29, 2014 at 03:07:04PM +, Sorin Vinturis wrote: Currently, whenever there's a missed packet, the ovs driver allocates memory and copies the packet even if there's no packet queue setup from userspace. Then if there's no queue created, the packet is released and dropped. The

Re: [ovs-dev] Iperf to test the openvswitch

2014-09-29 Thread Gurucharan Shetty
If you can ping but cannot use iperf for TCP, one thing to do would be to check iptables rules that block TCP connections in the VM (default in Centos) On Mon, Sep 29, 2014 at 9:07 AM, Alex Wang al...@nicira.com wrote: Could you try using `ovs-dpctl dump-flows` to see what the flow look like

Re: [ovs-dev] [PATCH] flow.c: correct the comment for miniflow_equal

2014-09-29 Thread Ben Pfaff
On Mon, Sep 29, 2014 at 03:21:37PM +0800, Wang Sheng-Hui wrote: It's for miniflow equalness check, not flow. Signed-off-by: Wang Sheng-Hui shh...@gmail.com Applied, thanks! ___ dev mailing list dev@openvswitch.org

[ovs-dev] [PATCH] datapath-windows: Missed packets are not queued.

2014-09-29 Thread Sorin Vinturis
Currently, whenever there's a missed packet, the ovs driver allocates memory and copies the packet even if there's no packet queue setup from userspace. Then if there's no queue created, the packet is released and dropped. The solution was to check for the existence of the userspace queue before

[ovs-dev] ovs.org down again?

2014-09-29 Thread Ben Pfaff
Can't seem to reach it now. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v1] datapath-windows: Build fix.

2014-09-29 Thread Ankur Sharma
Recently we changed the signature of NlAttrParse. Function OvsGetVport was not updated accordingly. Fixed the same. Signed-off-by: Ankur Sharma ankursha...@vmware.com --- datapath-windows/ovsext/Datapath.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath-windows/ovsext/Datapath.c

Re: [ovs-dev] [PATCH] bridge: Fix bug where IDL wakeup causes 100% CPU.

2014-09-29 Thread Alex Wang
Thx a lot for the fix, that was a bad move~ Acked-by: Alex Wang al...@nicira.com On Mon, Sep 29, 2014 at 3:09 AM, Joe Stringer joestrin...@nicira.com wrote: Commit 9c537baf613a16e (bridge: Refactor the stats and status update.) inadvertently changed the way that the status transaction is

[ovs-dev] [PATCH v5 1/1] netdev-dpdk: add dpdk vhost ports

2014-09-29 Thread maryam.tahhan
This patch implements the vhost-net offload API. It adds support for a new port type to userspace datapath called dpdkvhost. This allows KVM (QEMU) to offload the servicing of virtio-net devices to it's associated dpdkvhost port. Instructions for use are in INSTALL.DPDK. This has been tested on

Re: [ovs-dev] [PATCH v1] datapath-windows: Build fix.

2014-09-29 Thread Nithin Raju
On Sep 29, 2014, at 10:13 AM, Ankur Sharma ankursha...@vmware.com wrote: Recently we changed the signature of NlAttrParse. Function OvsGetVport was not updated accordingly. Fixed the same. Signed-off-by: Ankur Sharma ankursha...@vmware.com Acked-by: Nithin Raju nit...@vmware.com

Re: [ovs-dev] [PATCH v1] datapath-windows: Build fix.

2014-09-29 Thread Alin Serdean
Tested under Release/Debug. Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju Trimis: Monday, September 29, 2014 8:17 PM Către: Ankur Sharma Cc: dev@openvswitch.org Subiect: Re: [ovs-dev]

Re: [ovs-dev] [PATCH v1] datapath-windows: Build fix.

2014-09-29 Thread Ben Pfaff
On Mon, Sep 29, 2014 at 10:13:00AM -0700, Ankur Sharma wrote: Recently we changed the signature of NlAttrParse. Function OvsGetVport was not updated accordingly. Fixed the same. Signed-off-by: Ankur Sharma ankursha...@vmware.com Applied, thanks everyone!

[ovs-dev] [PATCH] FAQ: Replace reference to OVS 2.2 with 2.3.

2014-09-29 Thread Justin Pettit
We never released 2.2.0, so references to it are confusing. Signed-off-by: Justin Pettit jpet...@nicira.com --- FAQ |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/FAQ b/FAQ index 175a5ac..9e74a3f 100644 --- a/FAQ +++ b/FAQ @@ -149,7 +149,7 @@ A: The following table

Re: [ovs-dev] [PATCH] FAQ: Replace reference to OVS 2.2 with 2.3.

2014-09-29 Thread Gurucharan Shetty
On Mon, Sep 29, 2014 at 11:16 AM, Justin Pettit jpet...@nicira.com wrote: We never released 2.2.0, so references to it are confusing. Signed-off-by: Justin Pettit jpet...@nicira.com Acked-by: Gurucharan Shetty gshe...@nicira.com --- FAQ |2 +- 1 files changed, 1 insertions(+), 1

[ovs-dev] [PATCH] User mode event read for Windows

2014-09-29 Thread Eitan Eliahu
User mode sends down three distinct Read ioctl commands for Events, Packet Reads and Dumps. In case the Packet Read socket can not be distinguished a Set function will be provided. Signed-off-by: Eitan Eliahu elia...@vmware.com --- lib/netlink-socket.c | 12 +--- 1 file changed, 9

Re: [ovs-dev] [PATCH] bridge: Fix bug where IDL wakeup causes 100% CPU.

2014-09-29 Thread Joe Stringer
Thanks for review, I reworded the commit message and comment and pushed to master: Commit 9c537baf613a16e (bridge: Refactor the stats and status update.) inadvertently changed the way that the status transaction is destroyed, which could cause the main thread to constantly wake up.

Re: [ovs-dev] [PATCHv6 08/14] tests: Mention binomial coefficient in hash tests.

2014-09-29 Thread Ben Pfaff
On Fri, Sep 26, 2014 at 09:28:12PM +1200, Joe Stringer wrote: This just makes it a bit easier for someone coming in fresh to do some searches and figure out what the description means. Signed-off-by: Joe Stringer joestrin...@nicira.com --- v6: First post. Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCHv6 01/14] revalidator: Distinguish new and duplicate flows.

2014-09-29 Thread Ben Pfaff
On Fri, Sep 26, 2014 at 09:28:05PM +1200, Joe Stringer wrote: We previously counted flows that have been installed during the current dump as duplicates, rather than recognising them as new flows. This patch separates the counters out for these two cases. Signed-off-by: Joe Stringer

Re: [ovs-dev] [PATCH] FAQ: Replace reference to OVS 2.2 with 2.3.

2014-09-29 Thread Justin Pettit
Thanks.  Pushed. --Justin On September 29, 2014 at 11:26:11 AM, Gurucharan Shetty (shet...@nicira.com) wrote: On Mon, Sep 29, 2014 at 11:16 AM, Justin Pettit wrote: We never released 2.2.0, so references to it are confusing. Signed-off-by: Justin Pettit Acked-by: Gurucharan Shetty

Re: [ovs-dev] [PATCH] Makefiles: Add $(AM_V_GEN) annotations to clean up make output.

2014-09-29 Thread Joe Stringer
Looks a bit tidier, thanks! From the linked travis build, it seems like there's still a bit of verbosity on the testsuite builds, because they do a 'make distcheck' after the standard configure and make. Could we just run make distcheck in those cases, and make sure it gets run with the silent

Re: [ovs-dev] [PATCHv6 09/14] hash: Add 128-bit murmurhash.

2014-09-29 Thread Ben Pfaff
On Fri, Sep 26, 2014 at 09:28:13PM +1200, Joe Stringer wrote: Add the 128-bit murmurhash by Austin Appleby, r150 from: http://code.google.com/p/smhasher/source/browse/trunk/MurmurHash3.cpp Signed-off-by: Joe Stringer joestrin...@nicira.com --- The x64 version is approximately 2x faster than

Re: [ovs-dev] [PATCH] Makefiles: Add $(AM_V_GEN) annotations to clean up make output.

2014-09-29 Thread Ben Pfaff
Thanks for looking this over. I don't understand the suggestion. Can you explain further? One factor: I don't think automated builds should use --enable-silent-rules, because for automated builds one wants as much information as possible on failure. I do want it for my local developer builds,

Re: [ovs-dev] [PATCH] Makefiles: Add $(AM_V_GEN) annotations to clean up make output.

2014-09-29 Thread Joe Stringer
Ah, I thought that you may have proposed/pushed the --enable-silent-rules for travis build on master, rather than just using travis to test that this patch works as intended. Misunderstanding on my part, so never mind. On 30 September 2014 09:37, Ben Pfaff b...@nicira.com wrote: Thanks for

Re: [ovs-dev] [PATCHv6 11/14] datapath: Add support for unique flow identifiers.

2014-09-29 Thread Ben Pfaff
On Fri, Sep 26, 2014 at 09:28:15PM +1200, Joe Stringer wrote: If a datapath is created with the flag OVS_DP_F_INDEX_BY_UID, then an additional table_instance is added to the flow_table, which is indexed by unique identifiers (UID). Userspace implementations can specify a UID of up to 128 bits

Re: [ovs-dev] [PATCHv6 12/14] dpif: Index flows using unique identifiers.

2014-09-29 Thread Ben Pfaff
On Fri, Sep 26, 2014 at 09:28:16PM +1200, Joe Stringer wrote: This patch modifies the dpif interface to allow flows to be manipulated using a 128-bit identifier. This allows revalidator threads to perform datapath operations faster, as they do not need to serialise the entire flow key for

Re: [ovs-dev] [PATCHv6 14/14] udpif: Simplify storage of key, mask in udpif_key.

2014-09-29 Thread Ben Pfaff
On Fri, Sep 26, 2014 at 09:28:18PM +1200, Joe Stringer wrote: Previously we stored the netlink-formatted version of a flow key and mask in 'struct udpif_key'. This patch stores the original key,mask in the 'struct match' format, which reduces the size of a ukey from 1216 bytes to 560.

Re: [ovs-dev] [PATCH] Makefiles: Add $(AM_V_GEN) annotations to clean up make output.

2014-09-29 Thread Ben Pfaff
Great, thanks for the clarification. Applied to master. On Tue, Sep 30, 2014 at 09:44:46AM +1300, Joe Stringer wrote: Ah, I thought that you may have proposed/pushed the --enable-silent-rules for travis build on master, rather than just using travis to test that this patch works as intended.

Re: [ovs-dev] [PATCH 01/17] extract-ofp-msgs: Correct some user messages.

2014-09-29 Thread Ben Pfaff
On Wed, Sep 24, 2014 at 09:06:15AM +0900, YAMAMOTO Takashi wrote: Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: YAMAMOTO Takashi yamam...@valinux.co.jp Applied, thanks! ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 04/17] ofp-actions, nx-match: Use mf_oxm_header() instead of explicit constants.

2014-09-29 Thread Ben Pfaff
On Wed, Sep 24, 2014 at 09:22:30AM +0900, YAMAMOTO Takashi wrote: Following this change, only meta-flow.c uses any explicit NXM_* or OXM_* constants. An upcoming commit will actually remove the definitions of these constants, hiding them behind a functional interface, for better

Re: [ovs-dev] [PATCH 05/17] nx-match: Encode dp_hash and recirc_id in OXM also.

2014-09-29 Thread Ben Pfaff
On Wed, Sep 24, 2014 at 09:27:19AM +0900, YAMAMOTO Takashi wrote: dp_hash and recirc_id are specific to OVS, but that doesn't mean that we shouldn't encode them into flow matches when OXM is used in OpenFlow 1.2 and later. Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: YAMAMOTO

Re: [ovs-dev] [PATCH 07/17] util: New function bitwise_scan().

2014-09-29 Thread Ben Pfaff
On Wed, Sep 24, 2014 at 10:33:21AM +0900, YAMAMOTO Takashi wrote: This will acquire its first user in an upcoming commit. This implementation is not optimized at all but it doesn't matter for the purpose for which I intend to initially use it. Signed-off-by: Ben Pfaff b...@nicira.com

Re: [ovs-dev] [PATCH 09/17] ovs-ofctl: Encode cookies in OXM-compliant manner.

2014-09-29 Thread Ben Pfaff
On Wed, Sep 24, 2014 at 10:37:45AM +0900, YAMAMOTO Takashi wrote: NXM/OXM are only supposed to put 1-bits in a value if the corresponding bit in the mask is a 1-bit, but in the case of cookie matching, e.g. ovs-ofctl del-flows br0 cookie=0x3/0x1 ovs-ofctl would encode a bad OXM. This

Re: [ovs-dev] [PATCH 10/17] ofp-actions: Better support OXM in Copy-Field action.

2014-09-29 Thread Ben Pfaff
On Wed, Sep 24, 2014 at 10:40:14AM +0900, YAMAMOTO Takashi wrote: The OpenFlow 1.5 (draft) Copy-Field action has two OXM headers, one after the other. Until now, Open vSwitch has implemented these as a pair of ovs_be32 membes, which meant that only 32-bit OXM could be supported. This

[ovs-dev] [patch V2] INSTALL.DPDK: Update DPDK related documentation.

2014-09-29 Thread Alex Wang
This commit updates the DPDK related documentation to reflect the pmd thread multi-threading work. Signed-off-by: Alex Wang al...@nicira.com --- PATCH-V2: - use present tense. --- INSTALL.DPDK | 70 ++ vswitchd/vswitch.xml |5 ++-- 2

Re: [ovs-dev] [PATCHv6 09/14] hash: Add 128-bit murmurhash.

2014-09-29 Thread Joe Stringer
On 30 September 2014 09:30, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:13PM +1200, Joe Stringer wrote: Add the 128-bit murmurhash by Austin Appleby, r150 from: http://code.google.com/p/smhasher/source/browse/trunk/MurmurHash3.cpp Signed-off-by: Joe Stringer

[ovs-dev] [PATCH v1 0/5] datapath-windows flow_dump

2014-09-29 Thread Ankur Sharma
In this series we have flow dump/get in datapath-windows. We have added some additional APIs in Netlink that looked to be useful. Ankur Sharma (5): datapath-windows: Netlink additional APIs. datapath-windows: Added the API for getting unused space in nlbuf. datapath-windows: Flow Dump

[ovs-dev] [PATCH v1 1/5] datapath-windows: Netlink additional APIs.

2014-09-29 Thread Ankur Sharma
In this patch we have added following new APIs. NlMsgAlignSize = Aligns the size of netlink message. NlMsgSetSize = Sets the value of nlmsgLen. Signed-off-by: Ankur Sharma ankursha...@vmware.com --- datapath-windows/ovsext/Netlink/Netlink.c | 54 +++

[ovs-dev] [PATCH v1 2/5] datapath-windows: Added the API for getting unused space in nlbuf.

2014-09-29 Thread Ankur Sharma
Also, the boundary check in NlBufAt was a little weird. Fixed the same. Signed-off-by: Ankur Sharma ankursha...@vmware.com --- datapath-windows/ovsext/Datapath.c | 3 +-- datapath-windows/ovsext/Netlink/NetlinkBuf.c | 2 +- datapath-windows/ovsext/Netlink/NetlinkBuf.h | 14

[ovs-dev] [PATCH v1 3/5] datapath-windows: Flow Dump handler

2014-09-29 Thread Ankur Sharma
In this patch we have added basic changes for handler registeration for FLOW_GET command. Signed-off-by: Ankur Sharma ankursha...@vmware.com --- datapath-windows/include/OvsPub.h | 2 +- datapath-windows/ovsext/Datapath.c | 25 + datapath-windows/ovsext/Datapath.h | 14

[ovs-dev] [PATCH v1 5/5] datapath-windows: Flow get implementation.

2014-09-29 Thread Ankur Sharma
In this patch we have implemented the flow get. Signed-off-by: Ankur Sharma ankursha...@vmware.com --- datapath-windows/ovsext/Flow.c | 200 + 1 file changed, 184 insertions(+), 16 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c

[ovs-dev] [PATCH v1 4/5] datapath-windows: Flow dump implementation.

2014-09-29 Thread Ankur Sharma
In this patch we have implemented the flow dump. Signed-off-by: Ankur Sharma ankursha...@vmware.com --- datapath-windows/ovsext/Flow.c | 635 - 1 file changed, 625 insertions(+), 10 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c

Re: [ovs-dev] [PATCHv6 10/14] dpif: Generate flow_hash for revalidators in dpif.

2014-09-29 Thread Joe Stringer
On 30 September 2014 09:51, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:14PM +1200, Joe Stringer wrote: This patch shifts the responsibility for determining the hash for a flow from the revalidation logic down to the dpif layer. This assists in handling

Re: [ovs-dev] [PATCH 06/17] meta-flow: Autogenerate mf_field data structures.

2014-09-29 Thread YAMAMOTO Takashi
On Wed, Sep 24, 2014 at 10:24:11AM +0900, YAMAMOTO Takashi wrote: This is a first step toward improving the abstraction of OXM and NXM in the tree. As an immediate improvement, this commit removes all of the definitions of the OXM and NXM constants from the top-level header files,

Re: [ovs-dev] [PATCHv6 09/14] hash: Add 128-bit murmurhash.

2014-09-29 Thread Ben Pfaff
On Tue, Sep 30, 2014 at 11:30:38AM +1300, Joe Stringer wrote: On 30 September 2014 09:30, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:13PM +1200, Joe Stringer wrote: Add the 128-bit murmurhash by Austin Appleby, r150 from:

Re: [ovs-dev] [PATCHv6 11/14] datapath: Add support for unique flow identifiers.

2014-09-29 Thread Joe Stringer
On 30 September 2014 10:10, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:15PM +1200, Joe Stringer wrote: If a datapath is created with the flag OVS_DP_F_INDEX_BY_UID, then an additional table_instance is added to the flow_table, which is indexed by unique identifiers

[ovs-dev] [PATCH] CodingStyle: Mention our assumption about conversions to bool

2014-09-29 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi yamam...@valinux.co.jp --- CodingStyle | 5 + 1 file changed, 5 insertions(+) diff --git a/CodingStyle b/CodingStyle index c9b9989..d1ef65b 100644 --- a/CodingStyle +++ b/CodingStyle @@ -541,6 +541,11 @@ C DIALECT * bool and stdbool.h, but don't assume

Re: [ovs-dev] [PATCH 07/17] util: New function bitwise_scan().

2014-09-29 Thread YAMAMOTO Takashi
On Wed, Sep 24, 2014 at 10:33:21AM +0900, YAMAMOTO Takashi wrote: This will acquire its first user in an upcoming commit. This implementation is not optimized at all but it doesn't matter for the purpose for which I intend to initially use it. Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH 06/17] meta-flow: Autogenerate mf_field data structures.

2014-09-29 Thread YAMAMOTO Takashi
On Wed, Sep 24, 2014 at 10:24:11AM +0900, YAMAMOTO Takashi wrote: This is a first step toward improving the abstraction of OXM and NXM in the tree. As an immediate improvement, this commit removes all of the definitions of the OXM and NXM constants from the top-level header files,

Re: [ovs-dev] [PATCH 08/17] nx-match: Move all knowledge of OXM/NXM here.

2014-09-29 Thread YAMAMOTO Takashi
This improves the general abstraction of OXM/NXM by eliminating direct knowledge of it from the meta-flow code and other places. Some function renaming might be called for; for example, mf_oxm_header() may not be the best name now that the function is implemented within nx-match. However,

Re: [ovs-dev] [PATCH] User mode event read for Windows

2014-09-29 Thread Nithin Raju
On Sep 29, 2014, at 7:16 PM, Eitan Eliahu elia...@vmware.com wrote: User mode sends down three distinct Read ioctl commands for Events, Packet Reads and Dumps. In case the Packet Read socket can not be distinguished a Set function will be provided. Signed-off-by: Eitan Eliahu

Re: [ovs-dev] [PATCH 12/17] nx-match: Use nx_put_header() internally for encoding flow matches.

2014-09-29 Thread YAMAMOTO Takashi
This will make it easier to support 64-bit OXM experimenter fields. Signed-off-by: Ben Pfaff b...@nicira.com static void -nxm_put_ipv6(struct ofpbuf *b, uint32_t header, +nxm_put_ipv6(struct ofpbuf *b, + enum mf_field_id field, enum ofp_version version, const

[ovs-dev] Hallo.

2014-09-29 Thread Martha Maiga
Hello, How are you, I hope you're well, my name is Martha, I'm medium height and fair in complexion, i love,caring and I decided to contact you. I really want to have a good relationship with you. Next I have a special something I want to discuss with you and tell you more about my self. Hope

Re: [ovs-dev] [PATCHv6 12/14] dpif: Index flows using unique identifiers.

2014-09-29 Thread Joe Stringer
On 30 September 2014 10:15, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:16PM +1200, Joe Stringer wrote: This patch modifies the dpif interface to allow flows to be manipulated using a 128-bit identifier. This allows revalidator threads to perform datapath operations

Re: [ovs-dev] [PATCHv6 13/14] dpif: Minimize memory copy for revalidation.

2014-09-29 Thread Joe Stringer
On 30 September 2014 10:24, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:17PM +1200, Joe Stringer wrote: One of the limiting factors on the number of flows that can be supported in the datapath is the overhead of assembling flow dump messages in the datapath. This patch

Re: [ovs-dev] [PATCHv6 14/14] udpif: Simplify storage of key, mask in udpif_key.

2014-09-29 Thread Joe Stringer
On 30 September 2014 10:27, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:18PM +1200, Joe Stringer wrote: Previously we stored the netlink-formatted version of a flow key and mask in 'struct udpif_key'. This patch stores the original key,mask in the 'struct match' format,

Re: [ovs-dev] [PATCHv6 01/14] revalidator: Distinguish new and duplicate flows.

2014-09-29 Thread Joe Stringer
Thanks, applied to master. On 30 September 2014 08:54, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:05PM +1200, Joe Stringer wrote: We previously counted flows that have been installed during the current dump as duplicates, rather than recognising them as new flows. This

Re: [ovs-dev] [PATCHv6 08/14] tests: Mention binomial coefficient in hash tests.

2014-09-29 Thread Joe Stringer
Thanks, applied to master. On 30 September 2014 08:57, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:12PM +1200, Joe Stringer wrote: This just makes it a bit easier for someone coming in fresh to do some searches and figure out what the description means. Signed-off-by:

[ovs-dev] [PATCH] datapath: Add support for RHEL-7 / CentOS-7 kernel.

2014-09-29 Thread Pravin B Shelar
This patch mostly is related to tunnel API where RHEL 7 kernel API are not in-sync with newer linux kernel API. So extra checks are required to check for parameters of API. Signed-off-by: Pravin B Shelar pshe...@nicira.com --- acinclude.m4 |7 +++