Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-09 Thread Pravin Shelar
On Tue, Dec 9, 2014 at 4:25 PM, Joe Stringer wrote: > On 9 December 2014 at 10:32, Pravin Shelar wrote: >> On Tue, Dec 2, 2014 at 6:56 PM, Joe Stringer wrote: >>> @@ -662,11 +664,18 @@ static void get_dp_stats(const struct datapath *dp, >>> struct ovs_dp_stats *stats, >>> } >>> } >>>

Re: [ovs-dev] [PATCH 00/10] Expose vlog and vconn in public headers

2014-12-09 Thread YAMAMOTO Takashi
> On 12/10/14 at 01:29pm, YAMAMOTO Takashi wrote: >> > This series exposes the vlog and vconn API plus all required dependencies. >> > The vconn is only partially usable at this point because ofpbuf cannot >> > be exposed in its current state. A next series will start refactoring of >> > ofpbuf. >>

Re: [ovs-dev] [PATCH 00/10] Expose vlog and vconn in public headers

2014-12-09 Thread Thomas Graf
On 12/10/14 at 01:29pm, YAMAMOTO Takashi wrote: > > This series exposes the vlog and vconn API plus all required dependencies. > > The vconn is only partially usable at this point because ofpbuf cannot > > be exposed in its current state. A next series will start refactoring of > > ofpbuf. > > can

Re: [ovs-dev] [PATCH 1/5] route-table-bsd: Stop caching pid

2014-12-09 Thread YAMAMOTO Takashi
> On Wed, Dec 03, 2014 at 07:31:32PM +0900, YAMAMOTO Takashi wrote: >> The cache here doesn't work anymore as the recent >> commit b772066ffd066d59d9ebce092f6665150723d2ad >> ("route-table: Remove Unregister.") >> made this function called before daemonizing, >> thus with a different pid. >> >> Si

Re: [ovs-dev] [PATCH 2/5] ovs-router: non-Linux support

2014-12-09 Thread YAMAMOTO Takashi
> On Wed, Dec 3, 2014 at 2:31 AM, YAMAMOTO Takashi > wrote: >> Refactor ovs-router so that it can work with non-Linux platforms >> at least in some extent, using the existing route-table code as >> a fallback. Known restriction: for such platforms, "ovs/router/show" >> command does not show "Cac

Re: [ovs-dev] [PATCH 4/5] route-table-bsd: Provide gateway info

2014-12-09 Thread YAMAMOTO Takashi
> On Wed, Dec 03, 2014 at 07:31:35PM +0900, YAMAMOTO Takashi wrote: >> For userspace tunneling. >> >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff thank you. applied. YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openv

Re: [ovs-dev] [PATCH 5/5] route-table-bsd: Add some DBG logs

2014-12-09 Thread YAMAMOTO Takashi
> On Wed, Dec 03, 2014 at 07:31:36PM +0900, YAMAMOTO Takashi wrote: >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff thank you. applied. YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/5] ovs-router: Add "ovs/route/lookup" command

2014-12-09 Thread YAMAMOTO Takashi
> On Wed, Dec 3, 2014 at 2:31 AM, YAMAMOTO Takashi > wrote: >> This command is useful at least for testing. >> >> Example output: >> % ovs-appctl ovs/route/lookup '10.0.0.1' >> gateway 172.17.0.254 >> dev wm0 >> % >> > Can you add documentation for new command? like this? YAMAMO

Re: [ovs-dev] [PATCH 00/10] Expose vlog and vconn in public headers

2014-12-09 Thread YAMAMOTO Takashi
> This series exposes the vlog and vconn API plus all required dependencies. > The vconn is only partially usable at this point because ofpbuf cannot > be exposed in its current state. A next series will start refactoring of > ofpbuf. can you explain your motivation briefly? YAMAMOTO Takashi

Re: [ovs-dev] Support for MCAST_Snooping

2014-12-09 Thread Aman Kumar
Yes, Please do the patch against branch master and inform me, i will test it with branch master. Currently i am using the branch master only. Thanks Aman Kumar HP India On Wed, Dec 10, 2014 at 12:57 AM, Flavio Leitner wrote: > On Wed, Dec 10, 2014 at 12:09:07AM +0530, Aman Kumar wrote: > > > mc

Re: [ovs-dev] [PATCH 0/4] datapath: Compatibility to 3.18+

2014-12-09 Thread Pravin Shelar
On Wed, Dec 3, 2014 at 4:02 AM, Thomas Graf wrote: > Fixes compilation of datapath for both current net and net-next tree. > > Thomas Graf (4): > datapath: Check if nla_is_last() is available in > datapath: Mark compatible with kernels up to 3.18.x > datapath: Account for rename to vlan_ins

Re: [ovs-dev] [PATCH v8 5/5] datapath: add layer 3 support to ovs_packet_cmd_execute()

2014-12-09 Thread Jarno Rajahalme
On Dec 9, 2014, at 11:06 AM, Lori Jakab wrote: > On 11/21/2014 02:20 AM, Jesse Gross wrote: >> On Thu, Nov 20, 2014 at 4:06 PM, Jarno Rajahalme >> wrote: >>> On Nov 20, 2014, at 12:18 PM, Jesse Gross wrote: >>> >>> On Thu, Nov 20, 2014 at 10:35 AM, Jarno Rajahalme >>> wrote: >>> >>> The ne

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-09 Thread Joe Stringer
On 9 December 2014 at 10:32, Pravin Shelar wrote: > On Tue, Dec 2, 2014 at 6:56 PM, Joe Stringer wrote: >> @@ -662,11 +664,18 @@ static void get_dp_stats(const struct datapath *dp, >> struct ovs_dp_stats *stats, >> } >> } >> >> -static size_t ovs_flow_cmd_msg_size(const struct sw_flow_a

[ovs-dev] [PATCH] net: openvswitch: Support masked set actions.

2014-12-09 Thread Jarno Rajahalme
OVS userspace already probes the openvswitch kernel module for OVS_ACTION_ATTR_SET_MASKED support. This patch adds the kernel module implementation of masked set actions. The existing set action sets many fields at once. When only a subset of the IP header fields, for example, should be modified

Re: [ovs-dev] [PATCH net-next] openvswitch: set correct protocol on route lookup

2014-12-09 Thread David Miller
From: Jiri Benc Date: Fri, 5 Dec 2014 17:24:28 +0100 > Respect what the caller passed to ovs_tunnel_get_egress_info. > > Fixes: 8f0aad6f35f7e ("openvswitch: Extend packet attribute for egress tunnel > info") > Signed-off-by: Jiri Benc Applied, thanks.

Re: [ovs-dev] Support for MCAST_Snooping

2014-12-09 Thread Flavio Leitner
On Wed, Dec 10, 2014 at 12:09:07AM +0530, Aman Kumar wrote: > > mcast-snooping-flood=true, Once you enable that on a port, all > multicast traffic (but not Reports) will be sent over that port > > I have enabled "mcast-snooping-flood=true" on my port patch-tun and in this > case all traffic inclu

Re: [ovs-dev] [PATCH v8 5/5] datapath: add layer 3 support to ovs_packet_cmd_execute()

2014-12-09 Thread Lori Jakab
On 11/21/2014 02:20 AM, Jesse Gross wrote: > On Thu, Nov 20, 2014 at 4:06 PM, Jarno Rajahalme > wrote: >> On Nov 20, 2014, at 12:18 PM, Jesse Gross wrote: >> >> On Thu, Nov 20, 2014 at 10:35 AM, Jarno Rajahalme >> wrote: >> >> The netlink key for flow put is serialized from struct flow, so even

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-09 Thread David Miller
Please do not quote an entire patch just to add some simple feedback or signoff/ack. That means someone has to scroll past the entire patch in patchwork or the mailing list archives, unnecessarily. This is one of my largest pet peeves, please do not do this. Thanks.

Re: [ovs-dev] Support for MCAST_Snooping

2014-12-09 Thread Aman Kumar
> mcast-snooping-flood=true, Once you enable that on a port, all multicast traffic (but not Reports) will be sent over that port I have enabled "mcast-snooping-flood=true" on my port patch-tun and in this case all traffic including Reports are reaching to other side i.e on OVS2, since report is c

Re: [ovs-dev] OVS Kernel Datapath development

2014-12-09 Thread Pravin Shelar
On Tue, Dec 9, 2014 at 10:02 AM, Lori Jakab wrote: > On 12/08/2014 06:47 AM, Pravin Shelar wrote: >> Since the beginning OVS kernel datapath development is primarily done >> on external OVS repo. Now we have mostly synced upstream and external >> OVS. So we have decided to change this process. New

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-09 Thread Pravin Shelar
On Tue, Dec 2, 2014 at 6:56 PM, Joe Stringer wrote: > Previously, flows were manipulated by userspace specifying a full, > unmasked flow key. This adds significant burden onto flow > serialization/deserialization, particularly when dumping flows. > > This patch adds an alternative way to refer to

[ovs-dev] [PATCH 10/10] lib: Add test for library usage

2014-12-09 Thread Thomas Graf
This test covers inclusion of public header files and basic usage of the API such as vlog. Signed-off-by: Thomas Graf --- tests/.gitignore | 1 + tests/automake.mk | 6 tests/lib.at | 9 ++ tests/library.at | 4 +++ tests/test-lib.c | 94 +

[ovs-dev] [PATCH 08/10] lib: Move vlog.h to

2014-12-09 Thread Thomas Graf
A new function vlog_insert_module() is introduced to avoid using list_insert() from the vlog.h header. Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 3 +- include/openvswitch/vlog.h | 296 lib/automake.mk | 1 -

[ovs-dev] [PATCH 09/10] lib: Move vconn.h to

2014-12-09 Thread Thomas Graf
Also moves definitions for struct vconn and pvconn to the public header. The provider interface is kept private. Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 1 + include/openvswitch/vconn.h | 113 lib/automake.mk

[ovs-dev] [PATCH 03/10] lib: Expose ovs_mutex and ovsthread_once in

2014-12-09 Thread Thomas Graf
This picks the ovs_mutex and ovsthread_once API from lib/ovs-thread.h and exposes it in . Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 1 + include/openvswitch/thread.h| 137 lib/ovs-thread.h| 112 +---

[ovs-dev] [PATCH 04/10] lib: Move token-bucket.h to

2014-12-09 Thread Thomas Graf
Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk| 1 + include/openvswitch/token-bucket.h | 42 ++ lib/automake.mk| 1 - lib/token-bucket.c | 2 +- lib/token-bucket.h | 42

[ovs-dev] [PATCH 00/10] Expose vlog and vconn in public headers

2014-12-09 Thread Thomas Graf
This series exposes the vlog and vconn API plus all required dependencies. The vconn is only partially usable at this point because ofpbuf cannot be exposed in its current state. A next series will start refactoring of ofpbuf. Thomas Graf (10): lib: Move compiler.h to lib: Expose SOURCE_LOCAT

[ovs-dev] [PATCH 07/10] lib: Expose struct ovs_list definition in

2014-12-09 Thread Thomas Graf
Expose the struct ovs_list definition in . Keep the list access API private for now. Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 1 + include/openvswitch/list.h | 27 +++ lib/list.h | 9 + 3 files changed, 29 insert

[ovs-dev] [PATCH 05/10] lib: Expose SAT_MUT as OVS_SAT_MUL in

2014-12-09 Thread Thomas Graf
Insted of exposing the full sat-math.h API, only the macros used in headers is exposed through Signed-off-by: Thomas Graf --- include/openvswitch/util.h | 6 ++ lib/sat-math.h | 8 ++-- lib/vlog.h | 2 +- 3 files changed, 9 insertions(+), 7 deletions(-) diff

[ovs-dev] [PATCH 01/10] lib: Move compiler.h to

2014-12-09 Thread Thomas Graf
The following macros are renamed to avoid conflicts with other headers: * WARN_UNUSED_RESULT to OVS_WARN_UNUSED_RESULT * PRINTF_FORMAT to OVS_PRINTF_FORMAT * NO_RETURN to OVS_NO_RETURN Signed-off-by: Thomas Graf --- include/openvswitch/automake.mk | 1 + include/openvswitch/compiler.h | 22

[ovs-dev] [PATCH 02/10] lib: Expose SOURCE_LOCATOR as OVS_SOURCE_LOACATOR

2014-12-09 Thread Thomas Graf
Required to expose headers which depend on SOURCE_LOCATOR Signed-off-by: Thomas Graf --- include/openvswitch/util.h | 8 lib/backtrace.h| 4 ++-- lib/hmap.h | 8 lib/latch.h| 2 +- lib/ovs-thread.h | 16

Re: [ovs-dev] OVS Kernel Datapath development

2014-12-09 Thread Lori Jakab
On 12/08/2014 06:47 AM, Pravin Shelar wrote: > Since the beginning OVS kernel datapath development is primarily done > on external OVS repo. Now we have mostly synced upstream and external > OVS. So we have decided to change this process. New process is as > follows. Patch series that have previou

Re: [ovs-dev] OVS Kernel Datapath development

2014-12-09 Thread Pravin Shelar
On Tue, Dec 9, 2014 at 6:59 AM, Thomas F Herbert wrote: > Thanks. > > What is the impact on a developer submitting a patch. Do we now submit the > linux datapath portion of the patch to both netdev and ovs-dev? > Yes, if a feature needs kernel datapath changes the feature series should be posted o

Re: [ovs-dev] Support for MCAST_Snooping

2014-12-09 Thread Flavio Leitner
On Tue, Dec 09, 2014 at 06:49:36PM +0530, Aman Kumar wrote: > Now i got why ovs2 is not able to snoop the vm1's(running on ovs1) igmp > request, it's because action for patch-tun is not normal. > > But for action= NORMAL ovs is not sending the igmp report (or any packet) > to patch-tun. Port patch

Re: [ovs-dev] [PATCH 2/2] datapath-windows: return bool from NlFillOvs[Msg/Hdr]

2014-12-09 Thread Eitan Eliahu
Acked-by: Eitan Eliahu Thanks for addressing my comment. Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju Sent: Monday, December 08, 2014 9:43 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH 2/2] datapath-windows: return bool from NlFi

Re: [ovs-dev] [PATCH 1/2] datapath-windows: refactor BuildReplyMsgFromMsgIn & BuildErrorMsg

2014-12-09 Thread Eitan Eliahu
Acked-by: Eitan Eliahu Thanks! Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju Sent: Monday, December 08, 2014 9:43 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH 1/2] datapath-windows: refactor BuildReplyMsgFromMsgIn & BuildErrorMsg

Re: [ovs-dev] OVS Kernel Datapath development

2014-12-09 Thread Thomas F Herbert
Thanks. What is the impact on a developer submitting a patch. Do we now submit the linux datapath portion of the patch to both netdev and ovs-dev? --Tom On 12/8/14, 1:30 PM, Pravin Shelar wrote: On Mon, Dec 8, 2014 at 9:15 AM, Thomas Graf wrote: On 12/07/14 at 08:47pm, Pravin Shelar wrote:

Re: [ovs-dev] Support for MCAST_Snooping

2014-12-09 Thread Aman Kumar
Now i got why ovs2 is not able to snoop the vm1's(running on ovs1) igmp request, it's because action for patch-tun is not normal. But for action= NORMAL ovs is not sending the igmp report (or any packet) to patch-tun. Port patch-tun is on bridge br-int and it's connected to bridge br-tun(on same o

Re: [ovs-dev] OVS Kernel Datapath development

2014-12-09 Thread Flavio Leitner
On Sun, Dec 07, 2014 at 08:47:22PM -0800, Pravin Shelar wrote: > Since the beginning OVS kernel datapath development is primarily done > on external OVS repo. Now we have mostly synced upstream and external > OVS. So we have decided to change this process. New process is as > follows. > > 1. OVS f

[ovs-dev] Bug#771863: openvswitch-switch: Patch update, handle interface files sourced from /etc/network/interfaces

2014-12-09 Thread Stig Sandbeck Mathisen
Package: openvswitch-switch Version: 2.3.0+git20140819-2 Followup-For: Bug #771863 Dear Maintainer, The network_interfaces() function in the /etc/init.d/openvswitch-switch script also does not handle "source" or "source-directory" statements in /etc/network/interfaces. Please consider the attach