Re: [ovs-dev] [PATCH ovn 1/3] ovn: Enforce unique tags for container interfaces.

2015-04-07 Thread Thomas Graf
On 04/06/15 at 02:00pm, Gurucharan Shetty wrote: I think lxc deployment inside the VM definitely makes sense from a hardware isolation perspective but it may not be feasible for everyone. A simple example is resource allocation across multiple tenants on process level which becomes a lot

[ovs-dev] [PATCH] specify -w to set variables for sysctl(8) on NetBSD

2015-04-07 Thread Kevin Lo
We have to specify -w to set tunable sysctls on NetBSD. Signed-off-by: Kevin Lo kevlo at FreeBSD.org --- diff --git a/INSTALL.userspace.md b/INSTALL.userspace.md index 300d6c1..04c02cd 100644 --- a/INSTALL.userspace.md +++ b/INSTALL.userspace.md @@ -76,7 +76,7 @@ Other settings On NetBSD,

[ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-07 Thread Kevin Lo
On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the linker flags for linking with a pthread library. Add macro ax_pthread.m4 from GNU autoconf macro archive and use macro AX_PTHREAD. Signed-off-by: Kevin Lo kevlo at FreeBSD.org --- diff --git a/configure.ac b/configure.ac index

Re: [ovs-dev] [PATCH] specify -w to set variables for sysctl(8) on NetBSD

2015-04-07 Thread YAMAMOTO Takashi
We have to specify -w to set tunable sysctls on NetBSD. Signed-off-by: Kevin Lo kevlo at FreeBSD.org Acked-by: YAMAMOTO Takashi yamam...@valinux.co.jp --- diff --git a/INSTALL.userspace.md b/INSTALL.userspace.md index 300d6c1..04c02cd 100644 --- a/INSTALL.userspace.md +++

Re: [ovs-dev] I am sure this will be good for you

2015-04-07 Thread Robyn Gardner
I used to live in the gym Not anymore I just want you to feel as good as I do. http://x.co/8jbUo ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ofp-util: Fix length field of bundle messages

2015-04-07 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi yamam...@valinux.co.jp --- lib/ofp-util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index a0da289..7035c8c 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -8760,6 +8760,7 @@ ofputil_encode_bundle_ctrl_reply(const

Re: [ovs-dev] [PATCH branch-2.3] ofproto-dpif: Use fat_rwlock instead of ovs_rwlock.

2015-04-07 Thread Alex Wang
Looks good to me as well, this is a really good solution, Thanks, Alex Wang, On Mon, Apr 6, 2015 at 10:19 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Apr 06, 2015 at 09:18:58PM -0700, Ansis Atteka wrote: This patch fixes a deadlock introduced by commit 6b59b543 (ovs-thread: Use fair (but

[ovs-dev] [PATCH 2/3] ovs-dev: Hint that vport modules may need to be loaded manually

2015-04-07 Thread Thomas Graf
In case the openvswitch.ko is loaded manually without dependencies built, the vport modules need to be loaded manually as well. Signed-off-by: Thomas Graf tg...@noironetworks.com --- utilities/ovs-dev.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utilities/ovs-dev.py

[ovs-dev] [PATCH 3/3] NEWS: Leave a comment that vports are now separate kernel modules

2015-04-07 Thread Thomas Graf
Signed-off-by: Thomas Graf tg...@noironetworks.com --- NEWS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS b/NEWS index 9f9dc4c..9714831 100644 --- a/NEWS +++ b/NEWS @@ -77,6 +77,9 @@ Post-v2.3.0 numbers. OpenFlow is 6653 and OVSDB is 6640. - Support for DPDK vHost. -

Re: [ovs-dev] Offloading OVS Flows to the device.

2015-04-07 Thread Mehul Vora
You might start by looking at the Rocker switch implementation which creates multiple netdev devices for each port of the switch.   I will look at this implementation. In your case you'd  likely create these dummy netdev  definitions within you PF driver.  My assumption is that ALL packets would

[ovs-dev] [PATCH 0/3] Improve vport module handling

2015-04-07 Thread Thomas Graf
Thomas Graf (3): ovs-ctl: Unload reload vport modules on force-reload-kmod ovs-dev: Hint that vport modules may need to be loaded manually NEWS: Leave a comment that vports are now separate kernel modules NEWS | 3 +++ utilities/ovs-ctl.in | 22 --

[ovs-dev] [PATCH 1/3] ovs-ctl: Unload reload vport modules on force-reload-kmod

2015-04-07 Thread Thomas Graf
We manually rmmod the loaded vports as using modprobe -r only works if the modules are available through modules.dep We do not treat failures to load vports as a fatal error in case the vport module has been renamed. Bringing the bridge back up is considered more important. The error is still

[ovs-dev] Delivery reports about your e-mail

2015-04-07 Thread Mail Delivery Subsystem
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] specify -w to set variables for sysctl(8) on NetBSD

2015-04-07 Thread Ben Pfaff
On Tue, Apr 07, 2015 at 04:18:47PM +0800, Kevin Lo wrote: We have to specify -w to set tunable sysctls on NetBSD. Signed-off-by: Kevin Lo kevlo at FreeBSD.org Applied, thanks! ___ dev mailing list dev@openvswitch.org

[ovs-dev] [PATCH ovn 1/3 v2] ovn-nbd: Match bindings on lport name.

2015-04-07 Thread Russell Bryant
When ovn-nbd is looking through bindings to figure out if any logical ports in the northbound DB need to have their 'up' state changed, it should be using the logical port's name instead of UUID for matching up to rows in the OVN db. The switch to using the name instead of UUID means we don't

[ovs-dev] [PATCH ovn 3/3 v2] ovn-nbd: Fix unsafe HMAP_FOR_EACH_WITH_HASH usage.

2015-04-07 Thread Russell Bryant
The previous code assumed that hash_node would be NULL when the loop terminated without a match. That's not the case, so track the match a little differently. Signed-off-by: Russell Bryant rbry...@redhat.com --- ovn/ovn-nbd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

Re: [ovs-dev] [PATCH ovn 1/3] ovn: Enforce unique tags for container interfaces.

2015-04-07 Thread Russell Bryant
On 04/07/2015 03:29 AM, Thomas Graf wrote: On 04/06/15 at 02:00pm, Gurucharan Shetty wrote: I think lxc deployment inside the VM definitely makes sense from a hardware isolation perspective but it may not be feasible for everyone. A simple example is resource allocation across multiple

Re: [ovs-dev] [PATCH ovn 2/3] ovn-nbctl: Updates for container integration.

2015-04-07 Thread Russell Bryant
On 04/06/2015 06:53 PM, Justin Pettit wrote: On Apr 6, 2015, at 12:12 PM, Russell Bryant rbry...@redhat.com wrote: +if (ctx-argc == 5) { +/* Validate tag. */ +if (sscanf(ctx-argv[4], %SCNd64, tag) != 1 || tag 0 || tag 4095) { We have a wrapped version called

Re: [ovs-dev] [PATCH RFC 1/1] docs: Clarify bonding of DPDK enabled interfaces.

2015-04-07 Thread O Mahony, Billy
-Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of O Mahony, Billy Sent: Thursday, April 2, 2015 11:13 PM To: Ben Pfaff Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH RFC 1/1] docs: Clarify bonding of DPDK enabled interfaces. -Original

[ovs-dev] [PATCH ovn 2/3 v2] ovn-nbd: Don't shadow hash_node variable.

2015-04-07 Thread Russell Bryant
This variable is already defined at the top of the function, so just reuse that instead of defining it again. Signed-off-by: Russell Bryant rbry...@redhat.com --- ovn/ovn-nbd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ovn/ovn-nbd.c b/ovn/ovn-nbd.c index

[ovs-dev] [PATCH ovn 0/3 v2] Match bindings on lport name.

2015-04-07 Thread Russell Bryant
v1-v2: - Drop first patch that was merged. - Update 1/3 to fix unsafe HMAP_FOR_EACH_WITH_HASH usage. - Fix issues in pre-existing code to address the same unsafe HMAP_FOR_EACH_WITH_HASH usage. [PATCH 1/3] ovn-nbd: Match bindings on lport name. [PATCH 2/3] ovn-nbd: Don't shadow hash_node

[ovs-dev] Can openvswitch vxlan tunnel support vtep ip in different subnet?

2015-04-07 Thread 马啸
Hi,all I know in normal vxlan support,vteps can be in different subnets. But when I config the vxlan tunnel of openvswitch with the local ip and the remote ip in different subnets, I find the flow can not be matched. tap1 of vm1(192.168.10.2)--br-tun in Host1(eth3.1124

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-07 Thread Traynor, Kevin
-Original Message- From: Pravin Shelar [mailto:pshe...@nicira.com] Sent: Friday, April 3, 2015 6:32 AM To: Traynor, Kevin Cc: Flavio Leitner; Rogers, Gerald; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports On Thu, Apr 2, 2015 at

Re: [ovs-dev] [PATCH branch-2.3] ofproto-dpif: Use fat_rwlock instead of ovs_rwlock.

2015-04-07 Thread Ansis Atteka
On Mon, Apr 6, 2015 at 10:19 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Apr 06, 2015 at 09:18:58PM -0700, Ansis Atteka wrote: This patch fixes a deadlock introduced by commit 6b59b543 (ovs-thread: Use fair (but nonrecursive) rwlocks on glibc.) If STP is enabled, then a handler thread could

Re: [ovs-dev] [PATCH ovn 3/3] ovn-nbd: Update Bindings for container integration.

2015-04-07 Thread Russell Bryant
On 04/06/2015 08:50 PM, Justin Pettit wrote: On Apr 6, 2015, at 12:12 PM, Russell Bryant rbry...@redhat.com wrote: ovn-nbd updates the Bindings table of the OVN database when there are updates to the OVN_Northbound database. This update makes ovn-nbd copy over the container integration

Re: [ovs-dev] [PATCH ovn 1/3] ovn: Enforce unique tags for container interfaces.

2015-04-07 Thread Thomas Graf
On 04/07/15 at 10:20am, Russell Bryant wrote: IIRC, the proposal was actually quite explicit that the tag is a VLAN ID. It's not a hidden implementation detail because something (not OVN) has to set up ovs inside the VM with all of the containers attached and have it tag traffic from each

Re: [ovs-dev] Can openvswitch vxlan tunnel support vtep ip in different subnet?

2015-04-07 Thread Jesse Gross
On Tue, Apr 7, 2015 at 6:56 AM, 马啸 cumtb_max...@163.com wrote: Hi,all I know in normal vxlan support,vteps can be in different subnets. But when I config the vxlan tunnel of openvswitch with the local ip and the remote ip in different subnets, I find the flow can not be matched. Yes, it

[ovs-dev] [PATCH ovn 0/2 v2] Updates for container integration.

2015-04-07 Thread Russell Bryant
v1-v2 - Tweaks to ovn-nbctl as suggested by Juston - Update ovn-nbd to handle changes to parent and tag on a logical port after it is first created [PATCH 1/2] ovn-nbctl: Updates for container integration. [PATCH 2/2] ovn-nbd: Update Bindings for container integration. ovn-nbctl.8.xml |

[ovs-dev] [PATCH v3] datapath-windows: Solved BSOD when uninstalling the driver (race condition)

2015-04-07 Thread Sorin Vinturis
The BSOD occurred because the FilterAttach routine released the switch context, while there were IRPs in processing. The solution was to add a reference count to prevent premature deallocation of the global switch context structure, gOvsSwitchContext. Signed-off-by: Sorin Vinturis

[ovs-dev] [PATCH ovn 1/2 v2] ovn-nbctl: Updates for container integration.

2015-04-07 Thread Russell Bryant
Add support for specifying a parent port name and tag when creating logical ports. Also add commands for getting the parent_name or tag set on a logical port. These are necessary for dealing with container interfaces that sit behind normal interfaces. Signed-off-by: Russell Bryant

Re: [ovs-dev] [PATCH v2] datapath-windows: Solved BSOD when uninstalling the driver (race condition)

2015-04-07 Thread Sorin Vinturis
Thanks for your review Eitan. -Original Message- From: Eitan Eliahu [mailto:elia...@vmware.com] Sent: Tuesday, 7 April, 2015 18:39 To: Sorin Vinturis; dev@openvswitch.org Subject: RE: [PATCH v2] datapath-windows: Solved BSOD when uninstalling the driver (race condition) Hi Sorin, This

Re: [ovs-dev] [PATCH v2] datapath-windows: Solved BSOD when uninstalling the driver (race condition)

2015-04-07 Thread Eitan Eliahu
Hi Sorin, This is much better (it is hard to protect on the object using the object itself). Thank you! Eitan Acked-by: Eitan Eliahu elia...@vmware.com Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis Sent: Friday, April 03,

[ovs-dev] [PATCH ovn 2/2 v2] ovn-nbd: Update Bindings for container integration.

2015-04-07 Thread Russell Bryant
ovn-nbd updates the Bindings table of the OVN database when there are updates to the OVN_Northbound database. This update makes ovn-nbd copy over the container integration related fields from OVN_Northbound into the Bindings table. Signed-off-by: Russell Bryant rbry...@redhat.com ---

Re: [ovs-dev] [PATCH 1/3] ovs-ctl: Unload reload vport modules on force-reload-kmod

2015-04-07 Thread Flavio Leitner
On Tue, 7 Apr 2015 12:43:41 +0200 Thomas Graf tg...@noironetworks.com wrote: We manually rmmod the loaded vports as using modprobe -r only works if the modules are available through modules.dep We do not treat failures to load vports as a fatal error in case the vport module has been

[ovs-dev] [PATCH v6 2/6] dpif-netdev: Make datapath and flow stats atomic.

2015-04-07 Thread Daniele Di Proietto
A read operation from a non atomic shared value (without external locking) can return incorrect values. Using the atomic semantics prevents this from happening. However: * No memory barriers are used. We don't need that kind of consistency for statistics (we use relaxed operations). * The

[ovs-dev] [PATCH v6 5/6] dpif-provider: Add class init function.

2015-04-07 Thread Daniele Di Proietto
This init function is called when the dpif class is registered. It will be used by following commits Signed-off-by: Daniele Di Proietto diproiet...@vmware.com Acked-by: Ethan Jackson et...@nicira.com --- lib/dpif-netdev.c | 1 + lib/dpif-netlink.c | 1 + lib/dpif-provider.h | 8

[ovs-dev] [PATCH v6 3/6] dpif-netdev: Count exact match cache hits.

2015-04-07 Thread Daniele Di Proietto
We used to count exact match cache hits and masked classifier hits together. This commit splits the DP_STAT_HIT counter into two. This change will be used by future commits. Signed-off-by: Daniele Di Proietto diproiet...@vmware.com Acked-by: Ethan Jackson et...@nicira.com --- lib/dpif-netdev.c |

Re: [ovs-dev] [PATCH ovn 1/3] ovn: Enforce unique tags for container interfaces.

2015-04-07 Thread Jesse Gross
On Tue, Apr 7, 2015 at 8:29 AM, Thomas Graf tg...@noironetworks.com wrote: On 04/07/15 at 10:20am, Russell Bryant wrote: IIRC, the proposal was actually quite explicit that the tag is a VLAN ID. It's not a hidden implementation detail because something (not OVN) has to set up ovs inside the

Re: [ovs-dev] [PATCH v5 3/7] dpif-netdev: Make datapath and flow stats atomic.

2015-04-07 Thread Daniele Di Proietto
On 3 Apr 2015, at 02:19, Ethan Jackson et...@nicira.com wrote: Do we have to use the ATOMIC(long long) syntax, or can we use atomic_ullong for most of the struct variable definitions? If we have to use the former, there should be a comment explaining why. I’ve changed it to

[ovs-dev] [PATCH v6 4/6] dpif-netdev: Add simple per pmd-thread cycles counters.

2015-04-07 Thread Daniele Di Proietto
The counters use x86 TSC if available (currently only with DPDK). They will be exposed by subsequents commits Signed-off-by: Daniele Di Proietto diproiet...@vmware.com --- lib/dpif-netdev.c | 55 +++ 1 file changed, 55 insertions(+) diff --git

[ovs-dev] [PATCH v6 1/6] dpif-netdev: Group statistics updates in the slow path.

2015-04-07 Thread Daniele Di Proietto
Since statistics updates might require locking (in future commits) grouping them will reduce the locking overhead. Signed-off-by: Daniele Di Proietto diproiet...@vmware.com Acked-by: Ethan Jackson et...@nicira.com --- lib/dpif-netdev.c | 11 ++- 1 file changed, 6 insertions(+), 5

[ovs-dev] [PATCH v6 6/6] dpif-netdev: Add dpif-netdev/pmd-stats-* appctl commands.

2015-04-07 Thread Daniele Di Proietto
These commands can be used to get packets and cycles counters on a pmd thread basis. They're useful to get a clearer picture about the performance of the userspace datapath. They export these pieces of information: - A (per-thread) view of the caches hit rate. Hits in the exact match cache

[ovs-dev] [PATCH v6 0/6] Add pmd thread statistics

2015-04-07 Thread Daniele Di Proietto
The goal of this series is to add an appctl command to retrieve detailed performance statistics from the pmd thread execution. These statistics include exact match cache and masked classifier hits and rough cycles counters. This series also fixes some concurrency issues with statistics in the

Re: [ovs-dev] [PATCH 2/3] ovs-dev: Hint that vport modules may need to be loaded manually

2015-04-07 Thread Flavio Leitner
On Tue, 7 Apr 2015 12:43:42 +0200 Thomas Graf tg...@noironetworks.com wrote: In case the openvswitch.ko is loaded manually without dependencies built, the vport modules need to be loaded manually as well. Signed-off-by: Thomas Graf tg...@noironetworks.com --- utilities/ovs-dev.py | 3 +++

Re: [ovs-dev] [PATCH ovn 1/3] ovn: Enforce unique tags for container interfaces.

2015-04-07 Thread Jesse Gross
On Tue, Apr 7, 2015 at 11:14 AM, Thomas Graf tg...@noironetworks.com wrote: On 04/07/15 at 10:49am, Jesse Gross wrote: On Tue, Apr 7, 2015 at 8:29 AM, Thomas Graf tg...@noironetworks.com wrote: I remember this discussion. One alternative that comes to mind is to simply push a Geneve header

Re: [ovs-dev] [PATCH 2/3] ovs-dev: Hint that vport modules may need to be loaded manually

2015-04-07 Thread Thomas Graf
On 04/07/15 at 02:47pm, Flavio Leitner wrote: On Tue, 7 Apr 2015 12:43:42 +0200 Thomas Graf tg...@noironetworks.com wrote: In case the openvswitch.ko is loaded manually without dependencies built, the vport modules need to be loaded manually as well. Signed-off-by: Thomas Graf

Re: [ovs-dev] [PATCH ovn 1/3] ovn: Enforce unique tags for container interfaces.

2015-04-07 Thread Thomas Graf
On 04/07/15 at 10:49am, Jesse Gross wrote: On Tue, Apr 7, 2015 at 8:29 AM, Thomas Graf tg...@noironetworks.com wrote: I remember this discussion. One alternative that comes to mind is to simply push a Geneve header in front of it. It would provide a lot more flexibility down the road and we

Re: [ovs-dev] [PATCH] ofp-util: Fix length field of bundle messages

2015-04-07 Thread Jarno Rajahalme
Yamamoto, ofconn_send(), which will eventually be called for these, already does ofpmsg_update_length() before passing the message to rconn_send(). Given this, it seems unnecessary to make this change. Jarno On Apr 6, 2015, at 11:43 PM, YAMAMOTO Takashi yamam...@valinux.co.jp wrote:

Re: [ovs-dev] [PATCH v5 5/7] dpif-netdev: Add simple per pmd-thread cycles counters.

2015-04-07 Thread Daniele Di Proietto
I totally see your point. I guess it’s not important to keep the OTHER counter, so I’ve removed it. Using the new mutex-like semantics the code is much easier to understand. I’ve changed the names accordingly I’m sending a v6 Thanks for the review Daniele On 6 Apr 2015, at 22:49, Ethan

Re: [ovs-dev] I started last sunday and I am aready down two sizes

2015-04-07 Thread Brice Jeff
Nice to meet you After 4 days I noticed the change. http://catcut.net/UH3 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3] datapath-windows: Solved BSOD when uninstalling the driver (race condition)

2015-04-07 Thread Gurucharan Shetty
On Tue, Apr 7, 2015 at 9:35 AM, Sorin Vinturis svintu...@cloudbasesolutions.com wrote: The BSOD occurred because the FilterAttach routine released the switch context, while there were IRPs in processing. The solution was to add a reference count to prevent premature deallocation of the

Re: [ovs-dev] My body looks so much improved

2015-04-07 Thread Marion Salisburry
I tried everything to get in shape Trust me when I tell you that it's the best for your waistline. http://x.co/8jbiY ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Good change is always good

2015-04-07 Thread Scott Daniels
Eat more and gain less in my moto This is the new way to shape your body. http://x.co/8jbrG ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH ovn v3 3/5] meta-flow: Add new functions for subvalues.

2015-04-07 Thread Andy Zhou
assume av=1001, am = 1000, bv=1000, bm=1001. Should dv's last bit be zero? if not, then my interpretation of what this function does is wrong. On Mon, Apr 6, 2015 at 9:31 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Apr 06, 2015 at 03:28:37PM -0700, Andy Zhou wrote: On Tue, Mar 31, 2015 at

Re: [ovs-dev] [PATCH ovn 1/3] ovn: Enforce unique tags for container interfaces.

2015-04-07 Thread Thomas Graf
On 04/07/15 at 11:34am, Jesse Gross wrote: I just meant the software versions of offloading, not that we would need actual hardware support for this. We'd want to make sure that GSO, virtio, etc. support whatever we do in order to ensure that we can efficiently communicate between the host and

Re: [ovs-dev] [PATCH 6/9] tunneling: Factor out common UDP tunnel code.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross je...@nicira.com wrote: Currently, the userspace VXLAN implementation contains the code for generating and parsing both the UDP and VXLAN headers. This pulls out the UDP portion for better layering and to make it easier to support additional UDP

Re: [ovs-dev] Can openvswitch vxlan tunnel support vtep ip in different subnet?

2015-04-07 Thread 马啸
Thank you for your reply. The topology as: tap1(192.168.10.2)--br-int--br-tun(vxlan-0a0b1840 19/5 local_ip=10.10.24.69, remote_ip=10.11.24.64)==(vxlan-0a0a1845 3/8 local_ip=10.11.24.64, remote_ip=10.10.24.69)br-tun--br-int--tap2 (192.168.10.1) I ping from 192.168.10.1 to

Re: [ovs-dev] [PATCH 3/9] tunneling: Fix location of GRE checksums.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross je...@nicira.com wrote: The GRE checksum is a 16 bit field stored in a 32 bit option (the rest is reserved). The current code treats the checksum as a 32-bit field and places it in the right place for little endian systems but not big endian. This

Re: [ovs-dev] [PATCH 7/9] tunneling: Add userspace tunnel support for Geneve.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross je...@nicira.com wrote: This adds basic userspace dataplane support for the Geneve tunneling protocol. The rest of userspace only has the ability to handle Geneve without options and this follows that pattern for the time being. However, when the

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Gurucharan Shetty
The following series breaks windows build. Zero length arrays are not supported in the middle of structures. source='lib/bfd.c' object='lib/bfd.lo' libtool=yes \ DEPDIR=.deps depmode=none /bin/sh ./build-aux/depcomp \ /bin/sh ./libtool --tag=CC --mode=compile build-aux/cccl -DHAVE_CONFIG_H -I. -I

Re: [ovs-dev] [PATCH 5/9] odp-util: Shift VXLAN VNI when printing/parsing.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross je...@nicira.com wrote: Currently when printing a userspace tunnel action for VXLAN, the VNI is treated as a 32 bit field rather than 24 bit. Even if this is the representation that we use internally, we should still show the right VNI to avoid

Re: [ovs-dev] [PATCH 4/9] tunneling: Use flow flag for GRE checksum calculation.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross je...@nicira.com wrote: The indication to calculate the GRE checksum is currently the port config rather than the tunnel flow. Currently there is a one to one mapping between the two so there is no difference. However, the kernel datapath must use

Re: [ovs-dev] [PATCH 2/9] tunneling: Add check for GRE protocol is Ethernet.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross je...@nicira.com wrote: On receive, the userspace GRE code doesn't check the protocol field. Since OVS only understands Ethernet packets, this adds a check that the inner protocol is Ethernet and discards other types of packets. Signed-off-by:

Re: [ovs-dev] [PATCH 1/9] tunneling: Include IP TTL in flow metadata.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross je...@nicira.com wrote: The IP TTL is currently omitted in the extracted tunnel information that is stored in the flow for userspace tunneling. This includes it so that the same logic used by the kernel also applies. Signed-off-by: Jesse Gross

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross je...@nicira.com wrote: Kernel based OVS recently added the ability to support checksums for UDP based tunnels (Geneve and VXLAN). This adds similar support for the userspace datapath to bring feature parity. Signed-off-by: Jesse Gross

Re: [ovs-dev] [PATCH 8/9] packet: Add IP pseudoheader checksum calculation.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross je...@nicira.com wrote: As OVS adds userspace support for being the endpoint in protocols like tunnels, it will need to be able to calculate pseudoheaders as part of the checksum calculation. Signed-off-by: Jesse Gross je...@nicira.com Acked-by:

Re: [ovs-dev] [PATCH 7/9] tunneling: Add userspace tunnel support for Geneve.

2015-04-07 Thread Jesse Gross
On Tue, Apr 7, 2015 at 4:22 PM, Pravin Shelar pshe...@nicira.com wrote: On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross je...@nicira.com wrote: diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c index 0c9f5a4..ef96862 100644 --- a/lib/netdev-vport.c +++ b/lib/netdev-vport.c @@ -61,6 +61,11 @@

[ovs-dev] [PATCH] ovn: Rename ovn database to ovn-sb.

2015-04-07 Thread Justin Pettit
It was confusing having a database called ovn, since it's also the name of the project. Since we have an ovn-nb, rename ovn to ovn-sb. Signed-off-by: Justin Pettit jpet...@nicira.com --- ovn/.gitignore | 12 +- ovn/TODO | 22 +- ovn/automake.mk|

Re: [ovs-dev] Don't live a little! Buy best men's pills at our shop.

2015-04-07 Thread Lenny Archibald
A very popular prescription ED drug may work well for many people, but it is not the only solution. http://x.co/8npfE ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 2/2] ovs_threads: Avoid running pthread destructors from main thread exit.

2015-04-07 Thread Gurucharan Shetty
Windows uses pthreads-win32 library to provide the Linux pthread functionality. It is observed that when the main thread calls a pthread destructor after it exits, undefined behavior is seen (e.g., junk values in data). To avoid this, this commit de-registers the thread destructor when the main

[ovs-dev] [PATCH 1/2] tests: Avoid Windows unit tests from hanging.

2015-04-07 Thread Gurucharan Shetty
It has been observed that sometimes Windows unit tests hang. This happens when a daemon is started but does not get terminated when the test ends. In one particular case, OVS_VSWITCHD_STOP is called which inturn calls 'ovs-appctl exit'. This causes ovs-vswitchd's atexit handler to cleanup the

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Jesse Gross
Thanks, I pushed a fix to avoid this - nothing was using the member at the moment, so I just replaced it with a comment. On Tue, Apr 7, 2015 at 5:31 PM, Gurucharan Shetty shet...@nicira.com wrote: The following series breaks windows build. Zero length arrays are not supported in the middle of

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Gurucharan Shetty
On Tue, Apr 7, 2015 at 6:01 PM, Jesse Gross je...@nicira.com wrote: Thanks, I pushed a fix to avoid this - nothing was using the member at the moment, so I just replaced it with a comment. Thank you for the quick fix! On Tue, Apr 7, 2015 at 5:31 PM, Gurucharan Shetty shet...@nicira.com

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Gurucharan Shetty
It looks like this series also breaks the unit tests on Linux. Do you see it?

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Jesse Gross
It doesn't trigger on my system (since it is due to uninitialized memory) but I saw the problem from the autobuilder. I just pushed a patch to fix it: https://github.com/openvswitch/ovs/commit/46e7137c77d845c488e17b718eac7c3fb97cedcc Hopefully that's everything... On Tue, Apr 7, 2015 at 6:57 PM,

Re: [ovs-dev] Can you see yourself thin again

2015-04-07 Thread Lucinda Forster
I found it hard to drop belt sizes, until I tried for myself Your health with improve once you have this. http://zzb.bz/bGPKE ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH ovn 2/3] ovn-nbctl: Updates for container integration.

2015-04-07 Thread Justin Pettit
On Apr 7, 2015, at 8:03 AM, Russell Bryant rbry...@redhat.com wrote: On 04/06/2015 06:53 PM, Justin Pettit wrote: It might be nice to print the parent and tag in lport-list. Any thoughts on formatting? I don't care much. I was trying to keep it simple so it can be parsed without too