Re: [ovs-dev] [PATCH v2] netdev-dpdk: add dpdk vhost-user ports

2015-05-07 Thread Panu Matilainen
On 05/07/2015 08:38 PM, Ciara Loftus wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. A new dpdkvhostuser port will create a unix domain socket which when provided to QEMU is used to facilitate communication between the virtio-net device on the V

[ovs-dev] [PATCH v2 2/5] datapath-windows: Correctly link newly allocated NBL

2015-05-07 Thread Sorin Vinturis
OvsPartialCopyToMultipleNBLs function failed to correctly link the newly created NBL with single NB to the multiple NBLs list. Signed-off-by: Sorin Vinturis Co-authored-by: Alin Gabriel Serdean Acked-by: Nithin Raju --- v2: Added ack. --- datapath-windows/ovsext/BufferMgmt.c | 2 +- 1 file cha

[ovs-dev] [PATCH v2 1/5] datapath-windows: Added new function for native forwarded traffic

2015-05-07 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis Acked-by: Nithin Raju --- v2: Minor changes after code review. Added ack. --- datapath-windows/ovsext/PacketIO.c | 87 ++ 1 file changed, 40 insertions(+), 47 deletions(-) diff --git a/datapath-windows/ovsext/PacketIO.c b/datapa

Re: [ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-07 Thread Pravin Shelar
On Thu, May 7, 2015 at 4:28 PM, Jesse Gross wrote: > On Mon, May 4, 2015 at 3:58 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c >> index 552e748..84cb835 100644 >> --- a/datapath/linux/compat/gso.c >> +++ b/datapath/linux/compat/gso.c > [...]

Re: [ovs-dev] [PATCH] datapath: Add support for 4.0 kernel.

2015-05-07 Thread Jesse Gross
On Tue, May 5, 2015 at 2:01 PM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > acinclude.m4 | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Can you also update NEWS and the table in the FAQ? > diff --git a/acinclude.m4 b/acinclude.m4 > index e9d0ed9..cd2

Re: [ovs-dev] [PATCH] ovn: Adopt consistent naming, by renaming "Bindings" to "Binding".

2015-05-07 Thread Ben Pfaff
On Thu, May 07, 2015 at 04:15:13PM -0700, Justin Pettit wrote: > This is my kind of patch! I didn't check it thoroughly, but a spot check > looks good: I did think about asking you if you wanted to write it up yourself. > Acked-by: Justin Pettit Thanks, I'll apply this to ovn in a minute. ___

Re: [ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-07 Thread Jesse Gross
On Mon, May 4, 2015 at 3:58 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c > index 552e748..84cb835 100644 > --- a/datapath/linux/compat/gso.c > +++ b/datapath/linux/compat/gso.c [...] > /* Strictly this is not needed and will be optimised out

Re: [ovs-dev] [PATCH] ovn: Adopt consistent naming, by renaming "Bindings" to "Binding".

2015-05-07 Thread Justin Pettit
This is my kind of patch! I didn't check it thoroughly, but a spot check looks good: Acked-by: Justin Pettit --Justin > On May 7, 2015, at 4:09 PM, Ben Pfaff wrote: > > The convention in OVSDB is to use singular names for database tables, > but Bindings was plural. > > Signed-off-by: Ben

[ovs-dev] [PATCH] ovn: Adopt consistent naming, by renaming "Bindings" to "Binding".

2015-05-07 Thread Ben Pfaff
The convention in OVSDB is to use singular names for database tables, but Bindings was plural. Signed-off-by: Ben Pfaff --- ovn/controller/automake.mk |4 +- ovn/controller/{bindings.c => binding.c} | 42 ++--- ovn/controller/{bindings.h => binding.h} | 12 +

[ovs-dev] [PATCH] travis: Fix clang build for DPDK-2.0.

2015-05-07 Thread Joe Stringer
-Wno-cast-align is a CFLAG, not a configure option. Signed-off-by: Joe Stringer --- .travis/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis/build.sh b/.travis/build.sh index c7796e1..6dfc9fe 100755 --- a/.travis/build.sh +++ b/.travis/build.sh @@ -74,7 +74,7

Re: [ovs-dev] [PATCH 3/3] dpctl: Ignore enumeration errors if there is at least one datapath.

2015-05-07 Thread Ben Pfaff
On Wed, May 06, 2015 at 07:00:26PM +0100, Daniele Di Proietto wrote: > When dpctl commands are used to inspect a userspace datapath, but OVS > has also built-in support for the kernel datapath, an error message is > reported if the kernel module is not loaded. This commit suppresses the > message.

Re: [ovs-dev] [PATCH 2/3] dpctl: Factor out common code to iterate through all dpifs.

2015-05-07 Thread Ben Pfaff
On Wed, May 06, 2015 at 07:00:25PM +0100, Daniele Di Proietto wrote: > This commit introduces dps_for_each() which calls a callback for each > datapath of each registered type. > > Signed-off-by: Daniele Di Proietto Applied, thanks! ___ dev mailing lis

Re: [ovs-dev] [PATCH] lldp: Fix clang warning.

2015-05-07 Thread Joe Stringer
Thanks all, applied to master. On 7 May 2015 at 06:27, Flynn, Dennis R (Dennis) wrote: > Hi Joe, > > Yes, over-zealous checking on my part. > Thanks for finding and fixing this. > > Acked-by: Dennis Flynn > > > From: Joe Stringer [joestrin...@nicira.com]

Re: [ovs-dev] [PATCH 1/3] dpctl: Add OVS_PRINTF_FORMAT annotation to dpctl_* functions.

2015-05-07 Thread Ben Pfaff
On Wed, May 06, 2015 at 07:00:24PM +0100, Daniele Di Proietto wrote: > Signed-off-by: Daniele Di Proietto Applied, thanks! (Good catch.) ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ARP lookup and next hop functionality on windows

2015-05-07 Thread Ben Pfaff
On Mon, May 04, 2015 at 03:34:58PM +, Alin Serdean wrote: > This patch implements two functionalities needed for an active manager: > 1. ARP lookup > 2. Next hop > > The first functionality relies on the internal Windows API: > https://msdn.microsoft.com/en-us/library/windows/desktop/aa365956%

Re: [ovs-dev] [PATCH] lldp: Fix clang warning.

2015-05-07 Thread Ben Pfaff
On Wed, May 06, 2015 at 02:41:23PM -0700, Joe Stringer wrote: > Clang-3.7 generates warnings such as the following: > ../lib/ovs-lldp.c:394:19: error: address of array 'hardware->h_ifname' > will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] > > This value is fetched from a netdev,

Re: [ovs-dev] [PATCH] ovs-ofctl: replace-flows and diff-flows support for multiple tables

2015-05-07 Thread Ben Pfaff
On Sun, May 03, 2015 at 05:35:43PM -0700, shashank.shanb...@gmail.com wrote: > From: Shashank Shanbhag > > Fix replace-flows and diff-flows to modify/diff flows in multiple tables. > Add a --tables option that allows the user to specify a comma-separated > list of table indexes to replace/diff. >

Re: [ovs-dev] [PATCH v2] docs: Clarify creation & bonding of DPDK enabled interfaces.

2015-05-07 Thread Ben Pfaff
On Tue, May 05, 2015 at 05:37:31PM +0100, Billy O'Mahony wrote: > Unlike system interfaces, DPDK enabled interfaces must have their interface > type explicitly set when used to create ports. Mention this in relevant parts > of the documentation and add references to INTALL.DPDK.md, where there are

Re: [ovs-dev] [PATCH] netdev-dpdk: add dpdk vhost-user ports

2015-05-07 Thread Loftus, Ciara
> On Tue, May 5, 2015 at 8:58 AM, Ciara Loftus wrote: > > This patch adds support for a new port type to the userspace > > datapath called dpdkvhostuser. It adds to the existing > > infrastructure of vhost-cuse, however disables vhost-cuse ports > > as the default port type, in favour of vhost-use

[ovs-dev] [PATCH v2] netdev-dpdk: add dpdk vhost-user ports

2015-05-07 Thread Ciara Loftus
This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. A new dpdkvhostuser port will create a unix domain socket which when provided to QEMU is used to facilitate communication between the virtio-net device on the VM and the OVS port on the host. vhost-cuse ('

[ovs-dev] [PATCH] datapath-windows: Stateless TCP Tunnelling protocol - Initial implementation

2015-05-07 Thread Eitan Eliahu
This change include an initial implementable of STT. The following should be added: [1] Checksum offload (SW and HW) [2] LSO (SW and HW) [3] IP layer WFP callout for IP segments Testing: link layer connection through ping works. File transfer. Signed-off-by: Eitan Eliahu Co-authored-by: Saurabh

Re: [ovs-dev] [PATCH] datapath-windows: Stateless TCP Tunnelling protocol - Initial implementation

2015-05-07 Thread Ben Pfaff
On Thu, May 07, 2015 at 09:48:15AM -0700, Ben Pfaff wrote: > On Thu, May 07, 2015 at 04:00:45PM -0700, Eitan Eliahu wrote: > > This change include an initial implementable of STT. > > The following should be added: > > [1] Checksum offload (SW and HW) > > [2] LSO (SW and HW) > > [3] IP layer WFP ca

Re: [ovs-dev] [PATCH] datapath-windows: Stateless TCP Tunnelling protocol - Initial implementation

2015-05-07 Thread Ben Pfaff
On Thu, May 07, 2015 at 04:00:45PM -0700, Eitan Eliahu wrote: > This change include an initial implementable of STT. > The following should be added: > [1] Checksum offload (SW and HW) > [2] LSO (SW and HW) > [3] IP layer WFP callout for IP segments > > Testing: link layer connection through ping

[ovs-dev] [PATCH] datapath-windows: Stateless TCP Tunnelling protocol - Initial implementation

2015-05-07 Thread Eitan Eliahu
This change include an initial implementable of STT. The following should be added: [1] Checksum offload (SW and HW) [2] LSO (SW and HW) [3] IP layer WFP callout for IP segments Testing: link layer connection through ping works. File transfer. Signed-off-by: Eitan Eliahu Co-authored-by: Saurabh

Re: [ovs-dev] [PATCH v4 2/4] Sample to automate build installer

2015-05-07 Thread Eitan Eliahu
Hi Alin, I'm wondering if you addressed the issue of installation on Windows Server 2012. Unless we install the 8.0 driver, the driver load would fail. Thanks, Eitan > Begin forwarded message: > > From: Alin Serdean > To: "dev@openvswitch.org" > Date: April 28, 2015 at 3:36:28 PM PDT > Subject

Re: [ovs-dev] [PATCH] lldp: Fix clang warning.

2015-05-07 Thread Flynn, Dennis R (Dennis)
Hi Joe, Yes, over-zealous checking on my part. Thanks for finding and fixing this. Acked-by: Dennis Flynn From: Joe Stringer [joestrin...@nicira.com] Sent: Wednesday, May 06, 2015 5:44 PM To: Flynn, Dennis R (Dennis) Cc: dev@openvswitch.org Subject: Re:

Re: [ovs-dev] [PATCH 2/5] datapath-windows: Correctly link newly allocated NBL

2015-05-07 Thread Nithin Raju
> On May 6, 2015, at 11:57 PM, Sorin Vinturis > wrote: > > Hi Nithin, > > Thanks for your review on my two patches. Please ignore the fourth patch in > series, ' [PATCH 4/5] datapath-windows: Multiple NBLs support for userspace > forwarded packets', because it considers that OvsTcpSegmentNBL