Re: [ovs-dev] [PATCH v2] ofp-util: Convert flow_metadata to match structure.

2015-06-08 Thread Jesse Gross
On Sun, Jun 7, 2015 at 10:36 AM, Ben Pfaff b...@nicira.com wrote: On Mon, Jun 01, 2015 at 01:49:30PM -0700, Jesse Gross wrote: We have a special flow_metadata structure to represent the parts of a packet that aren't carried in the payload itself. This is used in the case where we need to send

Re: [ovs-dev] [PATCH] netdev-dpdk: Do not flush tx queue which is shared among CPUs since it is always flushed

2015-06-08 Thread Daniele Di Proietto
Thanks for figuring out this bug and for providing the patch! I did a quick phy-phy test and the throughput looks the same. I would be nice to fix the typo, as suggested by Mark. Otherwise Acked-by: Daniele Di Proietto diproiet...@vmware.com On 05/06/2015 13:27, Gray, Mark D

Re: [ovs-dev] [PATCH 1/2] flow: Add 'const' qualifiers in flow extraction.

2015-06-08 Thread Daniele Di Proietto
For other reasons I have (almost) the exact same commit in my local repository! Minor style nitpick below, otherwise: Acked-by: Daniele Di Proietto diproiet...@vmware.com On 08/06/2015 17:36, Ben Pfaff b...@nicira.com wrote: Signed-off-by: Ben Pfaff b...@nicira.com --- lib/flow.c | 18

Re: [ovs-dev] [PATCH 2/2] [RFC] flow: Use new miniflow_builder for miniflow_extract().

2015-06-08 Thread Jarno Rajahalme
On Jun 8, 2015, at 9:36 AM, Ben Pfaff b...@nicira.com wrote: +/* miniflow_builder */ + +void +miniflow_builder_init(struct miniflow_builder *b) +{ +b-map = 0; +} + +void +miniflow_builder_to_miniflow(struct miniflow_builder *b, + struct miniflow

Re: [ovs-dev] [PATCH 2/2] [RFC] flow: Use new miniflow_builder for miniflow_extract().

2015-06-08 Thread Jarno Rajahalme
On Jun 8, 2015, at 11:23 AM, Jarno Rajahalme jrajaha...@nicira.com wrote: manifold_extract I should turn the autocorrect off… ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] [RFC] flow: Use new miniflow_builder for miniflow_extract().

2015-06-08 Thread Jarno Rajahalme
On Jun 8, 2015, at 9:36 AM, Ben Pfaff b...@nicira.com wrote: This replaces the very specialized and difficult-to-maintain miniflow assembly macros by a simpler data structure named miniflow_builder that is more general and easier to use. It's not complete--it needs polishing and it

[ovs-dev] [PATCH 2/2] ovs-monitor-ipsec: Replace Racoon with StrongSwan.

2015-06-08 Thread Ansis Atteka
This patch would make strongSwan the default IKE keying daemon for ovs-monitor-ipsec daemon. It introduces also few new changes to the IPsec configuration that are not backward compatible with the older Racoon daemon: 1. StrongSwan would use IKEv2 protocol to negotiate keys (Opposed to IKEv1

Re: [ovs-dev] [PATCH] netdev-vport: Mark netdev_vport_get_dpif_port() as OVS_WARN_UNUSED_RESULT.

2015-06-08 Thread Andy Zhou
On Fri, Jun 5, 2015 at 10:09 PM, Ben Pfaff b...@nicira.com wrote: Ignoring the result of this function means that the caller is quite likely blindly using the character array passed in, instead of the return value, which leads to latent bugs. This would have prevented one of the bugs fixed by

Re: [ovs-dev] [PATCH 2/2] [RFC] flow: Use new miniflow_builder for miniflow_extract().

2015-06-08 Thread Ben Pfaff
On Mon, Jun 08, 2015 at 11:23:50AM -0700, Jarno Rajahalme wrote: On Jun 8, 2015, at 9:36 AM, Ben Pfaff b...@nicira.com wrote: +/* miniflow_builder */ + +void +miniflow_builder_init(struct miniflow_builder *b) +{ +b-map = 0; +} + +void

Re: [ovs-dev] [ovsdb speedup v4 3/3] ovsdb-monitor: add json cache

2015-06-08 Thread Andy Zhou
On Sat, Jun 6, 2015 at 2:58 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Jun 01, 2015 at 12:30:04AM -0700, Andy Zhou wrote: Although multiple jsonrpc monitors can share the same ovsdb monitor, each change still needs to translated into json object from scratch. This can be wasteful if multiple

[ovs-dev] [PATCH 1/2] datapath: take into account transport protocol ports in route lookup

2015-06-08 Thread Ansis Atteka
Transport protocol ports should be taken into account when doing route lookup because IPsec policies will depend on them. This will be used in upcoming commit that introduces IPsec support for Ethernet over L4 tunneling protocols. Signed-Off-By: Ansis Atteka aatt...@nicira.com ---

[ovs-dev] Computer Network Support Specialists

2015-06-08 Thread Minnie Romero
Hi, Good day to you, Reach all Computer Network Support Specialists such as Computer Network Specialist, IT Consultant (Information Technology Consultant), Network Engineer, Network Specialist, Network Support Specialist, Network Technical Analyst, Network Technician, Personal Computer

Re: [ovs-dev] [PATCH v6] This commit adds the windows installer to the OVS tree.

2015-06-08 Thread Alin Serdean
Hi Guru, 1. No that should not happen. Mind running the following command and send me offline the file log.txt so I can see what happens? msiexec /i OpenvSwitch.msi ADDLOCAL=ALL /qn /l*v log.txt 2. In the installer I set up the following environment variables:

Re: [ovs-dev] [PATCH] tunneling: Fix a tunnel name display bug

2015-06-08 Thread Andy Zhou
On Fri, Jun 5, 2015 at 10:05 PM, Ben Pfaff b...@nicira.com wrote: On Thu, Jun 04, 2015 at 01:52:16PM -0700, Andy Zhou wrote: Currently, 'ovs-appctl tnl/ports/show' command won't display gre port name correctly. Since netdev_vport_get_dpif_port() will not always set the 'namebuf' it receives.

Re: [ovs-dev] [ovsdb speedup v4 1/3] ovsdb-monitor: refactor ovsdb_monitor_create()

2015-06-08 Thread Andy Zhou
On Sat, Jun 6, 2015 at 2:29 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Jun 01, 2015 at 12:30:02AM -0700, Andy Zhou wrote: Add ovsdb_monitor_add_jsonrpc_monitor(). This change will allow ovsdb_monitor to be reference counted. Signed-off-by: Andy Zhou az...@nicira.com Acked-by: Ben Pfaff

Re: [ovs-dev] [ovsdb speedup v4 2/3] ovsdb-monitor: allow multiple jsonrpc monitors to share a single ovsdb monitor

2015-06-08 Thread Andy Zhou
On Sat, Jun 6, 2015 at 2:55 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Jun 01, 2015 at 12:30:03AM -0700, Andy Zhou wrote: Store ovsdb monitor in a global hmap. If a newly created ovsdb monitor object monitors the same tables and columns as an existing one, the existing monitor will be

Re: [ovs-dev] [PATCH 1/2] flow: Add 'const' qualifiers in flow extraction.

2015-06-08 Thread Ben Pfaff
Thanks for the ack and the typo fix. I applied both and pushed this to master. On Mon, Jun 08, 2015 at 05:52:35PM +, Daniele Di Proietto wrote: For other reasons I have (almost) the exact same commit in my local repository! Minor style nitpick below, otherwise: Acked-by: Daniele Di

Re: [ovs-dev] [RFC] db-ctl-base: Make common database command code into library.

2015-06-08 Thread William Adams
Hi Alex, I'm pretty new to the Open vSwitch world, but I've been working on a LuaJIT binding for the same: http://github.com/wiladams/LJIT2ovs While I've done the lowest level stuff, I am now focusing on higher level utilities, such as ovs-vsctl and the like. From a scripting environment

[ovs-dev] [PATCH branch-2.3] datapath: Fix build on RHEL 7.1

2015-06-08 Thread Pravin B Shelar
Some of code is backported from following commit. commit 13dd4a9738e99684a56b10ce2f1a5ee2d2ec2f9f Author: Joe Stringer joestrin...@nicira.com Date: Tue Mar 24 16:16:18 2015 -0700 compat: Fix RHEL7 build. Tested against 3.10.0-229.el7.x86_64. --8 Reported-by:

[ovs-dev] [PATCH v2] Do not flush tx queue which is shared among CPUs since it is always flushed

2015-06-08 Thread Wei li
When tx queue is shared among CPUS,the pkts always be flush in 'netdev_dpdk_eth_send' So it is unnecessarily for flushing in netdev_dpdk_rxq_recv Otherwise tx will be accessed without locking Signed-off-by: Wei li l...@dtdream.com --- v1-v2: fix typo lib/netdev-dpdk.c | 7 +-- 1 file

Re: [ovs-dev] [PATCH v2] Do not flush tx queue which is shared among CPUs since it is always flushed

2015-06-08 Thread Pravin Shelar
On Mon, Jun 8, 2015 at 6:13 PM, Wei li l...@dtdream.com wrote: When tx queue is shared among CPUS,the pkts always be flush in 'netdev_dpdk_eth_send' So it is unnecessarily for flushing in netdev_dpdk_rxq_recv Otherwise tx will be accessed without locking Signed-off-by: Wei li

[ovs-dev] Is the tx spinlock in __netdev_dpdk_vhost_send necessary?

2015-06-08 Thread Dongjun
This is the source code of __netdev_dpdk_vhost_send in master branch: ... /* There is vHost TX single queue, So we need to lock it for TX. */ rte_spinlock_lock(vhost_dev-vhost_tx_lock); do { unsigned int tx_pkts; tx_pkts = rte_vhost_enqueue_burst(virtio_dev,

[ovs-dev] Can't subscribe this maillist

2015-06-08 Thread huangdenghui
Hi guys I can't subscribe this maillist. Does anybody meet the problem too? 发自网易邮箱手机版 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v7] netdev-dpdk: add dpdk vhost-user ports

2015-06-08 Thread Pravin Shelar
On Mon, Jun 8, 2015 at 9:33 AM, Loftus, Ciara ciara.lof...@intel.com wrote: On Thu, Jun 4, 2015 at 6:53 AM, Loftus, Ciara ciara.lof...@intel.com wrote: On Fri, May 22, 2015 at 8:40 AM, Ciara Loftus ciara.lof...@intel.com wrote: This patch adds support for a new port type to the userspace

Re: [ovs-dev] [PATCH net-next V10 4/4] 8021AD: Flow key parsing and netlink attributes.

2015-06-08 Thread Pravin Shelar
On Tue, Jun 2, 2015 at 10:50 AM, Thomas F Herbert thomasfherb...@gmail.com wrote: Add support for 802.1ad to netlink parsing and flow conversation. Uses double nested encap attributes to represent double tagged vlan. This patch needs to be merged with earlier patch since it is part of qinq

[ovs-dev] I try to find a tour guide in your city for one hot night and have a lot of sweet goodies to reciprocate

2015-06-08 Thread Pamela Keat
Nice photos! You have everything to become my lover for this night! My friends went on a tour in your city, but I came here to find something much more delicious. The hotel room will be will be free this night. Would like you visit it and be my own tour guide in the world of pleasure? My named

Re: [ovs-dev] [PATCH v9] ovs-ofctl:Implementation of eviction on the basis of Importance

2015-06-08 Thread Saloni Jain
Hi Ben, Thanks for your inputs. We will share the updated patch. Kindly suggest for the below point.. This adds abstracted OFPUTIL_TABLE_CONFIG_* but it doesn't do any translation between them and OFPTC14_*. As per the openflow specs. 1.4, OFPTC14_* values are defined only for eviction and

[ovs-dev] [PATCH] netdev-windows: Fixed unresolved external symbols linker error

2015-06-08 Thread Sorin Vinturis
Adding missing dependency to iphlpapi library, required by the use of GetIpNetTable and GetAdaptersAddresses functions. Without this change the build fails with the error below: LINK : utilities/ovs-testcontroller.exe not found or not built by the last incremental link; performing full link

Re: [ovs-dev] [PATCH v2] datapath-windows: Stateless TCP Tunnelling protocol - Initial implementation

2015-06-08 Thread Eitan Eliahu
Yes, will do. Eitan -Original Message- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Saturday, June 06, 2015 1:52 PM To: Eitan Eliahu Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Stateless TCP Tunnelling protocol - Initial implementation On Wed, May 27,

[ovs-dev] report

2015-06-08 Thread miroslavnikolic
The original message was received at Mon, 8 Jun 2015 23:26:07 +0800 from rocketmail.com [70.183.244.20] - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH] netdev-windows: Fixed unresolved external symbols linker error

2015-06-08 Thread Gurucharan Shetty
On Mon, Jun 8, 2015 at 7:25 AM, Sorin Vinturis svintu...@cloudbasesolutions.com wrote: Adding missing dependency to iphlpapi library, required by the use of GetIpNetTable and GetAdaptersAddresses functions. Without this change the build fails with the error below: LINK :

Re: [ovs-dev] [PATCH] netdev-windows: Fixed unresolved external symbols linker error

2015-06-08 Thread Sorin Vinturis
No, I was not using those configure options. I wasn't passing the iphlpapi library. Thanks! -Original Message- From: Gurucharan Shetty [mailto:shet...@nicira.com] Sent: Monday, 8 June, 2015 17:54 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] netdev-windows:

[ovs-dev] [PATCH 2/2] [RFC] flow: Use new miniflow_builder for miniflow_extract().

2015-06-08 Thread Ben Pfaff
This replaces the very specialized and difficult-to-maintain miniflow assembly macros by a simpler data structure named miniflow_builder that is more general and easier to use. It's not complete--it needs polishing and it mysteriously fails a few tests--but I'd like some early feedback. In

[ovs-dev] [PATCH 1/2] flow: Add 'const' qualifiers in flow extraction.

2015-06-08 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- lib/flow.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index 0f9ee50..b5ad5f8 100644 --- a/lib/flow.c +++ b/lib/flow.c @@ -89,9 +89,9 @@ BUILD_ASSERT_DECL(offsetof(struct flow, tp_src)

Re: [ovs-dev] [PATCH v7] netdev-dpdk: add dpdk vhost-user ports

2015-06-08 Thread Loftus, Ciara
On Thu, Jun 4, 2015 at 6:53 AM, Loftus, Ciara ciara.lof...@intel.com wrote: On Fri, May 22, 2015 at 8:40 AM, Ciara Loftus ciara.lof...@intel.com wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. ... ... +

[ovs-dev] [PATCH v2] IGMPv3 support

2015-06-08 Thread Thadeu Lima de Souza Cascardo
Support IGMPv3 messages with multiple records. Make sure all IGMPv3 messages go through slow path, since they may carry multiple multicast addresses, unlike IGMPv2. Tests done: * multiple addresses in IGMPv3 report are inserted in mdb; * address is removed from IGMPv3 if record is INCLUDE_MODE;

[ovs-dev] conntrack: nfqueue action

2015-06-08 Thread Franck BAUDIN
Hello, Conntrack looks in very good progress on https://github.com/justinpettit/ovs.git However, I didn't find any code related to nfqueue openvswitch action, neither on https://github.com/tgraf/ovs.git. Is the nfqueue action still planned to be implemented for openvswitch 2.4? Do you need a