Re: [ovs-dev] [PATCH net-next V15 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-15 Thread Thomas F Herbert
On 10/13/15 2:14 PM, Pravin Shelar wrote: On Tue, Oct 13, 2015 at 10:39 AM, Thomas F Herbert wrote: Pravin, Thanks for the review. On 10/13/15 7:47 AM, Pravin Shelar wrote: On Sat, Oct 10, 2015 at 4:40 PM, Thomas F Herbert wrote: Add

[ovs-dev] [PATCH v2] datapath-windows: Support attribute OVS_KEY_ATTR_TCP_FLAGS

2015-10-15 Thread Sorin Vinturis
This patch adds OVS_KEY_ATTR_TCP_FLAGS to our flow mechanism. Also clean unecesarry parts of code. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Sorin Vinturis --- This patch is intended for branch-2.4 as well. ---

[ovs-dev] [PATCH v2] datapath-windows: Support attribute OVS_KEY_ATTR_TCP_FLAGS

2015-10-15 Thread Sorin Vinturis
This patch adds OVS_KEY_ATTR_TCP_FLAGS to our flow mechanism. Also clean unecesarry parts of code. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Sorin Vinturis --- This patch is intended for branch-2.4 as well. ---

[ovs-dev] [PATCH v4 57/79] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

2015-10-15 Thread Mikko Rapeli
Fixes userspace compiler error: error: unknown type name ‘uint32_t’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/openvswitch.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h

[ovs-dev] [PATCH 1/5] ovn-controller.8: Correct reference to "ovn-encap-type".

2015-10-15 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ovn/controller/ovn-controller.8.xml |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-controller.8.xml index aadec15..9c041ec 100644 ---

[ovs-dev] [PATCH 2/5] ovn-sbctl: Add multiple encaps with "chassis-add".

2015-10-15 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ovn/utilities/ovn-sbctl.8.in |9 --- ovn/utilities/ovn-sbctl.c| 44 ++--- tests/ovn-sbctl.at | 35 - 3 files changed, 71 insertions(+), 17

[ovs-dev] [PATCH 3/5] ovn-controller: Support VXLAN enapsulation.

2015-10-15 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ovn/controller/encaps.c |5 ++- ovn/controller/ovn-controller.8.xml | 17 -- ovn/controller/physical.c | 58 +++--- 3 files changed, 68 insertions(+), 12 deletions(-) diff

[ovs-dev] [PATCH 5/5] ovn.at: Add test for gateway.

2015-10-15 Thread Justin Pettit
This test exposed a problem that ovn-controller-vtep doesn't properly set up the "Mcast_Macs_Remote" table, which prevents broadcasts from being sourced from the physical side of the VTEP. That issue needs to be resolved, and then the full set of gateway traffic patterns can run. Signed-off-by:

[ovs-dev] [PATCH 4/5] ovn-controller: Support multiple encaps simultaneously.

2015-10-15 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ovn/controller/chassis.c| 88 ++- ovn/controller/encaps.c | 20 ovn/controller/ovn-controller.8.xml | 10 +++- ovn/controller/ovn-controller.c | 14 ++

Re: [ovs-dev] [PATCH 3/3] ovn.at: Fix tab/space issues.

2015-10-15 Thread Justin Pettit
> On Oct 15, 2015, at 1:42 AM, Justin Pettit wrote: > > >> On Oct 14, 2015, at 10:40 PM, Ben Pfaff wrote: >> >> On Wed, Oct 14, 2015 at 10:38:06PM -0700, Justin Pettit wrote: >>> Signed-off-by: Justin Pettit >> >> Acked-by: Ben Pfaff

[ovs-dev] [PATCH net-next V16 0/3] openvswitch: Add support for 802.1ad

2015-10-15 Thread Thomas F Herbert
This patch accompanies version 14 of the user level openvswitch patch submitted to openvswitch dev list. V16,15: Implement reviewer comments. V14: Add outer tpid to flow_key V13: Fix incorrect encoding and decoding of netlink to/from key attributes. V12: Fix some problems and issues

Re: [ovs-dev] [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-10-15 Thread Sergei Shtylyov
On 10/15/2015 5:01 PM, Thomas F Herbert wrote: Hm, I'm seeing no sign-off on this patch. --- include/linux/if_vlan.h | 16 1 file changed, 16 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 67ce5bd..ac23521 100644 ---

[ovs-dev] [PATCH net-next V16 1/3] openvswitch: 802.1ad uapi changes.

2015-10-15 Thread Thomas F Herbert
openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[ovs-dev] [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-10-15 Thread Thomas F Herbert
--- include/linux/if_vlan.h | 16 1 file changed, 16 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 67ce5bd..ac23521 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -627,6 +627,22 @@ static inline netdev_features_t

[ovs-dev] [PATCH net-next V16 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-15 Thread Thomas F Herbert
Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged vlan. Inner TPID encoded along with ctci in nested attributes. Signed-off-by: Thomas F

Re: [ovs-dev] [PATCH 04/23] ovn-nbctl: Remove external-ids commands.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > Users are served just as well through the general-purpose "set" and "get" > database commands, so avoid the additional code and documentation. > > (ovs-vsctl does have special external-ids commands for bridges, but those >

Re: [ovs-dev] [PATCH net-next V16 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-15 Thread Thomas F Herbert
On 10/15/15 7:02 PM, Pravin Shelar wrote: Thanks for the review. See my comment below. --TFH On Thu, Oct 15, 2015 at 7:01 AM, Thomas F Herbert wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to

Re: [ovs-dev] [PATCH 14/23] ovn: Add new predicates for matching broadcast and multicast packets.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > In my opinion, "eth.mcast" is a bit more readable than "eth.dst[40]", and > so on. > > Signed-off-by: Ben Pfaff I think there are a couple of spots in "ovn-northd.8.xml" that could use these new

Re: [ovs-dev] [PATCH 20/23] ovn-nb: Add "enabled" column to Logical_Router_Port.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:21 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 22/23] ovn-northd: Add stages for logical routers.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:21 PM, Ben Pfaff wrote: > > Until now, ovn-northd has only set up flows for logical switches. With the > arrival of logical routers, it needs to set up flows for them too. The > stages within logical routers are completely different from those for >

[ovs-dev] Delivery failed

2015-10-15 Thread Mail Administrator
This message was undeliverable due to the following reason: Your message could not be delivered because the destination server was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely

Re: [ovs-dev] [PATCH net-next V16 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-15 Thread Pravin Shelar
On Thu, Oct 15, 2015 at 7:01 AM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double >

Re: [ovs-dev] [PATCH 08/23] ovn-controller: Factor patch port management into new "patch" module.

2015-10-15 Thread Justin Pettit
After reviewing patch 10, I have a few more thoughts on this patch. This doesn't change my original ACK, though. > +static void > +create_patch_port(struct controller_ctx *ctx, > + const char *network, > + const struct ovsrec_bridge *b1, > +

Re: [ovs-dev] [PATCH 10/23] patch: Refactor to better support new kinds of patches.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > +/* Add any patch ports that should exist but don't. */ > +parse_bridge_mappings(ctx, br_int, _ports); This comment could probably use a bit more information. > +/* Delete any patch ports that do exist but

Re: [ovs-dev] [PATCH 18/23] ovn-nb.xml: Reorganize documentation for Logical_Port table.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > This uses the column grouping feature and the ability to document an > individual key within a column to better, in my opinion, organize the > documentation for the Logical_Port table. > > This will make it easier to document

[ovs-dev] [PATCH] physical: Improve treatment of localnet non-VLAN logical ports.

2015-10-15 Thread Ben Pfaff
Until now, the flow table treated localnet logical ports that have a VLAN quite differently from those that don't. The ones without a VLAN were essentially trunk ports: any packets that came in, that weren't picked off by a localnet port with a VLAN, were passed to the ones without a VLAN. This

Re: [ovs-dev] [PATCH 11/23] patch: Allow client to determine port names.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > -create_patch_ports(ctx, network, existing_ports, br_int, ovs_bridge); > -create_patch_ports(ctx, network, existing_ports, ovs_bridge, br_int); > +char *br_int_name = patch_port_name(br_int, ovs_bridge);

Re: [ovs-dev] [PATCH 13/23] ovn: Implement logical patch ports.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > diff --git a/ovn/controller/patch.c b/ovn/controller/patch.c > index 90c72ff..f25709c 100644 > --- a/ovn/controller/patch.c > +++ b/ovn/controller/patch.c > @@ -50,7 +50,7 @@ match_patch_port(const struct ovsrec_port *port,

Re: [ovs-dev] [PATCH 15/23] ovn-nb: Extend schema to support networks of routers.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 21/23] packets: New function ip_parse_masked().

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:21 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > +char * OVS_WARN_UNUSED_RESULT > +ip_parse_masked(const char *s, ovs_be32 *ip, ovs_be32 *mask) It might be nice to provide a comment describing this function. Acked-by: Justin

Re: [ovs-dev] [PATCH 12/23] ovn-controller: Rename "ovn-patch-port" to "ovn-localnet-port".

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > An upcoming patch will introduce a different use for patch ports, so > ovn-patch-port would become an ambiguous name. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin

Re: [ovs-dev] [PATCH net-next V16 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-15 Thread Pravin Shelar
On Thu, Oct 15, 2015 at 4:48 PM, Thomas F Herbert wrote: > On 10/15/15 7:02 PM, Pravin Shelar wrote: > Thanks for the review. See my comment below. > > --TFH > > >> On Thu, Oct 15, 2015 at 7:01 AM, Thomas F Herbert >> wrote: >>> >>> Add support

Re: [ovs-dev] [PATCH 17/23] ovn-nb: Add support for IP+MAC binding pairs in Port_Binding 'address'.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > When a logical router can statically obtain the IP+MAC pairs for its > attached logical switches, it can avoid expensive ARP resolution. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit

Re: [ovs-dev] [PATCH net-next V16 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-15 Thread Thomas F Herbert
On 10/15/15 8:37 PM, Pravin Shelar wrote: On Thu, Oct 15, 2015 at 4:48 PM, Thomas F Herbert wrote: On 10/15/15 7:02 PM, Pravin Shelar wrote: Thanks for the review. See my comment below. --TFH On Thu, Oct 15, 2015 at 7:01 AM, Thomas F Herbert

Re: [ovs-dev] [PATCH 01/23] ovn: Extend logical "next" action to jump to arbitrary flow tables.

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 01:46:44PM -0700, Justin Pettit wrote: > > > On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > > > @@ -30,8 +30,10 @@ struct action_context { > > /* Input. */ > > struct lexer *lexer;/* Lexer for pulling more tokens. */ > > const

Re: [ovs-dev] [PATCH ] debian: place kernel module to satisfy depmod search.

2015-10-15 Thread Saurabh Mohan
On 10/15/2015 01:55 PM, Ansis Atteka wrote: On Wed, Oct 14, 2015 at 5:33 PM, Saurabh Mohan wrote: On 10/14/2015 04:58 PM, Ansis Atteka wrote: On Wed, Oct 14, 2015 at 4:08 PM, Ben Pfaff wrote: On Wed, Oct 14, 2015 at 03:28:24PM -0700, Joe

Re: [ovs-dev] [PATCH] ovn: Add stateful ACL support.

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 10:32:51AM -0700, Justin Pettit wrote: > Add support for the "allow-related" ACL action. This is dependent on > the OVS conntrack functionality, which is not available on all platforms > or kernel versions. > > Here is a sample policy that will allow all tenants in

Re: [ovs-dev] [PATCH 16/23] ovn-nb: Rename Port_Bindings 'macs' column to 'addresses'.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > In an upcoming commit this column will also support IP+MAC pairs. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev

Re: [ovs-dev] [PATCH 2/4] ovs-ofctl: Fix OpenFlow versions with '--bundle'

2015-10-15 Thread Takashi Yamamoto
On Fri, Oct 16, 2015 at 6:28 AM, Jarno Rajahalme wrote: > While the presence of the '--bundle' option implicitly added the > OpenFlow 1.4 to the allowed protocols, it failed to remove OpenFlow > 1.0 from the allowed protocols. This is changed so that '--bundle' > option

Re: [ovs-dev] [PATCH 19/23] ovn-nb: Change how router ports work.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 5/5] ovn.at: Add test for gateway.

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 01:55:00AM -0700, Justin Pettit wrote: > This test exposed a problem that ovn-controller-vtep doesn't properly > set up the "Mcast_Macs_Remote" table, which prevents broadcasts from > being sourced from the physical side of the VTEP. That issue needs to > be resolved, and

[ovs-dev] [PATCH 3/4] ovs-ofctl: Support multiple tables in replace-flows and diff-flows.

2015-10-15 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- tests/ovs-ofctl.at| 60 - utilities/ovs-ofctl.c | 174 +++--- 2 files changed, 140 insertions(+), 94 deletions(-) diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at index

[ovs-dev] [PATCH 4/4] openflow: Remove OFPG11_*

2015-10-15 Thread Jarno Rajahalme
Protocol-independent symbols OFPG_* were already defined in openflow-common.h, so remove the protocol version dependent symbols. Found by inspection. Signed-off-by: Jarno Rajahalme --- include/openflow/openflow-1.1.h | 18 ++ lib/ofp-parse.c

[ovs-dev] [PATCH 1/4] Summary: From: Jarno Rajahalme <jrajaha...@nicira.com>

2015-10-15 Thread Jarno Rajahalme
ovs-ofctl: Fix replace-flows. The replace-flows test cases tested for incorrect behavior due to the missing initialization of the out_group member of struct ofputil_flow_stats_request. This patch fixes this by properly initializing out_group to OFPG_ANY. Note that replace-flows still does not

[ovs-dev] [PATCH 2/4] ovs-ofctl: Fix OpenFlow versions with '--bundle'

2015-10-15 Thread Jarno Rajahalme
While the presence of the '--bundle' option implicitly added the OpenFlow 1.4 to the allowed protocols, it failed to remove OpenFlow 1.0 from the allowed protocols. This is changed so that '--bundle' option now also implicitly removes versions lesser than 1.4 from the allowed protocols. This has

Re: [ovs-dev] [PATCH 4/5] ovn-controller: Support multiple encaps simultaneously.

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 01:54:59AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit The chassis.c code only verifies the IP address for one of the encapsulations, maybe it should do it for all of them, something like this: diff --git a/ovn/controller/chassis.c

Re: [ovs-dev] [PATCH ] debian: place kernel module to satisfy depmod search.

2015-10-15 Thread Saurabh Mohan
On 10/14/2015 04:58 PM, Ansis Atteka wrote: On Wed, Oct 14, 2015 at 4:08 PM, Ben Pfaff wrote: On Wed, Oct 14, 2015 at 03:28:24PM -0700, Joe Stringer wrote: On 14 October 2015 at 15:21, Ben Pfaff wrote: On Tue, Oct 06, 2015 at 04:35:32PM -0700, Saurabh Mohan

Re: [ovs-dev] [PATCH 05/23] nx-match: Serialize match on IP TTL even when outputting OXM.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > The 'oxm' parameter to nxm_put_ip() indicates whether NXM or OXM code > points should be used in cases where both exist. It shouldn't cause > matches to be dropped entirely, since that changes the meaning, but that's > what

Re: [ovs-dev] [PATCH 01/23] ovn: Extend logical "next" action to jump to arbitrary flow tables.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > @@ -30,8 +30,10 @@ struct action_context { > /* Input. */ > struct lexer *lexer;/* Lexer for pulling more tokens. */ > const struct shash *symtab; /* Symbol table. */ > -uint8_t next_table_id; /*

Re: [ovs-dev] [PATCH 1/4] Summary: From: Jarno Rajahalme <jrajaha...@nicira.com>

2015-10-15 Thread Jarno Rajahalme
> On Oct 15, 2015, at 2:28 PM, Jarno Rajahalme wrote: > > ovs-ofctl: Fix replace-flows. Sorry about the botched title, will fix for the commit, Jarno ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH ] debian: place kernel module to satisfy depmod search.

2015-10-15 Thread Ansis Atteka
On Wed, Oct 14, 2015 at 5:33 PM, Saurabh Mohan wrote: > On 10/14/2015 04:58 PM, Ansis Atteka wrote: >> >> On Wed, Oct 14, 2015 at 4:08 PM, Ben Pfaff wrote: >>> >>> On Wed, Oct 14, 2015 at 03:28:24PM -0700, Joe Stringer wrote: On 14 October

Re: [ovs-dev] [PATCH 07/23] ovn-controller: Un-inline get_chassis_by_name().

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > I don't know of any reason to inline this. Well, obviously because it's on the critical path. It has to do with registers and CPU caches and stuff--you wouldn't understand. > Also rename for consistency with get_bridge(). >

Re: [ovs-dev] [PATCH v4 02/12] ovs-ofctl: Add bundle support and unit testing.

2015-10-15 Thread Jarno Rajahalme
> On Oct 14, 2015, at 9:35 PM, Takashi Yamamoto wrote: > > hi, > > On Wed, Jun 10, 2015 at 9:24 AM, Jarno Rajahalme > wrote: >> >> diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at >> index 1e12827..b7db9bb 100644 >> --- a/tests/ovs-ofctl.at

Re: [ovs-dev] [PATCH 03/23] ovn: Change h1 titles to title case in documentation.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > Manpage section titles are traditionally all-uppercase, but OVS's > XML-to-nroff translator takes care of that and there's no need to actually > provide them in all-caps (and it looks ugly). > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH 09/23] patch: Bail out earlier if OVS IDL transactions cannot be executed.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > The whole point of this module is side effects on the Open vSwitch > database, so the whole thing can be skipped if those are impossible. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit

Re: [ovs-dev] [PATCH 3/5] ovn-controller: Support VXLAN enapsulation.

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 01:54:58AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit It looks like physical_run() will now iterate through every row in the Port_Binding table for each VXLAN tunnel. That seems expensive. Here's a suggested documentation update.

Re: [ovs-dev] [PATCH 08/23] ovn-controller: Factor patch port management into new "patch" module.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > This is a proposed plan for logical L3 in OVN. It is not entirely > complete but it includes many important details and I believe that it moves > planning forward. > > Signed-off-by: Ben Pfaff Acked-by:

Re: [ovs-dev] [PATCH 02/23] ovn: Implement logical action to decrement IPv4 TTL.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > This is necessary for IPv4 routing. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 02/23] ovn: Implement logical action to decrement IPv4 TTL.

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 01:53:23PM -0700, Justin Pettit wrote: > > > On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > > > This is necessary for IPv4 routing. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks, applied.

Re: [ovs-dev] [PATCH 08/23] ovn-controller: Factor patch port management into new "patch" module.

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 11:38:34PM +, Justin Pettit wrote: > After reviewing patch 10, I have a few more thoughts on this patch. This > doesn't change my original ACK, though. This patch is supposed to be mostly moving code around. I'm happy to make the improvements you mention but I'd

Re: [ovs-dev] [PATCH 04/23] ovn-nbctl: Remove external-ids commands.

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 01:58:08PM -0700, Justin Pettit wrote: > > > On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > > > Users are served just as well through the general-purpose "set" and "get" > > database commands, so avoid the additional code and documentation. > > > >

Re: [ovs-dev] [PATCH 03/23] ovn: Change h1 titles to title case in documentation.

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 01:54:26PM -0700, Justin Pettit wrote: > > > On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > > > Manpage section titles are traditionally all-uppercase, but OVS's > > XML-to-nroff translator takes care of that and there's no need to actually > > provide

Re: [ovs-dev] [PATCH 07/23] ovn-controller: Un-inline get_chassis_by_name().

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 02:04:26PM -0700, Justin Pettit wrote: > > > On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > > > I don't know of any reason to inline this. > > Well, obviously because it's on the critical path. It has to do with > registers and CPU caches and

[ovs-dev] [PATCH] ovn: Add stateful ACL support.

2015-10-15 Thread Justin Pettit
Add support for the "allow-related" ACL action. This is dependent on the OVS conntrack functionality, which is not available on all platforms or kernel versions. Here is a sample policy that will allow all tenants in logical switch "ls0" to SSH to each other. Anyone can make an HTTP request to

Re: [ovs-dev] [PATCH 2/3] ovn-controller.8: Correct reference to "ovn-encap-type".

2015-10-15 Thread Ben Pfaff
On Wed, Oct 14, 2015 at 10:38:05PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] ovn.at: Fix tab/space issues.

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 01:59:18AM -0700, Justin Pettit wrote: > > > On Oct 15, 2015, at 1:42 AM, Justin Pettit wrote: > > > > > >> On Oct 14, 2015, at 10:40 PM, Ben Pfaff wrote: > >> > >> On Wed, Oct 14, 2015 at 10:38:06PM -0700, Justin Pettit wrote: >

Re: [ovs-dev] [PATCH] ovs-vswitchd.conf.db.5: Update docs for max-idle.

2015-10-15 Thread Joe Stringer
On 14 October 2015 at 21:55, Justin Pettit wrote: > >> On Oct 14, 2015, at 8:28 PM, Joe Stringer wrote: >> >>> Do you want to make that change too? >> >> Sure. Is it something we want to backport or just apply to master? > > I'd just apply it to

Re: [ovs-dev] [PATCH 3/3] ovn.at: Fix tab/space issues.

2015-10-15 Thread Justin Pettit
> On Oct 15, 2015, at 9:51 AM, Ben Pfaff wrote: > > On Thu, Oct 15, 2015 at 01:59:18AM -0700, Justin Pettit wrote: >> >> Scratch reviewing that. My vtep series depended on that patch, so I >> just resent it as part of the series. > > I try not to resent patches. I just

Re: [ovs-dev] [PATCH 2/2] openvswitch: Allocate memory for ovs internal device stats.

2015-10-15 Thread Pravin Shelar
On Thu, Oct 15, 2015 at 7:54 AM, James Morse wrote: > "openvswitch: Remove vport stats" removed the per-vport statistics, in > order to use the netdev's statistics fields. > "openvswitch: Fix ovs_vport_get_stats()" fixed the export of these stats > to user-space, by using the

Re: [ovs-dev] [PATCH 2/5] ovn-sbctl: Add multiple encaps with "chassis-add".

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 01:54:57AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/5] ovn-controller.8: Correct reference to "ovn-encap-type".

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 01:54:56AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] (no subject)

2015-10-15 Thread Bounced mail
The original message was received at Thu, 15 Oct 2015 11:31:05 +0530 from 166.189.229.121 - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] OVN: V2 RFC add a new JSON-RPC selective monitoring method

2015-10-15 Thread Liran Schour
Ben Pfaff wrote on 15/10/2015 02:44:44 AM: > On Wed, Sep 23, 2015 at 08:57:38PM +0300, Liran Schour wrote: > > Here is an update for the proposed OVSDB protocol specification (RFC > > 7047)change suggested for overcoming OVN scalability issues by allowing > > clients to