Hi:
Problem
===
I'm glad to see that ovs add conntrack support, the conntrack support is
great, but I want to push it more forward.
Consider this scenario:
multiple tenant sharing a single global ip by using nat. ip address in
different tenant can be overlapped. let's say tenant A ip x and t
On Mon, Nov 30, 2015 at 10:03:11AM -0800, Jarno Rajahalme wrote:
>
> > On Nov 29, 2015, at 17:12, Ben Pfaff wrote:
> >
> >> On Mon, Nov 23, 2015 at 08:54:31PM -0800, Jarno Rajahalme wrote:
> >> Back by popular demand, here is the OpenFlow meter implementation for
> >> the userspace datapath. Me
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Dec 21, 2015 at 04:45:20PM -0800, Joe Stringer wrote:
> On 21 December 2015 at 16:11, Joe Stringer wrote:
> > On 21 December 2015 at 16:01, Ben Pfaff wrote:
> >> On Mon, Dec 21, 2015 at 03:56:40PM -0800, Joe Stringer wrote:
> >>> The previous definitions of these variables using designate
> On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote:
>
> +struct lport {
> +struct hmap_node name_node; /* Index by name. */
> +struct hmap_node key_node; /* Index by (dp->tunnel_key, tunnel_key). */
I could go either way, but do you think it might be clearler to change these
arguments to "
> On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote:
>
> It seems easier to understand if all of the tests for a given action
> are grouped together.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
dev@openvswitch.or
> On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote:
>
> The existing wording was very specific to the actual operation being
> performed. While this is nice for users, it becomes difficult to maintain
> as more and more operations are added. This commit makes the wording less
> specific, because a
Hi Joe,
On 14/12/2015 23:06, "Joe Stringer" wrote:
>On 2 December 2015 at 11:46, Daniele Di Proietto
>wrote:
>> The goal of this series is to introduce two dpctl command to interact
>> with the Linux kernel connection tracker. The same infrastructure
>> will be used by the userspace connection
On 12/21/2015 06:50 PM, Ben Pfaff wrote:
> On Mon, Dec 21, 2015 at 03:35:58PM -0500, Russell Bryant wrote:
>> Autotest keywords are helpful for running a subset of the test suite.
>> This patch makes it so you can run all OVN tests using the 'ovn'
>> keyword.
>>
>> $ make check TESTSUITEFLAGS="-k
On 21 December 2015 at 16:11, Joe Stringer wrote:
> On 21 December 2015 at 16:01, Ben Pfaff wrote:
>> On Mon, Dec 21, 2015 at 03:56:40PM -0800, Joe Stringer wrote:
>>> The previous definitions of these variables using designated
>>> initializers caused a variety of issues when attempting to compi
On Mon, Dec 21, 2015 at 07:29:41PM -0500, Russell Bryant wrote:
> On Mon, Dec 21, 2015 at 6:46 PM, Ben Pfaff wrote:
>
> > On Mon, Dec 21, 2015 at 06:20:42PM -0500, Russell Bryant wrote:
> > > On Mon, Dec 21, 2015 at 5:14 PM, Ben Pfaff wrote:
> > >
> > > > On Sat, Dec 19, 2015 at 11:37:00AM -0500
On Mon, Dec 21, 2015 at 6:46 PM, Ben Pfaff wrote:
> On Mon, Dec 21, 2015 at 06:20:42PM -0500, Russell Bryant wrote:
> > On Mon, Dec 21, 2015 at 5:14 PM, Ben Pfaff wrote:
> >
> > > On Sat, Dec 19, 2015 at 11:37:00AM -0500, Russell Bryant wrote:
> > > > $ make check TESTSUITEFLAGS="-k pep8"
> > >
On 21 December 2015 at 15:46, Ansis Atteka wrote:
>
>
> On 27 November 2015 at 05:35, Flavio Leitner wrote:
>
>> On Fri, Nov 20, 2015 at 03:33:20AM -0800, Andy Zhou wrote:
>> > Make RHEL systemd distributions start OVS and OVN daemons under user
>> > ovs. The 'ovs' user and group will be created
On 21 December 2015 at 16:01, Ben Pfaff wrote:
> On Mon, Dec 21, 2015 at 03:56:40PM -0800, Joe Stringer wrote:
>> The previous definitions of these variables using designated
>> initializers caused a variety of issues when attempting to compile with
>> MSVC, particularly if including these headers
It looks obviously correct to me but I guess that Daniele or Pravin
should apply it.
On Mon, Dec 21, 2015 at 10:04:55AM +, Weglicki, MichalX wrote:
> Hello,
>
> Is it possible to merge this patch? It is quite simple, and very important
> for integration with DPDK 2.2.
>
> Br,
> Michal.
On Mon, Dec 21, 2015 at 03:56:40PM -0800, Joe Stringer wrote:
> The previous definitions of these variables using designated
> initializers caused a variety of issues when attempting to compile with
> MSVC, particularly if including these headers from C++ code. By defining
> them like this, we can
The previous definitions of these variables using designated
initializers caused a variety of issues when attempting to compile with
MSVC, particularly if including these headers from C++ code. By defining
them like this, we can appease MSVC and keep the definitions the same on
all platforms.
VMwa
On Mon, Dec 21, 2015 at 03:35:58PM -0500, Russell Bryant wrote:
> Autotest keywords are helpful for running a subset of the test suite.
> This patch makes it so you can run all OVN tests using the 'ovn'
> keyword.
>
> $ make check TESTSUITEFLAGS="-k ovn"
>
> Signed-off-by: Russell Bryant
Acke
Based on off-list discussions, we're going to cancel the Hyper-V and OVN
meetings this week and next week. We'll resume the meetings on Jan. 5
and 7, respectively.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 27 November 2015 at 05:35, Flavio Leitner wrote:
> On Fri, Nov 20, 2015 at 03:33:20AM -0800, Andy Zhou wrote:
> > Make RHEL systemd distributions start OVS and OVN daemons under user
> > ovs. The 'ovs' user and group will be created at the openvswitch RPM
> > installtion time.
> >
>
Hi Flavio.
On Mon, Dec 21, 2015 at 06:20:42PM -0500, Russell Bryant wrote:
> On Mon, Dec 21, 2015 at 5:14 PM, Ben Pfaff wrote:
>
> > On Sat, Dec 19, 2015 at 11:37:00AM -0500, Russell Bryant wrote:
> > > $ make check TESTSUITEFLAGS="-k pep8"
> > >
> > > Another option would be to run this part at ovs build t
From: Ben Pfaff
The OFPT_SET_CONFIG and OFPT_GET_CONFIG_REPLY messages, which have the
same format, have a 'flags' field in which OpenFlow defines some bits,
which change somewhat from one version to another, and does not define
others. Until now, Open vSwitch has not abstracted these messages a
On Mon, Dec 21, 2015 at 3:10 PM, Joe Stringer wrote:
> On 21 December 2015 at 14:57, Pravin B Shelar wrote:
>> I found this missing commit while checking diff against upstream OVS.
>>
>> Upstream Commit msg:
>> Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside
>> of
From: Ben Pfaff
I was not previously aware that this feature was missing.
Reported-by: Minoru TAKAHASHI
Reported-at: http://openvswitch.org/pipermail/discuss/2015-October/019229.html
Signed-off-by: Ben Pfaff
---
NEWS | 1 +
lib/ofp-util.c | 22 --
I originally posted this near the beginning of November, but it's
received no reviews. I'd like to get it into 2.5 since it's a bug fix.
Ben Pfaff (2):
ovs-ofctl: Generalize code for finding ports into general-purpose
iterator.
ofproto: Implement OFPT_QUEUE_GET_CONFIG_REQUEST for OFPP_ANY
From: Ben Pfaff
The port_iterator will acquire another user in an upcoming commit.
Signed-off-by: Ben Pfaff
---
utilities/ovs-ofctl.c | 233 ++
1 file changed, 123 insertions(+), 110 deletions(-)
diff --git a/utilities/ovs-ofctl.c b/utilities/ov
On Mon, Dec 14, 2015 at 05:23:36PM -0800, Daniele Di Proietto wrote:
> In the ODP context an empty mask netlink attribute usually means that
> the flow should be an exact match.
>
> odp_flow_key_to_mask() instead returns a struct flow_wildcards
> with matches only on recirc_id and vlan_tci.
>
> A
On Mon, Dec 21, 2015 at 5:14 PM, Ben Pfaff wrote:
> On Sat, Dec 19, 2015 at 11:37:00AM -0500, Russell Bryant wrote:
> > $ make check TESTSUITEFLAGS="-k pep8"
> >
> > Another option would be to run this part at ovs build time, similar to a
> > number of other checks currently being done.
> >
> > $
On 21 December 2015 at 14:57, Pravin B Shelar wrote:
> I found this missing commit while checking diff against upstream OVS.
>
> Upstream Commit msg:
> Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside
> of a OVS_ACTION_ATTR_SET action attribute. When converting maske
On Tue, Nov 24, 2015 at 12:28 PM, Aaron Conole wrote:
> Commit 3544358aa596 ("datapath: Improve kernel hash table") removed the
> failure condition of ovs_vport_del by switching away from a custom
> hashtable which allocated a new bucket, to an hlist with flexible-array
> buckets. The function sto
On Mon, Dec 21, 2015 at 8:33 AM, Jesse Gross wrote:
> On Sun, Dec 20, 2015 at 8:05 PM, Pravin B Shelar wrote:
>> STT receive can accept packet on device which is not UP state.
>> Following patch fixes this issue by introducing another list
>> of devices which contains only devices in up state. Th
I found this missing commit while checking diff against upstream OVS.
Upstream Commit msg:
Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside
of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions
back to regular set actions, the inner attribute
On Mon, Dec 21, 2015 at 1:59 PM, Ben Pfaff wrote:
> On Mon, Dec 21, 2015 at 03:03:42PM -0500, Russell Bryant wrote:
> > On 12/21/2015 02:52 PM, Ben Pfaff wrote:
> > > On Mon, Dec 21, 2015 at 10:39:29AM -0500, Russell Bryant wrote:
> > >> On 12/21/2015 09:55 AM, Numan Siddique wrote:
> > >>> On 12
On Tue, Nov 24, 2015 at 03:28:35PM -0500, Aaron Conole wrote:
> Commit 3544358aa596 ("datapath: Improve kernel hash table") removed the
> failure condition of ovs_vport_del by switching away from a custom
> hashtable which allocated a new bucket, to an hlist with flexible-array
> buckets. The funct
On Sat, Dec 19, 2015 at 11:37:00AM -0500, Russell Bryant wrote:
> $ make check TESTSUITEFLAGS="-k pep8"
>
> Another option would be to run this part at ovs build time, similar to a
> number of other checks currently being done.
>
> $ grep 'ALL_LOCAL.*\-check' Makefile.am
> ALL_LOCAL += config-h-c
On Sat, Dec 19, 2015 at 11:38:51AM -0500, Russell Bryant wrote:
> On 12/19/2015 01:09 AM, Ben Pfaff wrote:
> > When the SSL code presents the name of the address to which it is bound,
> > it should include an "ssl:" or "pssl:" prefix instead of "tcp:" or "ptcp:".
> > This bug was introduced by comm
On Mon, Dec 21, 2015 at 03:03:42PM -0500, Russell Bryant wrote:
> On 12/21/2015 02:52 PM, Ben Pfaff wrote:
> > On Mon, Dec 21, 2015 at 10:39:29AM -0500, Russell Bryant wrote:
> >> On 12/21/2015 09:55 AM, Numan Siddique wrote:
> >>> On 12/21/2015 08:13 PM, Russell Bryant wrote:
> On 12/21/2015
On 21 December 2015 at 12:20, Anupam Chanda wrote:
> This change handles a corner case where local mac entries are not cleared
> if a
> vlan binding is deleted while the emulator is not running. The fix is to
> clean
> up the local mac entries once on restart.
>
> Reported-by: Hsin-Yi Shen
> Si
Also update the Python ovs package info to note that both Python 2 and 3
are supported.
Signed-off-by: Russell Bryant
---
NEWS| 3 +++
python/setup.py | 6 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 81f49e2..baa98e5 100644
--- a/NEWS
+++ b/
Add a configure script check for tox, so that we can conditionally run
it from 'make check'. Create tox.at which runs the py27, py34, and pep8
tox environments.
Signed-off-by: Russell Bryant
---
configure.ac | 1 +
m4/openvswitch.m4 | 14 ++
tests/atlocal.in | 1 +
tests/
Update these Python tests to run with both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/vlog.at | 174 +-
1 file changed, 99 insertions(+), 75 deletions(-)
diff --git a/tests/vlog.at b/tests/vlog.at
index 99565db..07d4811 100644
Update these Python tests to run with both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/unixctl-py.at | 198 +---
1 file changed, 111 insertions(+), 87 deletions(-)
diff --git a/tests/unixctl-py.at b/tests/unixctl-py.at
index 9ba7023..0
Convert these Python tests to run with both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/jsonrpc-py.at | 79 +++--
1 file changed, 47 insertions(+), 32 deletions(-)
diff --git a/tests/jsonrpc-py.at b/tests/jsonrpc-py.at
index 3d3bd3b..9
Update the reconnect tests to use both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/reconnect.at | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/reconnect.at b/tests/reconnect.at
index 9ebe183..c88ca78 100644
--- a/tests/reconnect.at
+++ b/tests/reconn
Update these Python tests to run with both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/daemon-py.at | 483 -
1 file changed, 260 insertions(+), 223 deletions(-)
diff --git a/tests/daemon-py.at b/tests/daemon-py.at
index cafa8df..e5
Update Python tests to run for both Python 2 and 3.
Signed-off-by: Russell Bryant
---
tests/library.at | 34 ++
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/tests/library.at b/tests/library.at
index d5dcb12..11a405b 100644
--- a/tests/library.at
Update Python tests to run for both Python 2 and Python 3.
Signed-off-by: Russell Bryant
---
tests/ovsdb-idl.at | 56 ++
1 file changed, 40 insertions(+), 16 deletions(-)
diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at
index ad780af..27b1
ovsdb.at includes some macros for running some identical test cases for
both C and Python. Update these macros to run the test case for both
Python 2 and 3. Retain the existing behavior for the direct use of the
_PY versions of these macros to only run against Python 2 without any
changes needed.
Update the tests in check-structs.at to run with both Python 2 and 3 if
available. The check-structs script is written in Python, though does
not use the ovs Python library. The script did require fixes in a
previous commit to make it Python 3 compatible, so this ensures that
compatibility remain
Run json.at tests for both Python 2 and 3 if available.
Signed-off-by: Russell Bryant
---
tests/json.at | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/tests/json.at b/tests/json.at
index 8846ac9..a4c40c8 100644
--- a/tests/json.at
+++ b/tests/json.at
@
The configure script already checked for Python 2 (>=2.7). Add another
check for Python 3 (>=3.4). This will be used later for automatically
running tests with Python 3 as well if available.
Signed-off-by: Russell Bryant
---
configure.ac | 1 +
m4/openvswitch.m4 | 42
Also fix minor style issues and add this script to the list of things
checked in the pep8 tox environment.
Signed-off-by: Russell Bryant
---
ofproto/ipfix-gen-entities | 70 +++---
python/tox.ini | 2 +-
2 files changed, 36 insertions(+), 36 d
Also fix some minor style issues and add this script to the list of
things checked in the pep8 tox environment.
Signed-off-by: Russell Bryant
---
python/tox.ini | 2 +-
.../usr_share_openvswitch_scripts_ovs-xapi-sync | 20 +++-
2 files
Also fix style issues found by the flake8 tool and add ovs-vtep to the
list of files checked in the pep8 tox environment.
Signed-off-by: Russell Bryant
---
python/tox.ini | 2 +-
vtep/ovs-vtep | 96 +-
2 files changed, 56 insertions(+), 4
Signed-off-by: Russell Bryant
---
debian/ovs-monitor-ipsec | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec
index d35ec46..1f1562d 100755
--- a/debian/ovs-monitor-ipsec
+++ b/debian/ovs-monitor-ipsec
@@ -
Remove an unused import and use "is None" instead of "== None".
Also add this script to the list of what's checked in the pep8 tox
environment.
Signed-off-by: Russell Bryant
---
debian/ovs-monitor-ipsec | 5 ++---
python/tox.ini | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
Also address style errors found by flake8 and add it to the list of
files checked in the pep8 tox environment.
Signed-off-by: Russell Bryant
---
python/tox.ini| 2 +-
utilities/ovs-pcap.in | 17 +++--
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/python/tox
Python 3 no longer supports __cmp__. Instead, we have to implement the
"rich comparison" operators. We implement __eq__ and __lt__ and use
functools.total_ordering to implement the rest.
In one case, no __cmp__ method was provided and instead relied on the
default behavior provided in Python 2.
Python 3 has separate types for strings and bytes. Python 2 used the
same type for both. We need to convert strings to bytes before writing
them out to a socket. We also need to convert data read from the socket
to a string.
Signed-off-by: Russell Bryant
---
python/ovs/jsonrpc.py | 10 +++
Comparing None to an integer worked in Python 2, but fails in Python 3.
Signed-off-by: Russell Bryant
---
python/ovs/reconnect.py | 2 +-
tests/test-reconnect.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/python/ovs/reconnect.py b/python/ovs/reconnect.py
index 39dd556
This test checks the output based on Python's string representation of
an array of two unicode strings. These strings have a "u" prefix in
Python 2, but not Python 3. In Python 3, all strings are unicode.
Use sed on the output to strip the "u" from Python 2 output when
checking for the expected
Make flake8 run clean against these. Also use isinstance() instead
of direct type comparisons.
Update the tox config to run flake8 against these files, as well.
Signed-off-by: Russell Bryant
---
python/tox.ini| 2 +-
tests/MockXenAPI.py | 3 +++
tests/test-daemon.py |
Add basic testing of the normal code path in the JSON parser.
This at least shows how to add more Python unit tests that validate the
code works on multiple Python versions. For things that are relatively
simple and Python specific, this seems like an easier way to add test
cases than autotest.
Apply fixes to the Python scripts in the main ovs test suite to make
them work with both Python 2 and Python 3. This makes use of the 'six'
module, but six is already a dependency for the ovs Python lib, which is
being used here.
Signed-off-by: Russell Bryant
---
tests/test-json.py | 18 ++
The ovsdb-doc utility uses the ovs Python library. This patch runs it
in the virtual Python environments (2.7 and 3.4) to ensure that it
completes successfully. This helped quickly expose some more bugs in
the Python 3 port.
The patch includes the addition of the -s/--silent option to ovsdb-doc,
I've hit several bugs in this Python 3 work where the fix was some code
needed to be converted to use isinstance(). This has been primarily
around deadling with the changes to unicode handling. Go ahead and
convert the rest of the direct type comparisons to use isinstance(), as
it could avoid a b
six.unichr() is equivalent to unichr() in Python 2
and chr() in Python 3.
Signed-off-by: Russell Bryant
---
python/ovs/json.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/ovs/json.py b/python/ovs/json.py
index a59a0c2..db74397 100644
--- a/python/ovs/json.py
+++ b/
sys.maxint does not exist in Python 3, as an int does not have a max
value anymore (except as limited by implementation details and system
resources).
sys.maxsize works as a reasonable substitute as it's the same as
sys.maxint. The Python 3.0 release notes have this to say:
The sys.maxint cons
StringIO.StringIO in Python 2 became io.StringIO in Python 3. Use
six.StringIO which is an alias for the two cases.
Signed-off-by: Russell Bryant
---
python/ovs/json.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/python/ovs/json.py b/python/ovs/json.py
index c1dcd63..f
Signed-off-by: Russell Bryant
---
build-aux/check-structs | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/build-aux/check-structs b/build-aux/check-structs
index f79f235..449fd41 100755
--- a/build-aux/check-structs
+++ b/build-aux/check-structs
@@ -1,5 +1,7 @@
#! /usr/
Python 2 had str and unicode. Python 3 only has str, which is always a
unicode string. Drop use of unicode with the help of six.text_type
(unicode in py2 and str in py3) and six.string_types ([str, unicode] in
py2 and [str] in py3).
Signed-off-by: Russell Bryant
---
python/ovs/db/data.py
Update xml2nroff to work with either Python 2 or Python 3. The changes
are minor and can be managed without the use of the six library.
For iterating a dict, we now use:
for k, v in subst.items():
This is the same as .iteritems() in Python 2. It's technically a little
less efficient for Py
Fix minor Python 3 compatibility issues. There was only one place where
we needed to adapt based on Python version. The inline implementation
of the set of valid string types seemed better than taking on the 'six'
dependency in this script since it's executed at ovs build time.
Signed-off-by: Ru
Fix build-aux/extract-ofp-* scripts to be compatible with both Python 2
and Python 3. The fixes do not require any new dependencies.
Signed-off-by: Russell Bryant
---
build-aux/extract-ofp-actions | 72 ++-
build-aux/extract-ofp-errors | 38 -
types.StringTypes does not exist in Python 3. We can use
six.string_types, instead.
Signed-off-by: Russell Bryant
---
python/ovs/unixctl/__init__.py | 4 +++-
python/ovs/unixctl/client.py | 5 +++--
python/ovs/unixctl/server.py | 3 +--
3 files changed, 7 insertions(+), 5 deletions(-)
diff
This code asserted that the callback argument was of type
types.FunctionType. It's more pythonic to just check that the argument
is callable, and not specifically that it's a function. There are other
ways to implement a callback than types.FunctionType.
Signed-off-by: Russell Bryant
---
pytho
Python 2 has both long and int types. Python 3 only has int, which
behaves like long.
In the case of needing a set of integer types, we can use
six.integer_types which includes int and long for Python 2 and just int
for Python 3.
We can convert all cases of long(value) to int(value), because as
Python 3 removed support for tuple parameter unpacking.
https://www.python.org/dev/peps/pep-3113/
Instead of:
def foo((a, b)):
print(a)
print(b)
you should do:
def foo(a_b):
a, b = a_b
print(a)
print(b)
but in both uses here, the values were nev
In Python 2, dict.items(), dict.keys(), and dict.values() returned a
list. dict.iteritems(), dict.iterkeys(), and dict.itervalues() returned
an iterator.
As of Python 3, dict.iteritems(), dict.itervalues(), and dict.iterkeys()
are gone. items(), keys(), and values() now return an iterator.
In t
Python 2 had range() and xrange(). xrange() is more efficient, but
behaves differently so range() was retained for compatibility. Python 3
only has range() and it behaves like Python 2's xrange().
Remove the one explicit use of xrange() and use six.moves.range() to
make sure we're using xrange()
The print statement from Python 2 is a function in Python 3. Enable
print function support for Python 2 and convert print statements to
function calls.
Signed-off-by: Russell Bryant
---
python/ovstest/rpcserver.py | 4 +++-
python/ovstest/tests.py | 36 +++-
Fix imports of xmlrpclib to be compatible with Python 3. Python 2 had
xmlrpclib (client) and SimpleXMLRPCServer (server). In Python 3, these
have been renamed to xmlrpc.client and xmlrpc.server.
The solution implemented here is to use the six library. It may seem
excessive for this particular i
Signed-off-by: Russell Bryant
---
python/ovs/dirs.py | 12
python/ovstest/tests.py | 12
2 files changed, 24 insertions(+)
diff --git a/python/ovs/dirs.py b/python/ovs/dirs.py
index 10571db..dae9288 100644
--- a/python/ovs/dirs.py
+++ b/python/ovs/dirs.py
@@ -1,3 +
Fix the following pep8 errors:
E201 whitespace after '('
E203 whitespace before ','
E226 missing whitespace around arithmetic operator
E231 missing whitespace after ':'
E241 multiple spaces after ':'
E251 unexpected spaces around keyword / parameter equals
E261 at least two spaces be
class Vlog now inherits from "object". This is a "new style" Python
class, which isn't new at all at this point. This was introduced back
in Python 2.x, and some Python 2 code won't work as expected without it.
In Python 3, this happens implicitly.
Signed-off-by: Russell Bryant
---
python/ovs/
Resolve pep8 errors:
E711 comparison to None should be 'if cond is None:'
The reason comparing against None with "is None" is preferred over
"== None" is because a class can define its own equality operator and
produce bizarre unexpected behavior. Using "is None" has a very
explicit meaning th
Resolve pep8 error:
E501 line too long (80 > 79 characters)
Signed-off-by: Russell Bryant
---
python/ovs/db/idl.py | 6 --
python/ovs/dirs.py| 10 +-
python/ovs/socket_util.py | 12
python/tox.ini| 2 +-
4 files changed, 18 insertions(+), 12
This code referred to "rows" where it meant to refer to "fetched_rows".
Signed-off-by: Russell Bryant
---
python/ovs/db/idl.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py
index 5e3466e..8d50f65 100644
--- a/python/ovs/db/idl.py
Resolve pep8 errors E302 and E303:
E302 expected 2 blank lines, found 1
E303 too many blank lines (3)
Signed-off-by: Russell Bryant
---
python/ovs/poller.py | 1 +
python/ovs/timeval.py | 3 +++
python/ovs/unixctl/__init__.py | 1 +
python/ovs/unixctl/server.py | 1 +
p
Signed-off-by: Russell Bryant
---
python/ovs/socket_util.py| 5 ++---
python/ovs/unixctl/client.py | 2 --
python/ovstest/vswitch.py| 3 ---
3 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/python/ovs/socket_util.py b/python/ovs/socket_util.py
index 3bd4750..a01c3aa 100644
-
PEP8 is the Python formatting standard. This test environment catches
cases where the code deviates from this standard. We exclude all of the
rules currently violated so we can start with a passing configuration.
They can be removed over time when they get cleaned up.
Signed-off-by: Russell Brya
tox is a tool for running Python tests in virtual Python environments.
This initial setup only attempts to install the ovs Python library in
both a virtual Python 2.7 environment and a virtual Python 3.4
environment. We also run the beginning of a test suite, which only
imports the code. This qui
v1:
- https://github.com/russellb/ovs/commits/python_submit_v1
I sent an RFC last Friday, but I was able to finish up the final tweaks
I wanted to make today, so it's ready for review.
This patch series ports the ovs Python library, as well as miscellaneous
Python scripts, to Python 3. The ser
From: Terry Wilson
This patch fixes just the Python 3 problems found by running:
python3 setup.py install
There are still many other issues to be fixed, but this is a start.
Signed-off-by: Terry Wilson
Signed-off-by: Russell Bryant
---
python/ovs/daemon.py | 31 -
Autotest keywords are helpful for running a subset of the test suite.
This patch makes it so you can run all OVN tests using the 'ovn'
keyword.
$ make check TESTSUITEFLAGS="-k ovn"
Signed-off-by: Russell Bryant
---
tests/ovn-controller-vtep.at | 1 +
tests/ovn-controller.at | 1 +
tests/
This change handles a corner case where local mac entries are not cleared if a
vlan binding is deleted while the emulator is not running. The fix is to clean
up the local mac entries once on restart.
Reported-by: Hsin-Yi Shen
Signed-off-by: Anupam Chanda
---
AUTHORS |1 +
vtep/ovs-vt
On 12/21/2015 02:52 PM, Ben Pfaff wrote:
> On Mon, Dec 21, 2015 at 10:39:29AM -0500, Russell Bryant wrote:
>> On 12/21/2015 09:55 AM, Numan Siddique wrote:
>>> On 12/21/2015 08:13 PM, Russell Bryant wrote:
On 12/21/2015 09:27 AM, Numan Siddique wrote:
What problem are you addressing here?
On Mon, Dec 21, 2015 at 10:39:29AM -0500, Russell Bryant wrote:
> On 12/21/2015 09:55 AM, Numan Siddique wrote:
> > On 12/21/2015 08:13 PM, Russell Bryant wrote:
> >> On 12/21/2015 09:27 AM, Numan Siddique wrote:
> >> What problem are you addressing here? It seems we would want the flows
> >> crea
"Traynor, Kevin" writes:
>> -Original Message-
>> From: Aaron Conole [mailto:acon...@redhat.com]
>> Sent: Friday, December 18, 2015 6:28 PM
>> To: dev@openvswitch.org
>> Cc: Flavio Leitner; Traynor, Kevin
>> Subject: [PATCH 4/5] lib/daemon: Move the user:group code up one level
>>
>> It w
"Traynor, Kevin" writes:
>> -Original Message-
>> From: Aaron Conole [mailto:acon...@redhat.com]
>> Sent: Friday, December 18, 2015 6:28 PM
>> To: dev@openvswitch.org
>> Cc: Flavio Leitner; Traynor, Kevin
>> Subject: [PATCH 3/5] netdev-dpdk: Autofill lcore coremask if absent
>>
>> The use
1 - 100 of 116 matches
Mail list logo
