[ovs-dev] Returned mail: Data format error

2016-01-19 Thread Post Office
The original message was received at Tue, 19 Jan 2016 11:29:31 +0300 from openvswitch.org [219.79.209.164] - The following addresses had permanent fatal errors - - Transcript of session follows - ... while talking to openvswitch.org.: 554

Re: [ovs-dev] [PATCH v3 3/3] netdev-dpdk: Autofill lcore coremask if absent

2016-01-19 Thread Qiu, Michael
On 1/14/2016 5:18 AM, Aaron Conole wrote: > The user has control over the DPDK internal lcore coremask, but this > parameter can be autofilled with a bit more intelligence. If the user > does not fill this parameter in, we use the lowest set bit in the > current task CPU affinity. Otherwise, we

Re: [ovs-dev] [PATCH 2/2] datapath-windows: Accept MPLS feature probe.

2016-01-19 Thread Alin Serdean
Hi Sorin, Thank you for the patch. Comments inlined. Alin. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis > Trimis: Monday, December 21, 2015 9:12 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 2/2] datapath-windows: Accept

[ovs-dev] RE

2016-01-19 Thread Margaret.Hoey
I got a donation for you, Email me for details via:: mr.ped...@qq.com Best Regards Mr. Pedro. ** This email is intended for the addressee named and may contain confidential information. If you are not the intended recipient, please delete it and notify the

Re: [ovs-dev] Testing experimenter match

2016-01-19 Thread Raul Suarez Marin
That's what I was looking for! Thank you Ben. Kind regards, Raúl 2016-01-18 0:21 GMT+01:00 Ben Pfaff : > You described the typical way that "make check" tests such things, for > cases where we had our doubts when we added a field. See, for example, > the tests "ofproto-dpif -

[ovs-dev] Query regarding tunnel parameters

2016-01-19 Thread niti Rohilla
Hi, I have a query regarding tunneling in OVS. I want to connect ovs with ODL (SDN Controller). I want to add flows from the odl to ovs to set tun_src and tun_dst parameters. Can somebody please help to understand which corresponding parameters should be sent from odl. Thanks Niti

Re: [ovs-dev] [PATCH 2/2] ovn: Fix localnet ports on the same chassis.

2016-01-19 Thread Russell Bryant
On 01/19/2016 10:27 AM, Kyle Mestery wrote: > On Mon, Jan 18, 2016 at 9:45 AM, Russell Bryant wrote: >> Multiple logical ports on the same chassis that were connected to the >> same physical network via localnet ports were not able to send packets >> to each other. This was

Re: [ovs-dev] [PATCH 14/41] ofp-errors: Add extension error codes for OF1.3+ property errors.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > Upcoming commits will introduce uses of the "property" message formats, > which are used in OF1.3 and especially in OF1.4+, in Nicira extension > messages for earlier versions of

Re: [ovs-dev] [PATCH 20/41] openflow: Remove unused (and not useful) property headers.

2016-01-19 Thread Jarno Rajahalme
One unintentional (?) blank line added, otherwise: Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > These are all just copies of the otherwise generic ofp_prop_header or > ofp_prop_experimenter. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH 18/41] ofp-prop: Add helpers for u8, be64/u64, flag, and UUID properties.

2016-01-19 Thread Jarno Rajahalme
Small nits below, Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > These will have users in upcoming commits. Unlike the previously > added helpers, there isn't any existing code that can immediately > use them. > > Signed-off-by:

[ovs-dev] Why do you think it became a symbol of male power?

2016-01-19 Thread Edith
96 Because v-vitamin really helps your desire! p{margin:10px 0;padding:0;} table{border-collapse:collapse;} h1,h2,h3,h4,h5,h6{display:block;margin:0;padding:0;} img,a img{border:0;height:auto;outline:none;text-decoration:none;}

Re: [ovs-dev] [PATCH v1 0/2] Accept zero TTL mask

2016-01-19 Thread Jesse Gross
On Thu, Jan 14, 2016 at 3:29 AM, Haggai Eran wrote: > These two patches allow passing tunnelled flows without a match on the > outer header TTL to the datapath. The first patch simply modifies ovs-dpctl > to pass along fields that don't have a mask set. The second patch

Re: [ovs-dev] [PATCH 09/41] openflow: Rename OF0.1-1.3 queue property constants.

2016-01-19 Thread Jarno Rajahalme
With a minor function naming question below: Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > At first glance, OF1.4 queue properties look a lot like those for OF1.0 > to OF1.3, but in fact their different padding makes them

Re: [ovs-dev] [PATCH 13/41] ofp-util: Improve function to emit a bitmap property.

2016-01-19 Thread Jarno Rajahalme
With a minor nit below: Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > The callers had some common code that could be reasonably encapsulated, so > this commit does so. > > Signed-off-by: Ben Pfaff > --- >

Re: [ovs-dev] [PATCH 16/41] ofp-prop: Add support for experimenter properties.

2016-01-19 Thread Jarno Rajahalme
With clarifications requested below: Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > --- > lib/ofp-prop.c | 98 +++-- > lib/ofp-prop.h | 57

Re: [ovs-dev] [PATCH 12/41] ofp-actions: Append in ofpacts_pull_openflow_actions(), instead of replace.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > An upcoming commit will have a need to parse actions incrementally, so this > change makes that easier to do. > > Signed-off-by: Ben Pfaff > --- > lib/ofp-actions.c | 20

Re: [ovs-dev] [PATCH 15/41] ofp-prop: New module for working with OpenFlow 1.3+ properties.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > Several OpenFlow 1.3+ messages use TLV-based properties that take a > common form. Until now, ofp-util has had some static functions for > dealing with properties. Because properties

Re: [ovs-dev] [PATCH 19/41] ofp-prop: New function ofpprop_put_zeros().

2016-01-19 Thread Jarno Rajahalme
With the bug fix below, Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > This will have additional users in later commits. > > Signed-off-by: Ben Pfaff > --- > lib/ofp-prop.c | 22 ++ >

Re: [ovs-dev] [PATCH 08/41] ofp-print: Improve formatting of queue stat requests and port_mods.

2016-01-19 Thread Jarno Rajahalme
There is still some inconsistency in using ‘=‘ vs. ‘:’ between a key and its value when printing different messages. Is there a reason for this? Nevertheless, Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > Without this,

Re: [ovs-dev] [PATCH 10/41] netdev-dummy: Add a dummy queue.

2016-01-19 Thread Jarno Rajahalme
With a question (or two) for clarification below: Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > Until now it's been pretty hard to properly test any of the queue support, > because the dummy network device doesn't have any queues.

Re: [ovs-dev] [PATCH 11/41] ovs-ofctl: Merge dump_stats_transaction() into dump_transaction().

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > The callers call dump_stats_transaction() for OFPST_* messages and > dump_transaction() for other messages, but the callee can easily > distinguish the two types, so this commit

Re: [ovs-dev] [PATCH 17/41] ofp-prop: Add generic functions for working with 16- and 32-bit properties.

2016-01-19 Thread Jarno Rajahalme
With minor questions below, Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > These will see increasing use in upcoming commits. > > Signed-off-by: Ben Pfaff > --- > include/openflow/openflow-1.4.h | 27 - >

Re: [ovs-dev] [PATCH 01/41] ofproto: Fix memory leak and memory exhaustion bugs in group_mod.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > In handle_group_mod() cases where adding a group failed, nothing freed the > list of buckets, causing a leak. The same was true in every case of > modifying a group. This commit fixes

Re: [ovs-dev] [PATCH 06/41] openflow-1.2: Remove unused struct definition.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > Experimenter stats are handled by code in ofp-msgs, and this struct isn't > good for anything. > > Signed-off-by: Ben Pfaff > --- > include/openflow/openflow-1.2.h | 9

Re: [ovs-dev] Is sparse checker working?

2016-01-19 Thread William Tu
Hi Ben, It see, thank you! William On Tue, Jan 19, 2016 at 9:31 AM, Ben Pfaff wrote: > On Tue, Jan 19, 2016 at 09:26:18AM -0800, William Tu wrote: > > I've installed sparse and cgcc and were playing with this tools. However, > > I'm not sure whether it's working in current

Re: [ovs-dev] [PATCH 07/41] pinsched: Remove obsolete ofpbuf_trim().

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > This call to ofpbuf_trim() comes from a time when the packets passed to > pinsched came directly from a dpif. For some time now that's no longer > true--now they are messages generated

Re: [ovs-dev] Is sparse checker working?

2016-01-19 Thread Ben Pfaff
I think that sparse defines that internally. On Tue, Jan 19, 2016 at 11:07:37AM -0800, William Tu wrote: > Hi Ben, > > When I do "make C=1", where and how does the "__CHECKER__" get set/defined? > I tried to dump preprocessor information "-dM -E" but I couldn't find any. > Thank you! > >

[ovs-dev] [PATCH v2 0/2] datapath-windows: MPLS support

2016-01-19 Thread Sorin Vinturis
This patch series adds support for MPLS to the OVS extension. Sorin Vinturis (2): [PATCH v2 1/2] datapath-windows: Support for OVS_KEY_ATTR_MPLS attribute [PATCH v2 2/2] datapath-windows: Accept MPLS feature probe. ___ dev mailing list

[ovs-dev] [PATCH v2 1/2] datapath-windows: Support for OVS_KEY_ATTR_MPLS attribute

2016-01-19 Thread Sorin Vinturis
This patch adds OVS_KEY_ATTR_MPLS to the OVS flow mechanism. Tested using ping. Tested using iperf (TCP and UDP). Tested using DriverVerifier. Signed-off-by: Sorin Vinturis --- Compared to the previous patch, the code regarding MPLS push actions was revised.

[ovs-dev] [PATCH v2 2/2] datapath-windows: Accept MPLS feature probe.

2016-01-19 Thread Sorin Vinturis
Currently all feature probe messages sent from userspace are suppressed by the OVS extension. This patch changes the current behaviour to allow feature probe for MPLS. Signed-off-by: Sorin Vinturis --- v2: Added NL buffer parsing in feature probe function. ---

Re: [ovs-dev] [PATCH 02/41] learning-switch: Use "if"s instead of "switch" to reduce maintenance.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > This code only cares about a very few kinds of OpenFlow messages, and it's > unlikely that it will care about new ones, so replace the "switch" by "if" > statements so that GCC won't

Re: [ovs-dev] [PATCH 05/41] ofp-util: Improve formatting of comment.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > --- > lib/ofp-util.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/ofp-util.h b/lib/ofp-util.h > index

Re: [ovs-dev] [PATCH 00/41] Implement "closures".

2016-01-19 Thread Jarno Rajahalme
FYI, I’ll review this series, Jarno > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > The purpose of this series is the final patch, which is important for > OVN and should also solve some problems that I've heard of in other > controllers over the years. > > Ben Pfaff

Re: [ovs-dev] Is sparse checker working?

2016-01-19 Thread William Tu
Hi Ben, When I do "make C=1", where and how does the "__CHECKER__" get set/defined? I tried to dump preprocessor information "-dM -E" but I couldn't find any. Thank you! Regards, William On Tue, Jan 19, 2016 at 9:43 AM, William Tu wrote: > Hi Ben, > > It see, thank you! >

Re: [ovs-dev] Group selection_method and hash

2016-01-19 Thread Ben Pfaff
The group hash selection extension is only for the OVS support for OpenFlow 1.5. On Tue, Jan 19, 2016 at 06:05:42PM +0100, Kashyap Thimmaraju wrote: > Hi Ben, > > Thank you for clarifying this. > > Is it that selecting the fields to hash is from OpenFlow15? > > Thanks, > > Kash > > On Tue,

Re: [ovs-dev] [PATCH 03/41] ofp-msgs: Fix definitions of OF1.4 OFPT_GET_ASYNC_REPLY and OFPT_SET_ASYNC.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > The structures declared in ofp-msgs.h for messages definitions should not > include an OpenFlow header (its presence is implied), but the definition of > these messages did. This commit

Re: [ovs-dev] [PATCH 00/41] Implement "closures".

2016-01-19 Thread Ben Pfaff
On Tue, Jan 19, 2016 at 10:56:27AM -0800, Jarno Rajahalme wrote: > FYI, > > I’ll review this series, Thanks! Feel free to ask any questions that might be helpful, or to review only the first few patches and ask for a rebase, etc. ___ dev mailing list

Re: [ovs-dev] [PATCH 24/41] ofp-util: Rewrite async config encoding and decoding to be table-driven.

2016-01-19 Thread Jarno Rajahalme
With a small nit below, Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > (snip) > +struct ofp14_async_prop { > +uint64_t prop_type; > +enum ofputil_async_msg_type oam; > +bool master; > +uint32_t allowed10, allowed14;

Re: [ovs-dev] [PATCH 31/41] openflow: Better abstract handling of packet-in messages.

2016-01-19 Thread Jarno Rajahalme
With two questions for clarification below, Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > (snip) > diff --git a/lib/ofp-util.c b/lib/ofp-util.c > index 347cb61..48e2e8e 100644 > --- a/lib/ofp-util.c > +++ b/lib/ofp-util.c > @@

Re: [ovs-dev] [PATCH 23/41] ofp-util: Define struct ofputil_async_cfg to hold async message config.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > This seems a little better than a pair of bare arrays. > > Signed-off-by: Ben Pfaff > --- > include/openflow/openflow-common.h | 24 ++- > lib/ofp-print.c

Re: [ovs-dev] [PATCH 33/41] hash: New helper functions hash_bytes32() and hash_bytes64().

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > All of the callers of hash_words() and hash_words64() actually find it > easier to pass in the number of bytes instead of the number of 32-bit > or 64-bit words. These new functions

Re: [ovs-dev] [PATCH 25/41] ofp-util: Fix OF1.4+ version of ofputil_decode_set_async_config().

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > The OF1.0 through OF1.3 "set async config" set the whole configuration, > OF1.4+ only update parts of it piecemeal, but the decoding function always > set the whole configuration. This

Re: [ovs-dev] [PATCH 27/41] ofp-print: Decode all async config messages the same way.

2016-01-19 Thread Jarno Rajahalme
Maybe the title should be “ofp-print: Print all async config messages the same way.” instead? Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > We have a single function to decode all of these messages, so there's no > reason to do it

Re: [ovs-dev] [PATCH 21/41] openflow: Implement OF1.4+ OFPMP_QUEUE_DESC multipart message.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > OpenFlow 1.0 through 1.3 have a message OFPT_QUEUE_GET_CONFIG_REQUEST and > its corresponding reply, for fetching a description of the queues > configured on a given port. OpenFlow 1.4

Re: [ovs-dev] [PATCH 32/41] connmgr: Generalize ofproto_packet_in to ofproto_async_msg.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > An upcoming commit will add another kind of asynchronous message that > should be handled in the same way as packet-ins. > > Signed-off-by: Ben Pfaff > --- >

Re: [ovs-dev] [PATCH 22/41] ofp-util: New function ofputil_async_msg_type_to_string().

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > An upcoming commit will add another user. > > Signed-off-by: Ben Pfaff > --- > lib/ofp-print.c | 27 ++- > lib/ofp-util.c | 17 + >

Re: [ovs-dev] [PATCH 29/41] fail-open: Drop some of the weirder special cases.

2016-01-19 Thread Jarno Rajahalme
I never understood this special case anyway, Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > I don't have any real evidence that these special cases make a difference > in real-world cases. The messages for the commits that add them

Re: [ovs-dev] [PATCH 30/41] pktbuf: Move from 'ofproto' to 'lib'.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > An upcoming commit will use this library from ofp-util instead of ofproto. > > Signed-off-by: Ben Pfaff > --- > lib/automake.mk | 4 +++- > {ofproto =>

[ovs-dev] 丈夫被冤狱迫害致死 郴州退休教师母子控告江泽民

2016-01-19 Thread dfgd dffg
丈夫被冤狱迫害致死 郴州退休教师母子控告江泽民 【明慧网二零一五年十二月二十五日】谢丽萍,五十岁,湖南省郴州资兴鲤鱼江电厂子弟学校退休教师,儿子贺思源,二十一岁,学生,家住湖南省郴州市。丈夫贺雪兆与谢丽萍同在一所学校教书,一家人同修大法,其乐融融。 然而,江氏集团开始迫害法轮功后,谢丽萍和丈夫贺雪兆屡遭绑架和关押,二零零六年,被非法判刑八年的贺雪兆被迫害致死。 二零一五年八月九日,谢丽萍和儿子贺思源通过网络举报迫害法轮功的元凶江泽民,希望民众了解他们一家以及更多法轮功学员被迫害的真相。

Re: [ovs-dev] [PATCH 28/41] openflow: Get rid of struct ofp13_packet_in.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > It's actually harder to parse OF1.2/OF1.3 "packet-in" messages when > ofp13_packet_in is involved than when the code just realizes that > ofp13_packet_in = ofp12_packet_in + cookie. > >

Re: [ovs-dev] Query regarding tunnel parameters

2016-01-19 Thread niti Rohilla
Hi Ben, Thanks for the reply. It means that tun_src and tun_dst parameters in ovs cannot be configured from ODL, as there is no corresponding OXM field defined for tun_src and tun_dst in Openflow specifications. I have looked into the code, for tun_src and tun_dst only NXM fields are defined but

[ovs-dev] [PATCH v9 4/7] userspace: add layer 3 flow and switching support

2016-01-19 Thread Simon Horman
From: Lorand Jakab This commit relaxes the assumption that all packets have an Ethernet header, and adds support for layer 3 flows. For each packet received on the Linux kernel datapath the l2 and l3 members of struct ofpbuf are intialized appropriately, and some functions

[ovs-dev] [PATCH v9 7/7] userspace: add non-tap (l3) support to GRE vports

2016-01-19 Thread Simon Horman
Add support for layer 3 GRE vports (non-tap aka non-VTEP). This makes use of a separate vport type for GRE, rather than a new mode for the existing (tap/VTEP) GRE vports as this fits more naturally with the kernel where implementation of GRE and thus implementation of this feature there. In

[ovs-dev] [PATCH v9 5/7] userspace: add layer 3 support to packet metadata

2016-01-19 Thread Simon Horman
From: Lorand Jakab This is needed for sending a packet back to the datapath after a miss upcall was processed. The presence of a layer 2 packet is signaled by adding OVS_KEY_ATTR_ETHERNET to the packet metadata sent with the ovs_packet netlink message. Layer 3 packets need

[ovs-dev] [PATCH v9 6/7] userspace: extend layer 3 support to cover non-IP packets

2016-01-19 Thread Simon Horman
Extend support for layer 3 packets to cover non-IP packets. This removes the assumption that the first octet of a layer 3 packet indicates the IP protocol version - true for IP (v4 and v6), but not for necessarily for other protocols. The key motivation for this is to allow forwarding of MPLS

Re: [ovs-dev] [PATCH 01/41] ofproto: Fix memory leak and memory exhaustion bugs in group_mod.

2016-01-19 Thread Ben Pfaff
Thanks. I applied this to master, branch-2.5, and branch-2.4. On Tue, Jan 19, 2016 at 11:25:03AM -0800, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > > > In handle_group_mod() cases where adding a

Re: [ovs-dev] [PATCH 2/2] ovn: Fix localnet ports on the same chassis.

2016-01-19 Thread Han Zhou
Hi Russell, On Mon, Jan 18, 2016 at 7:45 AM, Russell Bryant wrote: > > Multiple logical ports on the same chassis that were connected to the > same physical network via localnet ports were not able to send packets > to each other. This was because ovn-controller created a

[ovs-dev] [PATCH v9 0/7] Support for layer 3 ports/flows

2016-01-19 Thread Simon Horman
This series implements support for layer 3 ports. By removing the assumption that all packets/flows have Ethernet header, this series adds generic support for layer 3 ports in OVS. Support for layer 3 GRE tunnels is also added by this patchset. The implementation automatically adds appropriate

[ovs-dev] [PATCH v9 1/7] flow: add miniflow_push_uint8

2016-01-19 Thread Simon Horman
The motivation is to allow pushing single bytes in a manner to that already used for 16, 32 and 64 bit integers. This will be used by a follow-up patch to allow layer 3 packet - that is packets without an ethernet header - to be represented in flows. Signed-off-by: Simon Horman

[ovs-dev] [PATCH v9 3/7] userspace: add support for pop_eth and push_eth actions

2016-01-19 Thread Simon Horman
From: Lorand Jakab These actions will allow L2->L3 and L3->L2 switching, and are supposed to be added to flows installed in the datapath transparently by ovs-vswitchd. Signed-off-by: Lorand Jakab Signed-off-by: Simon Horman

[ovs-dev] [PATCH v9 2/7] flow: add miniflow_pad_from_64

2016-01-19 Thread Simon Horman
Provide leading padding to allow pushing a value to a miniflow where the value is not aligned to 64 bytes and no value has already been pushed to the same word. This will be used by a follow-up patch to allow layer 3 packet - that is packets without an ethernet header - to be represented in

[ovs-dev] [PATCH] rhel: provide our own SELinux custom policy package

2016-01-19 Thread Ansis Atteka
CentOS, RHEL and Fedora distributions ship with their own Open vSwitch SELinux policy that is too strict and prevents Open vSwitch to work normally out of the box. As a solution, this patch introduces a new package which will "loosen" up "openvswitch_t" SELinux domain so that Open vSwitch could

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Move local_datapaths calculation.

2016-01-19 Thread Han Zhou
On Mon, Jan 18, 2016 at 7:45 AM, Russell Bryant wrote: > > Before this patch, physical.c build up the set of local datapaths for > its own use. I'd like to use it in another module in a later patch, so > pull it out of physical. It's now populated by the bindings module, >

Re: [ovs-dev] [PATCH 07/41] pinsched: Remove obsolete ofpbuf_trim().

2016-01-19 Thread Ben Pfaff
Thanks for the reviews. I applied patches 2 through 7 to master. On Tue, Jan 19, 2016 at 11:44:30AM -0800, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > > > This call to ofpbuf_trim() comes from a time

[ovs-dev] You have the trainning now get the Degree to match

2016-01-19 Thread Alvaro Yates
BECAUSE YOU DESERVE IT! Is your lack of a degree holding you back from career advancement? Are you having difficulty finding employment in your field of interest because you don’t have the paper to back it up – even though you are qualified? If you are looking for a fast and effective

Re: [ovs-dev] [PATCH v3 3/3] netdev-dpdk: Autofill lcore coremask if absent

2016-01-19 Thread Aaron Conole
"Qiu, Michael" writes: > On 1/14/2016 5:18 AM, Aaron Conole wrote: >> The user has control over the DPDK internal lcore coremask, but this >> parameter can be autofilled with a bit more intelligence. If the user >> does not fill this parameter in, we use the lowest set bit

[ovs-dev] How OVN do SNAT/DNAT/VPN

2016-01-19 Thread Na Zhu
Hi, Can anyone tell me how OVN will support SNAT/DNAT and VPN in the future? In OVN, there is no use of neutron l3 agent, it uses native router for east-west traffic, this is distributed and already supported. But for SNAT/DNAT/VPN, currently still need l3 agent. What is your schedule about no

Re: [ovs-dev] How OVN do SNAT/DNAT/VPN

2016-01-19 Thread Russell Bryant
On 01/19/2016 08:32 AM, Na Zhu wrote: > Hi, > > Can anyone tell me how OVN will support SNAT/DNAT and VPN in the future? > In OVN, there is no use of neutron l3 agent, it uses native router for > east-west traffic, this is distributed and already supported. But for > SNAT/DNAT/VPN, currently

Re: [ovs-dev] [PATCH 1/2] datapath-windows: Support for OVS_KEY_ATTR_MPLS attribute

2016-01-19 Thread Alin Serdean
Hi Sorin, Thanks for the patch. Comments inlined. Alin. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis > Trimis: Monday, December 21, 2015 9:12 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 1/2] datapath-windows: Support for

Re: [ovs-dev] [PATCH 2/2] ovn: Fix localnet ports on the same chassis.

2016-01-19 Thread Kyle Mestery
On Mon, Jan 18, 2016 at 9:45 AM, Russell Bryant wrote: > Multiple logical ports on the same chassis that were connected to the > same physical network via localnet ports were not able to send packets > to each other. This was because ovn-controller created a single patch > port

Re: [ovs-dev] [PATCH 1/2] datapath-windows: Support for OVS_KEY_ATTR_MPLS attribute

2016-01-19 Thread Sorin Vinturis
Hi Alin, Thanks for reviewing my patch. Please see my answers to your comments inline. -Sorin -Original Message- From: Alin Serdean Sent: Tuesday, 19 January, 2016 14:28 To: Sorin Vinturis; dev@openvswitch.org Subject: RE: [PATCH 1/2] datapath-windows: Support for OVS_KEY_ATTR_MPLS

Re: [ovs-dev] [PATCH v2] ipv6 tunneling: Fix for performance drop introduced by ipv6 tunnel support.

2016-01-19 Thread Thadeu Lima de Souza Cascardo
On Thu, Jan 14, 2016 at 01:27:45PM +, Sugesh Chandran wrote: > Adding a new field called dl_type in flow tunnel structure to verify the > validity > of tunnel metadata. This field avoids the need of resetting and validating the > entire ipv4/ipv6 tunnel destination address which caused a

Re: [ovs-dev] [PATCH 2/2] datapath-windows: Accept MPLS feature probe.

2016-01-19 Thread Sorin Vinturis
Hi Alin, Thanks for reviewing this patch. Please see my answers inline. -Sorin -Original Message- From: Alin Serdean Sent: Tuesday, 19 January, 2016 12:29 To: Sorin Vinturis; dev@openvswitch.org Subject: RE: [PATCH 2/2] datapath-windows: Accept MPLS feature probe. Hi Sorin, Thank you

Re: [ovs-dev] [PATCH 26/41] ofp-util: Add function to encode OFPT_SET_ASYNC messages.

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > This isn't used yet but it will be in future commits. > > This also looks forward to supporting Open vSwitch extensions to OAM_*, > which will be coming up soon. > > Signed-off-by: Ben

[ovs-dev] [PATCH] ofproto-dpif-xlate: Don't consider mirrors used when excluded by VLAN.

2016-01-19 Thread Ben Pfaff
Mirroring is supposed to happen at most once for any destination on a given packet, so the implementation keeps track of which mirrors have already been used. However, until this commit it did that incorrectly: it considered a mirror "used" even if it had been rejected on the basis of VLAN. This

Re: [ovs-dev] question about mirror code

2016-01-19 Thread Ben Pfaff
On Sat, Jan 16, 2016 at 02:21:03PM +0800, hanxueluo wrote: > Hi, guys I have a question about the code below in function > "mirror_packet". Some mirrors in "mirrors" may be skipped because the > select_vlan doesn't match ("if (vlans && !bitmap_is_set(vlans, > vlan)"), but they may be useful for

Re: [ovs-dev] Group selection_method and hash

2016-01-19 Thread Ben Pfaff
On Mon, Jan 18, 2016 at 04:09:00PM +0100, Kashyap Thimmaraju wrote: > I would like to use the hash selection_method that OvS supports but with > OpenFlow13. > > Could someone tell me the fields that are used as the input to the hash > function for OpenFlow13 in OvS? The default is a hash that

Re: [ovs-dev] Query regarding tunnel parameters

2016-01-19 Thread Ben Pfaff
On Tue, Jan 19, 2016 at 05:24:49PM +0530, niti Rohilla wrote: > I have a query regarding tunneling in OVS. > > I want to connect ovs with ODL (SDN Controller). I want to add flows from > the odl to ovs to set tun_src and tun_dst parameters. Can somebody please > help to understand which

Re: [ovs-dev] Group selection_method and hash

2016-01-19 Thread Kashyap Thimmaraju
Hi Ben, Thank you for clarifying this. Is it that selecting the fields to hash is from OpenFlow15? Thanks, Kash On Tue, Jan 19, 2016 at 6:02 PM, Ben Pfaff wrote: > On Mon, Jan 18, 2016 at 04:09:00PM +0100, Kashyap Thimmaraju wrote: > > I would like to use the hash

Re: [ovs-dev] [PATCH 2/2] ovs-bugtool: Add OVN/VTEP db and schema files

2016-01-19 Thread Ben Pfaff
On Fri, Jan 15, 2016 at 04:05:27PM -0800, William Tu wrote: > Add ovn-nb.{db,ovsschema}, ovn-sb.{db,ovsschema}, and vtep.{db,ovsschema} > > Signed-off-by: William Tu Can we do this with a plugin, so that non-OVN installations don't have this code?

Re: [ovs-dev] [PATCH 1/2] ovs-bugtool: Add OVN commands to bugtool plugin scripts.

2016-01-19 Thread Ben Pfaff
On Fri, Jan 15, 2016 at 04:05:26PM -0800, William Tu wrote: > Add ovn-nbctl show, ovn-sbctl show, and ovn-sbctl lflow-list. > > Signed-off-by: William Tu I think that we should probably start a new ovn/utilities/bugtool directory for these, so that they can easily be

[ovs-dev] [PATCH v3] ipv6 tunneling: Fix for performance drop introduced by ipv6 tunnel support.

2016-01-19 Thread Sugesh Chandran
Adding a new field called dl_type in flow tunnel structure to verify the validity of tunnel metadata. This field avoids the need of resetting and validating the entire ipv4/ipv6 tunnel destination address which caused a serious performance drop. Fixes: 3ae91c019019 ("tunneling: add IPv6 support

[ovs-dev] Is sparse checker working?

2016-01-19 Thread William Tu
Hi, I've installed sparse and cgcc and were playing with this tools. However, I'm not sure whether it's working in current version of OVS. The acinclude.m4 indeed sets the SPARSE related flags. After I do "./configure", the Makefile shows: CC = $(if $(C),env REAL_CC="gcc" CHECK="$(SPARSE) -I

Re: [ovs-dev] Is sparse checker working?

2016-01-19 Thread Ben Pfaff
On Tue, Jan 19, 2016 at 09:26:18AM -0800, William Tu wrote: > I've installed sparse and cgcc and were playing with this tools. However, > I'm not sure whether it's working in current version of OVS. > > The acinclude.m4 indeed sets the SPARSE related flags. After I do > "./configure", the