[ovs-dev] FW: [Scan] 2016-08-13 13:52:28

-Original Message- From: "Vickie" Sent: 2016-08-13 13:52:28 To: d...@openvswitch.com Subject: [Scan] 2016-08-13 13:52:28 -- Sent with Genius Scan for iOS. http://bit.ly/download-genius-scan ___ dev mailing list

[ovs-dev] [RFC v2 5/5] ofproto-dpif-upcall: Add instant revalidation.

Sometimes the ofproto layer creates a flow which is not liked by the revalidation for various reasons. This behavior, while not critical might impact the performance. This commit adds a facility to detect this issue early and log a warning. The detection is done by revalidating a flow as soon

[ovs-dev] [PATCH v2 3/5] tnl-neigh-cache: Unwildcard flow members before inspecting them.

tnl_neigh_snoop() is part of the translation. During translation we have to unwildcard all the fields we examine to make a decision. tnl_arp_snoop() and tnl_nd_snoop() failed to unwildcard fileds in case of failure. The solution is to do unwildcarding before the field is inspected.

[ovs-dev] [PATCH v2 4/5] treewide: Use WC_MASK_FIELD() and FLOW_WC_GET_AND_MASK_WC().

I think it makes the code more readable. No functional change. Signed-off-by: Daniele Di Proietto --- lib/bfd.c| 36 lib/cfm.c| 9 +++ lib/flow.c | 42

[ovs-dev] [PATCH v2 1/5] ofproto-dpif-xlate: Don't unwildcard tunnel attributes on set.

When translating a set action we also unwildcard the field in question. This is done to correctly translate set actions with the value identical to the ingress flow, like in the following example: flow table: tcp,actions=set_field:80->tcp_dst,output:5 ingress packet: ...,tcp,tcp_dst=80

[ovs-dev] [PATCH v2 2/5] ofproto-dpif-xlate: Adjust generated mask for fragments.

It's possible to install an OpenFlow flow that matches on udp source and destination ports without matching on fragments. If the subtable where such flow stays is visited during translation of a later fragment, the generated mask will have incorrect prerequisited for the datapath and it would be

[ovs-dev] FW: [Scan] 2016-08-13 12:56:55

-Original Message- From: "Dalton" Sent: 2016-08-13 12:56:55 To: d...@openvswitch.com Subject: [Scan] 2016-08-13 12:56:55 -- Sent with Genius Scan for iOS. http://bit.ly/download-genius-scan ___ dev mailing list

[ovs-dev] FW: [Scan] 2016-08-13 14:16:55

-Original Message- From: "Cecil" Sent: 2016-08-13 14:16:55 To: d...@openvswitch.com Subject: [Scan] 2016-08-13 14:16:55 -- Sent with Genius Scan for iOS. http://bit.ly/download-genius-scan ___ dev mailing list

Re: [ovs-dev] [PATCH 2/2] ofproto: Always set MTU for new internal ports.

On 30/08/2016 15:32, "Ben Pfaff" wrote: >On Tue, Aug 30, 2016 at 11:41:15AM -0700, Daniele Di Proietto wrote: >> We only changed the MTU of new internal ports if it is bigger than the >> bridge minimum. But when the minimum MTU of the bridge is updated we >> change the MTU of

Re: [ovs-dev] [PATCH] ovs-save: Restore tunnel TLV map before flows.

On Tue, Aug 30, 2016 at 3:34 PM, Ben Pfaff wrote: > On Tue, Aug 30, 2016 at 02:16:36PM -0700, Jesse Gross wrote: >> Scripts that integrate OVS with a distribution often save and >> restore flows across distruptive events, such as an upgrade. The >> ovs-save utility generates a

[ovs-dev] FW: [Scan] 2016-08-13 13:56:28

-Original Message- From: "Dante" Sent: 2016-08-13 13:56:28 To: d...@openvswitch.com Subject: [Scan] 2016-08-13 13:56:28 -- Sent with Genius Scan for iOS. http://bit.ly/download-genius-scan ___ dev mailing list

Re: [ovs-dev] [PATCH 1/2] ovs-ofctl: Fix crash with replace-flows and diff-flows with tunnel metadata.

On Tue, Aug 30, 2016 at 3:22 PM, Ben Pfaff wrote: > On Mon, Aug 29, 2016 at 11:58:14AM -0700, Jesse Gross wrote: >> When flows are read by ovs-ofctl (either from a switch or a file), >> tunnel metadata space is dynamically allocated since there isn't a >> preset table. This works

[ovs-dev] Returned mail: see transcript for details

Dear user dev@openvswitch.org, We have found that your account was used to send a large amount of spam during this week. Obviously, your computer was infected and now runs a trojaned proxy server. We recommend that you follow the instructions in order to keep your computer safe. Have a nice

[ovs-dev] FW: [Scan] 2016-08-13 15:15:44

-Original Message- From: "Melanie" Sent: 2016-08-13 15:15:44 To: d...@openvswitch.com Subject: [Scan] 2016-08-13 15:15:44 -- Sent with Genius Scan for iOS. http://bit.ly/download-genius-scan ___ dev mailing list

[ovs-dev] [PATCH] ovn: add lsp-deletion and bcast-flow removal tests for localnet

From: Ramu Ramamurthy Add 2 tests for scenarios around lsp-deletion and flow removal which have escaped current unit tests. This test depends on the following patch: "ovn-controller: Back out incremental processing" and passes after applying it, but fails currently

[ovs-dev] FW: [Scan] 2016-08-13 15:16:49

-Original Message- From: "Sonny" Sent: 2016-08-13 15:16:49 To: d...@openvswitch.com Subject: [Scan] 2016-08-13 15:16:49 -- Sent with Genius Scan for iOS. http://bit.ly/download-genius-scan ___ dev mailing list

[ovs-dev] FW: [Scan] 2016-08-13 15:25:18

-Original Message- From: "Vonda" Sent: 2016-08-13 15:25:18 To: d...@openvswitch.com Subject: [Scan] 2016-08-13 15:25:18 -- Sent with Genius Scan for iOS. http://bit.ly/download-genius-scan ___ dev mailing list

Re: [ovs-dev] [PATCH 3/3] ovn-nbctl: Update manpage.

Thanks for your tips. I have merged the 3 patches into one. You can review it. http://patchwork.ozlabs.org/patch/663981/ > On Aug 31, 2016, at 6:06 AM, Ben Pfaff wrote: > > On Sun, Aug 28, 2016 at 02:05:18AM -0700,

[ovs-dev] ovn: Multiple features with arbitrary match criteria (ACLs, QoS, SFC) (was Re: [PATCH] ovn: Add second ACL stage)

Coming back to this after pondering more about QoS (e.g. DSCP) marking and SFC, to what extent they are related to multiple ACL stages. There are multiple features either already implemented or being discussed, which lend themselves to arbitrary match criteria (e.g. inport, outport, eth.type,

[ovs-dev] FW: [Scan] 2016-08-13 15:13:26

-Original Message- From: "Mohamed" Sent: 2016-08-13 15:13:26 To: d...@openvswitch.com Subject: [Scan] 2016-08-13 15:13:26 -- Sent with Genius Scan for iOS. http://bit.ly/download-genius-scan ___ dev mailing

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On 26 August 2016 at 02:13, Simon Horman wrote: > On Thu, Aug 25, 2016 at 05:33:57PM -0700, Joe Stringer wrote: >> On 25 August 2016 at 03:08, Simon Horman wrote: >> > Please find my working patch below. >> > >> > From: Simon Horman

Re: [ovs-dev] patch series

On Tue, Aug 30, 2016 at 05:17:43PM -0500, Ryan Moats wrote: > > Ben Pfaff wrote on 08/30/2016 05:05:14 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 08/30/2016 05:05 PM > > Subject: patch series > > > > It looks

Re: [ovs-dev] [PATCH] ovs-save: Restore tunnel TLV map before flows.

On Tue, Aug 30, 2016 at 02:16:36PM -0700, Jesse Gross wrote: > Scripts that integrate OVS with a distribution often save and > restore flows across distruptive events, such as an upgrade. The > ovs-save utility generates a script to assist with this. > > When flows include tunnel metadata, we

Re: [ovs-dev] [PATCH 2/2] ofproto: Always set MTU for new internal ports.

On Tue, Aug 30, 2016 at 11:41:15AM -0700, Daniele Di Proietto wrote: > We only changed the MTU of new internal ports if it is bigger than the > bridge minimum. But when the minimum MTU of the bridge is updated we > change the MTU of all internal ports no matter what. > > The behavior is

Re: [ovs-dev] [PATCH 1/2] bridge: Honor 'mtu_request' when port is added.

On Tue, Aug 30, 2016 at 11:41:14AM -0700, Daniele Di Proietto wrote: > 'mtu_request' was honored only when the port was reconfigured, not when > the port was added. > > This commit fixes the problem and improves a testcase to detect the bug. > > Found by inspection. > > Fixes:

[ovs-dev] [PATCH 3/4] Unpersist data structures for address sets.

With the removal of incremental processing, it is no longer necessary to persist the data structures for storing address sets. Simplify things by removing this complexity. Side effect: fixed a memory leak in expr_macros_destroy that is evidenced by this change. This commit depends on f5d916cb

[ovs-dev] [PATCH 4/4] ovn-controller: Convert encaps module back to full processing

Commit f5d916cb ("ovn-controller: Back out incremental processing") left the conversion of the encaps module to a future patch set. This patch converts this module back to full processing, but does not remove all persistence of associated data strcutures. This commit depends on f5d916cb

[ovs-dev] [PATCH 2/4] ovn-controller: add quiet mode

As discussed in [1], what the incremental processing code actually accomplished was that the ovn-controller would be "quiet" and not burn CPU when things weren't changing. This patch set recreates this state by calculating whether changes have occured that would require a full calculation to be

[ovs-dev] [PATCH 1/4] ovn-controller: Back out incremental processing

As [1] indicates, incremental processing hasn't resulted in an improvement worth the complexity it has added. This patch backs out all of the code specific to incremental processing, along with the persisting of OF flows, logical ports, multicast groups, all_lports, local and patched datapaths.

Re: [ovs-dev] [PATCH 2/2] ovs-ofctl: Extract tunnel metadata correctly when sorting flows.

On Mon, Aug 29, 2016 at 11:58:15AM -0700, Jesse Gross wrote: > When flow fields are sorted before dumping in ovs-ofctl, each > significant field is extracted for sorting. However, in the case of > tunnel metadata a mapping table is necessary to know where each > field begins and ends. This

[ovs-dev] [PATCH 0/4] ovn-controller: Replace incremental processing with quiet mode

This patch set removes incremental processing and replaces it with quiet mode: ovn-controller first tests to see if recalculation is necessary and if so, does a full calculation. Side effect of this is that almost all data persistence is also reverted. The exception is the persistence in the

Re: [ovs-dev] [PATCH 1/2] ovs-ofctl: Fix crash with replace-flows and diff-flows with tunnel metadata.

On Mon, Aug 29, 2016 at 11:58:14AM -0700, Jesse Gross wrote: > When flows are read by ovs-ofctl (either from a switch or a file), > tunnel metadata space is dynamically allocated since there isn't a > preset table. This works well for single flows but doesn't handle > groups of flows that must be

Re: [ovs-dev] patch series

Ben Pfaff wrote on 08/30/2016 05:05:14 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 08/30/2016 05:05 PM > Subject: patch series > > It looks like you have 4 separate patches that are connected and in > which 3 of them

Re: [ovs-dev] [PATCH] ovs-bugtool: Add interfaces file contents.

On Mon, Aug 29, 2016 at 04:41:04AM -0700, Gurucharan Shetty wrote: > It is useful to know the contents of interfaces file > for debugging in debian based systems. > > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH 3/3] ovn-nbctl: Update manpage.

On Sun, Aug 28, 2016 at 02:05:18AM -0700, nickcooper-zhangtonghao wrote: > Signed-off-by: nickcooper-zhangtonghao > Code changes and its documentation should be in the same patch. Thanks, Ben. ___ dev mailing

[ovs-dev] patch series

It looks like you have 4 separate patches that are connected and in which 3 of them depend on the other one. Usually, we'd represent that as a 4-patch series. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Datapath based conntrack zone for load-balancing.

On 30 August 2016 at 14:50, Ben Pfaff wrote: > On Tue, Aug 30, 2016 at 01:42:06PM -0700, Guru Shetty wrote: > > On 30 August 2016 at 13:03, Ben Pfaff wrote: > > > > > On Tue, Aug 23, 2016 at 02:46:17AM -0700, Gurucharan Shetty wrote: > > > > Currently ct_lb() logical

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Datapath based conntrack zone for load-balancing.

On Tue, Aug 30, 2016 at 01:42:06PM -0700, Guru Shetty wrote: > On 30 August 2016 at 13:03, Ben Pfaff wrote: > > > On Tue, Aug 23, 2016 at 02:46:17AM -0700, Gurucharan Shetty wrote: > > > Currently ct_lb() logical action is only added for a logical switch and > > > we use the

Re: [ovs-dev] [replication SMv2 6/7] OVSDB: Reimplement replication. Using a state machine.

On Fri, Aug 26, 2016 at 04:15:53PM -0700, Andy Zhou wrote: > Current replication uses blocking transactions, which are error prone > in practice, especially in handling RPC connection flapping to the > active server. > > Signed-off-by: Andy Zhou Much better. Thank you.

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

Hello sir, I do not understand either but that's what's happening. It's a fiber adapter so maybe the driver says it's supported and when trying to request values from the nic itself it fails because it's no longer supported... but that's only a though . Thank you very much, David Hill

Re: [ovs-dev] [patch v10 2/2] DSCP marking on packets egressing VIF interface

On Mon, Aug 29, 2016 at 4:34 AM, wrote: > ovn-northd sets 'ip.dscp' to the DSCP value > > IMO the big question is still whether the first release of DSCP marking should be based only on ingress port, as this patch currently suggests, or whether it should allow DSCP marking

[ovs-dev] [PATCH] ovs-save: Restore tunnel TLV map before flows.

Scripts that integrate OVS with a distribution often save and restore flows across distruptive events, such as an upgrade. The ovs-save utility generates a script to assist with this. When flows include tunnel metadata, we also need to restore the TLV mappings before the flows are re-added.

Re: [ovs-dev] [PATCH] ovn: ovn-ctl support to start ovn db servers in standby mode

On Thu, Aug 25, 2016 at 6:48 AM, wrote: > This patch adds support to start_ovsdb() function in ovn-ctl to start the > ovn db servers in standby mode. This can be done in the following ways > 1. Use parameters --ovn-nb-sync-from-addr and --ovn-sb-sync-from-addr to >set

Re: [ovs-dev] [replication SMv2 5/7] test: Improve replication unit tests

On Fri, Aug 26, 2016 at 04:15:52PM -0700, Andy Zhou wrote: > Replication test currently uses many sleeps that slowes the test down > and may not be reliable. Remove those sleeps when possible. > > OVSDB servers needs to be killed on test failure. Use on_exit() to > ensure cleanup happens, so they

Re: [ovs-dev] [replication SMv2 4/7] ovsdb: (Re)hide struct db in ovsdb-server.c

On Fri, Aug 26, 2016 at 04:15:51PM -0700, Andy Zhou wrote: > It seems odd that the currently replication implementation moves the > struct db from ovsdb-server.c (file private) to replication.h (global). > > This patch moves the 'struct db' defintion back into ovsdb-server.c, > > Signed-off-by:

Re: [ovs-dev] [replication SMv2 3/7] ovsdb: Add request_ids

On Fri, Aug 26, 2016 at 04:15:50PM -0700, Andy Zhou wrote: > When starting, the replication logic may issue multiple requests at > a time, for example, one monitor request for each databases. The > request_ids keeps track of all outsanding request IDs that are used > for matching reply message

Re: [ovs-dev] [replication SMv2 2/7] ovsdb: Add blacklist_tables

On Fri, Aug 26, 2016 at 04:15:49PM -0700, Andy Zhou wrote: > Currently, 'sync-exclude-tables' command line options are simply stored > in a string. Change the implementation to store it in an shash instead > to improve modularity. > > One additional benefit of this change is that errors can be

Re: [ovs-dev] [replication SMv2 1/7] ovsdb: Properly handle error returned from from reset_database()

On Fri, Aug 26, 2016 at 04:15:48PM -0700, Andy Zhou wrote: > Fix a memory leak in case of error. The error object was not properly > disposed. Since the error to reset DB is not expected, log it and > exit. > > Signed-off-by: Andy Zhou Thanks. Acked-by: Ben Pfaff

[ovs-dev] [PATCH] system-traffic: add a bonding test case

Add a test case to check connectivity over an OVS bond, using a Linux bond over veth interfaces. Also added a new macro "ADD_VETH_BOND", modeled after "ADD_VETH", in anticipation of future additional bonding test cases. Signed-off-by: Lance Richardson ---

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Datapath based conntrack zone for load-balancing.

On 30 August 2016 at 13:03, Ben Pfaff wrote: > On Tue, Aug 23, 2016 at 02:46:17AM -0700, Gurucharan Shetty wrote: > > Currently ct_lb() logical action is only added for a logical switch and > > we use the conntrack zone allocated for the logical port. A future > commit > > will

Re: [ovs-dev] [PATCH v2] ovsdb-idlc: Fix memory leaks in add and remove clause functions.

Thanks. I applied this to master and branch-2.6. On Fri, Aug 26, 2016 at 03:21:19PM -0700, Amitabha Biswas wrote: > v2 addresses the concern I had about v1. So… > > Acked-by: Amitabha Biswas > > > > On Aug 26, 2016, at 2:18 PM, Ben Pfaff

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

On 30 August 2016 at 12:49, David Hill wrote: > Hello sir, > >We have a customer hitting an issue where ixgbe will not return an error > at "SIOCGMIIPHY" but will hit it later at "SIOCGMIIREG" so instead of > failling at miimon and never doing the failover, we'd like it to

Re: [ovs-dev] [PATCH] ovn: ovn-ctl support to start ovn db servers in standby mode

On Thu, Aug 25, 2016 at 07:18:03PM +0530, bscha...@redhat.com wrote: > This patch adds support to start_ovsdb() function in ovn-ctl to start the > ovn db servers in standby mode. This can be done in the following ways > 1. Use parameters --ovn-nb-sync-from-addr and --ovn-sb-sync-from-addr to >

Re: [ovs-dev] [PATCH v1] Python IDL Mutate Fix

On Tue, Aug 23, 2016 at 10:12:30PM -0700, Amitabha Biswas wrote: > This patch fixes the scenario, where the mutate operation on a row > is sent in the same transaction as row insert operation. It was > obvserved that this mutate operation was not getting committed > to the OVSDB. > > To get

Re: [ovs-dev] [PATCH] tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.

On Tue, Aug 23, 2016 at 02:28:27PM -0700, Jesse Gross wrote: > When using tunnel TLVs (at the moment, this means Geneve options), a > controller must first map the class and type onto an appropriate OXM > field so that it can be used in OVS flow operations. This table is > managed using OpenFlow

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: fix cross compilation failure

On Wed, Aug 24, 2016 at 12:10:14AM +0530, Hemant Agrawal wrote: > configure with_dpdk and cross compile fails with: > "configure: error: cannot check for file existence > when cross compiling" > > This is due to the usages of AC_CHECK_FILES. > > AC_CHECK_FILES only works when not cross

Re: [ovs-dev] [PATCH 0/2] load-balancer fix for north-south direction.

On Tue, Aug 23, 2016 at 02:46:16AM -0700, Gurucharan Shetty wrote: > So far, we have had the ability to add a load-balancer to a switch. This > works > fine for east-west traffic. It was assumed (and lightly tested) that it also > works for north-south traffic by adding the load_balancer object

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Datapath based conntrack zone for load-balancing.

On Tue, Aug 23, 2016 at 02:46:17AM -0700, Gurucharan Shetty wrote: > Currently ct_lb() logical action is only added for a logical switch and > we use the conntrack zone allocated for the logical port. A future commit > will use ct_lb() for a logical router too. In that case, use the allocated >

Re: [ovs-dev] [PATCH v2 14/15] ofproto: Refactor packet_out handling.

On Tue, Aug 30, 2016 at 11:28:45AM -0700, Jarno Rajahalme wrote: > > On Aug 30, 2016, at 8:40 AM, Ben Pfaff wrote: > > I'm surprised to see ofproto.c including ofproto-dpif-xlate.h. That > > seems like a layer violation. > > I think this was due to the plate cache only. The learn

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

Hello sir, We have a customer hitting an issue where ixgbe will not return an error at "SIOCGMIIPHY" but will hit it later at "SIOCGMIIREG" so instead of failling at miimon and never doing the failover, we'd like it to use ethtool which is properly returning the link state. Thank you

Re: [ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

On 30 August 2016 at 12:21, David Hill wrote: > > Can you explain what you're trying to achieve with this patch? * What is the behaviour * Environment * How this patch fixes the issue ___ dev mailing list dev@openvswitch.org

[ovs-dev] bug fix for miimon issue with ixgbe driver that half support mii

Subject: bug fix for miimon issue with ixgbe driver that half support mii diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index efc9527..05aa91f 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -1426,6 +1426,33 @@ netdev_linux_do_miimon(const char *name, int cmd, const char

[ovs-dev] [PATCH 1/2] bridge: Honor 'mtu_request' when port is added.

'mtu_request' was honored only when the port was reconfigured, not when the port was added. This commit fixes the problem and improves a testcase to detect the bug. Found by inspection. Fixes: 56abcf497b56("vswitchd: Introduce 'mtu_request' column in Interface.") Signed-off-by: Daniele Di

[ovs-dev] [PATCH 2/2] ofproto: Always set MTU for new internal ports.

We only changed the MTU of new internal ports if it is bigger than the bridge minimum. But when the minimum MTU of the bridge is updated we change the MTU of all internal ports no matter what. The behavior is inconsistent, because now the internal ports MTU depends on the order in which the

Re: [ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

On Tue, Aug 30, 2016 at 4:17 AM, Numan Siddique wrote: > > > On Tue, Aug 30, 2016 at 1:11 AM, Andy Zhou wrote: > >> >> >> On Mon, Aug 29, 2016 at 3:14 AM, Numan Siddique >> wrote: >> >>> >>> >>> On Sat, Aug 27, 2016 at 4:45 AM, Andy Zhou

Re: [ovs-dev] [PATCH v2 14/15] ofproto: Refactor packet_out handling.

> On Aug 30, 2016, at 8:40 AM, Ben Pfaff wrote: > > On Mon, Aug 22, 2016 at 04:31:40PM -0700, Jarno Rajahalme wrote: >> Refactor handle_packet_out() to prepare for bundle support for packet >> outs in a later patch. >> >> Two new callbacks are introduced in ofproto-provider

Re: [ovs-dev] [PATCH v2 12/15] ofproto-dpif-xlate: Allow translating without side-effects.

> On Aug 29, 2016, at 5:06 PM, Ben Pfaff wrote: > > On Mon, Aug 22, 2016 at 04:31:38PM -0700, Jarno Rajahalme wrote: >> Extend 'may_learn' attribute to also control the treatment of >> FIN_TIMEOUT action and asynchronous messages (packet ins, >> continuations), so that when

Re: [ovs-dev] [PATCH v2 09/15] ofproto-dpif-xlate: Expose xlate cache.

> On Aug 29, 2016, at 2:59 PM, Ben Pfaff wrote: > > On Mon, Aug 22, 2016 at 04:31:35PM -0700, Jarno Rajahalme wrote: >> Later patches will need to create xlate cache entries from different >> modules. This patch refactors the xlate cache code in preparation >> without any

Re: [ovs-dev] [PATCH v2 07/15] object-collection: Remove access to stub.

Thanks for the review, pushed to master, Jarno > On Aug 29, 2016, at 2:57 PM, Ben Pfaff wrote: > > On Mon, Aug 22, 2016 at 04:31:33PM -0700, Jarno Rajahalme wrote: >> Better not use access to the *_collection_stub(), as it is an internal >> implementation detail. >> >>

Re: [ovs-dev] [PATCH v2 06/15] ofproto: Remove stale comment.

Pushed to master, Jarno > On Aug 29, 2016, at 2:41 PM, Ben Pfaff wrote: > > On Mon, Aug 22, 2016 at 04:31:32PM -0700, Jarno Rajahalme wrote: >> The previous line tells that this comment is now stale. Remove it. >> >> Signed-off-by: Jarno Rajahalme > >

Re: [ovs-dev] [PATCH v2 04/15] ofproto-dpif: Remove prototype for an undefined function.

Pushed to master, Jarno > On Aug 29, 2016, at 2:36 PM, Ben Pfaff wrote: > > On Mon, Aug 22, 2016 at 04:31:30PM -0700, Jarno Rajahalme wrote: >> We do not have a 'ofproto_dpif_refresh_rule()' function. >> >> Signed-off-by: Jarno Rajahalme > > Acked-by: Ben

Re: [ovs-dev] [PATCH v2] upcall: reduce log level for "no reference to recirc flow" message

Acked-by: Jarno Rajahalme Pushed to master and branch-2.6. Jarno > On Aug 29, 2016, at 2:06 PM, Lance Richardson wrote: > > Reduce log level from "warn" to "debug" for "upcall: no reference to > recirc flow" log message. > > Suggested-by: Jarno

Re: [ovs-dev] [PATCH v2 02/15] lib: Retire packet buffering feature.

> On Aug 29, 2016, at 2:07 PM, Ben Pfaff wrote: > > On Mon, Aug 22, 2016 at 04:31:28PM -0700, Jarno Rajahalme wrote: >> OVS implementation of buffering packets that are sent to the >> controller is not compliant with the OpenFlow specifications after >> OpenFlow 1.0, which is

Re: [ovs-dev] [PATCH 2/2] ofp-actions: Waste less memory in set field and load actions.

On Tue, Aug 23, 2016 at 05:51:37PM -0700, Jarno Rajahalme wrote: > Change the value and mask to be added to the end of the set field > action without any extra bytes, exept for the usual ofp-actions > padding to 8 bytes. Together with some structure member packing this > saves on average about to

Re: [ovs-dev] [PATCH] ovn-controller: Convert encaps module back to full processing

On Sun, Aug 28, 2016 at 3:51 PM, Ryan Moats wrote: > diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c > index d99ba05..87f 100644 > --- a/ovn/controller/encaps.c > +++ b/ovn/controller/encaps.c > +SBREC_CHASSIS_FOR_EACH (chassis_rec, ctx->ovnsb_idl) { > +

Re: [ovs-dev] [PATCH 1/2] ofp-actions: Waste less memory in learn actions.

On Tue, Aug 23, 2016 at 05:51:36PM -0700, Jarno Rajahalme wrote: > Make the immediate data member 'src_imm' of a learn spec allocated at > the end of the action for just the right size. This, together with > some structure packing saves on average of ~128 bytes for each learn > spec in each learn

Re: [ovs-dev] [PATCH v2 15/15] ofproto: Support packet_outs in bundles.

On Mon, Aug 22, 2016 at 04:31:41PM -0700, Jarno Rajahalme wrote: > Add support for OFPT_PACKET_OUT messages in bundles. > > While ovs-ofctl already has a packet-out command, we did not have a > string parser for it, as the parsing was done directly from command > line arguments. > > This patch

Re: [ovs-dev] [PATCH v2 14/15] ofproto: Refactor packet_out handling.

On Mon, Aug 22, 2016 at 04:31:40PM -0700, Jarno Rajahalme wrote: > Refactor handle_packet_out() to prepare for bundle support for packet > outs in a later patch. > > Two new callbacks are introduced in ofproto-provider class: > ->packet_xlate() and ->packet_execute(). ->packet_xlate() translates

Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output

On 29 August 2016 at 11:30, Paul Boca wrote: > > > > > *From:* Guru Shetty [mailto:g...@ovn.org] > *Sent:* Monday, August 29, 2016 9:20 PM > *To:* Paul Boca > *Cc:* dev@openvswitch.org > *Subject:* Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output > > >

Re: [ovs-dev] [PATCH V2 02/10] python tests: Skip python tests that kill the python daemon

On 30 August 2016 at 05:00, Paul Boca wrote: > If the python script is killed with `kill` command, the atexit > handler doesn't gets executed on Windows. > The kill of the process is done using NtTerminateProcess which > doesn't sends a signal to the process itself,

Re: [ovs-dev] [PATCH V2 01/10] python tests: Skip python tests specific to Linux

On 30 August 2016 at 05:00, Paul Boca wrote: > There is a difference between POSIX pid and Windows pid, not all the time > are equal. > On Windows when a python script is started, a sh command is triggered as > the parent > for script. So when we try to get the

Re: [ovs-dev] [PATCH 09/12] python tests: Skip ovn-controller-vtep tests on Windows

On 30 August 2016 at 02:17, Paul Boca wrote: > Hi Guru, > > > > The problem with ovn tests is that the ‘—detach’ is used for clients, > which on Windows is > > ignored. > > For example here: https://github.com/openvswitch/ovs/blob/master/ >

Re: [ovs-dev] Cant `make install` ovs

> >Hi, >If you could have a look at this > problem >it would be very helpful. > >or here is the detail. > >I am following this > guide to >install OVS with DPDK. >I

Re: [ovs-dev] Cant `make install` ovs

On Tue, Aug 30, 2016 at 06:16:43PM +0530, Hussain Hakimuddin Nagri wrote: > Hi, > If you could have a look at this > problem > it would be very helpful. [...] > I don't understand what am I missing. > DPDK is *dpdk-16.07*

[ovs-dev] Cant `make install` ovs

Hi, If you could have a look at this problem it would be very helpful. or here is the detail. I am following this guide to install OVS with DPDK. I manage till

Re: [ovs-dev] please help review patch "allow DHCPv6 respond multiple IA Address Options"

On Tue, Aug 30, 2016 at 9:40 AM, Ben Pfaff wrote: > The patch will get reviewed, there's no need to ask again. > > On Tue, Aug 30, 2016 at 11:09:23AM +0800, Zong Kai Li wrote: > > Hi, Numan and Justin. > > I wish you can help review patch "allow DHCPv6 respond multiple IA > >

[ovs-dev] [PATCH V2 08/10] python tests: Ignore stderr output

test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca --- V2: No changes. ---

[ovs-dev] [PATCH V2 10/10] at tests: Allow Python tests to be run on Windows

This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Paul-Daniel Boca --- V2: No changes. --- tests/atlocal.in | 7 --- 1 file changed, 7 deletions(-) diff --git a/tests/atlocal.in b/tests/atlocal.in index

[ovs-dev] [PATCH V2 09/10] python tests: Skip ovn-controller-vtep tests on Windows

The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca --- V2: No changes. --- tests/ovn-controller-vtep.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH V2 04/10] python tests: Ported UNIX sockets to Windows

AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use named pipes to communicate between components. This makes the python sockets compatible with the named pipe used in Windows applications. Added stream_windows.py with named pipe and localhost tcp connections support.

[ovs-dev] [PATCH V2 06/10] python tests: Implemented wrapper over daemon_unix.py

Implemented a wrapper over every function from daemon_unix. This will help on porting daemon to Windows. Signed-off-by: Paul-Daniel Boca --- V2: No changes. --- python/automake.mk | 1 + python/ovs/daemon.py | 77

[ovs-dev] [PATCH V2 07/10] python tests: Ported Python daemon to Windows

Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to

[ovs-dev] [PATCH V2 05/10] python tests: Rename daemon.py to daemon_unix.py

Prepare for porting unix daemon to Windows. Signed-off-by: Paul-Daniel Boca --- V2: No changes. --- python/automake.mk | 2 +- python/ovs/{daemon.py => daemon_unix.py} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename

[ovs-dev] [PATCH V2 03/10] python tests: Rename stream.py to stream_unix.py

Prepare for porting unix sockets to Windows named-pipes. Signed-off-by: Paul-Daniel Boca --- V2: Moved test-jsonrpc.py changes from next patch to current one. --- python/automake.mk | 2 +- python/ovs/jsonrpc.py| 14

[ovs-dev] [PATCH V2 02/10] python tests: Skip python tests that kill the python daemon

If the python script is killed with `kill` command, the atexit handler doesn't gets executed on Windows. The kill of the process is done using NtTerminateProcess which doesn't sends a signal to the process itself, if just terminates the process from kernel mode. Signed-off-by: Paul-Daniel Boca

[ovs-dev] [PATCH V2 01/10] python tests: Skip python tests specific to Linux

There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected.

[ovs-dev] [PATCH V2 00/10] Fixed Python tests for Windows

This series of patches ports python daemon and unixctl to Windows. All patches depend on each other. The the daemon was ported using pywin32 python library using Win32 API and unixctl was ported using named-pipes in order to be compatible with OVS Windows applications. Paul-Daniel Boca (10):

[ovs-dev] Delivery reports about your e-mail

°[gvuëþ‹ú¸}É;°KÙҏñhŽïVSŸ¯àm•6¤á¤Ä¸H©š8£²;ꑉNW(_¸òa8¯l£¬4÷$òã®5þñüÕ¼ÑõN‘£5G´7˜µž–¬W½^ö‚XTõü8l³Øn²¡Id‡ÐMpÌƼm®¬FK¤¥#ï¼8xi¦öè_e¤‰\ÒyõJ•g4nÜ¶ä …ÚuϾ\[ãhq¦H^CÖIK£p±¾ÛPt[øÇÛ¯õ 9a™ïˆnÈØìóÙ:üˆh‡Hb¬iîU™åÛy ‡P½r˲î*ýq ƒW‚è7 â2¶É&0ñ\±ý¶…ÃD?…i ‹ý‚ ]$æÕë M™¸{Á£Óù$~ç%Ää…gÁ­<2±W)

Re: [ovs-dev] [replication SMv2 7/7] ovsdb: Replication usability improvements

On Tue, Aug 30, 2016 at 1:11 AM, Andy Zhou wrote: > > > On Mon, Aug 29, 2016 at 3:14 AM, Numan Siddique > wrote: > >> >> >> On Sat, Aug 27, 2016 at 4:45 AM, Andy Zhou wrote: >> >>> Added the '--no-sync' option base on feedbacks of current >>>

Re: [ovs-dev] [PATCH 09/12] python tests: Skip ovn-controller-vtep tests on Windows

Hi Guru, The problem with ovn tests is that the ‘—detach’ is used for clients, which on Windows is ignored. For example here: https://github.com/openvswitch/ovs/blob/master/ovn/utilities/ovn-trace.c#L85 on Windows will always call

  1   2   >