Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-03 Thread Mickey Spiegel
On Thu, Nov 3, 2016 at 6:06 PM, Guru Shetty wrote: > > 2. If a stateful action such as DNAT or LB is taken on a > > gateway router, such that it is necessary for the reverse > > packet flow to come back to the same gateway router, > > then there should be an SNAT

Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-03 Thread Guru Shetty
> On Nov 3, 2016, at 7:16 PM, Mickey Spiegel wrote: > > See reply at the bottom. > >> On Thu, Nov 3, 2016 at 6:06 PM, Guru Shetty wrote: >> >> >> >> > It seems to me that the root of the problem has to do with >> > three issues: >> > 1. SNAT (and

Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-03 Thread Mickey Spiegel
See reply at the bottom. On Thu, Nov 3, 2016 at 6:06 PM, Guru Shetty wrote: > It seems to me that the root of the problem has to do with > > three issues: > > 1. SNAT (and DNAT) rules should not apply to ct.rpl traffic, > > instead only UNSNAT (and UNDNAT) rules should

Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-03 Thread Guru Shetty
> On Nov 3, 2016, at 4:34 PM, Mickey Spiegel wrote: > > Interesting problem. See comments inline. > >> On Thu, Nov 3, 2016 at 3:46 AM, Gurucharan Shetty wrote: >> >> When multiple gateway routers exist, a packet can >> enter any gateway router. Once the

Re: [ovs-dev] [PATCH 23/23] doc: Convert vswitchd/INTERNALS to rST

2016-11-03 Thread Russell Bryant
On Sun, Oct 30, 2016 at 2:30 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > lib/mac-learning.c | 3 +- > lib/mac-learning.h | 2 +- > vswitchd/INTERNALS | 239 -- > -- >

[ovs-dev] Coallescing of monitor notifications

2016-11-03 Thread Dennis Sam
Hi folks, After upgrading to 2.5.x, we noticed that monitor notifications can now coalesce multiple transactions. Can this be confirmed as new behaviour and that transactions are indeed being coalesced and not simply combined? Example 1: T0 Add A with uuid 0 T1 Del A with uuid 0 T2 Add B with

Re: [ovs-dev] [PATCH 14/23] doc: Convert INSTALL.SELinux to rST

2016-11-03 Thread Russell Bryant
On Sun, Oct 30, 2016 at 2:30 PM, Stephen Finucane wrote: > Refer to 'dnf' and not the deprecated 'yum'. > > Signed-off-by: Stephen Finucane > --- > INSTALL.SELinux.md | 173 -- > - > INSTALL.SELinux.rst |

Re: [ovs-dev] [PATCH 09/23] doc: Convert INSTALL.Fedora to rST

2016-11-03 Thread Russell Bryant
On Sun, Oct 30, 2016 at 2:29 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > INSTALL.Fedora.md | 130 --- > INSTALL.Fedora.rst | 144 ++ > +++

Re: [ovs-dev] [PATCH v2] release: Propose a shorter release cycle for 2.7.

2016-11-03 Thread Russell Bryant
On Thu, Nov 3, 2016 at 10:46 PM, Justin Pettit wrote: > > > On Nov 3, 2016, at 10:06 AM, Russell Bryant wrote: > > > > diff --git a/Documentation/release-process.md b/Documentation/release- > process.md > > index 0f8f49d..fcbd174 100644 > > ---

Re: [ovs-dev] [PATCH 3/3 v5] Windows: document multiple NIC support setup

2016-11-03 Thread Sairam Venugopal
Hi Alin, We had discussed this over IRC, will you be adding some more example to the documentation? Mainly around internal devices? Thanks, Sairam On 9/13/16, 11:13 AM, "Alin Serdean" wrote: >This patch updates the documentation on how to set up OVS with

Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-03 Thread Mickey Spiegel
Interesting problem. See comments inline. On Thu, Nov 3, 2016 at 3:46 AM, Gurucharan Shetty wrote: > When multiple gateway routers exist, a packet can > enter any gateway router. Once the packet reaches its > destination, its reverse direction should be via the > same gateway

Re: [ovs-dev] [PATCH 3/5 v2] datapath-windows: clean code in gre

2016-11-03 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 10/27/16, 11:55 AM, "Alin Serdean" wrote: >The purpose of this patch is to make the code more readable and >fix a static analyzer warning. > >Signed-off-by: Alin Gabriel Serdean

Re: [ovs-dev] [PATCH 1/5 v2] datapath-windows: clean code in vxlan

2016-11-03 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 10/27/16, 11:53 AM, "Alin Serdean" wrote: >The purpose of this patch is to make the code more readable and >fix a static analyzer warning. > >Signed-off-by: Alin Gabriel Serdean

Re: [ovs-dev] [PATCH 2/5 v2] datapath-windows: clean code in stt

2016-11-03 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 10/27/16, 11:55 AM, "Alin Serdean" wrote: >The purpose of this patch is to make the code more readable and >fix a static analyzer warning. > >Signed-off-by: Alin Gabriel Serdean

Re: [ovs-dev] [PATCH 4/5 v2] datapath-windows: clean code in geneve

2016-11-03 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 10/27/16, 11:57 AM, "Alin Serdean" wrote: >The purpose of this patch is to make the code more readable and >fix a static analyzer warning. > >Signed-off-by: Alin Gabriel Serdean

Re: [ovs-dev] [PATCH v2] release: Propose a shorter release cycle for 2.7.

2016-11-03 Thread Justin Pettit
> On Nov 3, 2016, at 10:06 AM, Russell Bryant wrote: > > diff --git a/Documentation/release-process.md > b/Documentation/release-process.md > index 0f8f49d..fcbd174 100644 > --- a/Documentation/release-process.md > +++ b/Documentation/release-process.md > @@ -88,9 +88,9 @@ of

[ovs-dev] [PATCH 2/3] ovn: Ability to skip some IP addresses for SNAT.

2016-11-03 Thread Gurucharan Shetty
We currently have the ability to add a large network to match on the source IP address of a packet and then SNAT it to a external_ip. For e.g. one could add a SNAT rule that SNATs all packets with source IP address of "0.0.0.0/0" to 10.1.1.10. It is useful to make a small subnet to pass-through

[ovs-dev] [PATCH 1/3] logical-fields: Add ct.dnat and ct.snat symbols.

2016-11-03 Thread Gurucharan Shetty
Upcoming commits use it. Signed-off-by: Gurucharan Shetty --- ovn/lib/logical-fields.c | 2 ++ ovn/ovn-sb.xml | 19 +-- tests/ovn.at | 4 +++- 3 files changed, 22 insertions(+), 3 deletions(-) diff --git a/ovn/lib/logical-fields.c

Re: [ovs-dev] [PATCH 06/23] doc: Convert rhel/README.RHEL to rST

2016-11-03 Thread Russell Bryant
On Sun, Oct 30, 2016 at 2:29 PM, Stephen Finucane wrote: > This is a top-level document, so plain old rST is preferred. > > Signed-off-by: Stephen Finucane > --- > INSTALL.Fedora.md | 2 +- > INSTALL.RHEL.md | 6 +- >

Re: [ovs-dev] [PATCH 06/23] doc: Convert rhel/README.RHEL to rST

2016-11-03 Thread Russell Bryant
On Thu, Nov 3, 2016 at 8:50 PM, Russell Bryant wrote: > > On Sun, Oct 30, 2016 at 2:29 PM, Stephen Finucane > wrote: > >> This is a top-level document, so plain old rST is preferred. >> >> Signed-off-by: Stephen Finucane >> --- >>

Re: [ovs-dev] [PATCH 05/23] doc: Convert OVSDB-replication to rST

2016-11-03 Thread Russell Bryant
On Sun, Oct 30, 2016 at 2:29 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > Documentation/OVSDB-replication.md | 152 --- > Documentation/OVSDB-replication.rst | 172 ++ >

Re: [ovs-dev] [PATCH 02/23] doc: Convert committer-grant-revocation to rST

2016-11-03 Thread Russell Bryant
On Sun, Oct 30, 2016 at 2:29 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > Documentation/automake.mk| 2 +- > Documentation/committer-grant-revocation.md | 356 > >

Re: [ovs-dev] [PATCH 04/23] doc: Convert release-process to rST

2016-11-03 Thread Russell Bryant
On Sun, Oct 30, 2016 at 2:29 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > Documentation/automake.mk | 2 +- > Documentation/release-process.md | 99 > Documentation/release-process.rst |

Re: [ovs-dev] [PATCH v2] doc: Convert DESIGN to rST

2016-11-03 Thread Russell Bryant
On Sun, Oct 30, 2016 at 2:15 PM, Stephen Finucane wrote: > This is a top-level document, so plain old rST is preferred. > > Signed-off-by: Stephen Finucane > --- > v2: > - Split the OF message table into multiple tables > - Resolve some issues with table

Re: [ovs-dev] [PATCH v2] release: Propose a shorter release cycle for 2.7.

2016-11-03 Thread Ben Pfaff
On Thu, Nov 03, 2016 at 01:06:00PM -0400, Russell Bryant wrote: > OVS recently adopted a six month release cycle. OVS doesn't > have to align to other projects, but it can be beneficial. > The dates for OVS 2.6 aligned very well to OpenStack, > which is a major consumer of OVS that usually does 6

Re: [ovs-dev] [PATCH 00/23] Convert next batch of docs to rST

2016-11-03 Thread Joe Stringer
On 3 November 2016 at 03:33, Stephen Finucane wrote: > On 2016-11-02 17:57, Joe Stringer wrote: >> >> On 30 October 2016 at 06:29, Stephen Finucane wrote: >>> >>> This is the third conversion series. This one is larger yet again, >>> though many of the docs

Re: [ovs-dev] [PATCH] ovn-nb: Document the syntax for an address set name.

2016-11-03 Thread Russell Bryant
On Wed, Nov 2, 2016 at 5:57 PM, Ben Pfaff wrote: > On Fri, Oct 07, 2016 at 09:00:13AM -0700, Ben Pfaff wrote: > > Also, it is not necessary to specify that the name must be unique because > > the schema documentation generator does that for us. > > > > Reported-by: Kevin Lin

[ovs-dev] [PATCH v2] release: Propose a shorter release cycle for 2.7.

2016-11-03 Thread Russell Bryant
OVS recently adopted a six month release cycle. OVS doesn't have to align to other projects, but it can be beneficial. The dates for OVS 2.6 aligned very well to OpenStack, which is a major consumer of OVS that usually does 6 month releases. OpenStack is doing a short release cycle for its Ocata

Re: [ovs-dev] [PATCH v2] ovn: Add a case of policy based routing.

2016-11-03 Thread Guru Shetty
On 2 November 2016 at 09:29, Ben Pfaff wrote: > On Wed, Nov 02, 2016 at 09:28:44AM -0700, Ben Pfaff wrote: > > On Thu, Oct 06, 2016 at 03:53:12AM -0700, Gurucharan Shetty wrote: > > > OVN currently supports multiple gateway routers (residing on > > > different chassis) connected to

Re: [ovs-dev] [PATCH ovs V1 0/9] Introducing HW offload support for openvswitch

2016-11-03 Thread Or Gerlitz
On 11/3/2016 3:19 PM, Simon Horman wrote: Am I right in thinking that the current implementation only allows offloading flows that output to one port? If so I'd like to hear your thoughts on how that restriction might be lifted. We are using the TC mirred action. For forwarding to multiple

Re: [ovs-dev] [PATCH ovs V1 0/9] Introducing HW offload support for openvswitch

2016-11-03 Thread Simon Horman
Hi Paul, thanks for this very interesting work. I hope we can see offload support present in OvS in the not too distant future. Looking over the patches I have a few high-level comments: * Please run the code through ./utilities/checkpatch.py * Please consider referring to flower or tc-flower

Re: [ovs-dev] [PATCH 00/23] Convert next batch of docs to rST

2016-11-03 Thread Stephen Finucane
On 2016-11-02 17:57, Joe Stringer wrote: On 30 October 2016 at 06:29, Stephen Finucane wrote: This is the third conversion series. This one is larger yet again, though many of the docs are rather small. After this series, only the two tutorial docs in 'tutorial' require

[ovs-dev] [RFC v2 5/5] ovn: distributed NAT flows

2016-11-03 Thread Mickey Spiegel
This patch implements the flows required in the ingress and egress pipeline stages in order to support NAT on a distributed logical router. NAT functionality is associated with the logical router gateway port. The flows that carry out NAT functionality all have match conditions on inport or

[ovs-dev] [RFC v2 4/5] ovn: avoid snat recirc only on gateway routers

2016-11-03 Thread Mickey Spiegel
Currently, for performance reasons on gateway routers, ct_snat that does not specify an IP address does not immediately trigger recirculation. On gateway routers, ct_snat that does not specify an IP address happens in the UNSNAT pipeline stage, which is followed by the DNAT pipeline stage that

[ovs-dev] [RFC v2 3/5] ovn: move load balancing flows after NAT flows

2016-11-03 Thread Mickey Spiegel
This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel

[ovs-dev] [RFC v2 2/5] ovn: add is_chassis_resident match expression component

2016-11-03 Thread Mickey Spiegel
This patch introduces a new match expression component is_chassis_resident(). Unlike match expression comparisons, is_chassis_resident is not pushed down to OpenFlow. It is a conditional that is evaluated in the controller during expr_simplify(), when it is replaced by a boolean expression. The

[ovs-dev] [RFC v2 0/5] ovn: add distributed NAT capability

2016-11-03 Thread Mickey Spiegel
Currently OVN supports NAT functionality by connecting each distributed logical router to a centralized "l3gateway" router that resides on a single chassis. NAT is only carried out in the "l3gateway" router. This patch set introduces NAT capability in the distributed logical router itself,

[ovs-dev] [RFC v2 1/5] ovn: Introduce "chassisredirect" port binding

2016-11-03 Thread Mickey Spiegel
Currently OVN handles all logical router ports in a distributed manner, creating instances on each chassis. The logical router ingress and egress pipelines are traversed locally on the source chassis. In order to support advanced features such as one-to-many NAT (aka IP masquerading), where