Re: [ovs-dev] OVS PatchWork Update

2016-01-24 Thread ALeX Wang
dd NULL > check for tun-dst. > 570946 New2016-01-20 22:33:17 [ovs-dev,v2,2/2] ovn-nbctl: Update > show format for addresses. > 570945 New2016-01-20 22:33:16 [ovs-dev,v2,1/2] ovn-nbctl: Help > catch lport-set-addresses mistakes. > 567326 New2016-01-14 11:29:08 [ovs-dev,v1,2/2] ofproto: Wildcard > TTL on IP tunnels > 567325 New2016-01-14 11:29:07 [ovs-dev,v1,1/2] odp-util: Accept > fields with zero mask > > -- Alex Wang, Open vSwitch developer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] OVS PatchWork Update

2016-01-24 Thread ALeX Wang
I think auto mark is useful, merged the change, On 18 January 2016 at 14:31, ALeX Wang <ee07b...@gmail.com> wrote: > Marked committed patches as 'Accepted' > Marked duplicates as 'Not Applicable' > > I have a patch that automates the marking above, > > h

Re: [ovs-dev] OVS PatchWork Update

2016-01-18 Thread ALeX Wang
Marked committed patches as 'Accepted' Marked duplicates as 'Not Applicable' I have a patch that automates the marking above, https://github.com/yew011/openvswitch.patchwork.mgmt/pull/1 Ben, can I merge it and do it in the weekly cron task? Thanks, Alex Wang, On 17 January 2016 at 16:01, <

Re: [ovs-dev] OVS PatchWork Update

2016-01-17 Thread ALeX Wang
So so so sorry for spaming the dev mailing list, Forgot to turn this off, just did, Alex Wang, On 17 January 2016 at 16:00, Ubuntu <ubu...@xiabibi.net> wrote: > 30+ Day Old Patches > === > ID State Date

Re: [ovs-dev] OVS PatchWork Update

2016-01-11 Thread ALeX Wang
my old understanding is that it won't do that automatically, you can turn on the ACK detector which will set the flag. other project uses that, Thanks, Alex Wang, On 11 January 2016 at 06:30, Russell Bryant <russ...@ovn.org> wrote: > On 01/11/2016 02:01 AM, ALeX Wang wrote: &

Re: [ovs-dev] OVS PatchWork Update

2016-01-10 Thread ALeX Wang
Marked "Committed Patches" as Accepted Marked "Duplicate Patches" as Not Applicable Alex Wang, On 10 January 2016 at 22:28, <al...@xiabibi.net> wrote: > 30+ Day Old Patches > === > ID State Date Name > --

Re: [ovs-dev] [v3 04/10] lib/damon: add --user option

2015-10-12 Thread ALeX Wang
Thx, all make sense, On 12 October 2015 at 11:25, Andy Zhou <az...@nicira.com> wrote: > On Sun, Oct 11, 2015 at 10:33 PM, ALeX Wang <ee07b...@gmail.com> wrote: > > Hey Andy, > > > > Sorry for this late post, just very interested in the feature > > impleme

Re: [ovs-dev] [v3 04/10] lib/damon: add --user option

2015-10-11 Thread ALeX Wang
parsing practice? Thanks, Alex Wang, -- Alex Wang, Open vSwitch developer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH V10] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-09-15 Thread ALeX Wang
Thx for the review, Applied to master~, On 14 September 2015 at 16:46, Justin Pettit <jpet...@nicira.com> wrote: > Looks good. Thanks! > > Acked-by: Justin Pettit <jpet...@nicira.com> > > --Justin > > > > On Sep 13, 2015, at 2:39 PM, Alex Wang <ee07

Re: [ovs-dev] [Patch V10] ovn-controller-vtep: Add vtep module.

2015-09-15 Thread ALeX Wang
Thx for the review, Applied to master~, On 14 September 2015 at 16:12, Justin Pettit <jpet...@nicira.com> wrote: > > > On Sep 13, 2015, at 1:58 PM, Alex Wang <ee07b...@gmail.com> wrote: > > > > --- a/ovn/controller-vtep/gateway.c > > +++ b/ovn/control

Re: [ovs-dev] [PATCH 4/4] ovn-nbctl: Enable database commands using db-ctl-base infrastructure.

2015-09-14 Thread ALeX Wang
On 14 September 2015 at 08:33, Ben Pfaff <b...@nicira.com> wrote: > On Sun, Sep 13, 2015 at 09:57:58AM -0700, ALeX Wang wrote: > > On 11 September 2015 at 20:29, Ben Pfaff <b...@nicira.com> wrote: > > > > > This makes ovn-nbctl into a pretty slavish imitatio

Re: [ovs-dev] [PATCH 3/4] ovn-nbctl: Give handler functions more specific names.

2015-09-13 Thread ALeX Wang
First three patches all look good to me, Acked-by: Alex Wang <ee07b...@gmail.com> On 11 September 2015 at 20:29, Ben Pfaff <b...@nicira.com> wrote: > I find that it's nice to give functions for commands names specific to the > utility, even though they're static, because occ

Re: [ovs-dev] [PATCH 0/4] ovn-sbctl improvements

2015-09-13 Thread ALeX Wang
All look good~, Acked-by: Alex Wang <ee07b...@gmail.com> On 11 September 2015 at 20:46, Ben Pfaff <b...@nicira.com> wrote: > These patches were originally in the series that adds end-to-end > tests for OVN, but they don't need to be there so I'm reposting > them separat

Re: [ovs-dev] [PATCH 4/4] ovn-nbctl: Enable database commands using db-ctl-base infrastructure.

2015-09-13 Thread ALeX Wang
om> > imitation of ovn-sbctl? Also, one thing I noticed is that there is no implementation for 'struct nbctl_context' and 'cache'. so, there is no guarantee that in a long cmd chain, the later cmd will never see the invalid db states. Thanks, Alex Wang, > --- > ovn/utilities/

[ovs-dev] [Patch V10] ovn-controller-vtep: Add vtep module.

2015-09-13 Thread Alex Wang
This commit adds the vtep module to ovn-controller-vtep. The module will scan through the Port_Binding table in OVN-SB database, and update the vtep logcial switches tunnel keys. Signed-off-by: Alex Wang <ee07b...@gmail.com> Acked-by: Russell Bryant <rbry...@redhat.com> Acked-by: J

Re: [ovs-dev] [PATCH V9 1/3] ovn-controller-vtep: Add vtep module.

2015-09-13 Thread ALeX Wang
On 12 September 2015 at 16:43, Justin Pettit <jpet...@nicira.com> wrote: > > > On Aug 27, 2015, at 11:21 PM, Alex Wang <ee07b...@gmail.com> wrote: > > > > > > --- a/ovn/controller-vtep/binding.c > > +++ b/ovn/controller-vtep/binding.c > > @@ -226

Re: [ovs-dev] [PATCH V9 2/3] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-09-13 Thread ALeX Wang
On 13 September 2015 at 10:45, Justin Pettit <jpet...@nicira.com> wrote: > > > On Aug 27, 2015, at 11:21 PM, Alex Wang <ee07b...@gmail.com> wrote: > > > > > > +/* Searches the 'chassis_rec->encaps' for the first vtep tunnel > > + * configurat

Re: [ovs-dev] [PATCH V9 1/3] ovn-controller-vtep: Add vtep module.

2015-09-13 Thread ALeX Wang
On 13 September 2015 at 11:59, Justin Pettit <jpet...@nicira.com> wrote: > > > On Sep 13, 2015, at 11:35 AM, ALeX Wang <ee07b...@gmail.com> wrote: > > > >> On 12 September 2015 at 16:43, Justin Pettit <jpet...@nicira.com> > wrote: > >>

Re: [ovs-dev] [PATCH V9 3/3] ovn-controller-vtep: Update related documentation.

2015-09-13 Thread ALeX Wang
On 13 September 2015 at 12:15, Justin Pettit <jpet...@nicira.com> wrote: > Go through ovn-sb to see what is also set by ovn-controller-vtep. For > example, the "chassis" column in the Port_Binding record. > > Done, thx for the reminder~! > > > On Aug 27

[ovs-dev] [PATCH V10] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-09-13 Thread Alex Wang
This commit extends the vtep module to support creating the 'Ucast_Macs_Remote' table entries in the vtep database for MAC addresses on the ovn logical ports. Signed-off-by: Alex Wang <ee07b...@gmail.com> Acked-by: Russell Bryant <rbry...@redhat.com> --- V9->V10: - Refine commen

[ovs-dev] [PATCH V10] ovn-controller-vtep: Update related documentation.

2015-09-13 Thread Alex Wang
' configuration. Signed-off-by: Alex Wang <ee07b...@gmail.com> Acked-by: Russell Bryant <rbry...@redhat.com> --- V9->V10 - fix gramma errors pointed out by Justin. - fix underscore notation of option keys (vtep-logical-switch, vtep-physical-switch). - rebase to master and convert 'lo

Re: [ovs-dev] About the Mega Flow

2015-09-08 Thread ALeX Wang
Hey, I would encourage you to try it yourself, using `ovs-appctl ofproto/trace` command, `ovs-appctl upcall/enable-megaflows` (also disable-megaflows) can be used to turn it on and off, Thanks, Alex Wang, On 8 September 2015 at 00:28, openvswitcher <openvswitc...@163.com> wrote: &g

[ovs-dev] Announce official patchwork for Open vSwitch project

2015-09-06 Thread ALeX Wang
Hey all, Glad to announce the patchwork site (hosted by ozlabs) for Open vSwitch project. https://patchwork.ozlabs.org/project/openvswitch/list/ The patchwork site link is also available on the index page of http://openvswitch.org/ Special thank to orzlabs~! Thanks, -- Alex Wang, Open vSwitch

Re: [ovs-dev] [PATCH] FAQ: mention about plotnetcfg tool

2015-09-03 Thread ALeX Wang
tried this out, looks useful, Look good to me, Thanks, Alex Wang, On 3 September 2015 at 07:53, Flavio Leitner <f...@sysclose.org> wrote: > The plotnetcfg is an open source tool to visualy represent > relationship between network interfaces on a single host. > > It helps to u

Re: [ovs-dev] [PATCH V4 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-09-01 Thread ALeX Wang
On 1 September 2015 at 19:42, Joe Stringer <joestrin...@nicira.com> wrote: > Hi Alex, a minor comment, otherwise > > On 29 August 2015 at 18:44, Alex Wang <ee07b...@gmail.com> wrote: > > This commit adds logic using ovs barrier to allow main thread pause > > al

Re: [ovs-dev] [PATCH V3 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-09-01 Thread ALeX Wang
Thx applied this patch to master~! Thanks, Alex Wang, On 29 August 2015 at 11:37, Joe Stringer <joestrin...@nicira.com> wrote: > On 29 August 2015 at 00:42, Alex Wang <ee07b...@gmail.com> wrote: > > When dpdk configuration changes, all pmd threads are recreated > >

Re: [ovs-dev] [PATCH 2/3] service controller: Allow change to punix socket file group ownership.

2015-08-30 Thread ALeX Wang
On 28 August 2015 at 00:25, Alex Wang al...@nicira.com wrote: On Wed, Aug 26, 2015 at 2:13 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Aug 21, 2015 at 11:10:32PM -0700, Alex Wang wrote: This commit adds a new key-value pair, 'punix_file_group=user group', to the 'other_config' column

[ovs-dev] [PATCH V2] service controller: Allow change to punix socket file group ownership.

2015-08-30 Thread Alex Wang
This commit adds a new key-value pair, 'punix_file_group=user group', to the 'other_config' column in the 'Controller' table. This new config allows user to change the punix socket file's group ownership, so that non-root process can also connect to ovs bridge. Signed-off-by: Alex Wang ee07b

[ovs-dev] [PATCH V3 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-29 Thread Alex Wang
the purging of datapath (e.g. pmd thread deletion in dpif-netdev). So, the ofproto-dpif-upcall module can react properly with deleting the ukeys and with collecting flows' last stats. Reported-by: Ilya Maximets i.maxim...@samsung.com Signed-off-by: Alex Wang ee07b...@gmail.com Acked-by: Daniele

[ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread Alex Wang
This commit adds logic using ovs barrier to allow main thread pause all revalidators. This new feature will be used in a later patch. Signed-off-by: Alex Wang ee07b...@gmail.com --- V3: - new patch. --- ofproto/ofproto-dpif-upcall.c | 46 +++ 1 file

Re: [ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread Alex Wang
On Sat, Aug 29, 2015 at 11:34 AM, Joe Stringer joestrin...@nicira.com wrote: Thanks for working on this, Alex. I've considered implementing an approach like this before, but haven't had a strong reason to. On 29 August 2015 at 00:42, Alex Wang ee07b...@gmail.com wrote: This commit adds

Re: [ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread ALeX Wang
On 29 August 2015 at 16:45, Joe Stringer joestrin...@nicira.com wrote: On 29 August 2015 at 15:24, Alex Wang al...@nicira.com wrote: On Sat, Aug 29, 2015 at 11:34 AM, Joe Stringer joestrin...@nicira.com wrote: Thanks for working on this, Alex. I've considered implementing

Re: [ovs-dev] [PATCH V3 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread ALeX Wang
Thx for pointing that out, Totally ignore the existence of other barriers ;D Let me address that, Thanks, Alex Wang, On 29 August 2015 at 17:49, Joe Stringer joestrin...@nicira.com wrote: On 29 August 2015 at 17:42, ALeX Wang ee07b...@gmail.com wrote: On 29 August 2015 at 16:45, Joe

[ovs-dev] [PATCH V4 1/2] ofproto-dpif-upcall: Allow main thread to pause all revalidators.

2015-08-29 Thread Alex Wang
This commit adds logic using ovs barrier to allow main thread pause all revalidators. This new feature will be used in a later patch. Signed-off-by: Alex Wang ee07b...@gmail.com --- V3-V4: - sync the pause_latch state among all revalidators~ thx Joe for point out~! V3: - new patch

Re: [ovs-dev] [PATCH 2/3] service controller: Allow change to punix socket file group ownership.

2015-08-28 Thread Alex Wang
On Wed, Aug 26, 2015 at 2:13 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Aug 21, 2015 at 11:10:32PM -0700, Alex Wang wrote: This commit adds a new key-value pair, 'punix_file_group=user group', to the 'other_config' column in the 'Controller' table. This new config allows user to change

[ovs-dev] [PATCH V9 1/3] ovn-controller-vtep: Add vtep module.

2015-08-28 Thread Alex Wang
This commit adds the vtep module to ovn-controller-vtep. The module will scan through the Port_Binding table in OVN-SB database, and update the vtep logcial switches tunnel keys. Signed-off-by: Alex Wang ee07b...@gmail.com Acked-by: Russell Bryant rbry...@redhat.com --- V8-V9: - Add Ack from

[ovs-dev] [PATCH V9 3/3] ovn-controller-vtep: Update related documentation.

2015-08-28 Thread Alex Wang
' configuration. Signed-off-by: Alex Wang ee07b...@gmail.com Acked-by: Russell Bryant rbry...@redhat.com --- V8-V9: - rebase. V7-V8: - rebase. V6-V7: - adopt suggestions from Russell. - leave out the documentation of feature that has not been implemented yet. V5-V6: - add description in ovn-architecture

[ovs-dev] [PATCH V9 2/3] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-08-28 Thread Alex Wang
This commit extends the vtep module to support creating the 'Ucast_Macs_Remote' table entries in the vtep database for MAC addresses on the ovn logical ports. Signed-off-by: Alex Wang ee07b...@gmail.com Acked-by: Russell Bryant rbry...@redhat.com --- V8-V9: - Add Ack from Russell. - Minor

[ovs-dev] [PATCH V2] bridge: Relax the whitelist format for punix path.

2015-08-28 Thread Alex Wang
This commit relaxes the whitelist format for punix path for service controller. Instead of only allowing punix:ovs_rundir/bridge_name.controller, the new format allows any suffix, like punix:ovs_rundir/bridge_name.*. (except '/'). Signed-off-by: Alex Wang ee07b...@gmail.com --- PATCH-V2

Re: [ovs-dev] [PATCH V8 2/3] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-08-28 Thread Alex Wang
Hey Russell, Sorry for this very delayed reply,~ Please see my reply inline, Thanks, Alex Wang, On Mon, Aug 24, 2015 at 10:48 AM, Russell Bryant rbry...@redhat.com wrote: On 08/23/2015 02:06 PM, Alex Wang wrote: This commit extends the vtep module to support creating

Re: [ovs-dev] [PATCH V2 1/2] ofproto-dpif-upcall: Do not attribute stats when flow_del returns error.

2015-08-28 Thread ALeX Wang
:25, Alex Wang ee07b...@gmail.com wrote: In the push_ukey_ops__(), when flow_del operation returns error, the 'struct stats' passed to the operation function will be set to all zero. And we should not use it to calculate the delta (i.e. minus the zero stats by the cached stats causes overflow

Re: [ovs-dev] [PATCH V2] bridge: Relax the whitelist format for punix path.

2015-08-28 Thread ALeX Wang
Thx, applied to master~ Alex Wang, On 28 August 2015 at 14:07, Ben Pfaff b...@nicira.com wrote: On Fri, Aug 28, 2015 at 07:31:21AM +, Alex Wang wrote: This commit relaxes the whitelist format for punix path for service controller. Instead of only allowing punix:ovs_rundir

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread ALeX Wang
Thanks, fixed the typo and adopted your suggested change,~ On 28 August 2015 at 09:18, Jarno Rajahalme jrajaha...@nicira.com wrote: On Aug 27, 2015, at 10:25 PM, Alex Wang ee07b...@gmail.com wrote: When dpdk configuration changes, all pmd threads are recreated and rx queues of each port

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread ALeX Wang
! On 28/08/2015 06:25, Alex Wang ee07b...@gmail.com wrote: When dpdk configuration changes, all pmd threads are recreated and rx queues of each port are reloaded. After this process, rx queue could be mapped to a different pmd thread other than the one before reconfiguration. However

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread ALeX Wang
, Will try and send out V3 patch~ Thanks, Alex Wang, On 28/08/2015 06:25, Alex Wang ee07b...@gmail.com wrote: When dpdk configuration changes, all pmd threads are recreated and rx queues of each port are reloaded. After this process, rx queue could be mapped to a different pmd thread

Re: [ovs-dev] [PATCH v3] tests: Avoid nonportable sed -i.

2015-08-27 Thread Alex Wang
Looks good to me, Thx for fixing it~ On Thu, Aug 27, 2015 at 11:11 AM, Ben Pfaff b...@nicira.com wrote: sed -i isn't entirely portable, and we can avoid it by using the argument to check_logs as intended. Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: Alex Wang al...@nicira.com

Re: [ovs-dev] [PATCH] Update my email address.

2015-08-27 Thread Alex Wang
On Thu, Aug 27, 2015 at 5:15 PM, Justin Pettit jpet...@nicira.com wrote: Sadly: Acked-by: Justin Pettit jpet...@nicira.com Thx, I also feel sad Will be around~ Thanks, Alex Wang, --Justin On Aug 27, 2015, at 4:59 PM, Alex Wang ee07b...@gmail.com wrote: Signed-off-by: Alex Wang

[ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-27 Thread Alex Wang
the purging of datapath (e.g. pmd thread deletion in dpif-netdev). So, the ofproto-dpif-upcall module can react properly with deleting the ukeys and with collecting flows' last stats. Reported-by: Ilya Maximets i.maxim...@samsung.com Signed-off-by: Alex Wang ee07b...@gmail.com --- PATCH-V2

[ovs-dev] [PATCH V2 1/2] ofproto-dpif-upcall: Do not attribute stats when flow_del returns error.

2015-08-27 Thread Alex Wang
, it is still good to make push_ukey_ops__() just ignore the operation when it fails. Signed-off-by: Alex Wang ee07b...@gmail.com --- V2: - new patch. --- ofproto/ofproto-dpif-upcall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif

Re: [ovs-dev] [PATCH v2] tests: Avoid nonportable sed -i.

2015-08-27 Thread Alex Wang
]]* reads, [[0-9]]* writes/d On Wed, Aug 26, 2015 at 3:55 PM, Ben Pfaff b...@nicira.com wrote: sed -i isn't entirely portable, and we can avoid it by using the argument to check_logs as intended. Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: Alex Wang al...@nicira.com --- v1-v2: Retain

[ovs-dev] [PATCH] Update my email address.

2015-08-27 Thread Alex Wang
Signed-off-by: Alex Wang ee07b...@gmail.com --- AUTHORS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index 254095e..4be28c4 100644 --- a/AUTHORS +++ b/AUTHORS @@ -7,7 +7,7 @@ Alexander Duyck alexander.h.du...@redhat.com Alexandru Copot

[ovs-dev] [PATCH V2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-26 Thread Alex Wang
the purging of datapath (e.g. pmd thread deletion in dpif-netdev). So, the ofproto-dpif-upcall module can react properly with deleting the ukeys and with collecting flows' last stats. Reported-by: Ilya Maximets i.maxim...@samsung.com Signed-off-by: Alex Wang al...@nicira.com --- PATCH-V2

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-26 Thread Alex Wang
in each 'pmd' have already gone... So, we did not harvest the last bit of stats, Instead, I think the right place to call purge_cb() is between pmd thread stop and deletion in dp_netdev_del_pmd(). Please see the V2 patch for details, Thanks, Alex Wang, On Mon, Aug 17, 2015 at 11:09 PM, Ilya

Re: [ovs-dev] [PATCH] tests: Avoid nonportable sed -i.

2015-08-26 Thread Alex Wang
Thx for informing the portability issue. I used 'sed -i' since I only saw this in ovsdb-server.log, so originally, did not want to miss same error logs in other *.log file, But, since 'sed -i' is not portable, I think it is good to do it in check_log() Acked-by: Alex Wang al...@nicira.com

Re: [ovs-dev] [PATCH] coverage: Add coverage_try_clear() for performance-critical threads.

2015-08-25 Thread Alex Wang
Apologize for the delay, applied to master~ On Tue, Aug 25, 2015 at 4:53 AM, Traynor, Kevin kevin.tray...@intel.com wrote: -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di Proietto Sent: Monday, August 24, 2015 7:08 PM To: Alex Wang

Re: [ovs-dev] [PATCH] ovn-controller-vtep.at: Remove all 'Broken pipe' warning logs from ovsdb-server.log.

2015-08-24 Thread Alex Wang
On Mon, Aug 24, 2015 at 11:30 AM, Russell Bryant rbry...@redhat.com wrote: On 08/22/2015 12:36 PM, Alex Wang wrote: This commit makes the OVN_CONTROLLER_VTEP_STOP remove all 'Broken pipe' warning logs from ovsdb-server.log before running 'check_log'. This is in that *ctl command (e.g

Re: [ovs-dev] [PATCH] ovn-controller-vtep.at: Remove all 'Broken pipe' warning logs from ovsdb-server.log.

2015-08-24 Thread Alex Wang
On Mon, Aug 24, 2015 at 2:46 PM, Russell Bryant rbry...@redhat.com wrote: On 08/24/2015 05:37 PM, Alex Wang wrote: On Mon, Aug 24, 2015 at 11:30 AM, Russell Bryant rbry...@redhat.com mailto:rbry...@redhat.com wrote: On 08/22/2015 12:36 PM, Alex Wang wrote: This commit

Re: [ovs-dev] [PATCH V2] openvswitch-cfg-update: Fix incorrect controller config.

2015-08-24 Thread Alex Wang
And branch 2.1, 2.0 On Mon, Aug 24, 2015 at 10:12 PM, Alex Wang al...@nicira.com wrote: Just realized that this needs to be backported to branch-2.3, did that,~ Thanks, Alex Wang, On Wed, Mar 11, 2015 at 2:05 PM, Alex Wang al...@nicira.com wrote: On Wed, Mar 11, 2015 at 2:04 PM, Ben

Re: [ovs-dev] [PATCH V2] openvswitch-cfg-update: Fix incorrect controller config.

2015-08-24 Thread Alex Wang
Just realized that this needs to be backported to branch-2.3, did that,~ Thanks, Alex Wang, On Wed, Mar 11, 2015 at 2:05 PM, Alex Wang al...@nicira.com wrote: On Wed, Mar 11, 2015 at 2:04 PM, Ben Pfaff b...@nicira.com wrote: Acked-by: Ben Pfaff b...@nicira.com Thx, applied to master

[ovs-dev] [PATCH V8 2/3] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-08-23 Thread Alex Wang
This commit extends the vtep module to support creating the 'Ucast_Macs_Remote' table entries in the vtep database for MAC addresses on the ovn logical ports. Signed-off-by: Alex Wang al...@nicira.com --- V7-V8: - rebase. V6-V7: - rebase. - adopt suggestions from Russell. V5-V6: - rebase. V4

[ovs-dev] [PATCH V8 3/3] ovn-controller-vtep: Update related documentation.

2015-08-23 Thread Alex Wang
' configuration. Signed-off-by: Alex Wang al...@nicira.com Acked-by: Russell Bryant rbry...@redhat.com --- V7-V8: - rebase. V6-V7: - adopt suggestions from Russell. - leave out the documentation of feature that has not been implemented yet. V5-V6: - add description in ovn-architecture. V5: new patch

[ovs-dev] [PATCH V8 1/3] ovn-controller-vtep: Add vtep module.

2015-08-23 Thread Alex Wang
This commit adds the vtep module to ovn-controller-vtep. The module will scan through the Port_Binding table in OVN-SB database, and update the vtep logcial switches tunnel keys. Signed-off-by: Alex Wang al...@nicira.com --- V7-V8: - Fix bug pointed out by Russell. V6-V7: - change the assertion

[ovs-dev] [PATCH 2/3] service controller: Allow change to punix socket file group ownership.

2015-08-22 Thread Alex Wang
This commit adds a new key-value pair, 'punix_file_group=user group', to the 'other_config' column in the 'Controller' table. This new config allows user to change the punix socket file's group ownership, so that non-root process can also connect to ovs bridge. Signed-off-by: Alex Wang al

[ovs-dev] [PATCH RFC 3/3] manager: Allow change to punix socket file group ownership.

2015-08-22 Thread Alex Wang
This commit adds a new key-value pair, 'punix_file_group=user group', to the 'other_config' column in the 'Manager' table. This new config allows user to change the punix socket file's group ownership, so that non-root process can also connect to ovsdb-server. Signed-off-by: Alex Wang al

Re: [ovs-dev] [PATCH RFC 3/3] manager: Allow change to punix socket file group ownership.

2015-08-22 Thread Alex Wang
If we want to make ovsdb-server non-root, this change may not be need,~ On Fri, Aug 21, 2015 at 11:10 PM, Alex Wang al...@nicira.com wrote: This commit adds a new key-value pair, 'punix_file_group=user group', to the 'other_config' column in the 'Manager' table. This new config allows user

[ovs-dev] [PATCH 1/3] bridge: Relax the whitelist format for punix path.

2015-08-22 Thread Alex Wang
This commit relaxes the whitelist format for punix path for service controller. Instead of only allowing punix:ovs_rundir/bridge_name.controller, the new format allows any suffix, like punix:ovs_rundir/bridge_name.*. Signed-off-by: Alex Wang al...@nicira.com --- tests/ovs-vswitchd.at | 11

Re: [ovs-dev] [PATCH] coverage: Add coverage_try_clear() for performance-critical threads.

2015-08-22 Thread Alex Wang
Sorry for the delay of pushing this and related dpdk patches, Want to spend some time next week measuring the performance impact,~ Thanks, Alex Wang, On Fri, Aug 21, 2015 at 12:48 PM, Ben Pfaff b...@nicira.com wrote: On Thu, Aug 13, 2015 at 11:48:49AM -0700, Alex Wang wrote: For performance

[ovs-dev] [PATCH] ovn-controller-vtep.at: Remove all 'Broken pipe' warning logs from ovsdb-server.log.

2015-08-22 Thread Alex Wang
) may immediately update the database; this later update may cause database sending update back to *ctl command if *ctl has not proceeded to exit yet; and if *ctl command exits before database calling send, the send will fail with 'Broken pipe' error. Signed-off-by: Alex Wang al...@nicira.com

Re: [ovs-dev] OVN: Broken pipe race

2015-08-21 Thread Alex Wang
On Fri, Aug 21, 2015 at 3:02 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Aug 17, 2015 at 11:24:48AM -0700, Alex Wang wrote: Hey, Want to open a thread to discuss the following race I encountered while unit testing ovn. The most simple case is when I run ovn-nbctl to add a lport

Re: [ovs-dev] [ovn-controller-vtep V7 2/3] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-08-20 Thread Alex Wang
On Thu, Aug 20, 2015 at 9:09 AM, Russell Bryant rbry...@redhat.com wrote: Looks good to me except for the one thing I noticed that was introduced in the last patch. On 08/18/2015 05:58 PM, Alex Wang wrote: This commit extends the vtep module to support creating the 'Ucast_Macs_Remote

Re: [ovs-dev] [ovn-controller-vtep V7 2/3] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-08-20 Thread Alex Wang
On Thu, Aug 20, 2015 at 9:40 AM, Russell Bryant rbry...@redhat.com wrote: On 08/20/2015 09:34 AM, Alex Wang wrote: On Thu, Aug 20, 2015 at 9:09 AM, Russell Bryant rbry...@redhat.com mailto:rbry...@redhat.com wrote: Looks good to me except for the one thing I noticed

Re: [ovs-dev] [ovn-controller-vtep V7 1/3] ovn-controller-vtep: Add vtep module.

2015-08-20 Thread Alex Wang
On Thu, Aug 20, 2015 at 8:24 AM, Russell Bryant rbry...@redhat.com wrote: acked this earlier, but just came across something while reviewing the next patch ... let me know if I'm missing something. On 08/18/2015 05:58 PM, Alex Wang wrote: This commit adds the vtep module to ovn-controller

Re: [ovs-dev] [ovn-controller-vtep V7 1/3] ovn-controller-vtep: Add vtep module.

2015-08-20 Thread Alex Wang
As well as a test to cover that~ ;D On Thu, Aug 20, 2015 at 9:06 AM, Alex Wang al...@nicira.com wrote: On Thu, Aug 20, 2015 at 8:24 AM, Russell Bryant rbry...@redhat.com wrote: acked this earlier, but just came across something while reviewing the next patch ... let me know if I'm missing

Re: [ovs-dev] [PATCH] ovn-controller-vtep.at: Check the successful exit of ovn-controller-vtep.

2015-08-19 Thread Alex Wang
On Wed, Aug 19, 2015 at 9:55 PM, Ben Pfaff b...@nicira.com wrote: On Tue, Aug 18, 2015 at 05:47:18PM -0700, Alex Wang wrote: Signed-off-by: Alex Wang al...@nicira.com --- tests/ovn-controller-vtep.at |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/ovn

Re: [ovs-dev] [PATCH 2/3] ovn-sbctl: Make 'chassis-del' delete all encaps.

2015-08-19 Thread Alex Wang
Just want to follow the same fashion like 'del_bridge()', in ovs-vsctl.c . Thanks, Alex Wang, ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [ovn-controller-vtep V5 00/12] Implement ovn-controller-vtep.

2015-08-19 Thread Alex Wang
as-is, or is it appropriate to post a rebased v6? Oh, never mind, I see now that there's a v6 already. And V7 ;D, three patches left, Thanks, Alex Wang, ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [ovn-controller-vtep V5 00/12] Implement ovn-controller-vtep.

2015-08-19 Thread Alex Wang
On Wed, Aug 19, 2015 at 9:45 PM, Russell Bryant rbry...@redhat.com wrote: On Aug 19, 2015, at 9:00 PM, Alex Wang al...@nicira.com wrote: On Wed, Aug 19, 2015 at 8:58 PM, Ben Pfaff b...@nicira.com wrote: On Wed, Aug 19, 2015 at 08:51:11PM -0700, Ben Pfaff wrote: I see that several

[ovs-dev] [PATCH 1/3] ovn-controller-vtep: Fix dereference of NULL pointer.

2015-08-18 Thread Alex Wang
Found by inspection. Signed-off-by: Alex Wang al...@nicira.com --- ovn/controller-vtep/binding.c |4 1 file changed, 4 insertions(+) diff --git a/ovn/controller-vtep/binding.c b/ovn/controller-vtep/binding.c index cb7f389..652852d 100644 --- a/ovn/controller-vtep/binding.c +++ b/ovn

[ovs-dev] [PATCH 3/3] ovn-controller-vtep: Make 'ovnsb_remote' and 'vtep_remote' free-able.

2015-08-18 Thread Alex Wang
Found by inspection. Signed-off-by: Alex Wang al...@nicira.com --- ovn/controller-vtep/ovn-controller-vtep.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ovn/controller-vtep/ovn-controller-vtep.c b/ovn/controller-vtep/ovn-controller-vtep.c index ff25319

[ovs-dev] [PATCH 2/3] ovn-controller-vtep: Call binding_cleanup() before gateway_cleanup().

2015-08-18 Thread Alex Wang
Otherwise, binding_cleanup() will be a no-op since all related chassis entries are deleted in gateway_cleanup(). Found by inspection. Signed-off-by: Alex Wang al...@nicira.com --- ovn/controller-vtep/ovn-controller-vtep.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] [PATCH] ovn: Free default db befor exit.

2015-08-18 Thread Alex Wang
Thx, applied to master, On Tue, Aug 18, 2015 at 11:06 AM, Alex Wang al...@nicira.com wrote: Acked-by: Alex Wang al...@nicira.com On Tue, Aug 18, 2015 at 8:24 AM, Russell Bryant rbry...@redhat.com wrote: The static result of default_db() was malloc'd but not freed before exit. Make

Re: [ovs-dev] [PATCH] ovn: Free default db befor exit.

2015-08-18 Thread Alex Wang
Acked-by: Alex Wang al...@nicira.com On Tue, Aug 18, 2015 at 8:24 AM, Russell Bryant rbry...@redhat.com wrote: The static result of default_db() was malloc'd but not freed before exit. Make the static result global and free it before exit. Signed-off-by: Russell Bryant rbry...@redhat.com

Re: [ovs-dev] [PATCH 2/3] ovn-controller-vtep: Call binding_cleanup() before gateway_cleanup().

2015-08-18 Thread Alex Wang
On Tue, Aug 18, 2015 at 8:10 AM, Russell Bryant rbry...@redhat.com wrote: On 08/17/2015 11:29 PM, Alex Wang wrote: Otherwise, binding_cleanup() will be a no-op since all related chassis entries are deleted in gateway_cleanup(). Found by inspection. Signed-off-by: Alex Wang al

[ovs-dev] [PATCH 3/3 V2] ovn-controller-vtep: Make 'ovnsb_remote' and 'vtep_remote' free-able.

2015-08-18 Thread Alex Wang
Found by inspection. Signed-off-by: Alex Wang al...@nicira.com --- PATCH-V2: - free 'default_db_'. --- ovn/controller-vtep/ovn-controller-vtep.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/ovn/controller-vtep/ovn-controller-vtep.c b/ovn/controller

Re: [ovs-dev] [PATCH 3/3 V2] ovn-controller-vtep: Make 'ovnsb_remote' and 'vtep_remote' free-able.

2015-08-18 Thread Alex Wang
Thanks, applied to master,~ On Tue, Aug 18, 2015 at 11:05 AM, Russell Bryant rbry...@redhat.com wrote: On 08/18/2015 11:02 AM, Alex Wang wrote: Found by inspection. Signed-off-by: Alex Wang al...@nicira.com Acked-by: Russell Bryant rbry...@redhat.com -- Russell Bryant

[ovs-dev] [PATCH] ovn-controller-vtep.at: Check the successful exit of ovn-controller-vtep.

2015-08-18 Thread Alex Wang
Signed-off-by: Alex Wang al...@nicira.com --- tests/ovn-controller-vtep.at |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at index de97bf9..fe2fd4d 100644 --- a/tests/ovn-controller-vtep.at +++ b/tests/ovn

[ovs-dev] [ovn-controller-vtep V7 2/3] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-08-18 Thread Alex Wang
This commit extends the vtep module to support creating the 'Ucast_Macs_Remote' table entries in the vtep database for MAC addresses on the ovn logical ports. Signed-off-by: Alex Wang al...@nicira.com --- V6-V7: - rebase. - adopt suggestions from Russell. V5-V6: - rebase. V4-V5: - rebase on top

[ovs-dev] [ovn-controller-vtep V7 3/3] ovn-controller-vtep: Update related documentation.

2015-08-18 Thread Alex Wang
' configuration. Signed-off-by: Alex Wang al...@nicira.com --- V6-V7: - adopt suggestions from Russell. - leave out the documentation of feature that has not been implemented yet. V5-V6: - add description in ovn-architecture. V5: new patch. --- ovn/TODO | 21 +++ ovn/ovn

[ovs-dev] [ovn-controller-vtep V7 1/3] ovn-controller-vtep: Add vtep module.

2015-08-18 Thread Alex Wang
This commit adds the vtep module to ovn-controller-vtep. The module will scan through the Port_Binding table in OVN-SB database, and update the vtep logcial switches tunnel keys. Signed-off-by: Alex Wang al...@nicira.com --- V6-V7: - change the assertion to VLOG_ERR in vtep_lswitch_run

[ovs-dev] [PATCH] ovn-controller-vtep.at: Skip test when using Windows setup.

2015-08-17 Thread Alex Wang
The 'ovs-vtep' simulator is not ported to Windows. So, for now, just skip all tests in ovn-controller-vtep.at when running in Windows. Signed-off-by: Alex Wang al...@nicira.com --- tests/ovn-controller-vtep.at |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/ovn

Re: [ovs-dev] [PATCH] ovn-northd: Ability to detach on Windows.

2015-08-17 Thread Alex Wang
Acked-by: Alex Wang al...@nicira.com Thx for writing this fix, Can you also add the same line to ovn/controller/ovn-controller.c and ovn/controller-vtep/ovn-controller-vtep.c ? Thanks, Alex Wang, On Mon, Aug 17, 2015 at 3:00 PM, Gurucharan Shetty shet...@nicira.com wrote: A unit test for ovn

Re: [ovs-dev] [ovn-controller-vtep V6 6/7] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-08-17 Thread Alex Wang
Wow, this is such an awesome change!!! I totally like it~ Could you send the patch? Would like to know what Ben thinks about this, Thanks, Alex Wang, On Mon, Aug 17, 2015 at 9:43 AM, Russell Bryant rbry...@redhat.com wrote: On 08/17/2015 09:06 AM, Alex Wang wrote: On Mon, Aug 17, 2015

Re: [ovs-dev] [PATCH v2] ovn-northd: Ability to detach on Windows.

2015-08-17 Thread Alex Wang
Thx for fixing this~! Acked-by: Alex Wang al...@nicira.com On Mon, Aug 17, 2015 at 3:44 PM, Gurucharan Shetty shet...@nicira.com wrote: A unit test for ovn-northd was hanging because ovn-northd running on Windows failed to detach. The detach function for Windows is implemented inside

Re: [ovs-dev] [PATCH] ovn-controller-vtep.at: Skip test when using Windows setup.

2015-08-17 Thread Alex Wang
Thx, applied to master~, On Mon, Aug 17, 2015 at 3:11 PM, Gurucharan Shetty shet...@nicira.com wrote: On Mon, Aug 17, 2015 at 3:09 PM, Alex Wang al...@nicira.com wrote: The 'ovs-vtep' simulator is not ported to Windows. So, for now, just skip all tests in ovn-controller-vtep.at when

Re: [ovs-dev] [ovn-controller-vtep V6 6/7] ovn-controller-vtep: Extend vtep module to install Ucast_Macs_Remote.

2015-08-17 Thread Alex Wang
On Mon, Aug 17, 2015 at 6:37 AM, Russell Bryant rbry...@redhat.com wrote: On 08/16/2015 07:24 PM, Alex Wang wrote: On Sun, Aug 16, 2015 at 3:26 PM, Russell Bryant rbry...@redhat.com mailto:rbry...@redhat.com wrote: On 08/09/2015 10:50 PM, Alex Wang wrote: +tnl_key

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-17 Thread Alex Wang
? This sounds to me like a different issue and may require more thinking, so I'd like to keep it a separate issue, Thanks, Alex Wang, Thanks On 11/08/2015 03:47, Alex Wang al...@nicira.com wrote: When dpdk configuration changes, all pmd threads are recreated and rx queues of each port

[ovs-dev] OVN: Broken pipe race

2015-08-17 Thread Alex Wang
. After that ovsdb-server will never try sending anything to *-*ctl commands, Would like to hear what you think?~ Thanks, Alex Wang, ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 1/3] ovn-controller-vtep.at: Fix intermittent test failure.

2015-08-16 Thread Alex Wang
The test waits until grep no vlan '200' from the VTEP 'vlan_binding' column. However, string '200' could also appear in other 'vlan_binding' entry's uuid value. Instead, we should grep for '200='. Signed-off-by: Alex Wang al...@nicira.com --- tests/ovn-controller-vtep.at |2 +- 1 file

[ovs-dev] [PATCH 2/3] ovn-sbctl: Make 'chassis-del' delete all encaps.

2015-08-16 Thread Alex Wang
Signed-off-by: Alex Wang al...@nicira.com --- ovn/utilities/ovn-sbctl.c |5 + 1 file changed, 5 insertions(+) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index 8887c95..c69800a 100644 --- a/ovn/utilities/ovn-sbctl.c +++ b/ovn/utilities/ovn-sbctl.c @@ -548,6 +548,11

[ovs-dev] [PATCH 3/3] ovn-controller-vtep.at: Fix intermittent test failure.

2015-08-16 Thread Alex Wang
. So, if the 'ovn-sbctl' exits right when the ovsdb-server tries to send update of readd of the deleted 'chassis', the sending will fail with 'Broken pipe' error. Signed-off-by: Alex Wang al...@nicira.com --- tests/ovn-controller-vtep.at |4 1 file changed, 4 insertions(+) diff --git

  1   2   3   4   5   6   7   8   9   10   >