Re: [ovs-dev] [PATCH] ovs-lldp: Remove dead store to TTL configuration.

2017-05-30 Thread Dennis Flynn
Signed-off-by: Dennis Flynn <drfl...@avaya.com> My plan has been to enhance OVS to implement more of the configurable LLDP options defined within the 802.1AB standard. tx_interval and tx_hold are two examples. I will re-instate this code when offering up those modifications. Dennis On Fr

Re: [ovs-dev] [PATCH] ovs-lldp: Remove unused variable 'lldp_size'.

2015-04-17 Thread Dennis Flynn
Acked-by: Dennis Flynn drfl...@avaya.com On Thu, Apr 16, 2015 at 4:44 PM, Ben Pfaff b...@nicira.com wrote: Doesn't seem to be good for anything. Found by LLVM scan-build. Reported-by: Kevin Lo ke...@freebsd.org Signed-off-by: Ben Pfaff b...@nicira.com --- lib/ovs-lldp.c | 6 +- 1

Re: [ovs-dev] [PATCH] bridge: Fix use-after-free in bridge_aa_refresh_queue().

2015-04-17 Thread Dennis Flynn
Acked-by: Dennis Flynn drfl...@avaya.com On Thu, Apr 16, 2015 at 5:49 PM, Ben Pfaff b...@nicira.com wrote: Found by LLVM scan-build. Reported-by: Kevin Lo ke...@freebsd.org Signed-off-by: Ben Pfaff b...@nicira.com --- vswitchd/bridge.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [ovs-dev] [PATCH] ovs-lldp: Avoid use-after-free in aa_mapping_unregister().

2015-04-17 Thread Dennis Flynn
Acked-by: Dennis Flynn drfl...@avaya.com On Thu, Apr 16, 2015 at 5:46 PM, Ben Pfaff b...@nicira.com wrote: Found by LLVM scan-build. Reported-by: Kevin Lo ke...@freebsd.org Signed-off-by: Ben Pfaff b...@nicira.com --- lib/ovs-lldp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [ovs-dev] [PATCH] ovs-lldp: Avoid free() of static data in aa_print_element_status_port().

2015-04-16 Thread Dennis Flynn
Thanks for finding and fixing this. Acked-by: Dennis Flynn drfl...@avaya.com On Thu, Apr 16, 2015 at 11:52 AM, Ben Pfaff b...@nicira.com wrote: In some cases 'id' could point to the static string None, which was then passed to free() even though it must not be. This commit fixes