[ovs-dev] [PATCH] ovs-lib: Handle daemon segfaults during exit.

2020-09-18 Thread Gurucharan Shetty
leted. So, we wait a little to give time for the monitor to restart the daemon (which is usually instantaneous) and then re-read the pidfile. VMware-BZ: #2633995 Signed-off-by: Gurucharan Shetty --- utilities/ovs-lib.in | 18 +- 1 file changed, 17 insertions(+), 1 deletion

[ovs-dev] [PATCH] ovs-atomic-c++.h: Fix for 64 bit atomics.

2019-06-13 Thread Gurucharan Shetty
*_explicit(). But it looks tricky to do this with macros. This patch tries to fix the compilation failures by calling atomic functions on the variables itself. Signed-off-by: Gurucharan Shetty --- lib/ovs-atomic-c++.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [PATCH] ovs-save: Handle cases of upgrades from very old OVS versions.

2019-05-08 Thread Gurucharan Shetty
assumption that any upgrade of OVS from versions before 2.7 will not attempt to save and restore flows. VMware-BZ: #2340482 Signed-off-by: Gurucharan Shetty --- utilities/ovs-save | 9 + 1 file changed, 9 insertions(+) diff --git a/utilities/ovs-save b/utilities/ovs-save index 1ba36e9

[ovs-dev] [PATCH 2/2] fedora: Handle upgrades from rhel package.

2019-05-03 Thread Gurucharan Shetty
start" is needed for systemd to see the old daemons. Another "restart" or "force-reload-kmod" is needed to actually use the new daemons. This commit, just takes care of the first restart. The "real" restart/force-reload-kmod will still have to be done outside the package

[ovs-dev] [PATCH 1/2] fedora: Ability to auto enable openvswitch service.

2019-05-03 Thread Gurucharan Shetty
, openvswitch service will be automatically enabled during package installation. make rpm-fedora RPMBUILD_OPT="--with autoenable" Signed-off-by: Gurucharan Shetty --- rhel/openvswitch-fedora.spec.in | 9 + 1 file changed, 9 insertions(+) diff --git a/rhel/openvswitch-fedora.spec

[ovs-dev] [PATCH v2] debian: Notes for systemd-networkd integration with OVS.

2019-04-19 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- v1-v2: use ip instead of ifconfig --- debian/openvswitch-switch.README.Debian | 76 - 1 file changed, 74 insertions(+), 2 deletions(-) diff --git a/debian/openvswitch-switch.README.Debian b/debian/openvswitch

[ovs-dev] [PATCH] debian: Notes for systemd-networkd integration with OVS.

2019-04-19 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- debian/openvswitch-switch.README.Debian | 76 - 1 file changed, 74 insertions(+), 2 deletions(-) diff --git a/debian/openvswitch-switch.README.Debian b/debian/openvswitch-switch.README.Debian index 7556844..ebe4cf0 100644

[ovs-dev] [PATCH] ovs-save: Parse geneve tlv map correctly.

2018-10-08 Thread Gurucharan Shetty
We now have an extra space in the o/p of `ovs-ofctl dump-tlv-map`. Fixes: 5a0e4aec1af (treewide: Convert leading tabs to spaces.) Signed-off-by: Gurucharan Shetty --- utilities/ovs-save | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-save b/utilities/ovs-save

[ovs-dev] [PATCH] ovs-ofctl.8: Fix reference to 'ip_frag'.

2018-09-20 Thread Gurucharan Shetty
The description of 'ip_frag' is now available in 'man ovs-fields' Signed-off-by: Gurucharan Shetty --- utilities/ovs-ofctl.8.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index 4850f4a..d6b6d28 100644

[ovs-dev] [PATCH] rhel/systemd: Prevent deletion of runtime directory.

2018-03-29 Thread Gurucharan Shetty
the runtime directory information from the systemd unit file. CC: acon...@redhat.com Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- I don't know whether there are other drawbacks of removing 'RuntimeDirectory' --- rhel/usr_lib_systemd_system_ovsdb-server.service | 2 -- 1 file changed, 2 del

[ovs-dev] [PATCH] ovn: Recirculate packets after a unSNAT.

2018-03-26 Thread Gurucharan Shetty
't get hit. This commit removes the optimization for unSNAT packets so that there is always a recirculation. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- include/ovn/actions.h | 3 --- ovn/controller/lflow.c | 10 -- ovn/lib/actions.c | 11 ---

[ovs-dev] [PATCH] ovn-northd.8: Move DHCP and DNS flow description to right section.

2018-03-09 Thread Gurucharan Shetty
The priority 34000 DHCP and DNS flows are added to the S_SWITCH_OUT_ACL table and not S_SWITCH_OUT_STATEFUL table. CC: Numan Siddique <nusid...@redhat.com> Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.8.xml | 38 +++--- 1

[ovs-dev] [PATCH] ovs-ctl: Don't remember vport-* kernel modules

2017-11-10 Thread Gurucharan Shetty
oid the above situation, by not loading vport-geneve kernel module. ovs-vswitchd when it starts will load upstream geneve. And when "iptables stop" runs, since "geneve" has nothing to do with conntrack, it spares it. Ideally, we should fix this by incrementing the refcount on the kernel mo

[ovs-dev] [PATCH v2] rhel.rst: Add python-sphinx as a dependency.

2017-10-20 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- Documentation/intro/install/rhel.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst index 86c5cf3..b68cb7d 100644 --- a/Documentation

[ovs-dev] [PATCH] rhel.rst: Add python-sphinx as a dependency.

2017-10-20 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- Documentation/intro/install/rhel.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/intro/install/rhel.rst b/Documentation/intro/install/rhel.rst index 86c5cf3..aff6ccf 100644 --- a/Documentation/intro/i

[ovs-dev] [PATCH] ovs-save: Handle different 'ip addr show' output.

2017-10-19 Thread Gurucharan Shetty
The keyword "dynamic" (according to 'man ip-address') is only used for ipv6, but in this case this is not true. Our current code will skip the ipv4 address restoration because of this. With this commit, we special case "dynamic" keyword to be valid in case of ipv4. VMware-BZ: #198

[ovs-dev] [PATCH 2/2] rhel: Skip systemctl redirect.

2017-10-06 Thread Gurucharan Shetty
-switch.service" and that inturn again calls "/etc/init.d/openvswitch-switch start" This patch avoids it. This is similar to what was done to Debian in commit 873d85653d8 (debian: Skip systemctl redirect.) Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- rhel/etc_init.d_openvswitch

[ovs-dev] [PATCH 1/2] ovs-ctl.in: Call 'hostname -f' after vswitchd starts.

2017-10-06 Thread Gurucharan Shetty
S restarts or upgrades. This commit calls 'hostname -f' after ovs-vswitchd has started. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- utilities/ovs-ctl.in | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index

[ovs-dev] [PATCH] ovn/actions: Improve OVN load-balancing performance.

2017-09-28 Thread Gurucharan Shetty
Currently, we send the first packet of every new connection to userspace to figure out the target IP address of load-balancing. With this patch, we use the selection method of dp_hash to prevent that situation. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/lib/actions.c | 2 +-

[ovs-dev] [PATCH 2/2] ovs-bugtool: Run the 'dmesg' command without condition.

2017-07-25 Thread Gurucharan Shetty
information to debug bugs. So always run the "dmesg" command and collect its output. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- utilities/bugtool/ovs-bugtool.in | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/utilities/bugtool/ovs-bugtool.in b/

[ovs-dev] [PATCH 1/2] ovs-bugtool: Collect OVS logs with "--ovs" option.

2017-07-25 Thread Gurucharan Shetty
ovs-bugtool collects a lot of data. This can be time consuming and can end up collecting a lot of redundant data. A option "--ovs" was added a while ago to only collect OVS relevent data. We missed adding the OVS logs to this filter. Signed-off-by: Gurucharan Shetty <g...@ovn.org>

[ovs-dev] [PATCH 2/2] openvswitch-switch.postinst: Remove upstart files.

2017-06-26 Thread Gurucharan Shetty
any stale upstart files that have remained in the system. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- debian/openvswitch-switch.postinst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/debian/openvswitch-switch.postinst b/debian/openvswitch-switch.postinst index 126e8fe..3

[ovs-dev] [PATCH 1/2] openvswitch-switch.postinst: Replace tabs by spaces

2017-06-26 Thread Gurucharan Shetty
There was some inconsistency with some tabs and some spaces used at different places. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- debian/openvswitch-switch.postinst | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/debian/openv

[ovs-dev] [PATCH 2/2] openvswitch-switch.postinst: Avoid getting redirected to systemctl.

2017-06-19 Thread Gurucharan Shetty
we would neither save flows or replace the kernel module. This commit tries to solve this problem by getting rid of '#DEBHELPER' and replacing "restart" with "ovsrestart" so that we skip systemd generated files. VMware-BZ: #1890631 Signed-off-by: Gurucharan Shetty <g...

[ovs-dev] [PATCH 1/2] openvswitch-switch.init: Add some aliases.

2017-06-19 Thread Gurucharan Shetty
that when called will skip the systemd generated files. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- debian/openvswitch-switch.init | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/openvswitch-switch.init b/debian/openvswitch-switch.init index 5c7c08b..b8cc23b

[ovs-dev] [PATCH 2/2] ovn-util: Allow /32 IP addresses for router ports.

2017-03-10 Thread Gurucharan Shetty
On Google cloud, a VM gets a /32 IP address. When OVN is deployed on such VMs, the OVN gateway router's IP address becomes a /32 IP address. This commit allows such a configuration. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/lib/ovn-util.c | 7 +--- tests/ovn.at

[ovs-dev] [PATCH 1/2] ovn-northd: Allow static routes with nexthop in different subnet.

2017-03-10 Thread Gurucharan Shetty
the destination is reachable. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- Patch2 of the series includes a unit test that also covers this case. --- ovn/northd/ovn-northd.c | 17 + ovn/ovn-nb.xml | 5 - 2 files changed, 21 insertions(+), 1 deletion(-) diff

[ovs-dev] [PATCH] docker.rst: Add documentation to open up TCP ports.

2017-02-07 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- Documentation/howto/docker.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/howto/docker.rst b/Documentation/howto/docker.rst index e23ca75..7845699 100644 --- a/Documentation/howto/docker.rst +++ b/Documentation

[ovs-dev] [PATCH] system-ovn.at: Fix race conditions.

2017-02-02 Thread Gurucharan Shetty
The code to wait for a particular type of flow in ovs-vswitchd was not specific enough. This commit changes that and to be doubly sure, also uses the sync command. Reported-by: Andy Zhou <az...@ovn.org> Reported-by: Joe Stringer <j...@ovn.org> Signed-off-by: Gurucharan Shetty &

[ovs-dev] [PATCH] ovn-nbctl: Ability to bootstrap CA certificate.

2017-01-18 Thread Gurucharan Shetty
-off-by: Gurucharan Shetty <g...@ovn.org> --- lib/automake.mk | 1 + lib/ssl-bootstrap.xml | 30 ++ ovn/utilities/ovn-nbctl.8.xml | 1 + ovn/utilities/ovn-nbctl.c | 6 ++ 4 files changed, 38 insertions(+) create mode 100644 l

[ovs-dev] [PATCH] ovn-ctl: Add bootstrap ovn-controller CA certificate option.

2017-01-18 Thread Gurucharan Shetty
) to every host. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/utilities/ovn-ctl | 20 ++-- ovn/utilities/ovn-ctl.8.xml | 1 + 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl index 90d0463..a3bdad1

[ovs-dev] [PATCH v4] ovn-northd: Force SNAT for multiple gateway routers.

2016-11-18 Thread Gurucharan Shetty
packet to $IP if it has been previously load-balanced. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- v3->v4: 1. Use an additional bit to hint that force SNAT has to be done for LB. 2. The established traffic of LB gets its own flows just like new connection. --- ovn/lib/logical

[ovs-dev] [PATCH v3 2/2] ovn-northd: Force SNAT for multiple gateway routers.

2016-11-14 Thread Gurucharan Shetty
packet to $IP if it has been previously load-balanced. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- v2->v3: Adds a unit test for load-balancing and multiple gateway routers. --- ovn/lib/logical-fields.c| 4 + ovn/lib/logical-fields.h| 5 + ovn/northd/ovn-northd.8.xml | 28

[ovs-dev] [PATCH v3 1/2] logical-fields: Add ct.dnat and ct.snat symbols.

2016-11-14 Thread Gurucharan Shetty
Upcoming commits use it. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- v2->v3: no change --- ovn/lib/logical-fields.c | 2 ++ ovn/ovn-sb.xml | 19 +-- tests/ovn.at | 4 +++- 3 files changed, 22 insertions(+), 3 deletions(-) diff --git

[ovs-dev] [PATCH 2/3] ovn: Ability to skip some IP addresses for SNAT.

2016-11-03 Thread Gurucharan Shetty
ss-through without any SNAT done on it. For e.g a subnet that is routable in the external network. This commit adds a "nosnat" option to the NAT table. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.8.xml | 8 ovn/no

[ovs-dev] [PATCH 1/3] logical-fields: Add ct.dnat and ct.snat symbols.

2016-11-03 Thread Gurucharan Shetty
Upcoming commits use it. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/lib/logical-fields.c | 2 ++ ovn/ovn-sb.xml | 19 +-- tests/ovn.at | 4 +++- 3 files changed, 22 insertions(+), 3 deletions(-) diff --git a/ovn/lib/logical-fields.c b/o

[ovs-dev] [PATCH v2] ovn: Add a case of policy based routing.

2016-10-06 Thread Gurucharan Shetty
t effected in the policy based routing table itself. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c | 24 +++-- ovn/ovn-nb.ovsschema | 8 +- ovn/ovn-nb.xml| 26 + ovn/utilities/ovn-nbctl.8.xml | 8 +- ovn/utilities/ovn-n

[ovs-dev] [PATCH v2] ovn-controller: Container can have connection to a hosting VM.

2016-10-05 Thread Gurucharan Shetty
nhi...@vmware.com> Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- AUTHORS | 1 + ovn/controller/physical.c | 27 --- tests/ovn.at | 195 ++ 3 files changed, 211 insertions(+), 12 deletions(-) diff --git a/AUTHO

[ovs-dev] [PATCH] ovn-controller: Container can have connection to a hosting VM.

2016-10-04 Thread Gurucharan Shetty
nhi...@vmware.com> Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- AUTHORS | 1 + ovn/controller/physical.c | 18 ++--- tests/ovn.at | 179 ++ 3 files changed, 190 insertions(+), 8 deletions(-) diff --git a/AUTHO

[ovs-dev] [PATCH v3] INSTALL.md: Add details about kernel module preference.

2016-09-27 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- INSTALL.md | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/INSTALL.md b/INSTALL.md index bb40e4a..a073465 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -322,9 +322,30 @@ Building the Sources

[ovs-dev] [PATCH v2] INSTALL.md: Add details about kernel module preference.

2016-09-26 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- INSTALL.md | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/INSTALL.md b/INSTALL.md index bb40e4a..6ecefdf 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -322,9 +322,30 @@ Building the Sources

[ovs-dev] [PATCH] INSTALL.md: Add details about kernel module preference.

2016-09-26 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- INSTALL.md | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/INSTALL.md b/INSTALL.md index bb40e4a..a9b70db 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -322,9 +322,29 @@ Building the Sources 4. Run

[ovs-dev] [PATCH v2] ovn: Initialize the databases.

2016-09-19 Thread Gurucharan Shetty
Without initializing the databases, commands of the form 'ovn-nbctl --wait=sb ls-add ls0' will simply hang. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c | 10 +++--- ovn/utilities/ovn-ctl | 2 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff

[ovs-dev] [PATCH] ovn-ctl: Initialize the databases.

2016-09-19 Thread Gurucharan Shetty
Without initializing the databases, commands of the form 'ovn-nbctl --wait=sb ls-add ls0' will simply hang. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/utilities/ovn-ctl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl index 0

[ovs-dev] [PATCH 2/2] ovn-northd: Format logical flows a little better.

2016-09-12 Thread Gurucharan Shetty
This is a cosmetic fix. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 648bd88..8b6f6a3 100644 --- a/ovn/northd/ovn-northd.c

[ovs-dev] [PATCH 1/2] ovn-northd: Fix a memory leak.

2016-09-12 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 5ccb516..648bd88 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -2570,6 +

[ovs-dev] [PATCH] ofctrl: Fix logic for mff_ovn_geneve.

2016-09-09 Thread Gurucharan Shetty
Fixes: 7fa39c6b9376e99 ("Fix memory leak in recv_S_TLV_TABLE_REQUESTED().") Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/controller/ofctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/controller/ofctrl.c b/ovn/controller/ofctrl.c index

[ovs-dev] [PATCH] ovn-controller: Fix group_id allocation.

2016-09-07 Thread Gurucharan Shetty
the above scenario. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- include/ovn/actions.h | 2 ++ ovn/controller/ofctrl.c | 6 +- ovn/lib/actions.c | 3 +++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/ovn/actions.h b/include/ovn/actions.h index d

[ovs-dev] [PATCH] ovn-northd: Tag allocation for nested containers.

2016-09-06 Thread Gurucharan Shetty
When there are hundreds of nodes controlled by OVN, the workflow to track and allocate unique tags across multiple hosts becomes complicated. It is much easier to let ovn-northd do the allocation. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c

[ovs-dev] [PATCH 2/2] ovn-northd: Add load-balancers to gateway routers.

2016-08-23 Thread Gurucharan Shetty
rn chooses a DNAT action. Established connections go through the DNAT table for a regular DNAT. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.8.xml | 63 +++ ovn/northd/ovn-northd.c | 150 +--- ovn/

[ovs-dev] [PATCH 0/2] load-balancer fix for north-south direction.

2016-08-23 Thread Gurucharan Shetty
the load_balancer to the gateway router too. It has the added benefit that it works fine with floating IPs for north-south traffic. i.e., floating ips can be load-balanced to logical ips. Gurucharan Shetty (2): ovn-controller: Datapath based conntrack zone for load-balancing. ovn-northd: Add load-balancers

[ovs-dev] [PATCH 1/2] ovn-controller: Datapath based conntrack zone for load-balancing.

2016-08-23 Thread Gurucharan Shetty
Currently ct_lb() logical action is only added for a logical switch and we use the conntrack zone allocated for the logical port. A future commit will use ct_lb() for a logical router too. In that case, use the allocated DNAT zone. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- i

[ovs-dev] [PATCH v2] system-ovn.at: Fix occasional test failures.

2016-08-19 Thread Gurucharan Shetty
A run of the NAT unit tests hundred times showed some occasional unit test failures. With this commit, I haven't seen any failures for 100 runs. Reported-by: Joe Stringer <j...@ovn.org> Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- tests/system-ovn.at | 8 ++-- 1 fil

[ovs-dev] [PATCH] ovn-controller: Don't clear desired groups during backlog.

2016-08-18 Thread Gurucharan Shetty
Doing so would mean that we will lose the desired groups forever because of incremental processing (till the next change in NB database). Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/controller/ofctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ovn/controller/ofctrl.c

[ovs-dev] [PATCH] system-ovn.at: Fix occasional test failures.

2016-08-16 Thread Gurucharan Shetty
A run of the NAT unit tests hundred times showed some occasional unit test failures. With this commit, I haven't seen any failures for 100 runs. Reported-by: Joe Stringer <j...@ovn.org> Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- tests/system-ovn.at | 8 ++-- 1 fil

[ovs-dev] [PATCH v2 1/2] ovn: Ability to set multiple load balancers.

2016-08-12 Thread Gurucharan Shetty
The schema prevented one from setting more than one load balancer to a switch. This removes that anomaly. (The test has a slightly unrelated change where it increases the number of connections to get rid of some occasional unit test failures.) Signed-off-by: Gurucharan Shetty <g...@ovn.

[ovs-dev] [PATCH v2 2/2] system-ovn.at: Add another load-balancing test.

2016-08-12 Thread Gurucharan Shetty
The client and servers are in the same subnet. (This would not have worked without the recent IPv6 patches that let packets to loop back) Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- tests/system-ovn.at | 118 1 file change

[ovs-dev] [PATCH 2/2] system-ovn.at: Add another load-balancing test.

2016-08-12 Thread Gurucharan Shetty
The client and servers are in the same subnet. (This would not have worked without the recent IPv6 patches that let packets to loop back) Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- tests/system-ovn.at | 117 1 file change

[ovs-dev] [PATCH 1/2] ovn: Ability to set multiple load balancers.

2016-08-12 Thread Gurucharan Shetty
The schema prevented one from setting more than one load balancer to a switch. This removes that anamoly. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c | 38 +++--- ovn/ovn-nb.ovsschema| 6 +++--- tests/system-ovn.at

[ovs-dev] [PATCH] ovn-northd: Warn when the peer of a router port is a switch port.

2016-07-18 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c | 8 1 file changed, 8 insertions(+) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 7ce509d..0a093c7 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -2603,6 +2

[ovs-dev] [PATCH] ovn.at: A "peer" is only for interconnected routers.

2016-07-18 Thread Gurucharan Shetty
s.") Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- tests/ovn.at | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 12de125..4f077d4 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -1508,8 +1508,7 @@ done o

[ovs-dev] [PATCH v2] ovn-northd: Combine two NAT loops into one.

2016-07-13 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c | 47 ++- 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index b1c2c6c..52e3229 100644 --- a/ovn/nort

[ovs-dev] [PATCH v2 2/2] system-ovn.at: Add a OVN load-balancing unit test.

2016-07-13 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- tests/system-ovn.at | 125 1 file changed, 125 insertions(+) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index b4cbc85..13f380f 100644 --- a/tests/system-ovn.at +++ b/tests/

[ovs-dev] [PATCH v2 1/2] system-ovn.at: Add a OVN NAT test using OVN gateway.

2016-07-13 Thread Gurucharan Shetty
multi-host scenarios (without NAT testing), so it should still be a decent coverage. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- tests/automake.mk | 2 + tests/system-kmod-testsuite.at | 1 + tests/system-ovn.at

[ovs-dev] [PATCH] ovn-northd: Combine two NAT loops into one.

2016-07-12 Thread Gurucharan Shetty
It is wasteful to have two loops that go through all the NAT entries. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c | 45 + 1 file changed, 13 insertions(+), 32 deletions(-) diff --git a/ovn/northd/ovn-northd.c

[ovs-dev] [PATCH 4/4] system-ovn.at: Add a OVN load-balancing unit test.

2016-07-12 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- Please note that there are a couple of unit tests around fragmentation (unrelated to OVN) that can cause kernel crashes when you run OVN kernel tests. So, if you intend to run these, run it via: make check-kmod TESTSUITEFLAGS="-k ovn&

[ovs-dev] [PATCH 2/4] system-common-macros.at: Add a iface-id to interfaces.

2016-07-12 Thread Gurucharan Shetty
IntegrationGuide.md explains the meaning of the key 'iface-id'. Adding it as part of ADD_VETH is useful for OVN related tests. For non-OVN tests, it should have no effect. Upcoming commits take advantage of this. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- tests/system-common-mac

[ovs-dev] [PATCH 3/4] system-ovn.at: Add a OVN NAT test using OVN gateway.

2016-07-12 Thread Gurucharan Shetty
multi-host scenarios (without NAT testing), so it should still be a decent coverage. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- Please note that there are a couple of unit tests around fragmentation (unrelated to OVN) that can cause kernel crashes when you run OVN kernel tests. So,

[ovs-dev] [PATCH 1/4] system-common-macros: Enhance ADD_VETH to take mac and gateway.

2016-07-12 Thread Gurucharan Shetty
It is useful to set the mac address and gateway while using ADD_VETH to connect a namespace to a OVN logical topology. Upcoming commits use this enhancement. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- tests/system-common-macros.at | 11 ++- 1 file changed, 10 insertions

[ovs-dev] [PATCH v2] ovn-controller: Change strategy for gateway conntrack zone allocation.

2016-07-08 Thread Gurucharan Shetty
in the commit. i.e. ovn-controller would crash. ) Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- This applies on top of https://patchwork.ozlabs.org/patch/646268/. I will rebase this if the dependent patch changes. --- ovn/controller/ovn-controller.c | 4 ++-- ovn/controller/ovn-controller.

[ovs-dev] [PATCH 2/2] ovn-controller: Change strategy for gateway conntrack zone allocation.

2016-07-08 Thread Gurucharan Shetty
ssing.") Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- This applies on top of https://patchwork.ozlabs.org/patch/646268/. I will rebase this if the dependent patch changes. --- ovn/controller/ovn-controller.c | 4 ++-- ovn/controller/ovn-controller.h | 2 +- ovn/controller/patch.c

[ovs-dev] [PATCH] INSTALL.Docker.md: Clarify OVS python library path.

2016-07-07 Thread Gurucharan Shetty
Reported-by: Taekho Nam <th...@smartx.kr> Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- AUTHORS | 1 + INSTALL.Docker.md | 23 +++ 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/AUTHORS b/AUTHORS index 704ba40..5d86dc6 100644 -

[ovs-dev] [PATCH 1/2] ovn-northd: Ability to loop-back in a router.

2016-07-05 Thread Gurucharan Shetty
that behavior and lets an OVN router loop-back the packet via the same interface. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.8.xml | 10 ++ ovn/northd/ovn-northd.c | 10 ++ 2 files changed, 20 insertions(+) diff --git a/ovn/northd/ovn-no

[ovs-dev] [PATCH 2/2] ovn-nb: Update documentation for Load balancers.

2016-07-05 Thread Gurucharan Shetty
Clarify that the load balancers needs a router in the topology. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/ovn-nb.xml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml index ff2e695..a1f560a 100644 --- a/ovn/ovn-nb.xml +++ b/ovn/ovn-

[ovs-dev] [PATCH 1/2] ovn-nbctl: Ability to update a route's output port.

2016-07-01 Thread Gurucharan Shetty
The command 'lr-route-add' currently cannot update the output port. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/utilities/ovn-nbctl.c | 4 tests/ovn-nbctl.at| 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-nbctl.c

[ovs-dev] [PATCH 2/2] ovn: Add a case of policy based routing.

2016-07-01 Thread Gurucharan Shetty
. Since each host gets a specific subnet, we can use source IP address based policy routing to decide on the gateway router. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c | 20 +++-- ovn/ovn-nb.ovsschema | 8 +- ovn/ovn-nb.xml| 22

[ovs-dev] [PATCH 7/7] ovn-northd: Logical flows for load balancers.

2016-06-29 Thread Gurucharan Shetty
("$IP_LIST") action. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.c | 201 +--- 1 file changed, 190 insertions(+), 11 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index ba80fbe

[ovs-dev] [PATCH 6/7] ovn-controller: Add support for load balancing.

2016-06-29 Thread Gurucharan Shetty
(192.168.1.2, 192.168.1.3); ct_lb(192.168.1.2:80, 192.168.1.3:80); Creates an OpenFlow group with multiple buckets and equal weights that changes the destination IP address (and port number) of the packet statefully to one of the options provided inside the parenthesis. Signed-off-by: Gurucharan

[ovs-dev] [PATCH 2/7] ovn-northd.8: Update documentation.

2016-06-29 Thread Gurucharan Shetty
-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.8.xml | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml index 260cc14..4d712a1 100644 --- a/ovn/northd/ovn-northd

[ovs-dev] [PATCH 5/7] ovn-nb: Add Load-balancer table to schema.

2016-06-29 Thread Gurucharan Shetty
Also add the ability to run database commands on the new schema using ovn-nbctl. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/ovn-nb.ovsschema | 22 -- ovn/ovn-nb.xml| 41 + ovn/utilities/ovn-nbctl.

[ovs-dev] [PATCH 1/7] ovn-northd: Split ACL and pre-ACL processing.

2016-06-29 Thread Gurucharan Shetty
Future patches introduce more tables between pre-ACL and ACL processing. As such, it looks easier to separate these out into separate functions to enhance code readability. Signed-off-by: Gurucharan Shetty <g...@ovn.org> Acked-by: Ben Pfaff <b...@ovn.org> --- ovn/northd/ovn-n

[ovs-dev] [PATCH 3/7] ovn-northd: Introduce pre-stateful table.

2016-06-29 Thread Gurucharan Shetty
in-turn will send the packet to conntrack if 'reg0[0]' is 1. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/northd/ovn-northd.8.xml | 36 ++- ovn/northd/ovn-northd.c | 46 +++-- 2 files changed, 63 insertions(

[ovs-dev] [PATCH 4/7] ovn-northd: Introduce stateful table.

2016-06-29 Thread Gurucharan Shetty
load balancing, this commit introduces a new stateful table that is responsible to commit packets to conntrack via ct_commit action. If ACL table needs to commit a packet, it sets 'reg0[1]' as 1. Stateful table in-turn will commit the packet if 'reg0[1]' is 1. Signed-off-by: Gurucharan Shetty &l

[ovs-dev] [PATCH 0/7] OVN load-balancers.

2016-06-29 Thread Gurucharan Shetty
cer \ vips:'"30.0.0.1:8000"'='"172.16.1.2:80,172.16.1.3:80,172.16.1.4:80"' And then attach the created load_balancer to any logical switch where the client resides. e.g.: ovn-nbctl set logical_switch foo \ load_balancer=91facf32-d6f1-43e9-bead-54c59af493e1 Gurucharan Shett

[ovs-dev] [PATCH v4] ovn: DNAT and SNAT on a gateway router.

2016-06-09 Thread Gurucharan Shetty
could combine case1 and case2 with nat type="dnat_and_snat" if the IP addresses are the same. case3 : SNAT and DNAT (east-west traffic) When bar1 pings 30.0.0.2, the traffic jumps to the gateway router and loops back to foo1 with a source ip address of 30.0.0.1 Signed-off-by: Gurucharan Shett

[ovs-dev] [PATCH 0/8] Make ovs-bugtool flake8 compatible.

2016-06-06 Thread Gurucharan Shetty
*** BLURB HERE *** Gurucharan Shetty (8): ovs-bugtool.in: Remove unused imports. ovs-bugtool.in: Fix errors around spaces and line length. ovs-bugtool.in: Remove unused variables. ovs-bugtool.in: Remove usage of 'has_key'. ovs-bugtool.in: Test for membership should be 'not in'. ovs

[ovs-dev] [PATCH 4/8] ovs-bugtool.in: Remove usage of 'has_key'.

2016-06-06 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- utilities/bugtool/ovs-bugtool.in | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugtool/ovs-bugtool.in index cd1924d..95ea482 100755 --- a/uti

[ovs-dev] [PATCH 3/8] ovs-bugtool.in: Remove unused variables.

2016-06-06 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- utilities/bugtool/ovs-bugtool.in | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugtool/ovs-bugtool.in index 605a6bf..cd1924d 100755 --- a/utilities/bugtool/ovs-bugt

[ovs-dev] [PATCH 2/8] ovs-bugtool.in: Fix errors around spaces and line length.

2016-06-06 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- utilities/bugtool/ovs-bugtool.in | 235 ++- 1 file changed, 135 insertions(+), 100 deletions(-) diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugtool/ovs-bugtool.in index 9e1f535..605a6bf

[ovs-dev] [PATCH 1/8] ovs-bugtool.in: Remove unused imports.

2016-06-06 Thread Gurucharan Shetty
Also take care of a 'import not at top of file' warning from flake8. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- utilities/bugtool/ovs-bugtool.in | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugto

[ovs-dev] [PATCH v3 3/5] ovn-controller: Refactor conntrack zone allocation.

2016-05-19 Thread Gurucharan Shetty
, this commit moves conntrack zone allocation code to ovn-controller.c where it would be easily accessible for router zone allocation too. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/controller/binding.c| 61 - ovn/controller/bin

[ovs-dev] [PATCH v3 5/5] ovn: DNAT and SNAT on a gateway router.

2016-05-19 Thread Gurucharan Shetty
ffic jumps to the gateway router and loops back to foo1 with a source ip address of 30.0.0.3 Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/lib/actions.c | 83 + ovn/northd/ovn-northd.8.xml | 129 +++--- ovn/northd/ovn-northd.c

[ovs-dev] [PATCH v3 4/5] ovn-controller: Assign conntrack zones for gateway router.

2016-05-19 Thread Gurucharan Shetty
OVS NAT currently cannot do snat and dnat in the same zone. So we need two zones per gateway router. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/controller/ovn-controller.c | 52 +++-- ovn/controller/ovn-controller.h | 2 ++ ovn/controller/p

[ovs-dev] [PATCH v3 2/5] ovn: Introduce l3 gateway router.

2016-05-19 Thread Gurucharan Shetty
on that chassis populates the "chassis" column for this record as an indication for other ovn-controllers of its physical location. Other ovn-controllers treat this port as they would treat a VM/Container port on a different chassis. Signed-off-by: Gurucharan Shetty <g...@ovn.

[ovs-dev] [PATCH v3 1/5] ovn-northd: Support connecting multiple routers to a switch.

2016-05-19 Thread Gurucharan Shetty
a a switch. With the above goal in mind, this commit gives the general ability to connect multiple routers via a switch. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- ovn/controller/lflow.c | 19 ++-- ovn/northd/ovn-northd.c | 56 +++- ovn/ovn-nb.xml | 7

[ovs-dev] [PATCH] tests: Add valgrind targets for ovn utilities and dameons.

2016-05-12 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- tests/automake.mk |4 1 file changed, 4 insertions(+) diff --git a/tests/automake.mk b/tests/automake.mk index a5c6074..211a80d 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -152,6 +152,10 @@ check-lcov: all tests/at

[ovs-dev] [RFC 5/5 v2] ovn: DNAT and SNAT on a gateway router.

2016-05-10 Thread Gurucharan Shetty
Add a SNAT rule in R2: ovn-nbctl set logical_router R2 snat:"192.168.1.0/24"=30.0.0.1 (You need a static route in R1 to send packets destined to outside world to go through R2) When foo1 pings alice1, alice1 receives traffic from 30.0.0.1 case3 : SNAT and DNAT (east-west traffic) You do

[ovs-dev] [PATCH 4/5] ovn-controller: Assign conntrack zones for gateway router.

2016-05-10 Thread Gurucharan Shetty
OVS NAT currently cannot do snat and dnat in the same zone. So we need two zones per gateway router. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- No v1. Newly added as part of v2. --- ovn/controller/ovn-controller.c | 50 +-- ovn/controll

[ovs-dev] [PATCH 3/5 v2] ovn-controller: Refactor conntrack zone allocation.

2016-05-10 Thread Gurucharan Shetty
, this commit moves conntrack zone allocation code to ovn-controller.c where it would be easily accessible for router zone allocation too. Signed-off-by: Gurucharan Shetty <g...@ovn.org> --- No v1. Newly added as part of v2. --- ovn/controller/binding.c

[ovs-dev] [PATCH 2/5] ovn: Introduce l3 gateway router.

2016-05-10 Thread Gurucharan Shetty
on that chassis populates the "chassis" column for this record as an indication for other ovn-controllers of its physical location. Other ovn-controllers treat this port as they would treat a VM/Container port on a different chassis. Signed-off-by: Gurucharan Shetty <g...@ovn.o

  1   2   3   4   5   6   7   8   9   10   >