Hi Guru,
There are other tests that check if the daemon is running fine.
In my opinion we could skip this test on Windows and let it on Linux to run.
Paul
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Tuesday, August 30, 2016 6:18 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev
test-unixctl.py and test-vlog.py outputs on stderr and on Windows
stderr is not overriden by every AT_CHECK call, the logs are only
apended to the file and subsequent AT_CHECKs get errors from previous
call.
Signed-off-by: Paul-Daniel Boca
---
V2: No changes.
---
tests/unixctl-py.at | 3 ++-
tes
This patch removes the code which disables Python tests to be run on
Windows.
Signed-off-by: Paul-Daniel Boca
---
V2: No changes.
---
tests/atlocal.in | 7 ---
1 file changed, 7 deletions(-)
diff --git a/tests/atlocal.in b/tests/atlocal.in
index 55070d8..6e744db 100644
--- a/tests/atlocal.i
The tests are not intended to run on Windows.
Until now they were skipped based on $HAVE_PYTHON only.
Signed-off-by: Paul-Daniel Boca
---
V2: No changes.
---
tests/ovn-controller-vtep.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-
AF_UNIX sockets are not supported on Windows.
Instead of an AF_UNIX socket use named pipes to communicate
between components. This makes the python sockets compatible with
the named pipe used in Windows applications.
Added stream_windows.py with named pipe and localhost
tcp connections support.
Si
Implemented a wrapper over every function from daemon_unix.
This will help on porting daemon to Windows.
Signed-off-by: Paul-Daniel Boca
---
V2: No changes.
---
python/automake.mk | 1 +
python/ovs/daemon.py | 77
2 files changed, 78 insert
Used subprocess.Popen instead os.fork (not implemented on windows)
and repaced of os.pipe with Windows pipes.
To be able to identify the child process I added an extra parameter
to daemon process '--pipe-handle', this parameter also contains
the parent Windows pipe handle, used by the child to sig
Prepare for porting unix daemon to Windows.
Signed-off-by: Paul-Daniel Boca
---
V2: No changes.
---
python/automake.mk | 2 +-
python/ovs/{daemon.py => daemon_unix.py} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename python/ovs/{daemon.py => daemon_unix.py} (100%
Prepare for porting unix sockets to Windows named-pipes.
Signed-off-by: Paul-Daniel Boca
---
V2: Moved test-jsonrpc.py changes from next patch to current one.
---
python/automake.mk | 2 +-
python/ovs/jsonrpc.py| 14 +++---
python/ovs/{stream.py
If the python script is killed with `kill` command, the atexit
handler doesn't gets executed on Windows.
The kill of the process is done using NtTerminateProcess which
doesn't sends a signal to the process itself, if just terminates the process
from kernel mode.
Signed-off-by: Paul-Daniel Boca
--
There is a difference between POSIX pid and Windows pid, not all the time are
equal.
On Windows when a python script is started, a sh command is triggered as the
parent
for script. So when we try to get the daemon pid with 'echo $!', this will get
the pid of sh
not of python.exe as expected.
Som
This series of patches ports python daemon and unixctl to Windows.
All patches depend on each other.
The the daemon was ported using pywin32 python library using Win32 API
and unixctl was ported using named-pipes in order to be compatible with
OVS Windows applications.
Paul-Daniel Boca (10):
py
]
Sent: Friday, August 26, 2016 9:07 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 09/12] python tests: Skip ovn-controller-vtep
tests on Windows
On 26 August 2016 at 07:40, Paul Boca
mailto:pb...@cloudbasesolutions.com>> wrote:
The tests are not intended to run on W
Hi Guru,
I will take this patch out from this series and will retest it.
Thanks,
Paul
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Friday, August 26, 2016 9:12 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 11/12] ovsdb-monitor: Skip monitor-cond tests on
Windows
On
A connection can be both a reply and related.
Signed-off-by: Paul-Daniel Boca
---
datapath-windows/ovsext/Conntrack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Conntrack.c
b/datapath-windows/ovsext/Conntrack.c
index af3d966..74fb38c 100644
--- a
In user mode the flags are interpreted as little endian.
This fix makes the kernel mode compatible with user mode.
Signed-off-by: Paul-Daniel Boca
---
datapath-windows/ovsext/Conntrack-tcp.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/datapath-windows/ovsex
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Monday, August 29, 2016 9:20 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output
So you are saying that running $srcdir/test-unixctl.py on Windows produces
output in stderr. Why? Is
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Monday, August 29, 2016 8:44 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output
On 29 August 2016 at 10:36, Paul Boca
mailto:pb...@cloudbasesolutions.com>> wrote:
Hi Guru,
plea
Hi Guru,
please see my comments inline.
Thanks,
Paul
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Friday, August 26, 2016 9:04 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output
On 26 August 2016 at 07:40, Paul Boca
mailto:pb
Hi Guru,
please see my comment inline.
Thanks,
Paul
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Friday, August 26, 2016 8:39 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 01/12] python tests: Skip python tests specific
to Linux
On 26 August 2016 at 07:40, Paul
Hi Guru,
I retested without this patch and indeed there is no flake error.
For some reason it gave me some errors when I made the changes.
I will get this changes out.
Thanks,
Paul
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Friday, August 26, 2016 9:01 PM
To: Paul Boca
Cc: dev
Hi Guru,
Thanks for suggestion.
Paul
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Friday, August 26, 2016 8:58 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 03/12] python tests: Ported UNIX sockets to
Windows
On 26 August 2016 at 07:40, Paul Boca
mailto:pb
This patch removes the code which disables Python tests to be run on
Windows.
Signed-off-by: Paul-Daniel Boca
---
tests/atlocal.in | 7 ---
1 file changed, 7 deletions(-)
diff --git a/tests/atlocal.in b/tests/atlocal.in
index 55070d8..6e744db 100644
--- a/tests/atlocal.in
+++ b/tests/atloca
The ovsdb-client doesn't suport detach and listening on a local port
on Windows.
The --detach switch is ignored.
Signed-off-by: Paul-Daniel Boca
---
tests/ovsdb-monitor.at | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/tests/ovsdb-monitor.at b/tests/ovsdb-monitor
The ipsec feature is not implemented on windows.
Signed-off-by: Paul-Daniel Boca
---
tests/tunnel.at | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/tunnel.at b/tests/tunnel.at
index 477517e..dbc6a11 100644
--- a/tests/tunnel.at
+++ b/tests/tunnel.at
@@ -198,6 +198,7 @@ AT_CLEANUP
The tests are not intended to run on Windows.
Until now they were skipped based on $HAVE_PYTHON only.
Signed-off-by: Paul-Daniel Boca
---
tests/ovn-controller-vtep.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at
i
test-unixctl.py and test-vlog.py outputs on stderr and on Windows
stderr is not overriden by every AT_CHECK call, the logs are only
apended to the file and subsequent AT_CHECKs get errors from previous
call.
Signed-off-by: Paul-Daniel Boca
---
tests/unixctl-py.at | 3 ++-
tests/vlog.at | 9
Used subprocess.Popen instead os.fork (not implemented on windows)
and repaced of os.pipe with Windows pipes.
To be able to identify the child process I added an extra parameter
to daemon process '--pipe-handle', this parameter also contains
the parent Windows pipe handle, used by the child to sig
Fixed small alignement issues.
Signed-off-by: Paul-Daniel Boca
---
python/ovs/daemon_unix.py | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/python/ovs/daemon_unix.py b/python/ovs/daemon_unix.py
index bd06195..0080677 100644
--- a/python/ovs/daemon_unix.py
+++ b/python
Implemented a wrapper over every function from daemon_unix.
This will help on porting daemon to Windows.
Signed-off-by: Paul-Daniel Boca
---
python/automake.mk | 1 +
python/ovs/daemon.py | 77
2 files changed, 78 insertions(+)
create mode
Prepare for porting unix daemon to Windows.
Signed-off-by: Paul-Daniel Boca
---
python/automake.mk | 2 +-
python/ovs/{daemon.py => daemon_unix.py} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename python/ovs/{daemon.py => daemon_unix.py} (100%)
diff --git a/pyth
AF_UNIX sockets are not supported on Windows.
Instead of an AF_UNIX socket use named pipes to communicate
between components. This makes the python sockets compatible with
the named pipe used in Windows applications.
Added stream_windows.py with named pipe and localhost
tcp connections support.
Si
Prepare for porting unix sockets to Windows named-pipes.
Signed-off-by: Paul-Daniel Boca
---
python/automake.mk | 2 +-
python/ovs/jsonrpc.py| 14 +++---
python/ovs/{stream.py => stream_unix.py} | 0
python/ovs/unixctl/client.py |
This series of patches ports python daemon and unixctl to Windows.
All patches depend on each other.
The the daemon was ported using pywin32 python library using Win32 API
and unixctl was ported using named-pipes in order to be compatible with
OVS Windows applications.
Paul-Daniel Boca (12):
py
There is a difference between POSIX pid and Windows pid, not all the time are
equal.
On Windows when a python script is started, a sh command is triggered as the
parent
for script. So when we try to get the daemon pid with 'echo $!', this will get
the pid of sh
not of python.exe as expected.
Som
Hi Guru!
Indeed there are some cases where that comment doesn’t apply.
Thanks for reporting this, I will update the comments accordingly.
Paul
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Wednesday, August 3, 2016 6:51 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH V11
include them in the commit description.
I will resend this patch after I add
[diff]
renames = copies
Thanks,
Paul
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Wednesday, August 3, 2016 7:07 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH V11 12/17] python tests: Prepare
Hi Guru!
There was a bug indeed and I solved it in V10 series.
Thanks for reporting this,
Paul
From: Guru Shetty [mailto:g...@ovn.org]
Sent: Friday, July 29, 2016 8:27 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH V8 00/17] Fix and enable Python tests on Windows
Thank
On Windows if a file is opened by an application for writing, we cannot move
it until all handles to that file are closed.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V4: No changes
V5: No changes
V6: Removed code that disables 'vlog/close' tests.
V7: Sm
The tests are not intended to run on Windows.
Until now they were skipped based on $HAVE_PYTHON only.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V4: No changes
V5: No changes
V6: No changes
V7: Removed Python check on running this test
V8: No changes
V9
test-unixctl.py and test-vlog.py outputs on stderr and on Windows
stderr is not overriden by every AT_CHECK call, the logs are only
apended to the file and subsequent AT_CHECKs get errors from previous
call.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V
This patch removes the code which disables Python tests to be run on
Windows.
Signed-off-by: Alin Gabriel Serdean
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: No changes
V9: No ch
Used subprocess.Popen instead os.fork (not implemented on windows)
and repaced of os.pipe with Windows pipes.
To be able to identify the child process I added an extra parameter
to daemon process '--pipe-handle', this parameter also contains
the parent Windows pipe handle, used by the child to sig
Renamed daemon.py to daemon_unix.py and implemented a wrapper over it.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V8: Initial commit.
V9: No changes
V10: Fixed exception on Unix
V11: No changes
---
python/automake.mk| 1 +
python/ovs/daemon.py | 489 ++
AF_UNIX sockets are not supported on Windows.
Instead of an AF_UNIX socket use localhost tcp connections to communicate
between components. This makes the python sockets compatible with
the ones used in Windows applications.
In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN error
There is a difference between POSIX pid and Windows pid, not all the time are
equal.
On Windows when a python script is started, a sh command is triggered as the
parent
for script. So when we try to get the daemon pid with 'echo $!', this will get
the pid of sh
not of python.exe as expected.
Als
IPsec is not used on Windows yet, and the services used by this test
are non-existent on Windows.
Also the paths in the test do not exist on Windows.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: Updated commit
On Windows if this exception is triggered then it will raise an exception while
in the
exception handler.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: Added comment when using OSE
This is needed for lockf function used to lock the PID file on Windows.
ioctl and fcntl functions are not implemented at this time because they are
not used by any script.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No chang
On windows a path containint ':' is considered an absolute path.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: No changes
V9: No changes
V10: No changes
V11: No changes
---
python/
The IPPROTO_IPV6 is not defined on Python for Windows because of
compatibility with older Windows versions.
Here is this issue discussed:https://bugs.python.org/issue6926
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No change
For bogus pid file path, use a windows-like file path.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: No changes
V9: No changes
V10: No changes
V11: No changes
---
tests/unixctl-py.
On Windows the CTL filename doesn't contain the pid of the process.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: Fixed flake8 errors. Addressed changes required by review.
V8: Fixed small alignem
SIGHUP and SIGALRM are not available on Windows.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as
EINPROGRESS on Windows
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: Simplified the
signal.alarm is not available in Windows and would trigger an exception
when called. Implemented this to mentain compatibility between
Windows and Linux for python tests.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: Code styling changes
V4: No changes
V5:
This series of patches ports the python damons to Windows and
fixes the tests to work on Windows.
There are still some python tests that fail on Windows, from which
some are failing on Linux too.
The patches in this series are dependent and are related to
python tests on Windows.
V2: Fixes more po
.
Thanks,
Paul
From: Cabrera Vega, Mario Alberto [mailto:mario.cabr...@hpe.com]
Sent: Monday, August 1, 2016 8:08 PM
To: Paul Boca
Cc: dev@openvswitch.org
Subject: RE: Replication feature bug
Hi,
The replication_init() function initializes the set that contains the names of
the
tables to be monitored
On Windows if a file is opened by an application for writing, we cannot move
it until all handles to that file are closed.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V4: No changes
V5: No changes
V6: Removed code that disables 'vlog/close' tests.
V7: Sm
test-unixctl.py and test-vlog.py outputs on stderr and on Windows
stderr is not overriden by every AT_CHECK call, the logs are only
apended to the file and subsequent AT_CHECKs get errors from previous
call.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V
The tests are not intended to run on Windows.
Until now they were skipped based on $HAVE_PYTHON only.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V4: No changes
V5: No changes
V6: No changes
V7: Removed Python check on running this test
V8: No changes
V9
Renamed daemon.py to daemon_unix.py and implemented a wrapper over it.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V8: Initial commit.
V9: No changes
V10: Fixed exception on Unix
---
python/automake.mk| 1 +
python/ovs/daemon.py | 489 ++
There is a difference between POSIX pid and Windows pid, not all the time are
equal.
On Windows when a python script is started, a sh command is triggered as the
parent
for script. So when we try to get the daemon pid with 'echo $!', this will get
the pid of sh
not of python.exe as expected.
Als
On windows a path containint ':' is considered an absolute path.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: No changes
V9: No changes
V10: No changes
---
python/ovs/util.py | 6
This patch removes the code which disables Python tests to be run on
Windows.
Signed-off-by: Alin Gabriel Serdean
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: No changes
V9: No ch
AF_UNIX sockets are not supported on Windows.
Instead of an AF_UNIX socket use localhost tcp connections to communicate
between components. This makes the python sockets compatible with
the ones used in Windows applications.
In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN error
Used subprocess.Popen instead os.fork (not implemented on windows)
and repaced of os.pipe with Windows pipes.
To be able to identify the child process I added an extra parameter
to daemon process '--pipe-handle', this parameter also contains
the parent Windows pipe handle, used by the child to sig
This is needed for lockf function used to lock the PID file on Windows.
ioctl and fcntl functions are not implemented at this time because they are
not used by any script.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No chang
On Windows if this exception is triggered then it will raise an exception while
in the
exception handler.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: Added comment when using OSE
The IPPROTO_IPV6 is not defined on Python for Windows because of
compatibility with older Windows versions.
Here is this issue discussed:https://bugs.python.org/issue6926
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No change
On Windows the CTL filename doesn't contain the pid of the process.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: Fixed flake8 errors. Addressed changes required by review.
V8: Fixed small alignem
IPsec is not used on Windows yet, and the services used by this test
are non-existent on Windows.
Also the paths in the test do not exist on Windows.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: Updated commit
For bogus pid file path, use a windows-like file path.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: No changes
V9: No changes
V10: No changes
---
tests/unixctl-py.at | 12
SIGHUP and SIGALRM are not available on Windows.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as
EINPROGRESS on Windows
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: Simplified the
signal.alarm is not available in Windows and would trigger an exception
when called. Implemented this to mentain compatibility between
Windows and Linux for python tests.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: Code styling changes
V4: No changes
V5:
This series of patches ports the python damons to Windows and
fixes the tests to work on Windows.
There are still some python tests that fail on Windows, from which
some are failing on Linux too.
The patches in this series are dependent and are related to
python tests on Windows.
V2: Fixes more po
lob/master/ovsdb/ovsdb-server.c#L1451
If the replication is set using ovs-appctl, the replication is correctly
initialized:
https://github.com/openvswitch/ovs/blob/0cedc9dbc1e4d40f975617ccf4b63cb594783443/ovsdb/ovsdb-server.c#L1073
Thanks,
Paul Boca
___
d
Acked-by: Paul Boca
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
> Sent: Tuesday, July 26, 2016 6:45 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH v2 4/4] datapath-windows: Fix VPORT when it is
> allocated b
Acked-by: Paul Boca
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
> Sent: Tuesday, July 26, 2016 6:45 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH v2 3/4] windows: document multiple NIC support
> setup
>
Acked-by: Paul Boca
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
> Sent: Tuesday, July 26, 2016 6:47 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH v2 2/4] datapath-windows: Add multiple switch
> internal por
; From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Paul Boca
> Sent: Friday, July 8, 2016 6:25 PM
> To: Ben Pfaff; Sorin Vinturis
> Cc: dev@openvswitch.org; Guru Shetty
> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Add Windows thread
> atomic APIs for x64 binaries.
Thanks for changes!
Acked-by: Paul Boca
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean
> Sent: Tuesday, July 26, 2016 6:44 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH v2 1/4] windows: Add internal switch port p
The tests are not intended to run on Windows.
Until now they were skipped based on $HAVE_PYTHON only.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V4: No changes
V5: No changes
V6: No changes
V7: Removed Python check on running this test
V8: No changes
V9
On Windows if a file is opened by an application for writing, we cannot move
it until all handles to that file are closed.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V4: No changes
V5: No changes
V6: Removed code that disables 'vlog/close' tests.
V7: Sm
This patch removes the code which disables Python tests to be run on
Windows.
Signed-off-by: Alin Gabriel Serdean
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: No changes
V9: No ch
Used subprocess.Popen instead os.fork (not implemented on windows)
and repaced of os.pipe with Windows pipes.
To be able to identify the child process I added an extra parameter
to daemon process '--pipe-handle', this parameter also contains
the parent Windows pipe handle, used by the child to sig
test-unixctl.py and test-vlog.py outputs on stderr and on Windows
stderr is not overriden by every AT_CHECK call, the logs are only
apended to the file and subsequent AT_CHECKs get errors from previous
call.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V
Renamed daemon.py to daemon_unix.py and implemented a wrapper over it.
Signed-off-by: Paul-Daniel Boca
---
V8: Initial commit.
V9: No changes
---
python/automake.mk| 1 +
python/ovs/daemon.py | 489 ++
python/ovs/daemon_unix.py | 530 +++
AF_UNIX sockets are not supported on Windows.
Instead of an AF_UNIX socket use localhost tcp connections to communicate
between components. This makes the python sockets compatible with
the ones used in Windows applications.
In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN error
On windows a path containint ':' is considered an absolute path.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: No changes
V9: No changes
---
python/ovs/util.py | 6 --
1 file c
There is a difference between POSIX pid and Windows pid, not all the time are
equal.
On Windows when a python script is started, a sh command is triggered as the
parent
for script. So when we try to get the daemon pid with 'echo $!', this will get
the pid of sh
not of python.exe as expected.
Als
On Windows if this exception is triggered then it will raise an exception while
in the
exception handler.
Signed-off-by: Paul-Daniel Boca
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: Added comment when using OSError on Windows
V9: No changes
-
The IPPROTO_IPV6 is not defined on Python for Windows because of
compatibility with older Windows versions.
Here is this issue discussed:https://bugs.python.org/issue6926
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No change
For bogus pid file path, use a windows-like file path.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
V8: No changes
V9: No changes
---
tests/unixctl-py.at | 12 +---
1 file cha
This is needed for lockf function used to lock the PID file on Windows.
ioctl and fcntl functions are not implemented at this time because they are
not used by any script.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No chang
IPsec is not used on Windows yet, and the services used by this test
are non-existent on Windows.
Also the paths in the test do not exist on Windows.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: Updated commit
On Windows the CTL filename doesn't contain the pid of the process.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: Fixed flake8 errors. Addressed changes required by review.
V8: Fixed small alignem
SIGHUP and SIGALRM are not available on Windows.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as
EINPROGRESS on Windows
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: Simplified the
signal.alarm is not available in Windows and would trigger an exception
when called. Implemented this to mentain compatibility between
Windows and Linux for python tests.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: Code styling changes
V4: No changes
V5:
This series of patches ports the python damons to Windows and
fixes the tests to work on Windows.
There are still some python tests that fail on Windows, from which
some are failing on Linux too.
The patches in this series are dependent and are related to
python tests on Windows.
V2: Fixes more po
I will resend this series once again.
I made a small mistake: " [PATCH V8 12/17] python tests: Ported Python daemon
to Windows"
should be 13/17.
Thanks!
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Paul Boca
> Sent: Tuesday, Ju
1 - 100 of 381 matches
Mail list logo
