Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

ACKs from all committers, including those moving to emeritus status, are much appreciated. Our policy requires a majority for this to be approved. Thank you! Russell Bryant -- Russell Bryant On Fri, May 19, 2023 at 10:53 AM Russell Bryant wrote: > The following document discusses emeri

[ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

of current committers (or the list of maintainers prior to this change) is required to move a committer to emeritus status. Signed-off-by: Russell Bryant CC: Alin Serdean CC: Andy Zhou CC: Ansis Atteka CC: Daniele Di Proietto CC: Gurucharan Shetty CC: Ian Stokes CC: Ilya Maximets CC: Jarno

Re: [ovs-dev] [PATCH] MAINTAINERS.rst: Make myself an active maintainer

Thanks, I applied this to master. On Thu, May 18, 2023 at 9:44 AM Alin Serdean wrote: > Acked-by: Alin Gabriel Serdean > > > > > > On 18 May 2023, at 15:40, Russell Bryant wrote: > > > > I am currently an emeritus committer, but I would like to become &g

[ovs-dev] [PATCH] MAINTAINERS.rst: Make myself an active maintainer

I am currently an emeritus committer, but I would like to become active again for a short period of time to work through some governance issues preventing us from updating our committers list following our approved policies for doing so. Signed-off-by: Russell Bryant --- MAINTAINERS.rst | 4

[ovs-dev] [PATCH ovn] MAINTAINERS: Move myself to emeritus status

From: Russell Bryant I have not been involved in OVN development long enough that I should transition to emeritus status. Signed-off-by: Russell Bryant --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 0d19bd622

[ovs-dev] [PATCH ovn] MAINTAINERS: Move myself to emeritus status

From: Russell Bryant I have not been involved in OVN development long enough that I should transition to emeritus status. Signed-off-by: Russell Bryant --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 0d19bd622

[ovs-dev] [PATCH] MAINTAINERS: Move myself to emeritus status

I have not been active in OVS development in long enough that I should move to emeritus status. Signed-off-by: Russell Bryant --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 1dc406170..5df9aab78 100644

[ovs-dev] [PATCH] MAINTAINERS: Move myself to emeritus status

From: Russell Bryant I have not been active in OVS development in long enough that I should move to emeritus status. Signed-off-by: Russell Bryant --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 1dc406170

Re: [ovs-dev] [PATCH ovn v1] northd: Allow /64 after ipv6_prefix

On Thu, Feb 20, 2020 at 10:46 AM Numan Siddique wrote: > On Wed, Feb 19, 2020 at 9:27 PM Russell Bryant wrote: > > > > We recently hit a bug in ovn-kubernetes, where I accidentally added > > /64 at the end of ipv6_prefix, to match the format we used for the >

[ovs-dev] [PATCH ovn v1] northd: Allow /64 after ipv6_prefix

l enforces a /64 CIDR prefix length. A test case was updated to ensure that a prefix with "/64" is now accepted. Signed-off-by: Russell Bryant --- northd/ovn-northd.c | 31 +-- tests/ovn.at| 4 +++- 2 files changed, 32 insertions(+), 3 deletions(-)

Re: [ovs-dev] [PATCH ovn v1] northd: Load config before processing nbdb contents

On Mon, Dec 9, 2019 at 11:44 AM Numan Siddique wrote: > On Mon, Dec 9, 2019 at 11:05 AM Russell Bryant wrote: > > > > Reorder ovnnb_db_run() such that configuration parameters are loaded > > or initialized before processing the nbdb contents. > > > > I found t

Re: [ovs-dev] [PATCH ovn v1 2/2] northd: Log all dynamic address assignments

On Mon, Dec 9, 2019 at 11:18 AM Numan Siddique wrote: > On Mon, Dec 9, 2019 at 8:17 AM Russell Bryant wrote: > > > > On Mon, Dec 9, 2019 at 3:01 AM Dumitru Ceara wrote: > > > > > On Sun, Dec 8, 2019 at 5:12 AM Russell Bryant wrote: > > > > >

[ovs-dev] [PATCH ovn v1] northd: Load config before processing nbdb contents

by the Pod. This bug can cause all of this to get out of sync, breaking network connectivity for Pods on an OVN virtual network. Signed-off-by: Russell Bryant --- northd/ovn-northd.c | 78 ++--- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git

Re: [ovs-dev] [PATCH ovn v1 1/2] tests: Updated expected log message

On Mon, Dec 9, 2019 at 2:54 AM Dumitru Ceara wrote: > On Sun, Dec 8, 2019 at 5:18 AM Russell Bryant wrote: > > > > A previous commit added more detail to this log message. Fix the test > > to reflect the new text. > > > > Signed-off-by: Russell Bryant >

Re: [ovs-dev] [PATCH ovn v1 2/2] northd: Log all dynamic address assignments

On Mon, Dec 9, 2019 at 3:01 AM Dumitru Ceara wrote: > On Sun, Dec 8, 2019 at 5:12 AM Russell Bryant wrote: > > > > This patch adds INFO level log messages for all dynamic address > > assignments (MAC, IPv4, IPv6). While debugging some issues in > > ovn-kubernetes,

[ovs-dev] [PATCH ovn v1 1/2] tests: Updated expected log message

A previous commit added more detail to this log message. Fix the test to reflect the new text. Signed-off-by: Russell Bryant --- tests/ovn.at | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 8f4d9a440..1d5369341 100644

[ovs-dev] [PATCH ovn v1 2/2] northd: Log all dynamic address assignments

This patch adds INFO level log messages for all dynamic address assignments (MAC, IPv4, IPv6). While debugging some issues in ovn-kubernetes, I found it would be helpful to see ovn-northd's view of what addresses were assigned where and when from its perspective. Signed-off-by: Russell Bryant

Re: [ovs-dev] [PATCH ovn v1] nbctl: Log the source of duplicate IP addresses

On Fri, Dec 6, 2019 at 7:39 PM Han Zhou wrote: > > > On Fri, Dec 6, 2019 at 12:13 PM Russell Bryant wrote: > > > > When doing an lsp-add, ovn-nbctl will ensure that there is not another > > port on the same logical switch with the same IP address. I'm seeing &g

[ovs-dev] [PATCH ovn v1] nbctl: Log the source of duplicate IP addresses

happening. Signed-off-by: Russell Bryant --- utilities/ovn-nbctl.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c index 8188948fa..46ba3a938 100644 --- a/utilities/ovn-nbctl.c +++ b/utilities/ovn-nbctl.c

Re: [ovs-dev] [PATCH ovn v1] northd: Remove misleading warning log message

On Mon, Dec 2, 2019 at 3:45 AM Numan Siddique wrote: > > On Mon, Dec 2, 2019 at 8:54 AM Russell Bryant wrote: > > > > While debugging an ovn-kubernetes cluster, I spotted several > > "Duplicate MAC set" warning messages in the ovn-northd log. It looks >

[ovs-dev] [PATCH ovn v1] northd: Remove misleading warning log message

he warning for that case. Signed-off-by: Russell Bryant --- northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index a943e1037..9f558c628 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -1395,7 +1395,7 @@ ipam_get_

Re: [ovs-dev] [PATCH ovn] northd: Match IPv4 or IPv6 for MAC resolution

On Tue, Nov 19, 2019 at 5:32 PM Han Zhou wrote: > > > On Tue, Nov 19, 2019 at 2:19 PM Russell Bryant wrote: > >> On Tue, Nov 19, 2019 at 4:44 PM Han Zhou wrote: >> > >> > >> > >> > On Tue, Nov 19, 2019 at 1:38 PM Han Zhou wrote: >>

Re: [ovs-dev] [PATCH ovn] northd: Match IPv4 or IPv6 for MAC resolution

On Tue, Nov 19, 2019 at 4:44 PM Han Zhou wrote: > > > > On Tue, Nov 19, 2019 at 1:38 PM Han Zhou wrote: >> >> >> >> On Tue, Nov 19, 2019 at 3:33 AM Numan Siddique wrote: >> > >> > On Tue, Nov 19, 2019 at 7:04 AM Russell Bryant wrote: &g

Re: [ovs-dev] [PATCH ovn] northd: Match IPv4 or IPv6 for MAC resolution

On Tue, Nov 19, 2019 at 6:33 AM Numan Siddique wrote: > > On Tue, Nov 19, 2019 at 7:04 AM Russell Bryant wrote: > > > > While debugging some problems in a cluster using ovn-kubernetes, I > > noticed that we're creating two conflicting logical flows. These tw

[ovs-dev] [PATCH ovn] northd: Match IPv4 or IPv6 for MAC resolution

or ip6 match to each flow as appropriate. Signed-off-by: Russell Bryant --- northd/ovn-northd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- NOTE --- I've only tested this by running "make check" and "make check-kernel" so far, and all tests still pass. If I

[ovs-dev] [PATCH ovn v2] system-ovn.at: Create IPv6 load balancing tests

Duplicate all of the IPv4 load balancing test cases for IPv6. All of these are passing without any changes needed in OVN code, but this will help ensure that we do not have any IPv6 load balancing regressions in the future. Signed-off-by: Russell Bryant --- tests/system-ovn.at | 876

Re: [ovs-dev] [PATCH ovn] system-ovn.at: Create IPv6 load balancing tests

On Tue, Nov 5, 2019 at 12:38 PM Ben Pfaff wrote: > On Tue, Nov 05, 2019 at 12:23:09PM -0500, Russell Bryant wrote: > > Duplicate all of the IPv4 load balancing test cases for IPv6. > > All of these are passing without any changes needed in OVN code, but > > this will h

[ovs-dev] [PATCH ovn] system-ovn.at: Create IPv6 load balancing tests

Duplicate all of the IPv4 load balancing test cases for IPv6. All of these are passing without any changes needed in OVN code, but this will help ensure that we do not have any IPv6 load balancing regressions in the future. Signed-off-by: Russell Bryant --- tests/system-ovn.at | 887

Re: [ovs-dev] [PATCH ovn v2 0/6] Add OVN IPv6 support

On Wed, Oct 30, 2019 at 11:56 AM Numan Siddique wrote: > On Wed, Oct 30, 2019 at 8:25 PM Russell Bryant wrote: > > > > v1 -> v2: > > - Address checkpatch warnings about line length > > - Fix a sparse error in ovn-nbctl > > - Add lflow docs in ovn-no

[ovs-dev] [PATCH ovn v2 5/6] system-ovn: Add IPv6 NAT test cases

These tests failed prior to the changes leading up to this one. Signed-off-by: Russell Bryant --- tests/system-ovn.at | 862 +++- 1 file changed, 860 insertions(+), 2 deletions(-) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index f88ad31e4

[ovs-dev] [PATCH ovn v2 4/6] northd: Add lflows for IPv6 NAT.

Signed-off-by: Russell Bryant --- northd/ovn-northd.8.xml | 233 +--- northd/ovn-northd.c | 384 ++-- 2 files changed, 418 insertions(+), 199 deletions(-) diff --git a/northd/ovn-northd.8.xml b/northd/ovn-northd.8.xml index d3e0e5ef2

[ovs-dev] [PATCH ovn v2 6/6] NEWS: Add IPv6 NAT support

Signed-off-by: Russell Bryant --- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 73045d65f..ab2f13318 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,9 @@ +Post-OVS-v2.12.0 +- + - OVN was split out from the OVS repository and is now released

[ovs-dev] [PATCH ovn v2 3/6] ovn-nbctl: Allow IPv6 NAT rules to be added

Signed-off-by: Russell Bryant --- tests/ovn-nbctl.at| 41 utilities/ovn-nbctl.c | 49 --- 2 files changed, 69 insertions(+), 21 deletions(-) diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at index 01091dd99

[ovs-dev] [PATCH ovn v2 2/6] actions: Add IPv6 support to lflow NAT actions

Signed-off-by: Russell Bryant --- include/ovn/actions.h | 6 +- lib/actions.c | 35 +++ tests/ovn.at | 18 -- utilities/ovn-trace.c | 15 ++- 4 files changed, 54 insertions(+), 20 deletions(-) diff --git a/include

[ovs-dev] [PATCH ovn v2 0/6] Add OVN IPv6 support

15 10 files changed, 1408 insertions(+), 243 deletions(-) -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn v2 1/6] northd: Fix table ID for IPv6 router ingress.

I noticed that this table number was outdated. This is now table 3. There are a few other sections of code for this table that were all correctly referencing table 3. Signed-off-by: Russell Bryant --- northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH ovn 5/6] system-ovn: Add IPv6 NAT test cases

These tests failed prior to the changes leading up to this one. Signed-off-by: Russell Bryant --- tests/system-ovn.at | 862 +++- 1 file changed, 860 insertions(+), 2 deletions(-) diff --git a/tests/system-ovn.at b/tests/system-ovn.at index f88ad31e4

[ovs-dev] [PATCH ovn 3/6] ovn-nbctl: Allow IPv6 NAT rules to be added

Signed-off-by: Russell Bryant --- tests/ovn-nbctl.at| 41 utilities/ovn-nbctl.c | 48 --- 2 files changed, 68 insertions(+), 21 deletions(-) diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at index 01091dd99

[ovs-dev] [PATCH ovn 6/6] NEWS: Add IPv6 NAT support

Signed-off-by: Russell Bryant --- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 73045d65f..ab2f13318 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,9 @@ +Post-OVS-v2.12.0 +- + - OVN was split out from the OVS repository and is now released

[ovs-dev] [PATCH ovn 4/6] northd: Add lflows for IPv6 NAT.

Signed-off-by: Russell Bryant --- northd/ovn-northd.c | 376 1 file changed, 278 insertions(+), 98 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index ae81a6944..a10017ba1 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn

[ovs-dev] [PATCH ovn 1/6] northd: Fix table ID for IPv6 router ingress.

I noticed that this table number was outdated. This is now table 3. There are a few other sections of code for this table that were all correctly referencing table 3. Signed-off-by: Russell Bryant --- northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH ovn 2/6] actions: Add IPv6 support to lflow NAT actions

Signed-off-by: Russell Bryant --- include/ovn/actions.h | 6 +- lib/actions.c | 35 +++ tests/ovn.at | 18 -- utilities/ovn-trace.c | 14 +- 4 files changed, 53 insertions(+), 20 deletions(-) diff --git a/include

[ovs-dev] [PATCH ovn 0/6] Add IPv6 NAT support

+- utilities/ovn-nbctl.c | 48 ++ utilities/ovn-trace.c | 14 9 files changed, 1266 insertions(+), 142 deletions(-) -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] Fix system-ovn test failures

Thanks, I just hit this and the patch fixes it for me. Acked-by: Russell Bryant On Tue, Oct 29, 2019 at 9:56 AM Han Zhou wrote: > > Acked-by: hz...@ovn.org > > On Tue, Oct 29, 2019 at 5:26 AM wrote: > > > From: Numan Siddique > > > > The commit b740928656a1(&

Re: [ovs-dev] [PATCH ovn] controller: Downgrade a warning log message

On Fri, Oct 25, 2019 at 10:17 AM Numan Siddique wrote: > > > > On Fri, Oct 25, 2019 at 7:07 PM Russell Bryant wrote: >> >> This log message was introduced in commit 5344f24ecb. It gets hit >> under normal circumstances, so it would be better as a debug message &g

[ovs-dev] [PATCH ovn] controller: Downgrade a warning log message

tests, and they failed because of these unexpected warning log messages. Signed-off-by: Russell Bryant --- controller/chassis.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/controller/chassis.c b/controller/chassis.c index 699b66281..978273e19 100644 --- a/controller

Re: [ovs-dev] [PATCH ovn] tests/system-ovn: Ignore some ovn-controller warnings

On Thu, Oct 24, 2019 at 10:56 PM Numan Siddique wrote: > > > > On Fri, Oct 25, 2019, 7:59 AM Numan Siddique wrote: >> >> >> >> On Fri, Oct 25, 2019, 6:56 AM Russell Bryant wrote: >>> >>> This log message was introduced in commit 5344f24e

[ovs-dev] [PATCH ovn] tests/system-ovn: Ignore some ovn-controller warnings

This log message was introduced in commit 5344f24ecb. It may be more appropriate as a deubg message, but as a warning, it breaks this test suite. Filtering it out of the logs gets these tests passing for me. A sample of the messages encountered in a test run are:

Re: [ovs-dev] [PATCH ovn] Fix the compilation failures

Sorry. Acked-by: Russell Bryant > On Sep 23, 2019, at 4:20 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > Below compilation errors are seen: > > - make[1]: *** No rule to make target 'Documentation/internals/charter.rst', > needed by 'all-am'. Stop

[ovs-dev] [PATCH 3/3] Acknowledge that OVN committers are a new group.

the exact same policies and procedures as the OVS committers group, and simply updates the project name in those documents. Signed-off-by: Russell Bryant --- AUTHORS.rst | 8 ++-- .../internals/committer-emeritus-status.rst | 10 ++--- .../internals/committer-grant

[ovs-dev] [PATCH 1/3] Update project name in RST file headers.

automated bulk pass at it instead. I realize that many of the files touched may not be relevant anymore, but the change seems harmless enough. Signed-off-by: Russell Bryant --- AUTHORS.rst | 2 +- CONTRIBUTING.rst

[ovs-dev] [PATCH 2/3] Remove the OVS charter.

Since OVN has been split out from OVS and is now hosted under its own, independent github org, the OVS project charter is no longer applicable. Formal governance under the LF or something similar would be set up separately from OVS. Signed-off-by: Russell Bryant --- Documentation/internals

Re: [ovs-dev] [RFC v2] Document process for compatibility between OVS and OVN.

so. > + > +This, however, is a "best effort" policy. The OVN project reserves the right > to > +withdraw compatibility support with a previous OVS version, for reasons such > as: > + > +- Security risks. > +- Earthshatteringly large changes in OVS (e.g. no longer using OpenFlow or > the > + OVSDB). > +- Difficulty in safely maintaining compatibility across versions. > + > +In the event that compatibility for a certain version or versions of OVS is > +dropped, the OVN project will clearly document it. I like this position as a starting point, not limiting compatibility until you hit a good reason to. You could consider adding a statement about what's tested vs. theoretically supported. Acked-by: Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] s/rhel/rpm/?

On Mon, Aug 13, 2018 at 12:01 PM Ben Pfaff wrote: > On Mon, Aug 13, 2018 at 10:33:59AM -0400, Russell Bryant wrote: > > On Wed, Aug 8, 2018 at 6:16 PM Ben Pfaff wrote: > > > > > On Thu, Aug 09, 2018 at 12:29:20AM +0300, Markos Chandras wrote: > > > > On

Re: [ovs-dev] s/rhel/rpm/?

e all the distro packaging out of OVS, because > distro packagers are good at packaging and OVS developers generally > aren't. So, unless it would actually make your job easier, let's keep > things as is. > I would agree that moving it all out of OVS would make sense., but I'm in no hurry to propose it myself. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] Avoid tunneling for VLAN packets redirected to a gateway chassis

values are included when the packet is sent over the tunnel? Are we confident those values are not needed, or can be inferred another way in this scenario? On Wed, May 30, 2018 at 3:59 PM, Russell Bryant wrote: > On Fri, May 25, 2018 at 7:33 AM, wrote: >> From: venkata anil >&g

Re: [ovs-dev] [PATCH v3] Avoid tunneling for VLAN packets redirected to a gateway chassis

e ip address. But source mac(172.16.1.6 MAC) > and > +# dest mac(172.16.1.1 mac) are properly configured. > +src_mac="02010203" > +dst_mac="f0010204" > +expected=${dst_mac}${src_mac}0800451c3f110100${src_ip}${dst_ip}0035111100080000 >

Re: [ovs-dev] [PATCH] ovn pacemaker: Fix the promotion issue in other cluster nodes when the master node is reset

On Thu, May 17, 2018 at 6:04 AM, wrote: > From: Numan Siddique > > When a node 'A' in the pacemaker cluster running OVN db servers in master is > brought down ungracefully ('echo b > /proc/sysrq_trigger' for example), > pacemaker > is not able to

Re: [ovs-dev] [PATCH v3] rhel: user/group openvswitch does not exist

ging:UsersAndGroups#Dynamic_allocation >>> >>> Submitted-at: https://github.com/openvswitch/ovs/pull/223 >>> Signed-off-by: Alan Pevec <alan.pe...@redhat.com> >>> Co-authored-by: Aaron Conole <acon...@redhat.com> >>> Signed-off-b

Re: [ovs-dev] [PATCH] rhel: don't drop capabilities when running as root

pdk to also run as non-root user") >> Signed-off-by: Aaron Conole <acon...@redhat.com> >> --- > > Ping? Applied to master and branch-2.9. Please continue to CC me on rhel patches like this that have been reviewed by someone and you feel are ready to be applied. Thanks, -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] python: Enable flake8 checking of ovs-pipegen.py.

On Wed, Mar 14, 2018 at 3:48 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Mar 14, 2018 at 11:07:44AM -0400, Russell Bryant wrote: > > Signed-off-by: Russell Bryant <russ...@ovn.org> > > flake8-check passes for me, with this change. > > Acked-by: Ben Pfaff &l

Re: [ovs-dev] [PATCH v2] tests: Add some Python3 test variants on ovsdb-idl.at

t10 idl $srcdir/idltest.ovsschema \ > ssl:127.0.0.1:$TCP_PORT $PKIDIR/testpki-privkey.pem \ > $PKIDIR/testpki-cert.pem $PKIDIR/testpki-cacert.pem $2], > [0], [stdout], [ignore], [kill `cat pid`]) > @@ -1255,6 +1279,12 @@ m4_define([OVSDB_CHECK_IDL_NOTIFY_SSL_PY], >

Re: [ovs-dev] [PATCH] python: KeyError shouldn't be raised from __getattr__

_________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] python: Enable flake8 checking of ovs-pipegen.py.

Signed-off-by: Russell Bryant <russ...@ovn.org> --- utilities/automake.mk| 3 ++- utilities/ovs-pipegen.py | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/utilities/automake.mk b/utilities/automake.mk index 1636cb93e..60cf1c5ed 100644 --- a/utilities/autom

Re: [ovs-dev] [PATCH] utilities: Make ovs-pipegen.py Python 3 friendly

; def main(): > -- > 2.14.3 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: Avoid losing bridge configuration after adding DPDK ports

-- add-bond "$OVS_BRIDGE" "$DEVICE" ${BOND_IFACES} >> $OVS_OPTIONS ${IFACE_TYPES} ${OVS_EXTRA+-- $OVS_EXTRA} >> + BRIDGE_MAC=$(get_hwaddr $OVS_BRIDGE) >> + # The bridge may change its MAC to be the lower one among all >> its >> + # ports. If that happens, bridge configuration (e.g. routes) >> will >> + # be lost. Restore the post-up bridge configuration again. >> + if [ "$BRIDGE_MAC_ORIG" != "$BRIDGE_MAC" ]; then >> + ${OTHERSCRIPT} "$OVS_BRIDGE" >> + fi >> ;; >> *) >> echo $"Invalid OVS interface type $TYPE" >> -- >> 1.9.1 >> >> ___ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] The dependency between ovndb_servers-master and VirtualIP is wrong

aster >> ovndb_servers-master \ >> +$ pcs constraint order start VirtualIP then promote ovndb_servers-master >> +$ pcs constraint colocation add master ovndb_servers-master with >> VirtualIP \ >> score=INFINITY >> -- >> 1.8.

Re: [ovs-dev] [PATCH] Drop support for RHEL 5 and 6

l need quite a bit of scripting changes, install script changes, > dependencies etc to get ourselves accustomed to systemd. So I would prefer > that we not do this till OVS 2.10 atleast. > > On 16 January 2018 at 08:44, Russell Bryant <russ...@ovn.org> wrote: >> >>

Re: [ovs-dev] [PATCH] Drop support for RHEL 5 and 6

ro/install/general/#build-requirements > > CC: Gurucharan Shetty <g...@ovn.org> > Signed-off-by: Timothy Redaelli <tredae...@redhat.com> Acked-by: Russell Bryant <russ...@ovn.org> I'm fine with this, but I'll let Guru comment as well before applying anything. >

Re: [ovs-dev] [PATCH] OVN pacemaker: Fix issues when started as pacemaker container bundles

issues seen and deletes the local unused function > 'ovsdb_server_find_active_peers'. > > [1] - Please see this commit in ResourceAgents for more information on > 'ocf_attribute_target' > https://github.com/ClusterLabs/resource-agents/commit/9bd94137d77f770967d35db5de716590cfaf0435 > > Signed-o

Re: [ovs-dev] [PATCH v6 2/2] OVN: Add support for periodic router advertisements.

-- a/ovn/northd/ovn-northd.c >> +++ b/ovn/northd/ovn-northd.c >> @@ -4486,7 +4486,7 @@ copy_ra_to_sb(struct ovn_port *op, const char >> *address_mode) >> smap_add_format(, "ipv6_ra_max_interval", "%d", max_interval); >> >> int min

Re: [ovs-dev] [PATCH branch-2.8 v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

On Wed, Dec 6, 2017 at 4:59 AM, wrote: > From: Lucas Alvares Gomes > > The external_ids column is missing from the NAT and > Logical_Router_Static_Route tables. > > As discussed at [0] the change to the schema for this backport should > leave the

Re: [ovs-dev] [PATCH v1 1/1] Build the JSON C extension for the Python lib

is, so I never really got into it. Terry - can you please recap the status of this patch? Do you feel it's ready as-is, or was there more work that needs to be done? -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4] OVN pacemaker: Add the monitor action for Master role

On Tue, Dec 5, 2017 at 1:17 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Dec 5, 2017 9:16 PM, "Russell Bryant" <russ...@ovn.org> wrote: > > On Mon, Dec 4, 2017 at 9:27 AM, <nusid...@redhat.com> wrote: >> From: Numan Siddique <

Re: [ovs-dev] [PATCH v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

"min": 0, "max": "unlimited"}}}, >> > "isRoot": false}, >> > "DHCP_Options": { >> > "columns": { >> > diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.x

Re: [ovs-dev] [PATCH v4] OVN pacemaker: Add the monitor action for Master role

"Master" role. If any of the ovsdb-server or ovn-northd is not > running, > monitor action will return OCF_NOT_RUNNING and this will cause the pacemaker > to restart the OVN OCF resource. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1512568 > Signed-off-by

Re: [ovs-dev] [PATCH v3] OVN pacemaker: Add the monitor action for Master role

" > # Record ourselves so that the agent has a better chance of doing > # the right thing at startup > @@ -404,6 +431,8 @@ ovsdb_server_promote() { > } > > ovsdb_server_demote() { > +# While demoting, check the status of ovn_northd. > +# In case ovn_northd is not running, we should return OCF_NOT_RUNNING. > ovsdb_server_check_status > if [ $? = $OCF_NOT_RUNNING ]; then > return $OCF_NOT_RUNNING > @@ -452,6 +481,10 @@ ovsdb_server_demote() { > ${OVN_CTL} demote_ovnsb --db-sb-sync-from-addr=${INVALID_IP_ADDRESS} > fi > > +if [ "$MANAGE_NORTHD" = "yes" ]; then > +# Stop ovn-northd service > +${OVN_CTL} --ovn-manage-ovsdb=no stop_northd > +fi > ovsdb_server_master_update $OCF_SUCCESS > return $OCF_SUCCESS > } > -- > 2.14.3 > -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

Hsiao <jhs...@redhat.com> > --- > rhel/openvswitch-fedora.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the patch! I applied this to master and branch-2.8. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovn pacemaker: Provide the option to configure inactivity probe value

start_northd >> >>> fi >> >>> >> >>> +conn=`ovn-nbctl get NB_global . connections` >> >>> +if [ "$conn" == "[]" ] >> >>> +then >> >>> +ovn-nbctl -- --id=@conn_uuid create Connection \ >> >>> +target="p${NB_MASTER_PROTO}\:${NB_MASTER_PORT}\:${MASTER_IP}" \ >> >>> +inactivity_probe=$INACTIVE_PROBE -- set NB_Global . >> connections=@conn_uuid >> >>> +fi >> >>> + >> >>> +conn=`ovn-sbctl get SB_global . connections` >> >>> +if [ "$conn" == "[]" ] >> >>> +then >> >>> +ovn-sbctl -- --id=@conn_uuid create Connection \ >> >>> +target="p${SB_MASTER_PROTO}\:${SB_MASTER_PORT}\:${MASTER_IP}" \ >> >>> +inactivity_probe=$INACTIVE_PROBE -- set SB_Global . >> connections=@conn_uuid >> >>> +fi >> >>> + >> >>> else >> >>> if [ "$MANAGE_NORTHD" = "yes" ]; then >> >>> # Stop ovn-northd service. Set --ovn-manage-ovsdb=no so >> that >> >>> -- >> >>> 2.13.5 >> >>> >> >>> ___ >> >>> dev mailing list >> >>> d...@openvswitch.org >> >>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 07/13] jsonrpc: Allow jsonrpc_session to have more than one remote.

On Mon, Oct 9, 2017 at 4:11 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Oct 09, 2017 at 03:57:18PM -0400, Russell Bryant wrote: >> On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff <b...@ovn.org> wrote: >> > The implementation cycles through the remotes in random or

Re: [ovs-dev] [PATCH 13/13] json: New function json_object_put_format().

iles changed, 17 insertions(+), 1 deletion(-) Acked-by: Russell Bryant <russ...@ovn.org> Is it required to put the printf function attribute in both json.h and json.c? I figure it's harmless, but wasn't sure if it was necessary. > diff --git a/include/openvswitch/json.h b/include/openvswitch

Re: [ovs-dev] [PATCH 12/13] json: New function json_nullable_clone().

On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > include/openvswitch/json.h | 1 + > lib/json.c | 8 +++- > 2 files changed, 8 insertions(+), 1 deletion(-) Acked-by: Russ

Re: [ovs-dev] [PATCH 11/13] uuid: New function uuid_random().

On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > lib/uuid.c | 8 > lib/uuid.h | 1 + > 2 files changed, 9 insertions(+) Acked-by: Russell Bryant <russ...@ovn.org> __

Re: [ovs-dev] [PATCH 10/13] tests: Add support for 1-argument 'seq' in emulation.

On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff <b...@ovn.org> wrote: > The testsuite has an emulation of the common utility 'seq' that only > supported 2- and 3-argument forms. This commit adds support for the > 1-argument form. > > Signed-off-by: Ben Pfaff <b...@ovn.org>

Re: [ovs-dev] [PATCH 09/13] socket-util: Make parse_bracketed_token() public, as inet_parse_token().

On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff <b...@ovn.org> wrote: > An upcoming commit will introduce a new user outside socket-util. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant

Re: [ovs-dev] [PATCH 08/13] jsonrpc: Increment sequence number when connection actually made.

> starts. Thus, this commit changes the code to increment the sequence > number at completion, not at the attempt. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> ___ dev

Re: [ovs-dev] [PATCH 07/13] jsonrpc: Allow jsonrpc_session to have more than one remote.

first element has a 50% chance of staying there, since it's only considered for a swap when i == 0. That extends to the general behavior that the closer an element is to the beginning, the better chance it has of staying near the beginning. Or am I reading it wrong? Thanks, -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 06/13] reconnect: Add ability to do a number of retries without backoff.

n Pfaff <b...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Introduce Emeritus Committer status.

On Mon, Oct 9, 2017 at 1:42 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Oct 09, 2017 at 01:25:57PM -0400, Russell Bryant wrote: >> On Sat, Oct 7, 2017 at 12:22 AM, Ben Pfaff <b...@ovn.org> wrote: >> > 2. Do we need a vote of the committers to approve this chang

[ovs-dev] [PATCH v2] Introduce Emeritus Committer status.

t;e...@eecs.berkeley.edu> Signed-off-by: Russell Bryant <russ...@ovn.org> --- Documentation/automake.mk | 1 + Documentation/index.rst| 3 +- .../internals/committer-emeritus-status.rst| 63 ++ Documentation/interna

Re: [ovs-dev] [PATCH] Introduce Emeritus Committer status.

On Sat, Oct 7, 2017 at 12:22 AM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Oct 06, 2017 at 08:19:04PM -0400, Russell Bryant wrote: >> This patch introduces an Emeritus status for OVS committers. An >> Emeritus Committer is recognized as having made a significant impact >>

Re: [ovs-dev] [PATCH] util: Fix style in ovs_hex_dump().

On Sat, Oct 7, 2017 at 12:01 AM, Ben Pfaff <b...@ovn.org> wrote: > Reported-by: Russell Bryant <russ...@ovn.org> > Signed-off-by: Ben Pfaff <b...@ovn.org> Thanks :-) Acked-by: Russell Bryant <russ...@ovn.org> ___ dev mai

Re: [ovs-dev] locks for clustered OVSDB

plementation. Both new and old approach support >> avoiding redundant work, but not for correctness (unless "assert" or some >> other "fence" is used). Is this correct? > > It's accurate that clustering would not technically introduce new > restrictions.

Re: [ovs-dev] [PATCH 05/13] ofp-print: Avoid trailing white space in OpenFlow dumps.

at the end of the > line. This commit gets rid of the trailing white space and the annoying > "@@" markers. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> ___ dev mailing list d...@op

Re: [ovs-dev] [PATCH 04/13] util: Avoid trailing white space in hex dumps.

at the end of the > line. This commit gets rid of the trailing white space and the annoying > "@@" markers. > > This also gets rid of an occasional trailing hyphen. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org>

Re: [ovs-dev] [PATCH 03/13] table: Avoid trailing white space in tables.

t; Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > lib/table.c| 3 ++ > tests/ovsdb-replication.at | 12 > tests/ovsdb-server.at | 38 > tests/ovsdb-tool.at| 72 > +++----------

Re: [ovs-dev] [PATCH 02/13] daemon-unix: With --monitor, only close standard fds if --detach also used.

ds in that case. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 01/13] replication: Avoid theoretical use-after-free error in reset_database().

but it > costs little to be careful. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] Introduce Emeritus Committer status.

t;e...@eecs.berkeley.edu> Signed-off-by: Russell Bryant <russ...@ovn.org> --- Documentation/automake.mk | 1 + Documentation/index.rst| 3 +- .../internals/committer-emeritus-status.rst| 65 ++ Documentation/interna

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

> --- a/rhel/openvswitch-fedora.spec.in > >> +++ b/rhel/openvswitch-fedora.spec.in > >> @@ -577,7 +577,7 @@ fi > >> %endif > >> %doc COPYING NOTICE README.rst NEWS rhel/README.RHEL.rst > >> /var/lib/openvswitch > >> -/var/log/openvswitch > >> +%attr(755,-,-) /var/log/openvswitch > >> %ghost %attr(755,root,root) %{_rundir}/openvswitch > >> > >> %files ovn-docker > -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

  1   2   3   4   5   6   7   8   9   10   >