Re: [ovs-dev] Fix up to the ovn-northd sync

2017-07-16 Thread Russell Bryant
On Sun, Jul 16, 2017 at 10:24 AM, Russell Bryant <russ...@ovn.org> wrote: > > On Fri, Jul 14, 2017 at 10:08 PM Russell Bryant <russ...@ovn.org> wrote: >> >> On Thu, Jul 13, 2017 at 9:13 AM, Miguel Angel Ajo <majop...@redhat.com> >> wrote: >> &g

Re: [ovs-dev] Fix up to the ovn-northd sync

2017-07-16 Thread Russell Bryant
On Fri, Jul 14, 2017 at 10:08 PM Russell Bryant <russ...@ovn.org> wrote: > On Thu, Jul 13, 2017 at 9:13 AM, Miguel Angel Ajo <majop...@redhat.com> > wrote: > > This is a fixup and regression test I've written for the l3ha series > > for an issue I found while res

Re: [ovs-dev] Fix up to the ovn-northd sync

2017-07-14 Thread Russell Bryant
or I can > squash it to the ovn-northd patch. I replied to the patch itself before seeing this message. I think it should be squashed into the ovn-northd patch. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org

Re: [ovs-dev] [PATCH v5 1/8] ovn: l3ha, add extra check on distributed gateway ports

2017-07-14 Thread Russell Bryant
l find Port_Binding logical_port=cr-alice | wc --lines], > [0], [0 > +]) > + > OVN_CLEANUP([hv1],[hv2],[hv3]) > > AT_CLEANUP I tweaked the subject line to remove "l3ha" since this patch isn't really l3ha code. I made the above changes and applied this to master. --

Re: [ovs-dev] [PATCH] tests: Disable no-format-truncation warnings

2017-07-14 Thread Russell Bryant
ly into a patch on patchwork instead of associating it with the original, so I missed it. I'll squash a revert of the original into Ben's patch here and apply that, too. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3 3/6] ovn: l3ha, handling of multiple gateway chassis

2017-07-10 Thread Russell Bryant
On Mon, Jul 10, 2017 at 5:38 AM, Miguel Angel Ajo Pelayo <majop...@redhat.com> wrote: > > > On Fri, Jul 7, 2017 at 9:09 PM, Russell Bryant <russ...@ovn.org> wrote: >> >> review part 2 of this one ... >> >> On Wed, Jul 5, 2017 at 9:45 AM, Mi

Re: [ovs-dev] [PATCH v3 6/6] ovn: l3ha, gratuitous ARP for HA router

2017-07-07 Thread Russell Bryant
--id=@gc0 create Gateway_Chassis \ > +name=outside_gw1 chassis_name=hv2 priority=1 -- \ > + --id=@gc1 create Gateway_Chassis \ > +name=outside_gw2 chassis_name=hv3 priority=10 -- \ > + set Logical_Router_Port lrp0 'gateway_chassis=[@gc0,@gc1]' > + > + > +as hv1 reset_pcap_file snoopvif hv1/snoopvif > +as hv2 reset_pcap_file br-phys_n1 hv2/br-phys_n1 > +as hv3 reset_pcap_file br-phys_n1 hv3/br-phys_n1 > + > +# Wait for packets to be received. > +OVS_WAIT_UNTIL([test `wc -c < "hv1/snoopvif-tx.pcap"` -ge 100]) > +trim_zeros() { > +sed 's/\(00\)\{1,\}$//' > +} > + > +$PYTHON "$top_srcdir/utilities/ovs-pcap.in" hv1/snoopvif-tx.pcap | > trim_zeros > hv1_snoopvif_tx > +AT_CHECK([sort hv1_snoopvif_tx], [0], [expout]) > +$PYTHON "$top_srcdir/utilities/ovs-pcap.in" hv3/br-phys_n1-tx.pcap | > trim_zeros > hv3_br_phys_tx > +AT_CHECK([grep $garp hv3_br_phys_tx | sort], [0], [expout]) > +$PYTHON "$top_srcdir/utilities/ovs-pcap.in" hv2/br-phys_n1-tx.pcap | > trim_zeros > hv2_br_phys_tx > +AT_CHECK([grep $garp hv2_br_phys_tx | sort], [0], []) > +OVN_CLEANUP([hv1],[hv2],[hv3]) > + > +AT_CLEANUP > + > -- > 1.8.3.1 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3 5/6] ovn: l3ha, make is_chassis_active aware of gateway_chassis

2017-07-07 Thread Russell Bryant
name=outside_gw2 chassis_name=gw2 priority=20 -- \ >set Logical_Router_Port outside 'gateway_chassis=[@gc0,@gc1]' > > + > # XXX: Let the change propagate down to the ovn-controllers > sleep 2 > > +# we make sure that the hypervisors noticed, and inverted the slave ports > AT_CHECK([as hv1 ovs-ofctl dump-flows br-int table=32 | grep active_backup | > grep slaves:$hv1_gw2_ofport,$hv1_gw1_ofport | wc -l], [0], [1 > ]) > > AT_CHECK([as hv2 ovs-ofctl dump-flows br-int table=32 | grep active_backup | > grep slaves:$hv2_gw2_ofport,$hv2_gw1_ofport | wc -l], [0], [1 > ]) > > +# check that the chassis redirect port has been reclaimed by the gw2 chassis > +AT_CHECK([ovn-sbctl --columns chassis --bare find Port_Binding > logical_port=cr-outside | grep $gw2_chassis | wc -l], > + [0],[[1 > +]]) > > # check BFD enablement on tunnel ports from gw1 # > as gw1 > @@ -7934,6 +7971,31 @@ AT_CHECK([ovs-vsctl --bare --columns bfd find > Interface name=ovn-hv1-0],[0], > [[enable=false > ]]) > > +# make sure that flows for handling the outside router port reside on gw2 now > +AT_CHECK([as gw2 ovs-ofctl dump-flows br-int table=23 | grep > 00:00:02:01:02:04 | wc -l], [0], [[1 > +]]) > +AT_CHECK([as gw1 ovs-ofctl dump-flows br-int table=23 | grep > 00:00:02:01:02:04 | wc -l], [0], [[0 > +]]) > + > +# disconnect GW2 from the network, GW1 should take over > +as gw2 > +port=${sandbox}_br-phys > +as main ovs-vsctl del-port n1 $port > +sleep 4 > + > +bfd_dump > + > +# make sure that flows for handling the outside router port reside on gw2 now > +AT_CHECK([as gw1 ovs-ofctl dump-flows br-int table=23 | grep > 00:00:02:01:02:04 | wc -l], [0], [[1 > +]]) > +AT_CHECK([as gw2 ovs-ofctl dump-flows br-int table=23 | grep > 00:00:02:01:02:04 | wc -l], [0], [[0 > +]]) > + > +# check that the chassis redirect port has been reclaimed by the gw1 chassis > +AT_CHECK([ovn-sbctl --columns chassis --bare find Port_Binding > logical_port=cr-outside | grep $gw1_chassis | wc -l], > + [0],[[1 > +]]) > + > OVN_CLEANUP([gw1],[gw2],[hv1],[hv2]) > > AT_CLEANUP > -- > 1.8.3.1 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 2/4] ovn: l3ha, enable bfd between tunnel endpoints

2017-07-07 Thread Russell Bryant
| 62 + > 5 files changed, 255 insertions(+), 18 deletions(-) > I was surprised to see the bfd code in binding.c. I would have expected it in encaps.c, where we are creating the tunnels to other chassis. Could it be done in there? -- Russell Bryant ___

Re: [ovs-dev] [PATCH v3 3/6] ovn: l3ha, handling of multiple gateway chassis

2017-07-07 Thread Russell Bryant
hv$i/vif1-tx.pcap \ > +options:rxq_pcap=hv$i/vif1-rx.pcap \ > + ofport-request=1 > + > +ovn-nbctl lsp-add inside inside$i \ > +-- lsp-set-addresses inside$i "f0:00:00:01:22:$i 192.168.1.10$i" > + > +done > + > +ovn_populate_arp > + > +ovn-nbctl create Logical_Router name=R1 > + > +# Connect inside to R1 > +ovn-nbctl lrp-add R1 inside 00:00:01:01:02:03 192.168.1.1/24 > +ovn-nbctl lsp-add inside rp-inside -- set Logical_Switch_Port rp-inside \ > +type=router options:router-port=inside \ > +-- lsp-set-addresses rp-inside router > + > +# Connect outside to R1 as distributed router gateway port on gw1+gw2 > +ovn-nbctl lrp-add R1 outside 00:00:02:01:02:04 192.168.0.101/24 > + > +ovn-nbctl --id=@gc0 create Gateway_Chassis \ > +name=outside_gw1 chassis_name=gw1 priority=20 -- \ > + --id=@gc1 create Gateway_Chassis \ > +name=outside_gw2 chassis_name=gw2 priority=10 -- \ > + set Logical_Router_Port outside 'gateway_chassis=[@gc0,@gc1]' > + > +ovn-nbctl lsp-add outside rp-outside -- set Logical_Switch_Port rp-outside \ > +type=router options:router-port=outside \ > +-- lsp-set-addresses rp-outside router > + > +# Create localnet port in outside > +ovn-nbctl lsp-add outside ln-outside > +ovn-nbctl lsp-set-addresses ln-outside unknown > +ovn-nbctl lsp-set-type ln-outside localnet > +ovn-nbctl lsp-set-options ln-outside network_name=phys > + > +# Allow some time for ovn-northd and ovn-controller to catch up. > +# XXX This should be more systematic. > +sleep 2 Add a sync=hv here, instead? > + > +echo "-NB dump-" > +ovn-nbctl show > +echo "-" > +ovn-nbctl list logical_router > +echo "-" > +ovn-nbctl list logical_router_port > +echo "-" > + > +echo "-SB dump-" > +ovn-sbctl list datapath_binding > +echo "-" > +ovn-sbctl list port_binding > +echo "-" > +ovn-sbctl dump-flows > +echo "-" > +ovn-sbctl list chassis > +ovn-sbctl list encap > +echo "-" > +echo "-- Gateway_Chassis dump (SBDB) ---" > +ovn-sbctl list Gateway_Chassis > +echo "-- Port_Binding chassisredirect ---" > +ovn-sbctl find Port_Binding type=chassisredirect > +echo "---" > + > + > +hv1_gw1_ofport=$(as hv1 ovs-vsctl --bare --columns ofport find Interface > name=ovn-gw1-0) > +hv1_gw2_ofport=$(as hv1 ovs-vsctl --bare --columns ofport find Interface > name=ovn-gw2-0) > +hv2_gw1_ofport=$(as hv2 ovs-vsctl --bare --columns ofport find Interface > name=ovn-gw1-0) > +hv2_gw2_ofport=$(as hv2 ovs-vsctl --bare --columns ofport find Interface > name=ovn-gw2-0) > + > +echo $hv1_gw1_ofport > +echo $hv1_gw2_ofport > +echo $hv2_gw1_ofport > +echo $hv2_gw2_ofport > + > +echo "--- hv1 ---" > +as hv1 ovs-ofctl dump-flows br-int table=32 > + > +echo "--- hv2 ---" > +as hv2 ovs-ofctl dump-flows br-int table=32 > + > +AT_CHECK([as hv1 ovs-ofctl dump-flows br-int table=32 | grep active_backup | > grep slaves:$hv1_gw1_ofport,$hv1_gw2_ofport | wc -l], [0], [1 > +]) > + > +AT_CHECK([as hv2 ovs-ofctl dump-flows br-int table=32 | grep active_backup | > grep slaves:$hv2_gw1_ofport,$hv2_gw2_ofport | wc -l], [0], [1 > +]) > + > +# set higher priority to gw2 instead of gw1, and check for changes > + > +ovn-nbctl --id=@gc0 create Gateway_Chassis \ > +name=outside_gw1 chassis_name=gw1 priority=10 -- \ > + --id=@gc1 create Gateway_Chassis \ > +name=outside_gw2 chassis_name=gw2 priority=20 -- \ > + set Logical_Router_Port outside 'gateway_chassis=[@gc0,@gc1]' > + > +# XXX: Let the change propagate down to the ovn-controllers > +sleep 2 A sync=hv should do the trick here. > + > +AT_CHECK([as hv1 ovs-ofctl dump-flows br-int table=32 | grep active_backup | > grep slaves:$hv1_gw2_ofport,$hv1_gw1_ofport | wc -l], [0], [1 > +]) > + > +AT_CHECK([as hv2 ovs-ofctl dump-flows br-int table=32 | grep active_backup | > grep slaves:$hv2_gw2_ofport,$hv2_gw1_ofport | wc -l], [0], [1 > +]) > + > + > +OVN_CLEANUP([gw1],[gw2],[hv1],[hv2]) > + > AT_CLEANUP > > -- > 1.8.3.1 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3 3/6] ovn: l3ha, handling of multiple gateway chassis

2017-07-07 Thread Russell Bryant
(re-adding the list) On Fri, Jul 7, 2017 at 6:50 AM, Miguel Angel Ajo Pelayo <majop...@redhat.com> wrote: > > Thank you!, I'll start tackling those today. > > On Fri, Jul 7, 2017 at 3:48 AM, Russell Bryant <russ...@ovn.org> wrote: >> >> I'm not done reviewing t

Re: [ovs-dev] [PATCH v3 2/6] ovn: l3ha, ovn-northd gateway chassis propagation

2017-07-07 Thread Russell Bryant
(re-adding mailing list, since I assume you meant to include it) On Fri, Jul 7, 2017 at 7:15 AM, Miguel Angel Ajo Pelayo <majop...@redhat.com> wrote: > > > On Thu, Jul 6, 2017 at 11:30 PM, Russell Bryant <russ...@ovn.org> wrote: >> >> On Wed, Jul 5, 2017 at

Re: [ovs-dev] [PATCH v3 3/6] ovn: l3ha, handling of multiple gateway chassis

2017-07-06 Thread Russell Bryant
ternal-ids:iface-id=inside$i \ > +options:tx_pcap=hv$i/vif1-tx.pcap \ > +options:rxq_pcap=hv$i/vif1-rx.pcap \ > +ofport-request=1 > + > +ovn-nbctl lsp-add inside inside$i \ > +-- lsp-set-addresses inside$i "f0:00:00:01:22:$i 192.168.1.10$i" > + > +done > + > +ovn_populate_arp > + > +ovn-nbctl create Logical_Router name=R1 > + > +# Connect inside to R1 > +ovn-nbctl lrp-add R1 inside 00:00:01:01:02:03 192.168.1.1/24 > +ovn-nbctl lsp-add inside rp-inside -- set Logical_Switch_Port rp-inside \ > +type=router options:router-port=inside \ > +-- lsp-set-addresses rp-inside router > + > +# Connect outside to R1 as distributed router gateway port on gw1+gw2 > +ovn-nbctl lrp-add R1 outside 00:00:02:01:02:04 192.168.0.101/24 > + > +ovn-nbctl --id=@gc0 create Gateway_Chassis \ > +name=outside_gw1 chassis_name=gw1 priority=20 -- \ > + --id=@gc1 create Gateway_Chassis \ > +name=outside_gw2 chassis_name=gw2 priority=10 -- \ > + set Logical_Router_Port outside 'gateway_chassis=[@gc0,@gc1]' > + > +ovn-nbctl lsp-add outside rp-outside -- set Logical_Switch_Port rp-outside \ > +type=router options:router-port=outside \ > +-- lsp-set-addresses rp-outside router > + > +# Create localnet port in outside > +ovn-nbctl lsp-add outside ln-outside > +ovn-nbctl lsp-set-addresses ln-outside unknown > +ovn-nbctl lsp-set-type ln-outside localnet > +ovn-nbctl lsp-set-options ln-outside network_name=phys > + > +# Allow some time for ovn-northd and ovn-controller to catch up. > +# XXX This should be more systematic. > +sleep 2 > + > +echo "-NB dump-" > +ovn-nbctl show > +echo "-" > +ovn-nbctl list logical_router > +echo "-" > +ovn-nbctl list logical_router_port > +echo "-" > + > +echo "-SB dump-" > +ovn-sbctl list datapath_binding > +echo "-" > +ovn-sbctl list port_binding > +echo "-" > +ovn-sbctl dump-flows > +echo "-" > +ovn-sbctl list chassis > +ovn-sbctl list encap > +echo "-" > +echo "-- Gateway_Chassis dump (SBDB) ---" > +ovn-sbctl list Gateway_Chassis > +echo "-- Port_Binding chassisredirect ---" > +ovn-sbctl find Port_Binding type=chassisredirect > +echo "---" > + > + > +hv1_gw1_ofport=$(as hv1 ovs-vsctl --bare --columns ofport find Interface > name=ovn-gw1-0) > +hv1_gw2_ofport=$(as hv1 ovs-vsctl --bare --columns ofport find Interface > name=ovn-gw2-0) > +hv2_gw1_ofport=$(as hv2 ovs-vsctl --bare --columns ofport find Interface > name=ovn-gw1-0) > +hv2_gw2_ofport=$(as hv2 ovs-vsctl --bare --columns ofport find Interface > name=ovn-gw2-0) > + > +echo $hv1_gw1_ofport > +echo $hv1_gw2_ofport > +echo $hv2_gw1_ofport > +echo $hv2_gw2_ofport > + > +echo "--- hv1 ---" > +as hv1 ovs-ofctl dump-flows br-int table=32 > + > +echo "--- hv2 ---" > +as hv2 ovs-ofctl dump-flows br-int table=32 > + > +AT_CHECK([as hv1 ovs-ofctl dump-flows br-int table=32 | grep active_backup | > grep slaves:$hv1_gw1_ofport,$hv1_gw2_ofport | wc -l], [0], [1 > +]) > + > +AT_CHECK([as hv2 ovs-ofctl dump-flows br-int table=32 | grep active_backup | > grep slaves:$hv2_gw1_ofport,$hv2_gw2_ofport | wc -l], [0], [1 > +]) > + > +# set higher priority to gw2 instead of gw1, and check for changes > + > +ovn-nbctl --id=@gc0 create Gateway_Chassis \ > +name=outside_gw1 chassis_name=gw1 priority=10 -- \ > + --id=@gc1 create Gateway_Chassis \ > +name=outside_gw2 chassis_name=gw2 priority=20 -- \ > + set Logical_Router_Port outside 'gateway_chassis=[@gc0,@gc1]' > + > +# XXX: Let the change propagate down to the ovn-controllers > +sleep 2 > + > +AT_CHECK([as hv1 ovs-ofctl dump-flows br-int table=32 | grep active_backup | > grep slaves:$hv1_gw2_ofport,$hv1_gw1_ofport | wc -l], [0], [1 > +]) > + > +AT_CHECK([as hv2 ovs-ofctl dump-flows br-int table=32 | grep active_backup | > grep slaves:$hv2_gw2_ofport,$hv2_gw1_ofport | wc -l], [0], [1 > +]) > + > + > +OVN_CLEANUP([gw1],[gw2],[hv1],[hv2]) > + > AT_CLEANUP > > -- > 1.8.3.1 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] 答复: Re: 答复: Re: 答复: [spam可疑邮件]Re: 答复: Re: [PATCH 2/2] ovn-northd: Fix ping failure of vlan networks.

2017-07-06 Thread Russell Bryant
oint on another chassis. Based on a quick review of the discussion, it does seem like dropping it is the better choice for now. If the security aspect is desired later, perhaps we could solve it another way by supporting ACLs associated with the L3 gateway sittin

Re: [ovs-dev] [PATCH] Makefiles: Fail build for flake8 only when configured with --enable-Werror.

2017-07-06 Thread Russell Bryant
anch. > > Thus, this adopts the same policy for compiler warnings: always report > them, but only fail the build if --enable-Werror was configured. Usually > just developers use that configure option, and they're prepared to deal > with the fallout. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH v3 2/6] ovn: l3ha, ovn-northd gateway chassis propagation

2017-07-06 Thread Russell Bryant
:02:01:02:03 172.16.1.1/24 > + > + > +ovn-nbctl \ > +--id=@gc0 create Gateway_Chassis name=alice_gw1 \ > + chassis_name=gw1 \ > + priority=20 -- \ > +--id=@gc1 create Gateway_Chassis name=alice_gw

Re: [ovs-dev] [PATCH v3 1/6] ovn: l3ha, NBDB and SBDB changes and documentation

2017-07-06 Thread Russell Bryant
at EOF. + warning: 1 line adds whitespace errors. Also, here's a patch you can squash into this one that adjusts the schema version numbers and adds a bit to the docs. I'll collect my suggestions in this branch for now: https://github.com/russellb/ovs/tree/l3ha commit 26c1347bfe8faa96a4218e36328

Re: [ovs-dev] [PATCH] ovs-ctl: Fix typo in a comment

2017-06-29 Thread Russell Bryant
On Thu, Jun 29, 2017 at 11:28 AM, Timothy Redaelli <tredae...@redhat.com> wrote: > s/conenct/connect/ > > Signed-off-by: Timothy Redaelli <tredae...@redhat.com> > --- > utilities/ovs-ctl.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied

Re: [ovs-dev] [PATCH] rhel-systemd: start vswitchd after udev

2017-06-29 Thread Russell Bryant
. Maybe we can >> > at least get a Tested-by tag. >> >> I didn't realize there was a tester. I guess that I should have looked >> at the bugzilla URL. >> >> If Maxim tested it successfully, we don't really need him to give us the >> Tested-by, we can add it ourselves. (But now that we've asked, we might >> as well get an answer.) >> >> Thanks, >> >> Ben. >> ___ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] Request to tag 2.7 branch with v2.7.1

2017-06-23 Thread Russell Bryant
ow some folks have been traveling this week. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v1 1/4] ovn: l3ha, handling of multiple gateways

2017-06-20 Thread Russell Bryant
rrow at 9am EST to talk about the topic >> on IRC. >> >> >> >> >> El 14 jun. 2017 9:02 p. m., "Russell Bryant" <russ...@ovn.org> escribió: >> >> On Wed, Jun 14, 2017 at 2:40 PM, Miguel Angel Ajo Pelayo >> <majop...@redhat

Re: [ovs-dev] [PATCH v1 1/4] ovn: l3ha, handling of multiple gateways

2017-06-14 Thread Russell Bryant
for > priorities would let us do that) > > I'm glad to hear suggestions for column names or structure here :) I'm happy to collaborate on the proposed alternate schema. Maybe we can connect on IRC tomorrow to work on it? > > > > El 13 jun. 2017 10:41 p. m., "Russell Bryant&qu

Re: [ovs-dev] [PATCH v1 1/4] ovn: l3ha, handling of multiple gateways

2017-06-13 Thread Russell Bryant
On Tue, Jun 13, 2017 at 4:40 PM, Russell Bryant <russ...@ovn.org> wrote: > On Fri, Jun 2, 2017 at 8:31 AM, <majop...@redhat.com> wrote: >> From: Miguel Angel Ajo <majop...@redhat.com> >> >> This patch handles multiple gateways with priorities i

Re: [ovs-dev] [PATCH v1 1/4] ovn: l3ha, handling of multiple gateways

2017-06-13 Thread Russell Bryant
an include a list of chassis, which would have to be a new record type in OVN northbound, containing much less info than the southbound counterpart. We'd have to add a similar new column to the Port_Binding table in OVN southbound. I'm curious what you

Re: [ovs-dev] [PATCH v2 1/4] ovn: l3ha, handling of multiple gateways

2017-06-13 Thread Russell Bryant
On Tue, Jun 13, 2017 at 1:22 PM, Guru Shetty <g...@ovn.org> wrote: > > > On 13 June 2017 at 10:17, Russell Bryant <russ...@ovn.org> wrote: >> >> On Fri, Jun 9, 2017 at 10:46 AM, Guru Shetty <g...@ovn.org> wrote: >> > On 8 June 2017 at 14:39, Ben Pf

Re: [ovs-dev] [PATCH] sandbox: ovn rbac support for sandbox environment

2017-06-13 Thread Russell Bryant
On Tue, Jun 13, 2017 at 1:24 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Jun 13, 2017 at 01:13:31PM -0400, Russell Bryant wrote: >> On Mon, Jun 12, 2017 at 6:42 PM, Lance Richardson <lrich...@redhat.com> >> wrote: >> > Enable OVN_Southbound RBAC b

Re: [ovs-dev] [PATCH v2 1/4] ovn: l3ha, handling of multiple gateways

2017-06-13 Thread Russell Bryant
eview this series. Guru, is >> it something you'd feel able to take a look at? Is anyone else planning >> to review this? >> > > I will have a go at it. Thanks a lot, Guru. Since this is important for OpenStack, let me know if you won't have time to review and I'll make time

Re: [ovs-dev] [PATCH] sandbox: ovn rbac support for sandbox environment

2017-06-13 Thread Russell Bryant
ure the best way to clean this up. Perhaps we could just run each southbound db in its own net namespace. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovn-sb.xml: Update and improve documentation.

2017-06-07 Thread Russell Bryant
-by: Ben Pfaff <b...@ovn.org> > --- > ovn/ovn-sb.xml | 89 > +- > 1 file changed, 50 insertions(+), 39 deletions(-) Acked-by: Russell Bryant <russ...@ovn.org> with one comment: > > -LN data is likely

Re: [ovs-dev] 答复: Re: [PATCH 2/2] ovn-northd: Fix ping failure of vlan networks.

2017-06-07 Thread Russell Bryant
Is the router bound to a chassis by specifying a "redirect-chassis" ? Dumping the northbound db might make it easier for me to understand and reproduce the issue ... On Mon, Jun 5, 2017 at 8:58 PM, <wang.qia...@zte.com.cn> wrote: > router is not external to OVN > >

Re: [ovs-dev] [PATCH v3] Copy external_ids from Logical_Switch_Port to SB database

2017-06-07 Thread Russell Bryant
.xml > @@ -2179,7 +2179,16 @@ tcp.flags = RST; > > > > -See External IDs at the beginning of this document. > + > + See External IDs at the beginning of this document. > + > + > + > + The ovn-northd program populates

Re: [ovs-dev] [PATCH] Copy external_ids from Logical_Switch_Port to SB database

2017-05-31 Thread Russell Bryant
ternal IDs at the beginning of this document. > + > + See External IDs at the beginning of this document. > + > + > + > + The ovn-northd program copies all these pairs into the > + column of the > + table in > + databa

Re: [ovs-dev] [PATCH v2] Replace most uses of and references to "ifconfig" by "ip".

2017-05-26 Thread Russell Bryant
e > below steps: > > Configure IP and enable interfaces:: > > - $ ifconfig eth0 5.5.5.1/24 up > - $ ifconfig eth1 90.90.90.1/24 up > + $ ip addr add 5.5.5.1/24 dev eth0 > + $ ip addr add 90.90.90.1/24 dev eth1 Is "ip link set eth0 up" needed here too to be equivalent? -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] OVN L3-HA request for feedback

2017-05-25 Thread Russell Bryant
On Thu, May 25, 2017 at 5:12 AM, Miguel Angel Ajo Pelayo <majop...@redhat.com> wrote: > > > On Wed, May 24, 2017 at 7:39 PM, Russell Bryant <russ...@ovn.org> wrote: >> >> On Wed, May 24, 2017 at 7:19 AM, Miguel Angel Ajo Pelayo >> <majop...@redhat.com>

Re: [ovs-dev] OVN L3-HA request for feedback

2017-05-24 Thread Russell Bryant
0,gw2:20,gw3:30 >>> >>> Or multiple chassis without priorities: >>> >>> ovn-nbctl lrp-add R1 alice 00:00:02:01:02:03 172.16.1.1/24 \ >>> -- set Logical_Router_Port alice >>> options:redirect-chassis=gw1,gw2,gw3 >>> >>> (and in this case we let ovn decide -and may be rewrite the >>> option- how to balance >>> priorities between gateways to spread the load) >>> >>> >>> We may want to have another field in the Logical_Router_Port, to >>> let us know which >>> one(s) is(are) the active gateway(s) >>> >>> >>>This logical model would also allow for Active/Active L3 when we >>> have that implemented, >>> for example by assigning the same priorities. >>> >>> >>>Alternatively we could have two options: >>> * ha-redirect-chassis=:[ .. >>> ::] >>> * ha-redirect-mode=active_standby/active_active >>> >>> >>> Best regards, >>> Miguel Ángel Ajo >>> >>> [1] https://github.com/openvswitch/ovs/blob/master/Documenta >>> tion/topics/high-availability.rst >>> >>> >> > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Supporting ovn-northd service HA depend on OVNDB-HA

2017-05-23 Thread Russell Bryant
@@ -122,8 +122,12 @@ ovsdb_server_notify() { >>>> # the right thing at startup >>>> ocf_log debug "ovndb_server: $host_name is the master" >>>> ${CRM_ATTR_REPL_INFO} -v "$host_name" >>>> +# Startup ovn-northd service >>>> +${OVN_CTL} start_northd >>>> >>>> else >>>> +# Stop ovn-northd service >>>> +${OVN_CTL} stop_northd >>>> # Synchronize with the new master >>>> ocf_log debug "ovndb_server: Connecting to the new master >>>> ${OCF_RESKEY_CRM_meta_notify_promote_uname}" >>>> ${OVN_CTL} demote_ovnnb --db-nb-sync-from-addr=${MASTER_IP} \ >>>> >>> >>> I tried this patch and it works. >>> In the case of OpenStack and Tripleo, puppet is used to create and manage >>> the pacemaker resources for OVN [1] and it also starts ovn-northd as a >>> pacemaker service with colocation constraint set to the virtual ip created >>> for the OVN DB servers. >>> >>> I think it makes more sense to start ovn-northd based on a flag (like >>> START_NORTHD) so that the user or the configuration systems can chose. >>> >>> Thanks >>> Numan >>> >>> >>> >>> [1] - https://review.openstack.org/#/c/372274/10/manifests/profi >>> le/pacemaker/ovn_northd.pp >>> >>> >>>> -- >>>> 2.10.2 >>>> >>>> ___ >>>> dev mailing list >>>> d...@openvswitch.org >>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >>>> >>> >>> >> > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] python ovs: Fix SSL exceptions with pyOpenSSL v0.13

2017-05-23 Thread Russell Bryant
o]) > AT_SKIP_IF([test $HAVE_PYTHON = no]) > - $PYTHON -m OpenSSL.SSL > + $PYTHON -c "import OpenSSL.SSL" > SSL_PRESENT=$? > AT_SKIP_IF([test $SSL_PRESENT != 0]) > AT_KEYWORDS([ovsdb server idl Python notify - ssl socket]) > -- > 2.9.3 > >

Re: [ovs-dev] 答复: Re: [PATCH] ovn-controller: Support vxlan tunnel in ovn

2017-05-04 Thread Russell Bryant
vxlan >> encapsulation will be better. this is the reason that why we do the modify >> as the patch. >> Now, ovn used for the scenary of hardware-switches link to sriov >> network-card is very difficult, >> and we want do more works for ovn-controller-hw to support hardw

Re: [ovs-dev] [PATCH] ovn-controller: Support vxlan tunnel in ovn

2017-05-03 Thread Russell Bryant
uld be added to OVN. Can you expand on what special scenarios you have in mind? Thanks, -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] fedora: do not restart ovn svcs automatically on pkg upgrade

2017-05-03 Thread Russell Bryant
On Tue, May 2, 2017 at 10:36 PM, Lance Richardson <lrich...@redhat.com> wrote: >> From: "Russell Bryant" <russ...@ovn.org> >> To: "Lance Richardson" <lrich...@redhat.com> >> Cc: "ovs dev" <d...@openvswitch.org> >> Sent

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

2017-05-03 Thread Russell Bryant
estion it. I imagine everyone assumed it was for good reason and that OVN required unique names. Oops. I see how you've made the best of it in your series and I really appreciate that effort. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] flake8 checking for release branches

2017-05-02 Thread Russell Bryant
* Only run flake8 when a configure option is given. > > * Apply fixes to release branches to avoid the warnings. > > Opinions? -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] fedora: do not restart ovn svcs automatically on pkg upgrade

2017-05-02 Thread Russell Bryant
om> > --- > NEWS| 2 ++ > rhel/openvswitch-fedora.spec.in | 24 ++-- > 2 files changed, 8 insertions(+), 18 deletions(-) Thanks! I applied this to master. -- Russell Bryant ___ dev mailin

Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets.

2017-05-02 Thread Russell Bryant
On Thu, Apr 27, 2017 at 5:26 PM, Aaron Conole <acon...@redhat.com> wrote: > Lance Richardson <lrich...@redhat.com> writes: > >>> From: "Russell Bryant" <russ...@ovn.org> >>> To: "Ben Pfaff" <b...@ovn.org> >>> Cc: &qu

Re: [ovs-dev] [PATCH] rhel: fix the fedora spec

2017-05-02 Thread Russell Bryant
@redhat.com> > Signed-off-by: Aaron Conole <acon...@redhat.com> applied to master, thanks! -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 05/27] ovn-sbctl, ovn-nbctl, ovs-vsctl: Remove useless record id methods.

2017-05-02 Thread Russell Bryant
On Tue, May 2, 2017 at 4:30 PM, Russell Bryant <russ...@ovn.org> wrote: > On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff <b...@ovn.org> wrote: >> These only did anything if both the first two members of the struct were >> nonnull, as you can see from the first test in get_r

Re: [ovs-dev] [PATCH 04/27] ovn-nbctl: Drop gratuitous indentation for "show" output.

2017-05-02 Thread Russell Bryant
aff <b...@ovn.org> > --- > ovn/utilities/ovn-nbctl.c | 26 +- > tests/ovn-nbctl.at| 16 > 2 files changed, 21 insertions(+), 21 deletions(-) I think this was my fault and I can't remember why I did this. This looks good to me

Re: [ovs-dev] [PATCH 02/27] uuid: Change semantics of uuid_is_partial_string().

2017-05-02 Thread Russell Bryant
, now yields 0. > "e66250bb-9531-491b-b9c3-5385cabb0080" previously yielded 36, still does. > "e66250bb-9531-491b-b9c3-5385cabb0080xyzzy" previously yielded 36, now 0. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Russell Bryant &l

Re: [ovs-dev] [PATCH 01/27] ovn-nb: Fix grouping in manpage.

2017-05-02 Thread Russell Bryant
On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff <b...@ovn.org> wrote: > DHCP columns shouldn't be part of "Common Columns" because that's just for > external_ids and other_config. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-b

Re: [ovs-dev] [PATCH] OVN localport type support

2017-05-02 Thread Russell Bryant
ll write an agent that runs on each node along side ovn-controller that will manage OVS ports and corresponding instances of haproxy. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: add python-sphinx as a build dependency

2017-04-28 Thread Russell Bryant
; BuildRequires: groff graphviz >> BuildRequires: checkpolicy, selinux-policy-devel >> +BuildRequires: python-sphinx >> # make check dependencies >> BuildRequires: %{_py2}-twisted%{?rhel:-core} %{_py2}-zope-interface >> %{_py2}-six >> BuildRequires: procp

Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets.

2017-04-27 Thread Russell Bryant
On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: >> The RPM build makefile targets are helpful during development and testing, >> but I personally almost never want the tests to run when I use

Re: [ovs-dev] [PATCH] ovn: Bump ovn-nb schema version.

2017-04-27 Thread Russell Bryant
On Mon, Apr 24, 2017 at 2:04 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Apr 19, 2017 at 12:41:37PM -0400, Russell Bryant wrote: >> Commit b89d25e5694b made the "router" DHCPv4 option optional instead of >> mandatory. This did not actually change the sch

Re: [ovs-dev] [RFC v2] OVN localport type support

2017-04-21 Thread Russell Bryant
lly in response to a request it > + received. > + > > > > @@ -986,11 +995,12 @@ > hypervisor. Each flow's actions implement sending a packet to the > port > it matches. For unicast logical output ports on remote h

Re: [ovs-dev] [PATCH] Avoid update probe interval to non-zero for unix socket.

2017-04-18 Thread Russell Bryant
> { > +if (!stream_or_pstream_needs_probes(fsm->name)) { > +probe_interval = 0; > +} > fsm->probe_interval = probe_interval ? MAX(1000, probe_interval) : 0; > } > > -- > 2.1.0 > > ___ >

Re: [ovs-dev] [PATCH v3] python: Allow tuning the session probe_interval from IDL

2017-04-13 Thread Russell Bryant
ython/ovs/db/idl.py | 12 +--- > python/ovs/jsonrpc.py | 11 +-- > 2 files changed, 18 insertions(+), 5 deletions(-) Thanks! I updated this patch to add your name to the AUTHORS file and applied this to master. -- Russell Bryant _

Re: [ovs-dev] [PATCH] docs: Update version numbers in doc config.

2017-04-12 Thread Russell Bryant
On Wed, Apr 12, 2017 at 9:12 AM, Stephen Finucane <step...@that.guru> wrote: > On Wed, 2017-04-12 at 08:58 -0400, Russell Bryant wrote: >> On Wed, Apr 12, 2017 at 7:29 AM, Stephen Finucane <step...@that.guru> >> wrote: >> > On Tue, 2017-04-11 at 13:15 -0400,

Re: [ovs-dev] [PATCH] docs: Update version numbers in doc config.

2017-04-12 Thread Russell Bryant
On Wed, Apr 12, 2017 at 7:29 AM, Stephen Finucane <step...@that.guru> wrote: > On Tue, 2017-04-11 at 13:15 -0400, Russell Bryant wrote: >> Update the version numbers in the documentation config to reflect >> 2.7.90 >> instead of 2.6.0. >> >> T

[ovs-dev] [PATCH] docs: Update version numbers in doc config.

2017-04-11 Thread Russell Bryant
to be automatically generated for docs.openvswitch.org. Signed-off-by: Russell Bryant <russ...@ovn.org> --- Documentation/automake.mk | 10 ++ Documentation/conf.py | 5 +- Documentation/conf.py.in | 349 ++ 3 files changed, 362 insertions(+), 2 del

Re: [ovs-dev] [PATCH v2] python: Allow tuning the session probe_interval from IDL

2017-04-11 Thread Russell Bryant
a gmail. Can you try re-submitting with git-send-email? Thanks, -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] python: Allow tuning the session probe_interval from IDL

2017-04-11 Thread Russell Bryant
gt; > which is a similar solution the the one above for the Python code. >> > >> > I don't have enough "big picture" OVN knowledge yet to know whether >> > this (and the ovn-remote-probe-interval) patch is the way to go or >> > whether independentl

Re: [ovs-dev] [PATCH] python: Allow tuning the session probe_interval from IDL

2017-04-06 Thread Russell Bryant
so that we can pass in the desired value before the connection is opened and is used from the beginning. The separate method is tempting as far as writing code that can deal with versions of this library that may or may not have support for the official way of setting this, but it still feels like

Re: [ovs-dev] [PATCH 1/2] doc: Describe how docs.openvswitch.org works

2017-04-06 Thread Russell Bryant
s.rst \ Documentation/internals/patchwork.rst \ -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [RFC] OpenStack Metadata API and OVN

2017-04-03 Thread Russell Bryant
/ Thanks, -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets.

2017-03-31 Thread Russell Bryant
and update the documentation accordingly. Signed-off-by: Russell Bryant <russ...@ovn.org> --- Documentation/intro/install/fedora.rst | 9 - rhel/automake.mk | 1 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/intro/install/fedora.

Re: [ovs-dev] [PATCH] sandbox: use ssl for ovn-controller to sb db connection

2017-03-27 Thread Russell Bryant
nce Richardson <lrich...@redhat.com> > --- > tutorial/automake.mk | 3 ++- > tutorial/ovs-sandbox | 42 -- > 2 files changed, 38 insertions(+), 7 deletions(-) Tested and it's working fine for me. Thanks for the patch. I appl

Re: [ovs-dev] [PATCH] Document: Fix default DB in ovn-nbctl/sbctl manpages.

2017-03-27 Thread Russell Bryant
On Mon, Mar 27, 2017 at 2:50 AM, Han Zhou <zhou...@gmail.com> wrote: > Signed-off-by: Han Zhou <zhou...@gmail.com> > --- > ovn/utilities/ovn-nbctl.8.xml | 2 +- > ovn/utilities/ovn-sbctl.8.in | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied to m

Re: [ovs-dev] [RFC] sandbox: use ssl for ovn-controller to sb db connection

2017-03-22 Thread Russell Bryant
"/ovnsb_db.sock \ > --ovnnb-db=unix:"$sandbox"/ovnnb_db.sock > rungdb $gdb_ovn_controller $gdb_ovn_controller_ex ovn-controller \ > ---detach --no-chdir --pidfile -vconsole:off --log-file > +$OVN_CTRLR_PKI --detach --no-chdir --pidfile

Re: [ovs-dev] [PATCH] build: Only re-gen HTML docs when needed.

2017-03-20 Thread Russell Bryant
On Thu, Mar 16, 2017 at 4:58 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Mar 16, 2017 at 01:57:20PM -0700, Ben Pfaff wrote: >> On Thu, Mar 16, 2017 at 01:01:32PM -0400, Russell Bryant wrote: >> > When sphinx-build is installed, the docs were being re-generated duri

Re: [ovs-dev] Proposed OVN live migration workflow

2017-03-16 Thread Russell Bryant
On Thu, Mar 16, 2017 at 1:39 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Feb 27, 2017 at 11:12:07AM -0500, Russell Bryant wrote: >> This is a proposed update to the VM live migration workflow with OVN. >> >> Currently, when doing live migration, you must not add

[ovs-dev] [PATCH] build: Only re-gen HTML docs when needed.

2017-03-16 Thread Russell Bryant
When sphinx-build is installed, the docs were being re-generated during every invocation of "make". This patch sets up dependencies such that sphinx-build will only be executed if one of the documentation files has changed. Signed-off-by: Russell Bryant <russ...@ovn.org>

Re: [ovs-dev] [PATCH] Document OVN support in ovs-sandbox.

2017-03-15 Thread Russell Bryant
On Wed, Mar 15, 2017 at 4:37 AM, Numan Siddique <nusid...@redhat.com> wrote: > On Tue, Mar 14, 2017 at 1:56 AM, Russell Bryant <russ...@ovn.org> wrote: >> >> A previous commit removed the original ovs-sandbox based OVN tutorial >> because it became too outdated an

Re: [ovs-dev] OVN: Compromised Chassis Mitigation

2017-03-14 Thread Russell Bryant
the indirection through role is suggested, to > allow access to various things without hardcoding specific logic > to determine what is subject to the rules. I had imagined we'd deploy OVN such that ovn-northd would connect to a different ovsdb remote that didn't have ACLs turned on. Currently

Re: [ovs-dev] [RFC] Use tox to build docs.

2017-03-14 Thread Russell Bryant
On Tue, Mar 14, 2017 at 8:21 AM, Stephen Finucane <step...@that.guru> wrote: > On Mon, 2017-03-13 at 17:41 -0400, Russell Bryant wrote: >> There have been a few patches lately tweaking docs to deal with >> different >> sphinx versions in different linux distributions.

[ovs-dev] [RFC] Use tox to build docs.

2017-03-13 Thread Russell Bryant
install tox Signed-off-by: Russell Bryant <russ...@ovn.org> --- .gitignore| 1 + Documentation/automake.mk | 8 +++- Makefile.am | 3 ++- tox.ini | 13 + 4 files changed, 19 insertions(+), 6 deletions(-) create mode 100644 t

[ovs-dev] [PATCH] Document OVN support in ovs-sandbox.

2017-03-13 Thread Russell Bryant
it. This commit introduces a new and shorter document that shows how to use OVN in ovs-sandbox. It provides a single sample configuration, as well as a sample ovn-trace command. Signed-off-by: Russell Bryant <russ...@ovn.org> --- Documentation/automake.mk | 1 + Documentation/ind

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

2017-03-13 Thread Russell Bryant
On Fri, Mar 10, 2017 at 4:48 PM, Russell Bryant <russ...@ovn.org> wrote: > On Fri, Mar 10, 2017 at 2:35 PM, Russell Bryant <russ...@ovn.org> wrote: >> On Thu, Mar 9, 2017 at 11:52 PM, Numan Siddique <nusid...@redhat.com> wrote: >> I don't think it's a Neutron issue

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

2017-03-10 Thread Russell Bryant
On Fri, Mar 10, 2017 at 2:35 PM, Russell Bryant <russ...@ovn.org> wrote: > On Thu, Mar 9, 2017 at 11:52 PM, Numan Siddique <nusid...@redhat.com> wrote: >> Thanks for the review. Please see inline. >> >> >> On Fri, Mar 10, 2017 at 1:44 AM, Russell Bryant <r

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

2017-03-10 Thread Russell Bryant
On Thu, Mar 9, 2017 at 11:52 PM, Numan Siddique <nusid...@redhat.com> wrote: > Thanks for the review. Please see inline. > > > On Fri, Mar 10, 2017 at 1:44 AM, Russell Bryant <russ...@ovn.org> wrote: >> >> On Mon, Feb 27, 2017 at 12:59 AM, <nusid...@redha

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

2017-03-09 Thread Russell Bryant
Where in the above process is it coming apart? If it's broken, it sounds like a more general problem than ICMP. It would be any type of traffic to the router IP where we expect a response. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] OVN: Compromised Chassis Mitigation

2017-03-08 Thread Russell Bryant
e: "chassis2" > delete: > chassis: UUIDs of all rows in Port_Binding table having > "chassis" equal to "chassis2" > > Transaction ACL Implementation: > > For each transaction request on a read-only connection, indi

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

2017-03-08 Thread Russell Bryant
-ds_put_cstr(ds, "{"); >> -for (int i = 0; i < op->lrp_networks.n_ipv4_addrs; i++) { >> -ds_put_format(ds, "%s, ", op->lrp_networks.ipv4_addrs[i].addr_s); >> -if (add_bcast) { >> -ds_put_format(ds, "%s, ",

Re: [ovs-dev] [PATCH] rhel: Use correct default port for OVN SB database

2017-03-08 Thread Russell Bryant
On Wed, Mar 8, 2017 at 3:19 PM, Lance Richardson wrote: > Fix typo in OVN SB database TCP port number. > > Fixes: commit 55f36be59122 ("rhel: Firewall service files for OVN.") > Signed-off-by: Lance Richardson Applied to master and branch-2.7, thanks!

Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix running under python3.

2017-03-08 Thread Russell Bryant
xt.split('\n'): > +for line in text.decode().split('\n'): > if current_file != previous_file: > previous_file = current_file > if any([fmt in current_file for fmt in line_length_blacklist]): Acked-by: Russell Bryant <russ...@ovn.or

Re: [ovs-dev] [PATCH 1/2] checkpatch: Check for pointer whitespace.

2017-03-08 Thread Russell Bryant
turn True > > > +def pointer_whitespace_check(line): > +"""Return TRUE if there is not an asterisk between a pointer name and the s/asterisk/space/ Otherwise: Acked-by: Russell Bryant <russ...@ovn.org> > + asterisk that denotes this is a api

Re: [ovs-dev] [PATCH] ovn-controller: Don't bind non-existent interfaces.

2017-03-08 Thread Russell Bryant
ller only binds > the interfaces that actually have a valid 'ofport'. > > Signed-off-by: Gurucharan Shetty <g...@ovn.org> This sounds reasonable to me. Acked-by: Russell Bryant <russ...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Makefile: Drop vestiges of support for non-GNU Make.

2017-03-08 Thread Russell Bryant
> --- > Makefile.am | 6 -- > acinclude.m4 | 54 ++ > configure.ac | 3 +-- > 3 files changed, 3 insertions(+), 60 deletions(-) > Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___

Re: [ovs-dev] [PATCH v3] packaging: Make Fedora spec file CentOS compatible

2017-03-08 Thread Russell Bryant
On Mon, Mar 6, 2017 at 3:46 PM, Leif Madsen wrote: > On CentOS, the package names aren't prefixed with python2, but rather > are prefixed with simply python. This change addresses that and fixes > up some documentation that was outdated, and updates the Vagrantfile > to use

Re: [ovs-dev] [PATCH] flake8: Fix build with flake8-import-order installed.

2017-03-07 Thread Russell Bryant
On Tue, Mar 7, 2017 at 1:57 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Mar 07, 2017 at 11:16:08AM -0500, Russell Bryant wrote: > > OpenStack CI is currently failing due to some flake8 warnings > > emitted from the flake8-import-order plugin. Just ignore all of > > t

Re: [ovs-dev] [PATCH v4] ovn: Modify the DHCPv4 router option to optional

2017-03-07 Thread Russell Bryant
> Signed-off-by: Guoshuai Li <l...@dtdream.com> > Acked-by: Numan Siddique <nusid...@redhat.com> > -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [patch_v1] doc: Support building ovs with Trusty.

2017-03-07 Thread Russell Bryant
submit a modification to the documentation style guide > as a follow up, noting the need to validate docs against the minimum > supported version? > Maybe we should set up a tox environment that builds the docs using the minimum supported version of sphinx. That would make it easy on everyone to test. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] fedora: Add python3-openvswitch split package

2017-03-02 Thread Russell Bryant
io > > Thanks! > Leif. > Thanks for letting us know. A conditional sounds fine to me. Maybe make it an option you can specify, on by default except for centos/rhel ? -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.ope

[ovs-dev] [PATCH] python: List 3.5 as a supported version.

2017-02-28 Thread Russell Bryant
All tests pass with Python 3.5 so list it as supported. Signed-off-by: Russell Bryant <russ...@ovn.org> --- python/setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/setup.py b/python/setup.py index 19c1f18..a85b3d1 100644 --- a/python/setup.py +++ b/python/setup.py @@

Re: [ovs-dev] [PATCH 2/2] rhel-systemd: Document systemd behavior

2017-02-27 Thread Russell Bryant
On Mon, Feb 20, 2017 at 9:42 AM, Flavio Leitner wrote: > On Wed, Feb 08, 2017 at 05:28:22PM +0100, Eelco Chaudron wrote: > > This is a follow up patch to document the systemd behavior including > > the change introduced by the "rhel-systemd: Restart openvswitch > > service if

Re: [ovs-dev] [PATCH] rhel-systemd: Restart openvswitch service if a daemon crashes

2017-02-27 Thread Russell Bryant
On Tue, Feb 7, 2017 at 7:38 AM, Eelco Chaudron wrote: > Currently if either ovsdb-server or ovs-vswitchd is crashing the > daemon is not restarting leaving the system in faulty state. > This patch will detect the daemon crash and will restart the > openvswitch service. > >

Re: [ovs-dev] [PATCH] ovn-controller: Assign ct_zone id to local datapaths instead of lports

2017-02-27 Thread Russell Bryant
ents and pointing out the conflicts. > > I will abandon the patch for now and revisit later if it is required to > optimize for the same host scenario.​ > > ​ > Or do you think it is good to optimize ? ​ > I would hold off on it for now until we find out for sure that this is a critical scenario. I'll try asking around for some opinions. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] Proposed OVN live migration workflow

2017-02-27 Thread Russell Bryant
would be re-applied, and the connections would be allowed to stay open. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/2] rhel: Add hostname as dependency

2017-02-23 Thread Russell Bryant
On Thu, Feb 23, 2017 at 4:06 PM, Russell Bryant <russ...@ovn.org> wrote: > From: Jakub Libosvar <libos...@redhat.com> > > ovs-ctl script uses hostname. This patch adds dependency for > rhel systems. > > Signed-off-by: Jakub Libosvar <libos...@redhat.com> &

[ovs-dev] [PATCH v2 1/2] rhel: Add hostname as dependency

2017-02-23 Thread Russell Bryant
From: Jakub Libosvar <libos...@redhat.com> ovs-ctl script uses hostname. This patch adds dependency for rhel systems. Signed-off-by: Jakub Libosvar <libos...@redhat.com> Signed-off-by: Russell Bryant <russ...@ovn.org> --- AUTHORS.rst | 1 + rhel/openvswi

[ovs-dev] [PATCH v2 0/2] Add hostname as a dependency.

2017-02-23 Thread Russell Bryant
as dependency [PATCH v2 2/2] debian: Add hostname as dependency -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

<    1   2   3   4   5   6   7   8   9   10   >