Re: [ovs-dev] [PATCH 1/2] doc: Fix cropped what-is-ovs page.

2019-05-16 Thread Stephen Finucane
;doc: Remove experimental warning for DPDK.") > Signed-off-by: Ilya Maximets Good call. Acked-by: Stephen Finucane > --- > Documentation/intro/what-is-ovs.rst | 8 > README.rst | 5 +++-- > 2 files changed, 7 insertions(+), 6 deletions(-)

Re: [ovs-dev] [ovs-dev, v1] datapath-windows: Do not send out nbls when cloned nbls are being accessed

2019-04-11 Thread Stephen Finucane
On Wed, 2019-04-10 at 13:53 -0400, Aaron Conole wrote: > Aaron Conole writes: > > > 0-day Robot writes: > > > > > Bleep bloop. Greetings Anand Kumar via dev, I am a robot and I have > > > tried out your patch. > > > Thanks for your contribution. > > > > > > I encountered some error that I

[ovs-dev] [PATCH] doc: Add missing ':doc:' role

2018-12-28 Thread Stephen Finucane
This was rendering in italics instead of cross-referencing as intended. Signed-off-by: Stephen Finucane --- Documentation/topics/dpdk/bridge.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/topics/dpdk/bridge.rst b/Documentation/topics/dpdk/bridge.rst index

Re: [ovs-dev] [PATCH] docs: Fix table title for VM MQ config in dpdk howto.

2018-08-31 Thread Stephen Finucane
On Thu, 2018-08-30 at 17:36 +0100, Cian Ferriter wrote: > Found this when searching "BIOS Settings" for use with DPDK. > > CC: Stephen Finucane > Fixes: c50938a24031 ("doc: Convert INSTALL.DPDK-ADVANCED to rST") > Signed-off-by: Cian Ferriter

Re: [ovs-dev] [PATCH] doc: Final cleanup of the DPDK documents

2018-05-11 Thread Stephen Finucane
On Thu, 2018-05-10 at 19:05 +, Stokes, Ian wrote: > > This concludes the cleanup by fixing some nits and adding some additional > > cross-references. > > > > Signed-off-by: Stephen Finucane <step...@that.guru> > > --- > > This was initially sent as

[ovs-dev] [PATCH] doc: Final cleanup of the DPDK documents

2018-05-09 Thread Stephen Finucane
This concludes the cleanup by fixing some nits and adding some additional cross-references. Signed-off-by: Stephen Finucane <step...@that.guru> --- This was initially sent as part of a larger series but excluded from a recent merge due to label issues. I wasn't able to reproduce these

[ovs-dev] [PATCH v3 10/n] docs: Clarify changes in Rx queue allocation

2018-04-20 Thread Stephen Finucane
-show' command was added in OVS 2.6.0 and modified in OVS 2.9.0 Correct both of these and modify the NEWS entry for this to clarify things a little (it took a bit of git spelunking and bothering people on IRC to figure out). Signed-off-by: Stephen Finucane <step...@that.guru> Cc: Kevin T

[ovs-dev] [PATCH v3 6/9] doc: Add "bridge" topic document

2018-04-19 Thread Stephen Finucane
This details configuration steps that apply to the entire bridge, rather than individual ports. Signed-off-by: Stephen Finucane <step...@that.guru> --- v3: - Add new files to automake.mk v2: - Cross-reference this document from all interface documents --- Documentation/autom

[ovs-dev] [PATCH v3 2/9] doc: Add "PMD" topic document

2018-04-19 Thread Stephen Finucane
This continues the breakup of the huge DPDK "howto" into smaller components. There are a couple of related changes included, such as using "Rx queue" instead of "rxq" and noting how Tx queues cannot be configured. Signed-off-by: Stephen Finucane <step...@t

[ovs-dev] [PATCH v3 4/9] doc: Add "vdev" topic document

2018-04-19 Thread Stephen Finucane
These are separate things from physical, ring and vhost-user interfaces and deserve their own documents. A couple of small typos are fixed along the way. Signed-off-by: Stephen Finucane <step...@that.guru> --- v3: - Add new files to automake.mk - Add 'versionchanged' directive to call ou

[ovs-dev] [PATCH v3 8/9] doc: Add "jumbo frames" topic document

2018-04-19 Thread Stephen Finucane
We include references from the physical and vhost-user interface guides. Signed-off-by: Stephen Finucane <step...@that.guru> --- v3: - Add new files to automake.mk - Add 'versionchanged' directive to call out when this was added v2: - Don't split the document into multiple docs --- Documen

[ovs-dev] [PATCH v3 3/9] doc: Move additional sections to "physical ports" doc

2018-04-19 Thread Stephen Finucane
The "hotplugging", "flow control", and "Rx checksum offload" sections only apply to 'dpdk' ports and are too detailed to include in a high-level howto. Move them, reworking some aspects of this in the process. Signed-off-by: Stephen Finucane <step...@that.guru&g

[ovs-dev] [PATCH v3 1/9] doc: Add an overview of the 'dpdk' port

2018-04-19 Thread Stephen Finucane
with a little more detailed overview of the binding process. There is additional cleanup to be done for the DPDK howto, but that will be done separately. We enable the TODO directive so we can actually start calling out some TODOs. Signed-off-by: Stephen Finucane <step...@that.guru> --- v3:

[ovs-dev] [PATCH v3 5/9] doc: Move "QoS" guide to its own document

2018-04-19 Thread Stephen Finucane
Again, this stuff is too detailed for a high-level howto. Signed-off-by: Stephen Finucane <step...@that.guru> --- v3: - Add new files to automake.mk - Add 'versionchanged' directive to call out when this was added v2: - Keep flow control section in 'phy' document --- Documentation/autom

[ovs-dev] [PATCH v3 0/9] Split up the DPDK how-to

2018-04-19 Thread Stephen Finucane
to be brief, high-level overviews on a particular group of features, with a focus on the user. They're not as all-encompassing as a 'tutorial', but not as specific as a 'topic'. Changes since v2: - Addressed comments from Ian Stokes Stephen Finucane (9): doc: Add an overview

Re: [ovs-dev] [PATCH v2 6/9] doc: Add "bridge" topic document

2018-04-19 Thread Stephen Finucane
On Wed, 2018-04-18 at 15:33 +, Stokes, Ian wrote: > > This details configuration steps that apply to the entire bridge, rather > > than individual ports. > > > > Signed-off-by: Stephen Finucane <step...@that.guru> > > --- > > v2: > > -

Re: [ovs-dev] [PATCH v2 2/9] doc: Add "PMD" topic document

2018-04-19 Thread Stephen Finucane
Tx queues cannot be configured. > > > > Signed-off-by: Stephen Finucane <step...@that.guru> > > --- > > v2: > > - Add cross-references from 'pmd' doc to 'vhost-user' and 'phy' docs > > - Add 'versionchanged' warning about automatic assignment of Rx queues

Re: [ovs-dev] [PATCH v2 4/9] doc: Add "vdev" topic document

2018-04-19 Thread Stephen Finucane
On Wed, 2018-04-18 at 15:32 +, Stokes, Ian wrote: > > These are separate things from physical, ring and vhost-user interfaces > > and deserve their own documents. A couple of small typos are fixed along > > the way. > > > > Signed-off-by: Steph

Re: [ovs-dev] [PATCH v2 1/9] doc: Add an overview of the 'dpdk' port

2018-04-19 Thread Stephen Finucane
build dependencies. Fixed now. > > > > We enable the TODO directive so we can actually start calling out some > > TODOs. > > > > Signed-off-by: Stephen Finucane <step...@that.guru> > > --- > > v2: > > - Add TODO for multiple ports sharing

Re: [ovs-dev] [PATCH v1 3/4] docs: Fix sphinx urls.

2018-04-19 Thread Stephen Finucane
On Thu, 2018-04-19 at 11:49 +0100, Ian Stokes wrote: > Update dead url links for sphinx documentation to avoid > make check-docs failing. > > Cc: Stephen Finucane <step...@that.guru> > Fixes: 26ea2d409 ("docs: Add writing guide") > Fixes: 73c76b447 ("

Re: [ovs-dev] [PATCH v1 2/4] docs: Fix style guide url in DocumentationStyle.rst.

2018-04-19 Thread Stephen Finucane
On Thu, 2018-04-19 at 11:49 +0100, Ian Stokes wrote: > The link used for IBM Style Guide is no longer valid. As there is no > longer a valid link via redbooks remove the url to avoid make > check-docs failing. > > Cc: Stephen Finucane <step...@that.guru> > Fixes: 26ea2

Re: [ovs-dev] [PATCH v1 4/4] docs: Fix urls in index.rst.

2018-04-19 Thread Stephen Finucane
On Thu, 2018-04-19 at 11:49 +0100, Ian Stokes wrote: > This patch prepends 'www.' to openvswitch urls in index.rst. Without this > make check-docs fails when verifying url liveness. Also remove url > referencing ovsdb-server(5) as these are no longer accessible. > > Cc: Stephen

Re: [ovs-dev] [PATCH v1 1/4] Docs: Fix sflow documentation url and markup.

2018-04-19 Thread Stephen Finucane
low. > > CC: Stephen Finucane <step...@that.guru> > Fixes: 198c5d3d0 ("doc: Add sFlow cookbook from website") > Signed-off-by: Ian Stokes <ian.sto...@intel.com> femotonit: s/Docs/docs/ (for the summary). Other than that...

Re: [ovs-dev] [PATCH 0/8] Split up the DPDK how-to

2018-04-17 Thread Stephen Finucane
these. > > > > Now to go back to figure how exactly NUMA affinity works for and affects > > PMD threads... > > > > [*] 'howto' documents are supposed to be brief, high-level overviews on > > a particular group of features, with a focus on the user. They're >

[ovs-dev] [PATCH v2 6/9] doc: Add "bridge" topic document

2018-04-16 Thread Stephen Finucane
This details configuration steps that apply to the entire bridge, rather than individual ports. Signed-off-by: Stephen Finucane <step...@that.guru> --- v2: - Cross-reference this document from all interface documents --- Documentation/howto/dpdk.rst

[ovs-dev] [PATCH v2 9/9] doc: Final cleanup of the DPDK documents

2018-04-16 Thread Stephen Finucane
This concludes the cleanup by fixing some nits and adding some additional cross-references. Signed-off-by: Stephen Finucane <step...@that.guru> --- v2: - Add changes to DPDK topic index doc --- Documentation/howto/dpdk.rst| 51 - Documentation/

[ovs-dev] [PATCH v2 8/9] doc: Add "jumbo frames" topic document

2018-04-16 Thread Stephen Finucane
We include refrences from the physical and vhost-user interface guides. Signed-off-by: Stephen Finucane <step...@that.guru> --- v2: - Don't split the document into multiple docs --- Documentation/howto/dpdk.rst | 52 ++ Documentation/topics/dpdk/ind

[ovs-dev] [PATCH v2 0/9] Split up the DPDK how-to

2018-04-16 Thread Stephen Finucane
to be brief, high-level overviews on a particular group of features, with a focus on the user. They're not as all-encompassing as a 'tutorial', but not as specific as a 'topic'. Changes since v1: - Addressed comments from Ian Stokes Stephen Finucane (9): doc: Add an overview

[ovs-dev] [PATCH v2 1/9] doc: Add an overview of the 'dpdk' port

2018-04-16 Thread Stephen Finucane
with a little more detailed overview of the binding process. There is additional cleanup to be done for the DPDK howto, but that will be done separately. We enable the TODO directive so we can actually start calling out some TODOs. Signed-off-by: Stephen Finucane <step...@that.guru> --- v2:

[ovs-dev] [PATCH v2 2/9] doc: Add "PMD" topic document

2018-04-16 Thread Stephen Finucane
This continues the breakup of the huge DPDK "howto" into smaller components. There are a couple of related changes included, such as using "Rx queue" instead of "rxq" and noting how Tx queues cannot be configured. Signed-off-by: Stephen Finucane <step...@that.gur

[ovs-dev] [PATCH v2 7/9] doc: Move "pdump" guide to its own document

2018-04-16 Thread Stephen Finucane
Yet another section that's far too detailed for someone getting started with DPDK in OVS. Split it out. Signed-off-by: Stephen Finucane <step...@that.guru> --- Documentation/howto/dpdk.rst| 39 -- Documentation/topics/dpdk/index.rst | 1 + Documentation/topic

[ovs-dev] [PATCH v2 3/9] doc: Move additional sections to "physical ports" doc

2018-04-16 Thread Stephen Finucane
The "hotplugging", "flow control", and "Rx checksum offload" sections only apply to 'dpdk' ports and are too detailed to include in a high-level howto. Move them, reworking some aspects of this in the process. Signed-off-by: Stephen Finucane <step...@that.guru&g

[ovs-dev] [PATCH v2 5/9] doc: Move "QoS" guide to its own document

2018-04-16 Thread Stephen Finucane
Again, this stuff is too detailed for a high-level howto. Signed-off-by: Stephen Finucane <step...@that.guru> --- v2: - Keep flow control section in 'phy' document --- Documentation/howto/dpdk.rst| 42 Documentation/topics/dpdk/index.rst | 1 + Documentation/

[ovs-dev] [PATCH v2 4/9] doc: Add "vdev" topic document

2018-04-16 Thread Stephen Finucane
These are separate things from physical, ring and vhost-user interfaces and deserve their own documents. A couple of small typos are fixed along the way. Signed-off-by: Stephen Finucane <step...@that.guru> --- Documentation/howto/dpdk.rst| 29 -- Documentation/topic

Re: [ovs-dev] [PATCH 6/8] doc: Move "pdump" guide to its own document

2018-04-16 Thread Stephen Finucane
n headers into a separate patch. Stephen > Ian > > > Signed-off-by: Stephen Finucane <step...@that.guru> > > --- > > Documentation/howto/dpdk.rst| 39 -- > > Documentation/topics/dpdk/index.rst | 7

Re: [ovs-dev] [PATCH 5/8] doc: Add "bridge" topic document

2018-04-16 Thread Stephen Finucane
On Mon, 2018-04-09 at 15:17 +, Stokes, Ian wrote: > > This details configuration steps that apply to the entire bridge, rather > > than individual ports. > > Comments inline. > > > > > Signed-off-by: Stephen Finucane <step...@that.guru> &g

Re: [ovs-dev] [PATCH 4/8] doc: Move "QoS" guide to its own document

2018-04-16 Thread Stephen Finucane
On Mon, 2018-04-09 at 15:16 +, Stokes, Ian wrote: > > Again, this stuff is too detailed for a high-level howto. > > > > Signed-off-by: Stephen Finucane <step...@that.guru> > > --- > > Documentation/howto/dpdk.rst| 70 - >

Re: [ovs-dev] [PATCH 3/8] doc: Move additional sections to "physical ports" doc

2018-04-16 Thread Stephen Finucane
ss some of these issues. A more substantial follow up to come on the cover letter. > More comments below. > > > > Signed-off-by: Stephen Finucane <step...@that.guru> > > --- > > Documentation/howto/dpdk.rst | 93 +++--- > > - &g

Re: [ovs-dev] [PATCH 2/8] doc: Add "PMD" topic document

2018-04-16 Thread Stephen Finucane
queues cannot be configured. > > > > We enable the TODO directive, so we can actually start calling out some > > TODOs. > > > > Signed-off-by: Stephen Finucane <step...@that.guru> > > --- > > Documentation/conf.py| 2 +- > &

Re: [ovs-dev] [PATCH 1/8] doc: Add an overview of the 'dpdk' port

2018-04-16 Thread Stephen Finucane
> > Start closing this gap by providing a standalone example of using these > > ports along with a little more detailed overview of the binding process. > > > > There is additional cleanup to be done for the DPDK howto, but that will > > be done separately. > >

Re: [ovs-dev] [PATCH 2/2] dpdk docs: Drop file share in libvirt config.

2018-04-13 Thread Stephen Finucane
On Thu, 2018-04-12 at 08:24 +0100, Lam, Tiago wrote: > On 11/04/2018 15:03, Stephen Finucane wrote: > > On Wed, 2018-04-11 at 09:54 -0400, Aaron Conole wrote: > > > Tiago Lam <tiago@intel.com> writes: > > > > > > > When explaining on

Re: [ovs-dev] [PATCH 2/2] dpdk docs: Drop file share in libvirt config.

2018-04-11 Thread Stephen Finucane
On Wed, 2018-04-11 at 09:54 -0400, Aaron Conole wrote: > Tiago Lam writes: > > > When explaining on how to add vhost-user ports to a guest, using > > libvirt, the following piece of configuration is used: > > > > > > > > > > > > > > > >

[ovs-dev] [PATCH 7/8] doc: Split Jumbo Frames guide between two docs

2018-02-12 Thread Stephen Finucane
While there is some duplication going on here, that's not necessarily a bad thing. If nothing else, it lets us remove one more overly-detailed step from the howto. Signed-off-by: Stephen Finucane <step...@that.guru> --- Documentation/howto/dpdk.rst

[ovs-dev] [PATCH 5/8] doc: Add "bridge" topic document

2018-02-12 Thread Stephen Finucane
This details configuration steps that apply to the entire bridge, rather than individual ports. Signed-off-by: Stephen Finucane <step...@that.guru> --- Documentation/howto/dpdk.rst | 60 Documentation/topics/dpdk/bridge.rst

[ovs-dev] [PATCH 4/8] doc: Move "QoS" guide to its own document

2018-02-12 Thread Stephen Finucane
Again, this stuff is too detailed for a high-level howto. Signed-off-by: Stephen Finucane <step...@that.guru> --- Documentation/howto/dpdk.rst| 70 - Documentation/topics/dpdk/index.rst | 1 + Documentation/topics/dpdk/phy.rst | 6 +++ Documentation/

[ovs-dev] [PATCH 0/8] Split up the DPDK howto

2018-02-12 Thread Stephen Finucane
exactly NUMA affinity works for and affects PMD threads... [*] 'howto' documents are supposed to be brief, high-level overviews on a particular group of features, with a focus on the user. They're not as all-encompassing as a 'tutorial', but not as specific as a 'topic'. Stephen Finucane (8

[ovs-dev] [PATCH 2/8] doc: Add "PMD" topic document

2018-02-12 Thread Stephen Finucane
y start calling out some TODOs. Signed-off-by: Stephen Finucane <step...@that.guru> --- Documentation/conf.py| 2 +- Documentation/howto/dpdk.rst | 86 --- Documentation/topics/dpdk/index.rst | 1 + Documentation/topics/dpdk/phy.rst

[ovs-dev] [PATCH 1/8] doc: Add an overview of the 'dpdk' port

2018-02-12 Thread Stephen Finucane
with a little more detailed overview of the binding process. There is additional cleanup to be done for the DPDK howto, but that will be done separately. Signed-off-by: Stephen Finucane <step...@that.guru> Cc: Ciara Loftus <ciara.lof...@intel.com> Cc: Kevin Traynor <ktra

[ovs-dev] [PATCH 6/8] doc: Move "pdump" guide to its own document

2018-02-12 Thread Stephen Finucane
Signed-off-by: Stephen Finucane <step...@that.guru> --- Documentation/howto/dpdk.rst| 39 -- Documentation/topics/dpdk/index.rst | 7 Documentation/topics/dpdk/pdump.rst | 65 + 3 files changed, 72 insertions(+), 39 del

[ovs-dev] [PATCH 3/8] doc: Move additional sections to "physical ports" doc

2018-02-12 Thread Stephen Finucane
The "vdev", "hotplugging", and "Rx checksum offload" sections only apply to 'dpdk' ports and are too detailed to include in a high-level howto. Move them, reworking some aspects of this in the process. Signed-off-by: Stephen Finucane <step...@that.guru> --- Do

[ovs-dev] [PATCH 8/8] doc: Final cleanup of the DPDK howto

2018-02-12 Thread Stephen Finucane
This concludes the cleanup by fixing some grammar nits and adding some additional cross-references. Signed-off-by: Stephen Finucane <step...@that.guru> --- Documentation/howto/dpdk.rst | 61 ++-- 1 file changed, 30 insertions(+), 31 deletions(-)

Re: [ovs-dev] [PATCH] MAINTAINERS: Fix links to other docs.

2017-12-29 Thread Stephen Finucane
On Fri, 2017-12-29 at 18:01 +0300, Ilya Maximets wrote: > Hard links to .rst files are broken in compiled documentation. > Fix that by changing to proper :doc: reference. > > Signed-off-by: Ilya Maximets I hadn't done this because MAINTAINERS is a top-level document and

Re: [ovs-dev] [PATCH] docs: Fix table view for VM config in dpdk howto.

2017-12-13 Thread Stephen Finucane
On Tue, 2017-12-12 at 16:19 +0300, Ilya Maximets wrote: > In current version table contains only one row with all the values > together. This is not readable. 'Simple table' format should work for > this case. > > CC: Stephen Finucane <step...@that.guru> > Fixes: 167

Re: [ovs-dev] [PATCH v3 5/5] doc: ConnTracker cfg parameters.

2017-10-19 Thread Stephen Finucane
gned-off-by: Antonio Fischetti <antonio.fische...@intel.com> One nit below, but otherwise LGTM. Acked-by: Stephen Finucane <step...@that.guru> > --- > Documentation/intro/install/dpdk.rst | 25 + > lib/dpctl.man| 10 ++ &

Re: [ovs-dev] [PATCH] Documentation: Add Faucet tutorial.

2017-10-19 Thread Stephen Finucane
On Wed, 2017-10-18 at 14:05 -0700, Ben Pfaff wrote: > This is for a talk at the Faucet conference on Oct. 19: > http://conference.faucet.nz/schedule/ > > Signed-off-by: Ben Pfaff Spotted a few small issues while skimming this. Did this build correctly and did the output HTML look

Re: [ovs-dev] [RFC PATCH v1] docs: Add release feature roadmap.

2017-09-28 Thread Stephen Finucane
On Wed, 2017-09-13 at 22:04 +0100, Ian Stokes wrote: > Add a document to outline the roadmap of features contributors are targeting > for upcoming OVS releases. > > Signed-off-by: Ian Stokes > --- > Documentation/automake.mk |1 + >

Re: [ovs-dev] [PATCH v2] docs: Add references to git-pw

2017-09-28 Thread Stephen Finucane
On Thu, 2017-09-28 at 08:44 -0700, Ben Pfaff wrote: > On Thu, Sep 28, 2017 at 04:36:04PM +0100, Stephen Finucane wrote: > > On Mon, 2017-09-04 at 14:09 +0100, Stephen Finucane wrote: > > > Now that Patchwork 2.0 is out, folks can start to take advantage of some > &g

Re: [ovs-dev] [PATCH v2] docs: Add references to git-pw

2017-09-28 Thread Stephen Finucane
On Mon, 2017-09-04 at 14:09 +0100, Stephen Finucane wrote: > Now that Patchwork 2.0 is out, folks can start to take advantage of some > of the new features that it offers. Chief among these is series support, > which is only exposed via the web UI and new REST API and which,

Re: [ovs-dev] pwclient XML errors and form feeds

2017-09-04 Thread Stephen Finucane
On Fri, 2017-08-18 at 21:27 +, Mark Michelson wrote: > On Fri, Aug 18, 2017 at 4:09 PM Ben Pfaff wrote: > > > On Mon, Aug 14, 2017 at 09:54:10PM +, Mark Michelson wrote: > > > I debugged the problem further and I now have figured out that the > > > > problem > > > has to

[ovs-dev] [PATCH v2] docs: Add references to git-pw

2017-09-04 Thread Stephen Finucane
documented. Signed-off-by: Stephen Finucane <step...@that.guru> --- v2: - Add information on configuring git-pw for the OVS project - Remove most documentation for pwclient, leaving only a footnote about its deprecated nature --- Documentation/internals/patchwork.rs

Re: [ovs-dev] [PATCH] docs: Add references to git-pw

2017-08-31 Thread Stephen Finucane
On Wed, 2017-08-30 at 10:38 -0700, Joe Stringer wrote: > On 29 August 2017 at 02:54, Stephen Finucane <step...@that.guru> wrote: > > Now that Patchwork 2.0 is out, folks can start to take advantage of some > > of the new features that it offers. Chief among these is seri

[ovs-dev] [PATCH] docs: Add references to git-pw

2017-08-29 Thread Stephen Finucane
documented. Signed-off-by: Stephen Finucane <step...@that.guru> --- PS: I still plan to get back to converting the man pages to rST, but have been sidetracked by other projects/work. Eventually! :) --- Documentation/internals/patchwork.rst | 34 ++ 1 file c

Re: [ovs-dev] [PATCH] docs: Update dpdk vdev naming instructions

2017-06-07 Thread Stephen Finucane
On Wed, 2017-06-07 at 15:33 +0100, Stephen Finucane wrote: > On Tue, 2017-06-06 at 16:26 +0100, Ciara Loftus wrote: > > Signed-off-by: Ciara Loftus <ciara.lof...@intel.com> > > I couldn't find where this changed (the only related commit was 69876ed, but > that referenc

Re: [ovs-dev] [PATCH] docs: Update dpdk vdev naming instructions

2017-06-07 Thread Stephen Finucane
the docs side: Acked-by: Stephen Finucane <step...@that.guru> > --- >  Documentation/howto/dpdk.rst | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst > index f3c7aff..93248b4 100644 >

Re: [ovs-dev] [PATCH v6 2/5] userspace: L3 tunnel support for GRE and LISP

2017-05-26 Thread Stephen Finucane
On Thu, 2017-05-25 at 09:22 -0700, Ben Pfaff wrote: > On Mon, May 22, 2017 at 01:43:25PM +, Jan Scheurich wrote: > > > I think that parse_gre_header() should perhaps be pickier about > > > the > > > Ethertypes it accepts, since values below 0x600 are not valid > > > Ethertypes and sometimes

[ovs-dev] [PATCH 1/2] docs: Clarify the superiority of dpdkvhostuserclient

2017-05-26 Thread Stephen Finucane
Apparently dpdkvhostuser interfaces are inferior to dpdkvhostuserclient. Explain why. Signed-off-by: Stephen Finucane <step...@that.guru> Cc: Ciara Loftus <ciara.lof...@intel.com> Cc: Kevin Traynor <ktray...@redhat.com> --- I'd like to note what happens to traffic when OVS or

[ovs-dev] [PATCH 2/2] docs: Document dpdkr ports

2017-05-26 Thread Stephen Finucane
I has an idea what these were but that idea was somewhat incorrect and out-of-date. Add a minimal guide to fill in these gaps, along with a warning about how useless these things generally are now (yay, vhost-user). Signed-off-by: Stephen Finucane <step...@that.guru> Cc: Ciara Loftus <

Re: [ovs-dev] [RFC 1/2] doc: Reduce duplication in 'man_pages'

2017-05-19 Thread Stephen Finucane
hanuprakash.  Damn - I missed that. Patch submitted to fix this now. Stephen > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > > boun...@openvswitch.org] On Behalf Of Ben Pfaff > > Sent: Thursday, May 18, 2017 11:50 PM >

[ovs-dev] [PATCH] doc: Resolve pep8 warnings in conf.py

2017-05-19 Thread Stephen Finucane
flake8 doesn't like us redefining variables in loops. Signed-off-by: Stephen Finucane <step...@that.guru> Reported-by: Bhanuprakash Bodireddy <bhanuprakash.bodire...@intel.com> Fixes: f15010f ("doc: Reduce duplication in 'man_pages'") Cc: Ben Pfaff <b...@ovn.org> --

[ovs-dev] [RFC 2/2] doc: Convert ovs-vswitchd to rST

2017-05-10 Thread Stephen Finucane
want to make best use of the Sphinx indexing. - TODO Signed-off-by: Stephen Finucane <step...@that.guru> --- This patch isn't complete, but I wanted to see what people thought of the formatting for more complex commands. There are a couple of issues with this that I still need to work t

Re: [ovs-dev] Cover letters (was Re: [PATCH 0/7] Add OVS DPDK keep-alive functionality)

2017-05-02 Thread Stephen Finucane
On Tue, 2017-05-02 at 12:21 -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Mon, May 01, 2017 at 04:45:56PM -0400, Aaron Conole wrote: > > > Ben Pfaff writes: > > > ... > > > > I think it'd be even better to include measurements in one of > > > > the commit

Re: [ovs-dev] [PATCH v2 6/6] Documentation: Update DPDK doc with Keepalive feature.

2017-04-27 Thread Stephen Finucane
hm_name" > +   SendNotification True > +   > +    > + > +``LCoreMask`` should be set to the PMD cores that were earlier > registered > +for keepalive monitoring. ``KeepAliveShmName`` refers to shared > memory block > +region. > + +Enable ``csv``

Re: [ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST

2017-04-26 Thread Stephen Finucane
On Wed, 2017-04-26 at 10:55 -0400, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: "Lance Richardson" > > Cc: "Leif Madsen" , "ovs dev" > org> > > Sent: Wednesday, 26 April, 2017 10:33:09 AM > > Subject: Re:

Re: [ovs-dev] [branch-2.7] Documentation: Remove external dependence on pygments.

2017-04-19 Thread Stephen Finucane
On Wed, 2017-04-19 at 08:12 -0700, Ben Pfaff wrote: > On Wed, Apr 19, 2017 at 12:23:39PM +0100, Stephen Finucane wrote: > > From: Ilya Maximets <i.maxim...@samsung.com> > > > > Current documentation uses syntax highlighting in 'sphinx' > > via 'pygments' libr

Re: [ovs-dev] [PATCH ovs V2] Documentation: fix broken links in maintainers page

2017-04-19 Thread Stephen Finucane
n/latest/internals/committer- responsibilities.rst>`__ or, cleaner: `here`__ __ http://docs.openvswitch.org/en/latest/internals/committer-responsi bilities.rst I should have mentioned this before but I didn't think of it . Thi s can be fixed at merge time though, so for this as-is: Acked

Re: [ovs-dev] [PATCH] Documentation: Remove external dependence on pygments.

2017-04-19 Thread Stephen Finucane
On Wed, 2017-04-19 at 12:21 +0100, Stephen Finucane wrote: > From: Ilya Maximets <i.maxim...@samsung.com> > > Current documentation uses syntax highlighting in 'sphinx' > via 'pygments' library. This leads to build failures on the > systems with old version of this library. &

[ovs-dev] [branch-2.7] Documentation: Remove external dependence on pygments.

2017-04-19 Thread Stephen Finucane
From: Ilya Maximets Current documentation uses syntax highlighting in 'sphinx' via 'pygments' library. This leads to build failures on the systems with old version of this library. In fact that only 'windows.rst' uses highlighting it's a very simple change. This helps us

[ovs-dev] [PATCH] Documentation: Remove external dependence on pygments.

2017-04-19 Thread Stephen Finucane
From: Ilya Maximets Current documentation uses syntax highlighting in 'sphinx' via 'pygments' library. This leads to build failures on the systems with old version of this library. In fact that only 'windows.rst' uses highlighting it's a very simple change. This helps us

Re: [ovs-dev] problem in "make" for openvswitch-2.7.0

2017-04-19 Thread Stephen Finucane
On Wed, 2017-04-19 at 12:16 +0100, rihab isims wrote: > Hi, > > I am following the installation guide to install openvswitch-2.7.0 > from > this link http://docs.openvswitch.org/en/latest/intro/install/general > / > however i am blocked at "make" command execution with the following > error: > >

Re: [ovs-dev] [PATCH ovs] Documentation: fix broken links in maintainers page

2017-04-18 Thread Stephen Finucane
On Tue, 2017-04-18 at 15:08 +0300, Roi Dayan wrote: > The links were pointing to static non-existent location instead > of internal doc link. > > Signed-off-by: Roi Dayan > --- >  MAINTAINERS.rst | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [ovs-dev] [PATCH 5/6] doc: Convert ovs-test to rST

2017-04-18 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > From: Stephen Finucane <step...@that.guru> > > Signed-off-by: Stephen Finucane <step...@that.guru> > Signed-off-by: Ben Pfaff <b...@ovn.org> Same comment on the 'Synopsis' section. Other than that, LGTM. Ac

Re: [ovs-dev] [PATCH 6/6] doc: Remove latex output configuration

2017-04-18 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > From: Stephen Finucane <step...@that.guru> > > We don't care about building LaTeX documentation, so there's no need > to > keep this build cruft around. > > Signed-off-by: Stephen Finucane <step...@that.guru&

Re: [ovs-dev] [PATCH 4/6] doc: Convert ovs-vlan-test to rST

2017-04-18 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > From: Stephen Finucane <step...@that.guru> > > Let's start with a simple one that lets us focus on setting up most > of > the required "infrastructure" for building man pages using Sphinx. > > Thi

Re: [ovs-dev] [PATCH 3/6] doc: Add man page section to documentation guide

2017-04-18 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > From: Stephen Finucane <step...@that.guru> > > We also replace 'reST' with the far more common 'rST'. > > Signed-off-by: Stephen Finucane <step...@that.guru> > Signed-off-by: Ben Pfaff <b...@ovn.org>

[ovs-dev] [PATCH] doc: Remove cruft from conf.py

2017-04-18 Thread Stephen Finucane
This file has enough going on as-is without keeping all this commented out noise around. Signed-off-by: Stephen Finucane <step...@that.guru> --- Documentation/conf.py | 248 -- 1 file changed, 248 deletions(-) diff --git a/Documentation/con

[ovs-dev] [PATCH] doc: Don't override default theme

2017-04-18 Thread Stephen Finucane
< 1.3) or 'alabaster'. [1] https://github.com/sphinx-doc/sphinx/commit/68021b0bd [2] https://github.com/sphinx-doc/sphinx/commit/034c4e942 Signed-off-by: Stephen Finucane <step...@that.guru> Cc: Matthew Thode <mth...@mthode.org> --- We might want to backport this if there a

Re: [ovs-dev] [PATCH] doc: fix doc build when not using ovs theme

2017-04-18 Thread Stephen Finucane
On Mon, 2017-04-17 at 10:21 -0700, Ben Pfaff wrote: > On Mon, Apr 17, 2017 at 11:47:30AM -0500, Matthew Thode wrote: > > On 04/17/2017 11:42 AM, Ben Pfaff wrote: > > > On Mon, Apr 17, 2017 at 11:32:13AM -0500, Matthew Thode wrote: > > > > On 04/17/2017 11:20 AM, Ben Pfaff wrote: > > > > > On Mon,

Re: [ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST

2017-04-14 Thread Stephen Finucane
On Fri, 2017-04-14 at 12:49 -0700, Ben Pfaff wrote: > On Fri, Apr 14, 2017 at 06:55:38PM +0100, Stephen Finucane wrote: > > On Thu, 2017-04-13 at 21:27 -0700, Ben Pfaff wrote: > > > Thank you!  rST is much more readable than nroff.  I have some > > > comments > >

Re: [ovs-dev] [PATCH 3/3] doc: Remove some link targets that aren't used anywhere.

2017-04-14 Thread Stephen Finucane
style document?), but if > not > then it seems reasonable to leave out the unused ones since they look > to > me like just visual clutter. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Stephen Finucane <step...@that.guru> __

Re: [ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST

2017-04-14 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:27 -0700, Ben Pfaff wrote: > Thank you!  rST is much more readable than nroff.  I have some > comments > below. > > On Mon, Apr 10, 2017 at 01:12:28PM +0100, Stephen Finucane wrote: > > Let's start with a simple one that lets us foc

Re: [ovs-dev] [PATCH 2/6] doc: Avoid need to generate conf.py.

2017-04-14 Thread Stephen Finucane
e difference between, e.g., 2.7 > +# and 2.7.90, which can be very different versions (2.7.90 may be > much > +# closer to 2.8 than to 2.7), so check for that. > +version = release if '.90' in release else > '.'.join(release.split('.')[0:2]) nit: You probably don't need to

Re: [ovs-dev] [PATCH 1/6] doc: Also delete stamp file in clean-docs target.

2017-04-14 Thread Stephen Finucane
On Thu, 2017-04-13 at 21:43 -0700, Ben Pfaff wrote: > Otherwise "make docs-check" won't necessarily do anything since its > apparent target is up to date. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Stephen

Re: [ovs-dev] [PATCH] docs: Automatically extract version from NEWS

2017-04-13 Thread Stephen Finucane
On Thu, 2017-04-13 at 11:22 -0700, Ben Pfaff wrote: > On Wed, Apr 12, 2017 at 12:32:24PM +0100, Stephen Finucane wrote: > > Parse the version and release from the NEWS file. This looks a bit > > hacky, but the NEWS file is generally well formatted and should be > > reliable en

Re: [ovs-dev] [PATCH] docs: Update version numbers in doc config.

2017-04-12 Thread Stephen Finucane
On Wed, 2017-04-12 at 08:58 -0400, Russell Bryant wrote: > On Wed, Apr 12, 2017 at 7:29 AM, Stephen Finucane <step...@that.guru> > wrote: > > On Tue, 2017-04-11 at 13:15 -0400, Russell Bryant wrote: > > > Update the version numbers in the documentation config to reflect

Re: [ovs-dev] [PATCH] docs: Update version numbers in doc config.

2017-04-12 Thread Stephen Finucane
On Tue, 2017-04-11 at 13:15 -0400, Russell Bryant wrote: > Update the version numbers in the documentation config to reflect > 2.7.90 > instead of 2.6.0. > > This patch also updates the build system to automatically update this > file. > conf.py is now a generated file from conf.py.in.  We still

[ovs-dev] [PATCH v2] doc: Link to release FAQ from DPDK install guide

2017-04-10 Thread Stephen Finucane
I wanted to find the mappings of DPDK versions to OVS versions. This was a little more difficult than expected. Resolve the issue by linking to it from the DPDK install guide. Signed-off-by: Stephen Finucane <step...@that.guru> --- v2: - Add a link to the releases FAQ from the instal

Re: [ovs-dev] [PATCH] doc: Link to release FAQ from DPDK install guide

2017-04-10 Thread Stephen Finucane
On Fri, 2017-04-07 at 15:28 +, Darrell Ball wrote: > > On 4/7/17, 6:58 AM, "ovs-dev-boun...@openvswitch.org on behalf of > Stephen Finucane" <ovs-dev-boun...@openvswitch.org on behalf of steph > e...@that.guru> wrote: > > I wanted to find the mapping

[ovs-dev] [RFC 1/4] doc: Add man page section to documentation guide

2017-04-10 Thread Stephen Finucane
We also replace 'reST' with the far more common 'rST'. Signed-off-by: Stephen Finucane <step...@that.guru> --- .../internals/contributing/documentation-style.rst | 84 +++--- 1 file changed, 76 insertions(+), 8 deletions(-) diff --git a/Documentation/internals/contri

[ovs-dev] [RFC 3/4] doc: Convert ovs-test to rST

2017-04-10 Thread Stephen Finucane
Signed-off-by: Stephen Finucane <step...@that.guru> --- See comment on the previous change --- Documentation/automake.mk | 2 + Documentation/conf.py | 3 + Documentation/ref/index.rst | 1 + Documentation/ref/ovs-test.rst

[ovs-dev] [RFC 2/4] doc: Convert ovs-vlan-test to rST

2017-04-10 Thread Stephen Finucane
ction character". Other than that, hurrah for (mostly) legible syntaxes. [1] http://www.tldp.org/HOWTO/Man-Page/q2.html Signed-off-by: Stephen Finucane <step...@that.guru> --- I don't know if this is correctly integrated into the docs build system or not. I need someone to double check

  1   2   3   >