Re: [ovs-dev] 答复: Re: 答复: Re: 答复: Re: [PATCH v2] ovn: Support for taas(tap-as-a-service) function

On Wed, Sep 6, 2017 at 3:57 AM, Russell Bryant wrote: > What if a mirror port *only* receives mirrored packets? If the only > packets it ever receives are mirrored packets, a new flag would not be > necessary. > > Do you intend for the port to operate as both a regular port

Re: [ovs-dev] [PATCH] acinclude.m4: Avoid error from printf.

oops, thank you. On Tue, Jul 18, 2017 at 2:12 AM, Ben Pfaff wrote: > GNU (at least) printf interprets -I as an option, but we want to print it > literally, so use %s. > > CC: YAMAMOTO Takashi > Fixes: 27d41afaa446 ("acinclude.m4: Avoid echo -n") > Signed-off-by:

Re: [ovs-dev] [PATCH] acinclude.m4: Avoid echo -n

On Sun, Jul 16, 2017 at 7:45 AM, Ben Pfaff wrote: > On Sun, Jul 16, 2017 at 12:17:28AM +0900, YAMAMOTO Takashi wrote: > > -n option for echo is not portable. Use printf instead. > > This fixes OSX build on travis-ci. > > > > Signed-off-by: YAMAMOTO Takashi > >

Re: [ovs-dev] [PATCH 5/6] ovn.at: Use a correct operator in a test expression

On Sat, Jul 15, 2017 at 6:56 AM, Ben Pfaff wrote: > On Sat, Jul 15, 2017 at 02:39:45AM +0900, YAMAMOTO Takashi wrote: > > == is a GNU extension. > > > > Signed-off-by: YAMAMOTO Takashi > > I wish this didn't exist in the GNU version. It's a useless extension. >

Re: [ovs-dev] [PATCH 6/6] packet-type-aware.at: Avoid GNU extension

On Sat, Jul 15, 2017 at 6:56 AM, Ben Pfaff wrote: > On Sat, Jul 15, 2017 at 02:39:46AM +0900, YAMAMOTO Takashi wrote: > > \t is GNU sed extension. > > > > Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff > applied to master. thank you.

Re: [ovs-dev] [PATCH 3/6] pmd.at: Avoid using GNU sed extension

On Sat, Jul 15, 2017 at 6:55 AM, Ben Pfaff wrote: > On Sat, Jul 15, 2017 at 02:39:43AM +0900, YAMAMOTO Takashi wrote: > > BRE alternative (\|) is an GNU sed extension. [1] > > It isn't available in NetBSD sed. > > > > [1]

Re: [ovs-dev] [PATCH 2/6] NetBSD: Stop recommending pkg_alternatives

On Sat, Jul 15, 2017 at 6:55 AM, Ben Pfaff wrote: > On Sat, Jul 15, 2017 at 02:39:42AM +0900, YAMAMOTO Takashi wrote: > > Because: > > - It's no longer necessary > > - It can cause problems for some utilities (e.g. ovs-pcap) > > Cf.

Re: [ovs-dev] [PATCH 1/6] interface-reconfigure.at: Use $PYTHON explicitly

On Sat, Jul 15, 2017 at 6:55 AM, Ben Pfaff wrote: > On Sat, Jul 15, 2017 at 02:39:41AM +0900, YAMAMOTO Takashi wrote: > > Workaround pkg_alternative issue for NetBSD: > > http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=51152 > > > > An alternative would be generating

Re: [ovs-dev] [PATCH 4/6] testsuite: Drain the list of jobs in the shell

Hi, 2017/07/15 6:55 "Ben Pfaff" : On Sat, Jul 15, 2017 at 02:39:44AM +0900, YAMAMOTO Takashi wrote: > SUS says: > When jobs reports the termination status of a job, > the shell removes its process ID from the list of those > "known in the current shell execution

Re: [ovs-dev] [PATCH] socket-util: Support sendmmsg() on Linux and non-Linux platforms.

On Thu, Jul 13, 2017 at 1:23 AM, Ben Pfaff wrote: > This will have its first user in an upcoming commit. > > Signed-off-by: Ben Pfaff > --- > configure.ac| 3 ++- > include/sparse/sys/socket.h | 5 + > lib/socket-util.c | 38

Re: [ovs-dev] [PATCH] ovn.at: Fix "ovn -- 1 LR with distributed router gateway port" test

On Tue, May 2, 2017 at 5:21 AM, Ben Pfaff wrote: > On Fri, Apr 21, 2017 at 10:32:57AM +0900, YAMAMOTO Takashi wrote: > > NetBSD implementation of wc command outputs extra whitespaces > > like the following. Tweak the test to success on such environments. > > > > % echo hoge|wc

Re: [ovs-dev] [PATCH] ovn.at: Fix "ovn -- 1 LR with distributed router gateway port" test

On Mon, Apr 24, 2017 at 9:48 AM, Mickey Spiegel wrote: > > On Thu, Apr 20, 2017 at 6:32 PM, YAMAMOTO Takashi > wrote: > >> NetBSD implementation of wc command outputs extra whitespaces >> like the following. Tweak the test to success on such

Re: [ovs-dev] [PATCH] Update netbsd install doc

On Wed, Dec 21, 2016 at 3:25 AM, Hui Kang wrote: > - test ovs on netbsd 7.0.2 > - use gmake to compile and install > > Signed-off-by: Hui Kang > --- > Documentation/intro/install/netbsd.rst | 5 +++-- > 1 file changed, 3 insertions(+), 2

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

On Wed, Dec 14, 2016 at 9:02 AM, Jarno Rajahalme <ja...@ovn.org> wrote: > > On Dec 13, 2016, at 3:32 PM, Takashi YAMAMOTO <yamam...@ovn.org> wrote: > > > > On Tue, Dec 13, 2016 at 6:49 PM, Thomas Morin <thomas.mo...@orange.com> > wrote: > >

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

On Tue, Dec 13, 2016 at 6:49 PM, Thomas Morin wrote: > Hi Jarno, > > 2016-12-10, Jarno Rajahalme: > > On Dec 9, 2016, at 7:04 AM, Thomas Morin wrote: > > > 2016-12-09, Thomas Morin: > > In the same setup as the one on which the bug was observed,

Re: [ovs-dev] [PATCH] mpls: Fix MPLS restoration after patch port and group bucket.

and 'base flow' > and issuing MPLS actions if they can transform the packet from an MPLS > packet to a non-MPLS packet. For an IP packet the change in ttl can > then be correctly committed before the last two output actions. > > Two test cases are added to prevent future regressions. &

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

hi, On Fri, Dec 2, 2016 at 10:57 AM, Jarno Rajahalme wrote: > > > On Nov 30, 2016, at 8:50 PM, Ben Pfaff wrote: > > > > On Wed, Nov 30, 2016 at 06:58:57PM -0800, Jarno Rajahalme wrote: > >> > >>> On Nov 30, 2016, at 8:41 AM, Ben Pfaff wrote: > >>> >

[ovs-dev] "nb7" branch

hi, i mistakenly pushed a branch "nb7" and then removed it. sorry if it caused glitches to something. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/3] Fix parent_pid on NetBSD

On Wed, Oct 19, 2016 at 1:46 AM, Ben Pfaff wrote: > On Tue, Oct 18, 2016 at 09:25:24PM +0900, YAMAMOTO Takashi wrote: > > Fix recently introduced parent_pid macro on NetBSD 7.0. > > On NetBSD, procfs status file looks like the following. > > > > n7% cat /proc/$$/status > >

Re: [ovs-dev] [PATCH 2/3] ovn.at: Avoid using "printf -v"

On Wed, Oct 19, 2016 at 1:47 AM, Ben Pfaff wrote: > On Tue, Oct 18, 2016 at 09:25:25PM +0900, YAMAMOTO Takashi wrote: > > It seems like a non-portable bash extension. > > > > Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff > thank you.

Re: [ovs-dev] [PATCH 3/3] ovn-controller.at: Stop hardcoding a list of iface types

On Wed, Oct 19, 2016 at 1:48 AM, Ben Pfaff wrote: > On Tue, Oct 18, 2016 at 09:25:26PM +0900, YAMAMOTO Takashi wrote: > > The list of supported iface types hardcoded in the test > > is wrong on NetBSD. (or any userland-only ports I guess) > > Instead of adding another case for

Re: [ovs-dev] [PATCH] Makefile.am: Add DocumentationStyle.rst to distribution.

On Wed, Oct 19, 2016 at 9:13 AM, Daniele Di Proietto wrote: > 2016-10-18 16:59 GMT-07:00 Jarno Rajahalme : > > > Compile fails otherwise. > > > > Signed-off-by: Jarno Rajahalme > > > > Acked-by: Daniele Di Proietto >

Re: [ovs-dev] [PATCH] ovn.at: Use = instead of == for test

applied to master, thank you. On Wed, Jul 6, 2016 at 12:36 AM, Ben Pfaff wrote: > On Tue, Jul 05, 2016 at 06:35:04PM +0900, YAMAMOTO Takashi wrote: > > == is a GNU extension which might not be available. > > > > Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben

Re: [ovs-dev] [PATCH] ovs-numa: Fix a compilation error

On Thu, Jun 9, 2016 at 3:31 AM, Ben Pfaff wrote: > On Wed, Jun 08, 2016 at 03:19:46PM +0900, YAMAMOTO Takashi wrote: > > Fix the following error on NetBSD 7.0. > > > > ../lib/ovs-numa.c: In function 'ovs_numa_set_cpu_mask': > > ../lib/ovs-numa.c:555:9: error: array

Re: [ovs-dev] [PATCH] netdev-native-tnl: Fix a build error on NetBSD 7.0

On Sat, May 21, 2016 at 3:42 AM, Jeff Feng wrote: > > > > diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c > > index 2e181f2..123f3b2 100644 > > --- a/lib/netdev-native-tnl.c > > +++ b/lib/netdev-native-tnl.c > > @@ -20,6 +20,7 @@ > > #include > > #include >

Re: [ovs-dev] [PATCH 3/4] ovn-controller-vtep.at: Pre-sort output before feeding to "sort -d"

On Fri, May 20, 2016 at 2:30 PM, Takashi YAMAMOTO <yamam...@ovn.org> wrote: > > > On Fri, May 20, 2016 at 12:45 PM, Ben Pfaff <b...@ovn.org> wrote: > >> On Wed, May 18, 2016 at 03:30:30AM +0900, YAMAMOTO Takashi wrote: >> > NetBSD's "sort -d"

Re: [ovs-dev] [PATCH 4/4] utilities: Tweak python shebangs to use env

On Fri, May 20, 2016 at 2:42 PM, Takashi YAMAMOTO <yamam...@ovn.org> wrote: > > > On Fri, May 20, 2016 at 12:47 PM, Ben Pfaff <b...@ovn.org> wrote: > >> On Wed, May 18, 2016 at 03:30:31AM +0900, YAMAMOTO Takashi wrote: >> > "python" comma

Re: [ovs-dev] [PATCH 2/4] ovsdb-server.at: Fix races

On Fri, May 20, 2016 at 12:43 PM, Ben Pfaff wrote: > On Wed, May 18, 2016 at 03:30:29AM +0900, YAMAMOTO Takashi wrote: > > As ovsdb-server creates pid file before unixctl socket, waiting > > for pid file creation is not enough. Fix the race by retrying > > with "version" command

Re: [ovs-dev] [PATCH 1/4] dpif: Remove a warning

On Fri, May 20, 2016 at 12:38 PM, Ben Pfaff wrote: > On Wed, May 18, 2016 at 03:30:28AM +0900, YAMAMOTO Takashi wrote: > > Remove "attempted to unregister a datapath provider that is not > registered" > > warning. It's normal for --enabled-dummy=system with userland-only > build.

Re: [ovs-dev] [PATCH 4/4] utilities: Tweak python shebangs to use env

On Fri, May 20, 2016 at 12:47 PM, Ben Pfaff wrote: > On Wed, May 18, 2016 at 03:30:31AM +0900, YAMAMOTO Takashi wrote: > > "python" command provided by pkg_alternatives is a shell script. > > At least on NetBSD-7, execve can't execute scripts whose interpreter > > is another shell

Re: [ovs-dev] [PATCH 3/4] ovn-controller-vtep.at: Pre-sort output before feeding to "sort -d"

On Fri, May 20, 2016 at 12:45 PM, Ben Pfaff wrote: > On Wed, May 18, 2016 at 03:30:30AM +0900, YAMAMOTO Takashi wrote: > > NetBSD's "sort -d" preserves the order of lines which doesn't have > > alphanumeric and blanks. eg. empty lines and []. > > It means it sometimes preserve

Re: [ovs-dev] [PATCH] util.h: Restore stdarg.h which is necessary for va_list

On Sat, Apr 23, 2016 at 12:28 PM, Ben Pfaff wrote: > On Sat, Apr 23, 2016 at 11:14:40AM +0900, YAMAMOTO Takashi wrote: > > Fixes a regression in commit b44ff8d826535025f4f8d12808c4ef36a7a8 . > > ("Misc cleanup with "util.h" header files") > > > > Signed-off-by: YAMAMOTO Takashi

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

this should be done differently? If you do, then I will not accept it. > But if you do not feel strongly about it, then I'll start properly > reviewing it. > > Thanks, > > Ben. > > On Mon, Apr 18, 2016 at 07:05:52PM +0800, Xiao Liang wrote: > > On Mon, Apr 18, 2016 at 5

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

sier to find and convert ports > back and forth. of_name and kernel_name could be configured (if > supported) independently of each other. > > On Mon, Apr 18, 2016 at 11:43 AM, Takashi YAMAMOTO <yamam...@ovn.org> > wrote: > > let me explain what netdev-bsd does first. > > on so

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

; Hi Ben, Yamamoto-san, > > Kindly remind you of this thread. Would like to hear your preference > on the way to implement this feature. > > On Mon, Apr 11, 2016 at 11:18 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Mon, Apr 11, 2016 at 04:30:04PM +0800, Xiao Liang wrot

Re: [ovs-dev] [PATCH v2] Add configurable OpenFlow port name.

hi, have you considered the opposite way? ie. have an ability to specify the device name. netdev-bsd already has a distinction between "kernel name" and "ovs name". On Mon, Apr 11, 2016 at 4:23 PM, Xiao Liang wrote: > Add new column "ofname" in Interface table to configure

Re: [ovs-dev] [PATCH 4/4] ofproto/trace: Fix "unchanged" output for Final flow

On Thu, Mar 24, 2016 at 1:12 AM, Takashi Yamamoto <yamam...@midokura.com> wrote: > On Thu, Mar 24, 2016 at 12:50 AM, Ben Pfaff <b...@ovn.org> wrote: >> On Wed, Mar 16, 2016 at 09:39:34PM +0900, YAMAMOTO Takashi wrote: >>> Clear actset_output so that it can be com

Re: [ovs-dev] [PATCH 3/4] vlog.at: Avoid using GNU sed extension

On Thu, Mar 24, 2016 at 12:46 AM, Ben Pfaff wrote: > On Wed, Mar 16, 2016 at 09:39:33PM +0900, YAMAMOTO Takashi wrote: >> BRE alternative (\|) is an GNU sed extension. [1] >> It isn't available in NetBSD sed. >> >> [1]

Re: [ovs-dev] [PATCH 4/4] ofproto/trace: Fix "unchanged" output for Final flow

On Thu, Mar 24, 2016 at 12:50 AM, Ben Pfaff wrote: > On Wed, Mar 16, 2016 at 09:39:34PM +0900, YAMAMOTO Takashi wrote: >> Clear actset_output so that it can be compared via flow_equal. >> Note: trace->key has actset_output == 0. >> >> Found by OVS flow tests under development for

Re: [ovs-dev] [PATCH 2/4] ovs_strerror, ovs_format_message: Always use "Success" for errno 0

On Thu, Mar 24, 2016 at 12:44 AM, Ben Pfaff wrote: > On Wed, Mar 16, 2016 at 09:39:32PM +0900, YAMAMOTO Takashi wrote: >> So that testsuite can compare log messages including the string. >> >> Signed-off-by: YAMAMOTO Takashi > > Thanks. I didn't know about

Re: [ovs-dev] [PATCH 1/4] INSTALL.NetBSD.md: Update for six

2016-03-24 0:42 GMT+09:00 Ben Pfaff : > On Wed, Mar 16, 2016 at 09:39:31PM +0900, YAMAMOTO Takashi wrote: >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff thank you. pushed to master. ___

Re: [ovs-dev] [PATCH 3/3] ovn.at: Fix races

hi, On Thu, Dec 3, 2015 at 3:26 AM, Flavio Fernandes wrote: > On Thu, Nov 26, 2015 at 4:41 AM, YAMAMOTO Takashi > wrote: > >> These tests are racy as nothing prevents packet re-ordering. >> Fix them by sorting outputs before comparing. >> >>

Re: [ovs-dev] [PATCH] fix compile error on FreeBSD

On Wed, Dec 2, 2015 at 3:21 PM, Kevin Lo wrote: > Hi, > > Missing a include file caused compile error: > http://dpaste.com/22E4MHK why to add it to lib/util.h, rather than ovs-router.c? > > FreeBSD (and NetBSD?) needs to include netinet/in.h to define > struct in6_addr. > >

Re: [ovs-dev] [PATCH 1/3] ovn.at: Use {} to make this less ambiguous

On Sat, Nov 28, 2015 at 3:17 AM, Ben Pfaff wrote: > On Thu, Nov 26, 2015 at 06:41:30PM +0900, YAMAMOTO Takashi wrote: >> While (surprisingly to me) bash interprets $10 as ${1}0, >> many other shells, including NetBSD's /bin/sh, interpret it as ${10}. >> >> Signed-off-by: YAMAMOTO

Re: [ovs-dev] [PATCH] fix compile error on FreeBSD

On Wed, Dec 2, 2015 at 4:12 PM, Kevin Lo <ke...@freebsd.org> wrote: > On Wed, Dec 02, 2015 at 03:47:57PM +0900, Takashi Yamamoto wrote: >> >> On Wed, Dec 2, 2015 at 3:21 PM, Kevin Lo <ke...@freebsd.org> wrote: >> > Hi, >> > >> > Missing a inc

Re: [ovs-dev] [PATCH 2/3] ovn.at: Avoid using GNU sed extension

hi, On Sat, Nov 28, 2015 at 3:20 AM, Ben Pfaff wrote: > On Thu, Nov 26, 2015 at 06:41:31PM +0900, YAMAMOTO Takashi wrote: >> Signed-off-by: YAMAMOTO Takashi >> --- >> tests/ovn.at | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff

Re: [ovs-dev] [PATCH 17/21] ofproto-dpif.at: Workaround a race

i forgot it too. i'll investigate if it can be used. On Tue, Nov 10, 2015 at 1:55 PM, Ben Pfaff wrote: > On Mon, Nov 09, 2015 at 08:53:14PM -0800, Joe Stringer wrote: >> On 18 October 2015 at 21:29, YAMAMOTO Takashi wrote: >> > Signed-off-by: YAMAMOTO

Re: [ovs-dev] [PATCH 10/21] ofproto-macros.at: Add another strerror(0) value

hi, On Tue, Nov 10, 2015 at 1:19 PM, Ben Pfaff wrote: > On Mon, Oct 19, 2015 at 01:29:01PM +0900, YAMAMOTO Takashi wrote: >> On NetBSD, strerror(0) is "Undefined error: 0". >> >> Signed-off-by: YAMAMOTO Takashi >> --- >> tests/ofproto-macros.at | 3 ++- >>

Re: [ovs-dev] [PATCH 06/21] daemon_switch_user: Improve portablility

hi, On Mon, Oct 19, 2015 at 3:14 PM, Andy Zhou wrote: > On Sun, Oct 18, 2015 at 9:28 PM, YAMAMOTO Takashi > wrote: >> NetBSD doesn't have [gs]etres[ug]id. >> >> Signed-off-by: YAMAMOTO Takashi >> --- >> lib/daemon-unix.c | 40

Re: [ovs-dev] [PATCH 06/21] daemon_switch_user: Improve portablility

gt; getresuid() call. Make sense? well, this fallback code is currently for FreeBSD and NetBSD, for which the semantics are consistent, right? > > > > On Sun, Oct 18, 2015 at 11:48 PM, Takashi Yamamoto > <yamam...@midokura.com> wrote: >> hi, >> >> On Mon, Oc

Re: [ovs-dev] [PATCH 2/4] ovs-ofctl: Fix OpenFlow versions with '--bundle'

On Fri, Oct 16, 2015 at 6:28 AM, Jarno Rajahalme wrote: > While the presence of the '--bundle' option implicitly added the > OpenFlow 1.4 to the allowed protocols, it failed to remove OpenFlow > 1.0 from the allowed protocols. This is changed so that '--bundle' > option

Re: [ovs-dev] shell substitution "${withval/:/}"

On Wed, Oct 14, 2015 at 1:35 PM, IWAMOTO Toshihiro <iwam...@valinux.co.jp> wrote: > At Wed, 14 Oct 2015 13:06:01 +0900, > Takashi Yamamoto wrote: >> >> hi, >> >> m4/openvswitch.m4 has the following substitution. >> NetBSD's /bin/sh complains on that. >

Re: [ovs-dev] [PATCH v4 02/12] ovs-ofctl: Add bundle support and unit testing.

hi, On Wed, Jun 10, 2015 at 9:24 AM, Jarno Rajahalme wrote: > All existing ovs-ofctl flow mod commands now take an optional > '--bundle' argument, which executes the flow mods as a single > transaction. OpenFlow 1.4+ is implicitly assumed when '--bundle' is > specified. >

Re: [ovs-dev] [RFC PATCH] userspace: Define and use struct eth_addr.

hi, On Thu, Sep 17, 2015 at 12:44 AM, Ben Pfaff <b...@nicira.com> wrote: > On Wed, Sep 16, 2015 at 10:55:10AM +0900, Takashi Yamamoto wrote: >> hi, >> >> > --- a/build-aux/extract-odp-netlink-h >> > +++ b/build-aux/extract-odp-netlink-h >

[ovs-dev] shell substitution "${withval/:/}"

hi, m4/openvswitch.m4 has the following substitution. NetBSD's /bin/sh complains on that. PTHREAD_WIN32_DIR_DLL=/${withval/:/}/dll/x64 i've looked at bash's man page but i couldn't find this substitution. can you explain what does it mean, and even better, replace it with something more

Re: [ovs-dev] [RFC PATCH] userspace: Define and use struct eth_addr.

hi, > --- a/build-aux/extract-odp-netlink-h > +++ b/build-aux/extract-odp-netlink-h > @@ -20,11 +20,14 @@ $i\ > #include "OvsDpInterfaceExt.h"\ > #endif\ > > +# Use OVS's own struct eth_addr instead of a 6-byte char array. > +s,,"openvswitch/types.h", > +s,#.*,, > +s/__u8[

Re: [ovs-dev] [PATCH] Update my email address

Justin, Miguel, thank you! applied to master, branch-2.3, 2.2, and 2.1. On Tue, Jun 2, 2015 at 5:12 PM, Miguel Ángel Ajo majop...@redhat.com wrote: Congratulations :) Midokura did something very smart ;) Miguel Ángel Ajo On Tuesday, 2 de June de 2015 at 8:03, Justin Pettit wrote:

Re: [ovs-dev] Can we trivially enable group chaining?

hi, On Wed, Jun 3, 2015 at 3:36 PM, Ben Pfaff b...@nicira.com wrote: We have the following comment in ofproto-dpif-xlate.c: /* Prevent nested translation of OpenFlow groups. * * OpenFlow allows this restriction. We enforce this restriction only * because,