Re: [ovs-dev] [PATCH] AUTHORS: Update email address for Thadeu Lima de Souza Cascardo.

On Fri, Dec 08, 2017 at 07:51:08AM -0800, Ben Pfaff wrote: > CC: Thadeu Lima de Souza Cascardo <casca...@cascardo.eti.br> > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Thadeu Lima de Souza Cascardo <casca...@cascardo.eti.br> > --- > AUTHORS.rst | 2 +- >

Re: [ovs-dev] two possible bugs about ipv6 multicast

On Wed, Nov 15, 2017 at 11:03:10AM -0800, Ben Pfaff wrote: > On Mon, Sep 04, 2017 at 11:40:01PM +0800, Huanle Han wrote: > > I'm just learning ipv6. When I go through ovs code about ipv6 normal > > forwarding, I find 2 possible "bugs". Could you explain some for me? Thanks. > > > > 1. In fucntion

Re: [ovs-dev] [PATCH 1/1] netdev-vport: reject concomitant incompatible tunnels

On Mon, Jul 10, 2017 at 06:47:21AM -0300, Thadeu Lima de Souza Cascardo wrote: > On Mon, Jul 10, 2017 at 10:19:49AM +0200, Eelco Chaudron wrote: > > On 07/07/2017 08:32 PM, Ben Pfaff wrote: > > > On Fri, Jun 09, 2017 at 11:09:08AM +0200, Eelco Chaudron wrote: > > >

Re: [ovs-dev] [PATCH 1/1] netdev-vport: reject concomitant incompatible tunnels

On Mon, Jul 10, 2017 at 10:19:49AM +0200, Eelco Chaudron wrote: > On 07/07/2017 08:32 PM, Ben Pfaff wrote: > > On Fri, Jun 09, 2017 at 11:09:08AM +0200, Eelco Chaudron wrote: > > > This is a follow up patch for an earlier patch send by Cascardo, > > > however I think this patch might not be

[ovs-dev] [PATCH 2.5 2/2] tests: add test for the output of ovs/route/lookup

Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- tests/ovs-router.at | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/tests/ovs-router.at b/tests/ovs-rou

Re: [ovs-dev] [PATCH] netdev: Fix sockaddr cast warning.

i++; > } > -- > 1.8.3.1 > > _______ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Daniele sent the same patch. Acked-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

On November 15, 2016 11:57:21 AM GMT-02:00, "Yang, Yi Y" wrote: >Hi, Jiri > >I'm very glad to see you're continuing this work :-), I asked Simon >about this twice, but nobody replies. I also remember Cascardo has a >patch set to collaborate with this patch set, I asked

[ovs-dev] [PATCH 2/3] ovs-router: report error when failing to insert route

Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/ovs-router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ovs-router.c b/lib/ovs-router.c index e27514a..e29d462 100644 --- a/lib/ovs-router.c +++ b/lib/ovs-router.c @@ -316,7

Re: [ovs-dev] [PATCH] ovs-router: Fix selection of source IP address when a gateway ip is introduced

> -----Original Message- > > From: Thadeu Lima de Souza Cascardo [mailto:casca...@redhat.com] > > Sent: Thursday, October 27, 2016 5:21 PM > > To: Waizel, Ariel <ariel.wai...@hpe.com> > > Cc: dev@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH]

Re: [ovs-dev] OVS 2.6.1 release?

On Mon, Oct 31, 2016 at 09:57:39AM -0700, Justin Pettit wrote: > > > On Oct 25, 2016, at 10:49 AM, Thadeu Lima de Souza Cascardo > > <casca...@redhat.com> wrote: > > > > So, it turns out my fix does not introduce any new problems. I have just > > posted

Re: [ovs-dev] br-int bridge dpid changes when openvswitch is restarted

On Thu, Oct 27, 2016 at 11:51:42PM +, Bertrand Low wrote: > Hi there, > > Has anyone noticed a "connection flapping" behaviour for the br-int bridge > (used between openstack and opendaylight's netvirt module) when openvswitch > is restarted? I've provided some details below. > > Scenario:

Re: [ovs-dev] [PATCH] ovs-router: Fix selection of source IP address when a gateway ip is introduced

On Thu, Oct 27, 2016 at 02:08:13PM +, Waizel, Ariel wrote: > > > When adding a VXLAN tunnel that connects to a VTEP residing in a > > different IP network, the tunnel source ip needs to be selected by > > best fit (longest matching netmask), based on the destination VTEP > > ip, and the

Re: [ovs-dev] [PATCH] ovs-router: Fix selection of source IP address when a gateway ip is introduced

suite.at > index 2123bee..a2c707d 100644 > --- a/tests/testsuite.at > +++ b/tests/testsuite.at > @@ -75,3 +75,4 @@ m4_include([tests/ovn-nbctl.at]) > m4_include([tests/ovn-sbctl.at]) > m4_include([tests/ovn-controller.at]) > m4_include([tests/ovn-controller-vtep.at]) > +

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Wed, Oct 26, 2016 at 02:05:22PM -0700, Pravin Shelar wrote: > On Wed, Oct 26, 2016 at 2:55 AM, Thadeu Lima de Souza Cascardo > <casca...@redhat.com> wrote: > > On Tue, Oct 25, 2016 at 08:21:55PM -0700, Pravin Shelar wrote: > >> > The fallback option should alread

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Tue, Oct 25, 2016 at 08:21:55PM -0700, Pravin Shelar wrote: > > The fallback option should already work, then. We can make sure during > > testing > > that is the case, so there would be no need to verify ovs_vxlan is present > > in > > case 3. Would that be OK for you? > > > I am not sure

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

On Thu, Oct 20, 2016 at 10:30:41AM -0700, Pravin Shelar wrote: > On Tue, Sep 20, 2016 at 7:01 AM, Thadeu Lima de Souza Cascardo > <casca...@redhat.com> wrote: > > In order to use rtnetlink to create new tunnel vports, the backported > > tunnels require some co

Re: [ovs-dev] OVS 2.6.1 release?

On Wed, Oct 19, 2016 at 06:08:12PM +0200, Justin Pettit wrote: > > > On Oct 19, 2016, at 5:55 PM, Thadeu Lima de Souza Cascardo > > <casca...@redhat.com> wrote: > > > >> On Tue, Oct 18, 2016 at 05:35:27PM +0200, Justin Pettit wrote: > >> > >&g

[ovs-dev] [PATCH] ifnotifier: do not wake up when there is no db connection

. This is easily reproduced by starting ovs-vswitchd without starting ovsdb-server, and then creating a new system interface, like using 'ip link add type veth'. ovs-vswitchd will then consume 100% CPU. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- This should be backported

[ovs-dev] [PATCH] netdev-dpdk: Use instant sending instead of queueing of packets.

1 Mpps Min. Latency: 11.9780 usec Avg. Latency: 18.0692 usec Max. Latency: 29.5200 Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> Cc: Ilya Maximets <i.maxim...@samsung.com> Cc: Daniele Di Proietto <diproiet...@vmware.com>

Re: [ovs-dev] OVS 2.6.1 release?

On Tue, Oct 18, 2016 at 05:35:27PM +0200, Justin Pettit wrote: > > > On Oct 18, 2016, at 5:31 PM, Russell Bryant wrote: > > > >> On Tue, Oct 18, 2016 at 4:54 AM, Justin Pettit wrote: > >> > On Oct 17, 2016, at 5:54 PM, Ben Pfaff wrote: > >> > >

[ovs-dev] [PATCH] ovn: fix build on FreeBSD

The missing include was needed for struct in6_addr. Otherwise, this build failure would occur. In file included from ovn/lib/actions.c:23: ovn/lib/ovn-dhcp.h:163:21: error: field has incomplete type 'struct in6_addr' Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> ---

[ovs-dev] [PATCH] tnl-ports: fix missing netdev_close

ed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- So, Aaron found out that applying the following commits would fix a bug in branch 2.5, but we considered that would be too much. So, after some investigation, we realized that the change below fixes the issue, as described above. So, w

[ovs-dev] [PATCH v2] vagrant: cleanup before building

Clean the source directory before building, otherwise, build might fail if it has been configured already. Only do it if there is a Makefile present, as suggested by Ben Pfaff. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> Cc: Ben Pfaff <b...@ovn.org> --- Vag

Re: [ovs-dev] [PATCH] NEWS: Add release date for 2.6.0.

- First supported release of OVN. See ovn-architecture(7) for more > details. > -- > 2.1.3 > Acked-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] vagrant: cleanup before building

On Tue, Oct 04, 2016 at 12:00:33PM -0700, Ben Pfaff wrote: > On Mon, Sep 19, 2016 at 04:31:03PM -0300, Thadeu Lima de Souza Cascardo wrote: > > Clean the source directory before building, otherwise, build might fail if > > it > > has been configured already. > > > &

Re: [ovs-dev] [PATCH] ovs-router: Fix selection of source IP address when a gateway ip is introduced

; > +if (err && ipv6_addr_is_set(gw)) { > +err = get_src_addr(gw, output_bridge, >src_addr); > +} > if (err) { > free(p); > return err; Hi, Ariel. Thanks for that. Can you resend wrapping the log text to 72 columns and add a test

Re: [ovs-dev] [PATCH] tests/bundle: test bundle action with ports up and down

On Mon, Oct 03, 2016 at 10:10:27AM -0700, Ben Pfaff wrote: > On Fri, Sep 30, 2016 at 06:53:37PM -0300, Thadeu Lima de Souza Cascardo wrote: > > Also, add the keyword bundle_action to all the tests in bundle.at, > > distinguishing it from OF bundles. > > > > It ca

[ovs-dev] [PATCH] tests/bundle: test bundle action with ports up and down

for the bundle action, I thought it would be nice to do it as a way of documenting this behavior. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- tests/bundle.at | 66 + 1 file changed, 66 insertions(+) diff

[ovs-dev] [PATCH] Change some old references to nicira-ext.h.

Some of these references are not valid anymore, as things were moved to either meta-flow.h or ofp-actions.c. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/bundle.h | 2 +- lib/learn.h | 2 +- lib/meta-flow.c | 2 +- tests/learn.at

[ovs-dev] [PATCH] vagrant: add CentOS 7.2 support

Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- Vagrantfile | 34 ++ 1 file changed, 34 insertions(+) diff --git a/Vagrantfile b/Vagrantfile index 91f943d..f83d3fc 100644 --- a/Vagrantfile +++ b/Vagrantfile @@ -30,6 +30,15 @@ aptit

[ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

Garver <e...@erig.me> Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- datapath/linux/Modules.mk | 1 + datapath/linux/compat/geneve.c | 15 +-- datapath/linux/compat/include/linux/if_tunnel.h | 71 datapath/

[ovs-dev] [PATCH 2/2] vagrant: use RECHECK=yes for system checks

Use RECHECK=yes for both kernel and userspace datapath tests. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- Vagrantfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Vagrantfile b/Vagrantfile index 11bd048..91f943d 100644 --- a/Vagrantfile

[ovs-dev] [PATCH 1/2] vagrant: cleanup before building

Clean the source directory before building, otherwise, build might fail if it has been configured already. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- Vagrantfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Vagrantfile b/Vagrantfile index 72f224c..1

[ovs-dev] [PATCH] datapath: backport: openvswitch: use alias for genetlink family names

Upstream commit: openvswitch: use alias for genetlink family names When userspace tries to create datapaths and the module is not loaded, it will simply fail. With this patch, the module will be automatically loaded. Signed-off-by: Thadeu Lima de Souza Cascardo <ca

Re: [ovs-dev] [PATCH v2 2/2] openvswitch: use percpu flow stats

On Thu, Sep 15, 2016 at 04:09:26PM -0700, Eric Dumazet wrote: > On Thu, 2016-09-15 at 19:11 -0300, Thadeu Lima de Souza Cascardo wrote: > > Instead of using flow stats per NUMA node, use it per CPU. When using > > megaflows, the stats lock can be a bottleneck in scalability. > &

[ovs-dev] [PATCH v2 1/2] openvswitch: fix flow stats accounting when node 0 is not possible

with only node 1 possible. Also compile-tested with CONFIG_NUMA off. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- net/openvswitch/flow.c | 6 -- net/openvswitch/flow_table.c | 5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/net/openv

[ovs-dev] [PATCH v2 2/2] openvswitch: use percpu flow stats

. This has been tested on a system with possible CPUs 0-7,16-23. After module removal, there were no corruption on the slab cache. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> Cc: pravin shelar <pshe...@ovn.org> --- v2: * use smp_processor_id as ovs_flow_stats_upda

Re: [ovs-dev] [PATCH] socket-util-unix: Avoid buffer read overrun in get_unix_name_len().

On Wed, Sep 14, 2016 at 08:39:03PM -0700, Ben Pfaff wrote: > If the socket length does not include any of the bytes of the path, then > the code should not read even the first byte of the path. > > Found by valgrind. > > CC: Thadeu Lima de Souza Cascardo <casca...@redhat.co

[ovs-dev] [PATCH v2] vagrant: Add Debian Jessie support

Now, vagrant up will test both Fedora 23 and Debian Jessie (8.0), which uses Linux 3.16. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- Vagrantfile | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff

Re: [ovs-dev] [PATCH] vagrant: Add Debian Jessie support

On Fri, Sep 09, 2016 at 06:44:21PM -0700, Joe Stringer wrote: > On 9 September 2016 at 14:09, Thadeu Lima de Souza Cascardo > <casca...@redhat.com> wrote: > > Now, vagrant up will test both Fedora 23 and Debian Jessie (8.0), which uses > > Linux 3.16. > > > >

[ovs-dev] [PATCH] vagrant: Add Debian Jessie support

Now, vagrant up will test both Fedora 23 and Debian Jessie (8.0), which uses Linux 3.16. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- Vagrantfile | 44 ++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff

Re: [ovs-dev] [PATCH] stream-unix: only use path-based socket names

On Fri, Sep 09, 2016 at 01:47:01PM -0700, Joe Stringer wrote: > On 19 July 2016 at 20:08, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Jul 19, 2016 at 05:05:51PM -0300, Thadeu Lima de Souza Cascardo > > wrote: > >> FreeBSD returns a socklen of sockaddr_storage when do

[ovs-dev] [PATCH] openvswitch: use alias for genetlink family names

When userspace tries to create datapaths and the module is not loaded, it will simply fail. With this patch, the module will be automatically loaded. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- net/openvswitch/datapath.c | 4 1 file changed, 4 insertions(+)

[ovs-dev] [PATCH 2/2] openvswitch: use percpu flow stats

. This has been tested on a system with possible CPUs 0-7,16-23. After module removal, there were no corruption on the slab cache. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- net/openvswitch/flow.c | 43 +++ net/openvswitch/

[ovs-dev] [PATCH 1/2] openvswitch: fix flow stats accounting when node 0 is not possible

with only node 1 possible. Also compile-tested with CONFIG_NUMA off. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- I am providing this intermediate patch, that will be thrown out by the next one, in case there is any need to backport this fix. --- net/openvswitch/

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

On Thu, Sep 01, 2016 at 05:17:44PM +, Daniele Di Proietto wrote: > Let me try to sum up the problem further > > 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU > for new internal ports."): > > a) When an internal interface is added, or its MTU has changed we

Re: [ovs-dev] Cant `make install` ovs

On Tue, Aug 30, 2016 at 06:16:43PM +0530, Hussain Hakimuddin Nagri wrote: > Hi, > If you could have a look at this > problem > it would be very helpful. [...] > I don't understand what am I missing. > DPDK is *dpdk-16.07*

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Replace ukeys for deleted flows.

On Tue, Aug 23, 2016 at 07:18:50PM -0700, Joe Stringer wrote: > If a revalidator dumps/revalidates a flow during the 'dump' phase, > resulting in the deletion of the flow, then ukey->flow_exists is set to > false, and the ukey is kept around until the 'sweep' phase. The ukey is > kept around to

[ovs-dev] [RFC PATCH] openvswitch: use percpu flow stats

Instead of using flow stats per NUMA node, use it per CPU. When using megaflows, the stats lock can be a bottleneck in scalability. On a E5-2690 12-core system, usual throughput went from ~4Mpps to ~15Mpps when forwarding between two 40GbE ports with a single flow configured on the datapath. ---

Re: [ovs-dev] [PATCH] Revert "netdev: do not allow devices to be opened with conflicting types"

On Tue, Aug 16, 2016 at 10:27:32AM -0300, Thadeu Lima de Souza Cascardo wrote: > This reverts commit d2fa6c676a13e86acc7f17261b2d87484f625d45. > > When doing a restart, the routing table will open ports as system, which > prevents internal ports to be opened with the right type.

[ovs-dev] [PATCH] Revert "netdev: do not allow devices to be opened with conflicting types"

on the routing table layer. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/netdev.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/netdev.c b/lib/netdev.c index 5cf8bbb..10f2d0f 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -339,8

Re: [ovs-dev] [PATCH V7 1/7] ofproto: Consider datapath_type when looking for internal ports.

On Wed, Aug 10, 2016 at 10:09:07AM +, Kavanagh, Mark B wrote: > > > >On 09/08/2016 09:08, "Thadeu Lima de Souza Cascardo" <casca...@redhat.com> > >wrote: > > > >>On Tue, Aug 09, 2016 at 05:01:14PM +0100, Mark Kavanagh wrote: > &

Re: [ovs-dev] [CudaMailTagged] [PATCH 2/2] Tunnel: Fix the issue of tunnel port creation

On Thu, Aug 11, 2016 at 03:32:20AM +0800, Binbin Xu wrote: > If a kernel space vxlan port was added first, and then we try to > add a user space vxlan port. But unfortunate, the user space > vxlan port can't be created. > > This commit separates kernel space with user space tunnel port, > for

Re: [ovs-dev] [PATCH V7 1/7] ofproto: Consider datapath_type when looking for internal ports.

gt; > Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> Acked-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> Hi, Mark. Can you keep my Ack in further submissions in case there are no changes to this patch? Thanks. Cascardo. > --- > ofproto/ofproto.c |

Re: [ovs-dev] [PATCH V4 1/7] ofproto: Consider datapath_type when looking for internal ports.

gt; > Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> Acked-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> This should be applied any way for 2.6. Cascardo. > --- > ofproto/ofproto.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-

Re: [ovs-dev] [PATCH V3 1/7] ofproto: Consider datapath_type when looking for internal ports.

gt; > Signed-off-by: Daniele Di Proietto <diproiet...@vmware.com> Acked-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> > --- > ofproto/ofproto.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/ofproto/ofproto.c b/ofprot

Re: [ovs-dev] [CudaMailTagged] [PATCH 2/2] Tunnel: Fix the issue of tunnel port creation

On Sat, Aug 06, 2016 at 04:55:15AM +0800, Binbin Xu wrote: > If a kernel space vxlan port was added first, and then we try to > add a user space vxlan port. But unfortunate, the user space > vxlan port can't be created. > > This commit separates kernel space with user space tunnel port, > for

Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15

On Tue, Jul 26, 2016 at 02:24:19PM -0700, Jesse Gross wrote: > On Sun, Jul 24, 2016 at 10:53 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Sun, Jul 24, 2016 at 08:39:31AM -0300, Thadeu Lima de Souza Cascardo > > wrote: > >> On Sat, Jul 23, 2016 at 08:

[ovs-dev] [RFC] Revert "netdev: do not allow devices to be opened with conflicting types"

This reverts commit d2fa6c676a13e86acc7f17261b2d87484f625d45. When doing a restart, the routing table will open ports as system, which prevents internal ports to be opened with the right type. That causes failures in creating the ports. I am sending this as an RFC, as I will try to fix it on the

Re: [ovs-dev] [PATCH v2] route-table: flush addresses list when route table is reset

On Thu, Jul 28, 2016 at 01:14:58PM -0300, Thadeu Lima de Souza Cascardo wrote: > When the route table is reset, the addresses list may be out of date, as we > race > for the many netlink socket notifications. > > A quick fix for this is flushing the addresses list, before dum

Re: [ovs-dev] [PATCH 1/2] ovs-router: ignore IPv6 source addresses for IPv4 routes

On Wed, Jul 27, 2016 at 01:49:39PM -0700, Ben Pfaff wrote: > On Sun, Jul 24, 2016 at 01:07:26PM -0300, Thadeu Lima de Souza Cascardo wrote: > > Though this should not happen when we have another address on the device > > that is > > IPv4 mapped, we should prevent adding a

[ovs-dev] [PATCH v2] route-table: flush addresses list when route table is reset

. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/route-table.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/route-table.c b/lib/route-table.c index 58e7f62..0457de3 100644 --- a/lib/route-table.c +++ b/lib/route-table.c @@ -25,6 +25,7 @@ #i

Re: [ovs-dev] [PATCH 2/2] route-table: flush addresses list when route table is reset

On Wed, Jul 27, 2016 at 01:48:47PM -0700, Ben Pfaff wrote: > On Sun, Jul 24, 2016 at 01:07:27PM -0300, Thadeu Lima de Souza Cascardo wrote: > > When the route table is reset, the addresses list may be out of date, as we > > race > > for the many netlink socket notifications.

[ovs-dev] [PATCH 3/5] netdev-vport: don't use system type when opening netdev

-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/netdev-vport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c index 83a795c..87a30f8 100644 --- a/lib/netdev-vport.c +++ b/lib/netdev-vport.c @@ -274,7

[ovs-dev] [PATCH 4/5] dpif-netdev: use the open_type when creating the local port

n creating the dp_netdev_port. That changes the output of dpctl when showing the local port, and also when trying to change its type. So, corresponding tests are fixed. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> Signed-off-by: Daniele Di Proietto <diproiet...@vmware

[ovs-dev] [PATCH 5/5] netdev: do not allow devices to be opened with conflicting types

will arise. The netdev will be opened with the incorrect type and that will make vswitchd remove it, but adding it again will fail as it already exists. Failing earlier prevents some vswitchd loops in reconfiguring the interface. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --

[ovs-dev] [PATCH 2/5] in-band: don't use system type when opening netdev

type. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- ofproto/in-band.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/in-band.c b/ofproto/in-band.c index e3ee41a..f69e94f 100644 --- a/ofproto/in-band.c +++ b/ofproto/in-band.c @@ -134,7

[ovs-dev] [PATCH 0/5] netdev_open conflicting types

type than the one requested already exists. This will fix some bugs and alert users when conflicting interfaces exist on the system and the database. For example, when a user configures an interface with a type other than system, and there is a system interface with the same name. Thadeu Lima de

[ovs-dev] [PATCH 1/5] in-band: use open_type when opening internal device

this doesn't cause any problems right now, as the needed type would be opened already, a later patch assumes netdev with different types cannot be opened. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- ofproto/in-band.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

Re: [ovs-dev] [RFC 4/5] dpctl: uses open_type when calling netdev_open

On Tue, Jul 26, 2016 at 11:20:38AM -0700, Daniele Di Proietto wrote: > Hi Cascardo, > > thanks for your input on this. It's quite messy right now, but I believe > we have a chance > to fix this up. > > Replies inline > > 2016-07-26 7:33 GMT-07:00 Thadeu Li

Re: [ovs-dev] [RFC 0/5] netdev_open conflicting types

On Mon, Jul 25, 2016 at 02:12:52PM -0300, Thadeu Lima de Souza Cascardo wrote: > On Fri, Jul 22, 2016 at 01:10:33PM -0700, Ben Pfaff wrote: > > On Mon, Jul 18, 2016 at 02:00:20PM -0300, Thadeu Lima de Souza Cascardo > > wrote: > > > This series is a proposal to fix s

Re: [ovs-dev] [RFC 4/5] dpctl: uses open_type when calling netdev_open

On Mon, Jul 25, 2016 at 11:03:29AM -0700, Daniele Di Proietto wrote: > 2016-07-25 9:57 GMT-07:00 Thadeu Lima de Souza Cascardo <casca...@redhat.com > >: > > > On Fri, Jul 22, 2016 at 02:49:39PM -0700, Daniele Di Proietto wrote: > > > I would prefer if dpctl

Re: [ovs-dev] [RFC 0/5] netdev_open conflicting types

On Fri, Jul 22, 2016 at 01:10:33PM -0700, Ben Pfaff wrote: > On Mon, Jul 18, 2016 at 02:00:20PM -0300, Thadeu Lima de Souza Cascardo wrote: > > This series is a proposal to fix some users of netdev_open and > > introduce a new behavior for netdev_open when called with a differen

Re: [ovs-dev] [RFC 4/5] dpctl: uses open_type when calling netdev_open

avior, and improves the case in add-if, without breaking it; and leave the dpif_port_query fix and reverse mapping to another day. What do you think? Regards. Cascardo. > 2016-07-18 10:00 GMT-07:00 Thadeu Lima de Souza Cascardo < > casca...@redhat.com>: > > > dpc

Re: [ovs-dev] [PATCH 2/2] route-table: flush addresses list when route table is reset

On Sun, Jul 24, 2016 at 01:07:27PM -0300, Thadeu Lima de Souza Cascardo wrote: > When the route table is reset, the addresses list may be out of date, as we > race > for the many netlink socket notifications. > > A quick fix for this is flushing the addresses list, before dum

[ovs-dev] [PATCH 1/2] ovs-router: ignore IPv6 source addresses for IPv4 routes

:14ff:feb1:b54b Cached: 172.16.10.0/24 dev br3 SRC fe80::c4d0:14ff:feb1:b54b Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/ovs-router.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/ovs-router.c b/lib/ovs-router.c index 90e2f82..685e1ad 100644 --- a/l

[ovs-dev] [PATCH 2/2] route-table: flush addresses list when route table is reset

or preventing an entry to be added because of missing source addresses, repeated tests showed the correct entry is always added. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/route-table.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/route-table.c

Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15

On Sat, Jul 23, 2016 at 08:59:35AM -0700, Ben Pfaff wrote: > The proposed Open vSwitch release schedule calls for branching 2.6 from > master on Aug. 1, followed by a period of bug fixes and stabilization, > with release on Sep. 15. The proposed release schedule is posted here > for review: >

Re: [ovs-dev] ovn test failures

On Thu, Jul 21, 2016 at 07:32:02AM -0400, Lance Richardson wrote: > It seems the failure rate for OVN end-to-end tests went up significantly > when commit 70c7cfef188b5ae9940abd5b7d9fe46b1fa88c8e was merged earlier > this week. > For me, I see some occasional failures as well, but the following

[ovs-dev] [PATCH 6/6] datapath: remove VLAN compat code from GSO

This compatibility code was only needed for Linux 2.6.36 and older. With the support for versions older than 3.10 dropped, this code is not needed anymore. The style for checking for mpls was kept in case some other protocol type is added in the future. Signed-off-by: Thadeu Lima de Souza

[ovs-dev] [PATCH 5/6] datapath: remove rtnl_delete_link support for older Linux

The changes from upstream version of rtnl_delete_link were only there to support Linux 2.6.33 or older. The removal of this support makes it identical to upstream version as of 4.6. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- datapath/linux/compat/dev-openvsw

[ovs-dev] [PATCH 4/6] datapath: remove rpl_ipv6_skip_exthdr

This backported functon was only used for Linux 3.2 or older. As we support only Linux 3.10 or newer, there is no need for it anymore. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- datapath/linux/compat/exthdrs_core.c | 46 da

[ovs-dev] [PATCH 3/6] datapath: remove net namespace

The code that used that module was already removed when some support for Linux older than 3.10 was removed. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- datapath/linux/Modules.mk | 1 - datapath/linux/compat/net_namespace.

[ovs-dev] [PATCH 2/6] datapath: remove flow_dissector

flow_dissector was only built for Linux 3.8 and older. There is no need for this anymore, as anything older than 3.10 is no longer supported. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- datapath/linux/Modules.mk | 2 - datapath/linux/

[ovs-dev] [PATCH 1/6] datapath: remove flex_array

flex_array is already present on Linux 3.10, so there is no need for its backport anymore. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- datapath/linux/Modules.mk| 3 - datapath/linux/compat/flex_array.c

[ovs-dev] [PATCH 0/6] Remove some compat code for Linux older than 3.10

The following patches remove compatibility code for Linux versions older than Linux 3.10. Thadeu Lima de Souza Cascardo (6): datapath: remove flex_array datapath: remove flow_dissector datapath: remove net namespace datapath: remove rpl_ipv6_skip_exthdr datapath: remove rtnl_delete_link

[ovs-dev] [PATCH] stream-unix: only use path-based socket names

) (xid=0x1): Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/socket-util-unix.c | 5 +++-- lib/socket-util.h | 3 ++- lib/stream-unix.c | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/socket-util-unix.c b/lib/socket-util-unix.c index

[ovs-dev] [RFC 5/5] netdev: do not allow devices to be opened with conflicting types

When a device is already opened, netdev_open should verify that the types match, or else return an error. Otherwise, users might expect to open a device with a certain type and get a handle belonging to a different type. This also prevents certain conflicting configurations that would have a

[ovs-dev] [RFC 4/5] dpctl: uses open_type when calling netdev_open

dpctl uses a user or database defined type when calling netdev_open. Instead, it should use the type from dpif_port_open_type. Otherwise, when using the internal type, it could open it with that type instead of the correct one, which would be tap or dummy. --- lib/dpctl.c | 17 -

[ovs-dev] [RFC 2/5] in-band: don't use system type when opening netdev

A netdev might be already opened with a different type and that can be used instead. The system type is already the default type that will be used when there is no netdev opened and the type is not specified. And as long as the opened netdev supports the required operations, it doesn't matter its

[ovs-dev] [RFC 0/5] netdev_open conflicting types

, like not having to defer some operation when the proper netdev is created, and also allows potential conflicts to appear earlier. On the other hand, some conflicts might be created where they wouldn't exist, though I haven't run into it yet. Thadeu Lima de Souza Cascardo (5): in-band: use open_type

[ovs-dev] [RFC 3/5] netdev-vport: don't use system type when opening netdev

tunnel_check_status_change__ calls netdev_open with type system. Using NULL instead will default to system in case the device is not opened yet, and allow a different type in case it's already opened. Any type should be fine, as netdev_get_carrier will work with any of them. ---

[ovs-dev] [RFC 1/5] in-band: use open_type when opening internal device

in-band code will open a device that it expects to be the main internal port of the bridge. However, it's possible that the correct type is a different one. For dpif-netdev, it might be a tap device, or a dummy device for dummy datapaths. ofproto_port_open_type will give the correct type. While

[ovs-dev] [PATCH] stream-unix: only use path-based socket names

Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/stream-unix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stream-unix.c b/lib/stream-unix.c index cadd180..76206f8 100644 --- a/lib/stream-unix.c +++ b/lib/stream-unix.c @@ -113,7 +113,7 @@

Re: [ovs-dev] [PATCH] Remove old address set after change.

On Thu, Jul 07, 2016 at 11:24:25AM -0500, Ryan Moats wrote: > Currently, when address set value changes, ovn controller > doesn't remove the old entry from the tracking hash, it > just adds the new one, leading to multiple entries for the > same symbol. > > Fix this behavior. > > ToDo: figure

[ovs-dev] [PATCH] bridge: open_type should be used for netdev_open

ized configured type in the database. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- tests/automake.mk| 1 + tests/netdev-type.at | 24 tests/testsuite.at | 1 + vswitchd/bridge.c| 16 4 files changed, 38 insertions(

Re: [ovs-dev] [PATCH v3 0/5] create tunnel devices using rtnetlink interface

On Thu, Jun 30, 2016 at 03:44:37PM -0700, Jesse Gross wrote: > On Thu, Jun 30, 2016 at 12:25 PM, Thadeu Lima de Souza Cascardo > <casca...@redhat.com> wrote: > > On Wed, Jun 29, 2016 at 09:38:00PM -0700, Jesse Gross wrote: > >> On Wed, Jun 22, 2016 at 8:47 AM, Th

Re: [ovs-dev] [PATCH v3 0/5] create tunnel devices using rtnetlink interface

On Wed, Jun 29, 2016 at 09:38:00PM -0700, Jesse Gross wrote: > On Wed, Jun 22, 2016 at 8:47 AM, Thadeu Lima de Souza Cascardo > <casca...@redhat.com> wrote: > > This series adds support for the creation of tunnels using the rtnetlink > > interface. This will open the poss

[ovs-dev] [PATCH v3 5/5] dpif-netlink: add GENEVE creation support

apath - ping over geneve tunnel". Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/dpif-netlink.c | 82 ++ 1 file changed, 82 insertions(+) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 5f1b867

[ovs-dev] [PATCH v3 2/5] dpif-netlink: break out code to add compat and non-compat vports

and the interfaces that we shouldn't. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> --- lib/dpif-netlink.c | 195 +++-- 1 file changed, 144 insertions(+), 51 deletions(-) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 9

  1   2   3   >