Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-26 Thread Alin Serdean
12:10 AM Către: Alin Serdean Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote: Add an additional check to see if the flowTable is not NULL. Hi Alin, can you provide a Signed

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-26 Thread Ben Pfaff
@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote: Add an additional check to see if the flowTable is not NULL. Hi Alin, can you provide a Signed-off-by? Thanks, Ben

[ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Alin Serdean
Add an additional check to see if the flowTable is not NULL. kd k Child-SP RetAddr Call Site d000`26166af8 f802`dde5e7c6 nt!DbgBreakPointWithStatus d000`26166b00 f802`dde5e0d7 nt!KiBugCheckDebugBreak+0x12 d000`26166b60 f802`51a4 nt!KeBugCheck2+0x8ab

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Sorin Vinturis
Acked-by: Sorin Vinturis svintu...@cloudbasesolutions.com -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Tuesday, 25 November, 2014 19:09 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Eitan Eliahu
] [PATCH] datapath-windows: Fix BSOD when uninstalling driver Add an additional check to see if the flowTable is not NULL. kd k Child-SP RetAddr Call Site d000`26166af8 f802`dde5e7c6 nt!DbgBreakPointWithStatus d000`26166b00 f802`dde5e0d7 nt!KiBugCheckDebugBreak

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Nithin Raju
On Nov 25, 2014, at 9:09 AM, Alin Serdean aserd...@cloudbasesolutions.com wrote: +if (datapath-flowTable == NULL) { +status = STATUS_INVALID_PARAMETER; +goto dp_unlock; +} Alin, We allocate the flow table in OvsAllocateFlowTable() when the datapath is allocated,

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote: Add an additional check to see if the flowTable is not NULL. Hi Alin, can you provide a Signed-off-by? Thanks, Ben. ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Nithin Raju
Hi Ben, This change is not good to go. Alin has filed a bug for investigating this. Sorin or I will address it soon. Thanks, -- Nithin - sent from mobile - On Nov 25, 2014, at 14:11, Ben Pfaff b...@nicira.com wrote: On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote: Add an

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Ben Pfaff
OK, thanks for letting me know, I had the impression it was ready. On Tue, Nov 25, 2014 at 10:15:19PM +, Nithin Raju wrote: Hi Ben, This change is not good to go. Alin has filed a bug for investigating this. Sorin or I will address it soon. Thanks, -- Nithin - sent from mobile -