Re: [ovs-dev] [PATCH] datapath-windows: Fix bug in OvsTcpGetWscale().

2016-04-27 Thread Daniele Di Proietto
Thanks, pushed this to master! On 20/04/2016 21:06, "Sairam Venugopal" wrote: >Acked-by: Sairam Venugopal > > >On 4/15/16, 5:04 PM, "Daniele Di Proietto" wrote: > >>The userspace conntrack had a bug in tcp_wscale_get(), where

Re: [ovs-dev] [PATCH] datapath-windows: Fix bug in OvsTcpGetWscale().

2016-04-20 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 4/15/16, 5:04 PM, "Daniele Di Proietto" wrote: >The userspace conntrack had a bug in tcp_wscale_get(), where the length >of an option would be read from the third octet of the option TLV >instead of the second. This

[ovs-dev] [PATCH] datapath-windows: Fix bug in OvsTcpGetWscale().

2016-04-15 Thread Daniele Di Proietto
The userspace conntrack had a bug in tcp_wscale_get(), where the length of an option would be read from the third octet of the option TLV instead of the second. This could cause an incorrect wscale value to be returned, and it would at least impact performance. Also use 'int' instead of