Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation

2015-08-03 Thread Nithin Raju
> On Jul 3, 2015, at 8:36 AM, Sorin Vinturis > wrote: > > > +__inline BOOLEAN OvsBufferIsEmpty(char *buf, size_t size) > +{ > +return (buf[0] == 0 && !memcmp(buf, buf + 1, size - 1)); > +} > + The reason 'instance->dumpState.ovsMsg’ was a pointer and not a structure originally was to sav

Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation

2015-07-13 Thread Eitan Eliahu
Sorin Vinturis Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation On Fri, Jul 03, 2015 at 03:36:37PM +, Sorin Vinturis wrote: > Changed the dump start message memory representation to be static. > > Signed-off

Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation

2015-07-13 Thread Alin Serdean
Vinturis Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation On Fri, Jul 03, 2015 at 03:36:37PM +, Sorin Vinturis wrote: > Changed the dump start message memory representation to be static. > > Signed-off-by: Sorin

Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation

2015-07-13 Thread Eitan Eliahu
...@openvswitch.org] On Behalf Of Sorin Vinturis Sent: Friday, July 03, 2015 8:37 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation Changed the dump start message memory representation to be static. Signed-off-by: Sorin Vinturis

Re: [ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation

2015-07-13 Thread Ben Pfaff
On Fri, Jul 03, 2015 at 03:36:37PM +, Sorin Vinturis wrote: > Changed the dump start message memory representation to be static. > > Signed-off-by: Sorin Vinturis It's been over a week without a review. I hope that someone looks at this soon. ___

[ovs-dev] [PATCH] datapath-windows: Modified dump start message memory representation

2015-07-03 Thread Sorin Vinturis
Changed the dump start message memory representation to be static. Signed-off-by: Sorin Vinturis --- datapath-windows/ovsext/Datapath.c | 53 +- datapath-windows/ovsext/Datapath.h | 8 +++--- datapath-windows/ovsext/Flow.c | 4 +-- datapath-windows/ovsex