Re: [ovs-dev] [PATCH] dp-packet: Fix use of uninitialised value at emc_lookup.

2016-04-06 Thread William Tu
Hi Darrell and Daniele, Thanks for the comments! I will use dp_packet_rss_invalidate() instead and send v2 patch. Regards, William On Wed, Apr 6, 2016 at 11:26 AM, Daniele Di Proietto wrote: > 2016-04-06 10:09 GMT-07:00 Darrell Ball : > > On Wed, Apr 6,

Re: [ovs-dev] [PATCH] dp-packet: Fix use of uninitialised value at emc_lookup.

2016-04-06 Thread Daniele Di Proietto
2016-04-06 10:09 GMT-07:00 Darrell Ball : > On Wed, Apr 6, 2016 at 9:37 AM, William Tu wrote: > >> Valgrind reports "Conditional jump or move depends on uninitialised value" >> and "Use of uninitialised value" at case 2016 ovn -- 3 HVs, 1 LS, 3 >> lports/HV.

Re: [ovs-dev] [PATCH] dp-packet: Fix use of uninitialised value at emc_lookup.

2016-04-06 Thread Darrell Ball
On Wed, Apr 6, 2016 at 9:37 AM, William Tu wrote: > Valgrind reports "Conditional jump or move depends on uninitialised value" > and "Use of uninitialised value" at case 2016 ovn -- 3 HVs, 1 LS, 3 > lports/HV. It is caused by reading uninitialized 'key->hash' at >

[ovs-dev] [PATCH] dp-packet: Fix use of uninitialised value at emc_lookup.

2016-04-06 Thread William Tu
Valgrind reports "Conditional jump or move depends on uninitialised value" and "Use of uninitialised value" at case 2016 ovn -- 3 HVs, 1 LS, 3 lports/HV. It is caused by reading uninitialized 'key->hash' at emc_lookup() and 'rss_hash_valid' from dp_packet_rss_valid(). At emc_processing(), the