Re: [ovs-dev] [PATCH] dpif-netdev: Fix dp_netdev_pmd_remove_flow().

2016-05-04 Thread Daniele Di Proietto
Thanks for the review! Applied to master and branch-2.5 On 04/05/2016 11:28, "Jarno Rajahalme" wrote: >Acked-by: Jarno Rajahalme > >> On May 3, 2016, at 6:10 PM, Daniele Di Proietto >> wrote: >> >> After removing a flow from the

Re: [ovs-dev] [PATCH] dpif-netdev: Fix dp_netdev_pmd_remove_flow().

2016-05-04 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On May 3, 2016, at 6:10 PM, Daniele Di Proietto > wrote: > > After removing a flow from the dpcls classifier there might still be > readers who have access to the flow, until the next grace period. > > Setting

[ovs-dev] [PATCH] dpif-netdev: Fix dp_netdev_pmd_remove_flow().

2016-05-03 Thread Daniele Di Proietto
After removing a flow from the dpcls classifier there might still be readers who have access to the flow, until the next grace period. Setting flow->cr.mask to NULL can cause concurrent readers to crash, so this commit avoids doing it. The crash can be reproduced, for example, by invoking an