Re: [ovs-dev] [PATCH] ofproto: Initialise return value of modify_flows__

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 11:06:09AM +0900, Simon Horman wrote: dd51dae29bccca3 (ofproto: Move logic for collecting read-only rules into rule_criteria.) modifies modify_flows__ such that the variable error, the return value, may be uninitialised if either of the following is true: 1.

Re: [ovs-dev] [PATCH] ofproto: Initialise return value of modify_flows__

2014-06-13 Thread Simon Horman
On Fri, Jun 13, 2014 at 10:46:07AM -0700, Ben Pfaff wrote: On Fri, Jun 13, 2014 at 11:06:09AM +0900, Simon Horman wrote: dd51dae29bccca3 (ofproto: Move logic for collecting read-only rules into rule_criteria.) modifies modify_flows__ such that the variable error, the return value, may be

[ovs-dev] [PATCH] ofproto: Initialise return value of modify_flows__

2014-06-12 Thread Simon Horman
dd51dae29bccca3 (ofproto: Move logic for collecting read-only rules into rule_criteria.) modifies modify_flows__ such that the variable error, the return value, may be uninitialised if either of the following is true: 1. ofproto-ofproto_class-rule_premodify_actions is NULL 2. rules-n is zero It

Re: [ovs-dev] [PATCH] ofproto: Initialise return value of modify_flows__

2014-06-12 Thread Joe Stringer
This looks good to me, although I'm not too familiar with the code. Tested-by: Joe Stringer joestrin...@nicira.com On 13 June 2014 14:06, Simon Horman ho...@verge.net.au wrote: dd51dae29bccca3 (ofproto: Move logic for collecting read-only rules into rule_criteria.) modifies modify_flows__