Re: [ovs-dev] [PATCH 07/41] pinsched: Remove obsolete ofpbuf_trim().

2016-01-19 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > This call to ofpbuf_trim() comes from a time when the packets passed to > pinsched came directly from a dpif. For some time now that's no longer > true--now they are messages generated

Re: [ovs-dev] [PATCH 07/41] pinsched: Remove obsolete ofpbuf_trim().

2016-01-19 Thread Ben Pfaff
Thanks for the reviews. I applied patches 2 through 7 to master. On Tue, Jan 19, 2016 at 11:44:30AM -0800, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > > > This call to ofpbuf_trim() comes from a time

[ovs-dev] [PATCH 07/41] pinsched: Remove obsolete ofpbuf_trim().

2016-01-18 Thread Ben Pfaff
This call to ofpbuf_trim() comes from a time when the packets passed to pinsched came directly from a dpif. For some time now that's no longer true--now they are messages generated by ofputil_encode_packet_in(), which generally are well sized and do not benefit from trimming. This is not a bug