Re: [ovs-dev] [PATCH 09/41] openflow: Rename OF0.1-1.3 queue property constants.

2016-01-20 Thread Ben Pfaff
On Tue, Jan 19, 2016 at 12:40:05PM -0800, Jarno Rajahalme wrote: > With a minor function naming question below: > > Acked-by: Jarno Rajahalme ... > > -put_queue_rate(struct ofpbuf *reply, enum ofp_queue_properties property, > > - uint16_t rate) > >

Re: [ovs-dev] [PATCH 09/41] openflow: Rename OF0.1-1.3 queue property constants.

2016-01-19 Thread Jarno Rajahalme
With a minor function naming question below: Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:26 PM, Ben Pfaff wrote: > > At first glance, OF1.4 queue properties look a lot like those for OF1.0 > to OF1.3, but in fact their different padding makes them

[ovs-dev] [PATCH 09/41] openflow: Rename OF0.1-1.3 queue property constants.

2016-01-18 Thread Ben Pfaff
At first glance, OF1.4 queue properties look a lot like those for OF1.0 to OF1.3, but in fact their different padding makes them incompatible. In addition, OF1.4 switches from using regular OpenFlow messages to request queue properties, to using multipart messages. Thus, we really need to use