Re: [ovs-dev] [PATCH 12/12] timeval: Reorder elements in clock structure.

2016-10-07 Thread Jarno Rajahalme
I would leave the ‘stopped’ member below the comment. Also, the 2nd cacheline is only ever accessed during unit tests, so this should not have real performance impact. Acked-by: Jarno Rajahalme > On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy >

[ovs-dev] [PATCH 12/12] timeval: Reorder elements in clock structure.

2016-10-07 Thread Bhanuprakash Bodireddy
By reordering the elements in clock structure, pad bytes can be reduced and also a cache line is saved. Before: structure size:136, holes:3, sum padbytes:18, cachelines:3 After: structure size:120, holes:1, sum padbytes:2, cachelines:2 Signed-off-by: Bhanuprakash Bodireddy