Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Use UKEY_DELETE for ukey deletion.

2016-01-07 Thread Joe Stringer
On 7 January 2016 at 13:53, Jarno Rajahalme wrote: > While correct, I would find this easier to follow (as an incremental on top > of this patch): > > diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c > index d611131..390acbf 100644 > ---

[ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Use UKEY_DELETE for ukey deletion.

2016-01-07 Thread Joe Stringer
Flows which are deleted during the revalidator "dump" phase have their corresponding dump seq updated, which leads to such ukeys being handled by the "UKEY_KEEP" logic in revalidator_sweep__() here: } else if (!seq_mismatch) { result = UKEY_KEEP; } In practice, this has allowed

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Use UKEY_DELETE for ukey deletion.

2016-01-07 Thread Jarno Rajahalme
While correct, I would find this easier to follow (as an incremental on top of this patch): diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index d611131..390acbf 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -2240,9 +2240,8 @@