Re: [ovs-dev] [PATCH 24/41] ofp-util: Rewrite async config encoding and decoding to be table-driven.

2016-01-20 Thread Ben Pfaff
Thanks, I improved that and applied this to master. On Tue, Jan 19, 2016 at 03:57:38PM -0800, Jarno Rajahalme wrote: > With a small nit below, > > Acked-by: Jarno Rajahalme > > > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > > > > (snip) > > > +struct

Re: [ovs-dev] [PATCH 24/41] ofp-util: Rewrite async config encoding and decoding to be table-driven.

2016-01-19 Thread Jarno Rajahalme
With a small nit below, Acked-by: Jarno Rajahalme > On Jan 18, 2016, at 11:27 PM, Ben Pfaff wrote: > (snip) > +struct ofp14_async_prop { > +uint64_t prop_type; > +enum ofputil_async_msg_type oam; > +bool master; > +uint32_t allowed10, allowed14;

[ovs-dev] [PATCH 24/41] ofp-util: Rewrite async config encoding and decoding to be table-driven.

2016-01-18 Thread Ben Pfaff
The encoding and decoding of the OpenFlow and Open vSwitch async config messages was, until now, a collection of disjoint code that had a lot of redundancy. This commit changes it all to be driven using a single central table. This rewrite fixes a bug in the OF1.4+ version of the code, which