Hello Nithin,
This patch looks good!
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
From: Nithin Raju [nit...@vmware.com]
Sent: Wednesday, September 17, 2014 5:06 AM
To: dev@openvswitch.org; Samuel Ghinet; elia...@vmware.com;
Oh, except a little typo in the commit message:
Eg. the Windows kernel does not send embed an error
Sam
From: Samuel Ghinet
Sent: Wednesday, September 17, 2014 4:34 PM
To: Nithin Raju; dev@openvswitch.org; elia...@vmware.com; ankursha...@vmware.com
Hi Nithin, look good. Few comments:
if (request_nlmsg-nlmsg_seq != reply_nlmsg-nlmsg_seq)
Unlink the Linux implementation the above condition should never happen. I
would put just an assert there.
Before accessing request_nlmsg we need to check its size against the reply_len
parameter
In this patch, we add support for nl_transact() on Windows using
the OVS_IOCTL_TRANSACT ioctl that sends down the request and gets
the reply in the same call to the kernel.
This is obviously a digression from the way it is implemented in
Linux where all the sends are done at once using sendmsg()
