Re: [ovs-dev] [PATCH 3/6] lib: Fix compose nd

2016-03-14 Thread pravin shelar
On Fri, Mar 11, 2016 at 11:29 AM, Thadeu Lima de Souza Cascardo wrote: > On Wed, Mar 09, 2016 at 04:40:42PM -0800, Pravin B Shelar wrote: >> Following patch fixes number of issues with compose nd, like >> setting ip packet header, set ICMP opt-len, checksum. >> >> Signed-off-by: Pravin B Shelar >

Re: [ovs-dev] [PATCH 3/6] lib: Fix compose nd

2016-03-11 Thread Thadeu Lima de Souza Cascardo
On Wed, Mar 09, 2016 at 04:40:42PM -0800, Pravin B Shelar wrote: > Following patch fixes number of issues with compose nd, like > setting ip packet header, set ICMP opt-len, checksum. > > Signed-off-by: Pravin B Shelar > --- > lib/packets.c | 60 > +--

Re: [ovs-dev] [PATCH 3/6] lib: Fix compose nd

2016-03-10 Thread pravin shelar
On Thu, Mar 10, 2016 at 4:18 PM, Ben Pfaff wrote: > On Wed, Mar 09, 2016 at 04:40:42PM -0800, Pravin B Shelar wrote: >> Following patch fixes number of issues with compose nd, like >> setting ip packet header, set ICMP opt-len, checksum. >> >> Signed-off-by: Pravin B Shelar > > sparse says: > >

Re: [ovs-dev] [PATCH 3/6] lib: Fix compose nd

2016-03-10 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 04:40:42PM -0800, Pravin B Shelar wrote: > Following patch fixes number of issues with compose nd, like > setting ip packet header, set ICMP opt-len, checksum. > > Signed-off-by: Pravin B Shelar sparse says: ../lib/packets.c:1332:45: warning: incorrect type in argume

[ovs-dev] [PATCH 3/6] lib: Fix compose nd

2016-03-09 Thread Pravin B Shelar
Following patch fixes number of issues with compose nd, like setting ip packet header, set ICMP opt-len, checksum. Signed-off-by: Pravin B Shelar --- lib/packets.c | 60 +-- 1 file changed, 42 insertions(+), 18 deletions(-) diff --git a/li