Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-23 Thread Ben Pfaff
On Tue, Jun 23, 2015 at 12:02:44AM +, Nithin Raju wrote: On Jun 22, 2015, at 10:58 AM, Sorin Vinturis svintu...@cloudbasesolutions.com wrote: Hi Nithin, I didn't thought about your idea. I have added instrumentation code in order to force the EEXIST error and test the patch

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-23 Thread Nithin Raju
On Jun 23, 2015, at 11:46 AM, Ben Pfaff b...@nicira.com wrote: On Tue, Jun 23, 2015 at 12:02:44AM +, Nithin Raju wrote: On Jun 22, 2015, at 10:58 AM, Sorin Vinturis svintu...@cloudbasesolutions.com wrote: Hi Nithin, I didn't thought about your idea. I have added instrumentation

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-22 Thread Sorin Vinturis
, June 18, 2015 11:37 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects There are cases when the WFP callout or sublayer, being persistent objects, already exists when we try to register the OVS callout. In this cases, when

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-22 Thread Nithin Raju
On Jun 22, 2015, at 10:25 AM, Sorin Vinturis svintu...@cloudbasesolutions.com wrote: Hi Eitan/Nithin, In normal execution flow all WFP objects are released after the extension is disabled. The patch was meant to address the cases when the extension was not properly disabled due to

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-22 Thread Eitan Eliahu
the extension. Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis Sent: Thursday, June 18, 2015 11:37 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-22 Thread Nithin Raju
On Jun 22, 2015, at 10:58 AM, Sorin Vinturis svintu...@cloudbasesolutions.com wrote: Hi Nithin, I didn't thought about your idea. I have added instrumentation code in order to force the EEXIST error and test the patch and the code performs as expected. The extension is able to be

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-22 Thread Sorin Vinturis
Hi Nithin, I didn't thought about your idea. I have added instrumentation code in order to force the EEXIST error and test the patch and the code performs as expected. The extension is able to be activated, in case of both the sublayer and callout are already present, and everything works as

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-20 Thread Eitan Eliahu
Vinturis Sent: Thursday, June 18, 2015 11:37 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects There are cases when the WFP callout or sublayer, being persistent objects, already exists when we try to register the OVS callout

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-19 Thread Nithin Raju
aserd...@cloudbasesolutions.com -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis Trimis: Thursday, June 18, 2015 9:37 PM Către: dev@openvswitch.org Subiect: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP

Re: [ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-18 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis Trimis: Thursday, June 18, 2015 9:37 PM Către: dev@openvswitch.org Subiect: [ovs-dev] [PATCH v2] datapath-windows: Return success

[ovs-dev] [PATCH v2] datapath-windows: Return success for already existing WFP objects

2015-06-18 Thread Sorin Vinturis
There are cases when the WFP callout or sublayer, being persistent objects, already exists when we try to register the OVS callout. In this cases, when trying to add again these WFP objects the return code is STATUS_FWP_ALREADY_EXISTS, which we are interpreting as an error. This is incorrect and