Re: [ovs-dev] [PATCH v2] lib/netlink-socket.c: always pass the output buffer in a transaction

2014-10-13 Thread Nithin Raju
On Oct 7, 2014, at 8:01 PM, Eitan Eliahu elia...@vmware.com wrote: Hi Nithin, Thanks for addressing the transactional error issue. Are we sure we want to make another copy for the Reply just for getting the transactional error on a different buffer? Can we use the stack buffer only if

Re: [ovs-dev] [PATCH v2] lib/netlink-socket.c: always pass the output buffer in a transaction

2014-10-13 Thread Ben Pfaff
On Tue, Oct 07, 2014 at 03:08:53PM -0700, Nithin Raju wrote: We need to pass down the output buffer so that the kernel can return transaction status - error or otherwise. Also, we were processing the output buffer only when when 'txn-reply != NULL' ie when the caller specified an ofpbuf for

Re: [ovs-dev] [PATCH v2] lib/netlink-socket.c: always pass the output buffer in a transaction

2014-10-10 Thread Ankur Sharma
Acked-by: Ankur Sharma ankursha...@vmware.com From: dev dev-boun...@openvswitch.org on behalf of Eitan Eliahu elia...@vmware.com Sent: Tuesday, October 7, 2014 8:01 PM To: Nithin Raju; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2] lib/netlink

[ovs-dev] [PATCH v2] lib/netlink-socket.c: always pass the output buffer in a transaction

2014-10-07 Thread Nithin Raju
We need to pass down the output buffer so that the kernel can return transaction status - error or otherwise. Also, we were processing the output buffer only when when 'txn-reply != NULL' ie when the caller specified an ofpbuf for the reply. In this patch, the code has been updated to process the

Re: [ovs-dev] [PATCH v2] lib/netlink-socket.c: always pass the output buffer in a transaction

2014-10-07 Thread Eitan Eliahu
? Please find a comment inline. Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju Sent: Tuesday, October 07, 2014 3:09 PM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH v2] lib/netlink-socket.c: always pass the output buffer