Re: [ovs-dev] [PATCH v2] netdev-dpdk: vhost: Fix txq enabling in the absence of notifications.

On 29.03.2016 04:47, Daniele Di Proietto wrote: > Thanks for the patch, Ilya > > In __netdev_dpdk_vhost_send() we have > > qid = vhost_dev->tx_q[qid % vhost_dev->real_n_txq].map; > > if (OVS_UNLIKELY(!is_vhost_running(virtio_dev) || qid == -1)) { > > > Should we change -1 to

Re: [ovs-dev] [PATCH v2] netdev-dpdk: vhost: Fix txq enabling in the absence of notifications.

Thanks for the patch, Ilya In __netdev_dpdk_vhost_send() we have qid = vhost_dev->tx_q[qid % vhost_dev->real_n_txq].map; if (OVS_UNLIKELY(!is_vhost_running(virtio_dev) || qid == -1)) { Should we change -1 to OVS_VHOST_QUEUE_MAP_UNKNOWN and handle also OVS_VHOST_QUEUE_DISABLED? On

Re: [ovs-dev] [PATCH v2] netdev-dpdk: vhost: Fix txq enabling in the absence of notifications.

On Fri, Mar 25, 2016 at 7:50 AM, Ilya Maximets wrote: > According to QEMU documentation (docs/specs/vhost-user.txt) one queue > should be enabled initially. More queues are enabled dynamically, by > sending message VHOST_USER_SET_VRING_ENABLE. > > Currently all queues in

Re: [ovs-dev] [PATCH v2] netdev-dpdk: vhost: Fix txq enabling in the absence of notifications.

On Fri, Mar 25, 2016 at 09:50:33AM +0300, Ilya Maximets wrote: > According to QEMU documentation (docs/specs/vhost-user.txt) one queue > should be enabled initially. More queues are enabled dynamically, by > sending message VHOST_USER_SET_VRING_ENABLE. > > Currently all queues in OVS disabled by

[ovs-dev] [PATCH v2] netdev-dpdk: vhost: Fix txq enabling in the absence of notifications.

According to QEMU documentation (docs/specs/vhost-user.txt) one queue should be enabled initially. More queues are enabled dynamically, by sending message VHOST_USER_SET_VRING_ENABLE. Currently all queues in OVS disabled by default. This breaks above specification. So, queue #0 should be enabled